{"thread":{"id":"57097","subject":"[PATCH] Makefile: don't invoke msgfmt with --statistics","startedAt":"2021-12-17T00:10:07Z","lastAt":"2021-12-17T00:10:07Z","messageCount":1,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"444289","messageId":"patch-1.1-58408f384e7-20211217T000729Z-avarab@gmail.com","threadId":"57097","inReplyTo":null,"subject":"[PATCH] Makefile: don't invoke msgfmt with --statistics","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-12-17T00:10:00Z","receivedAt":"2021-12-17T00:10:07Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Remove the --statistics flag that I added in 5e9637c6297 (i18n: add\ninfrastructure for translating Git with gettext, 2011-11-18). Our\nMakefile output is good about reducing verbosity by default, except in\nthis case:\n\n    $ rm -rf po/build/locale/e*; time make -j $(nproc) all\n        SUBDIR templates\n        MKDIR -p po/build/locale/el/LC_MESSAGES\n        MSGFMT po/build/locale/el/LC_MESSAGES/git.mo\n        MKDIR -p po/build/locale/es/LC_MESSAGES\n        MSGFMT po/build/locale/es/LC_MESSAGES/git.mo\n    1038 translated messages, 3325 untranslated messages.\n    5230 translated messages.\n\nI didn't have any good reason for using --statistics at the time other\nthan ad-hoc eyeballing of the output. We don't need to spew out\nexactly how many messages we've got translated every time. Now we'll\ninstead emit:\n\n    $ rm -rf po/build/locale/e*; time make -j $(nproc) all\n        SUBDIR templates\n        MKDIR -p po/build/locale/el/LC_MESSAGES\n        MSGFMT po/build/locale/el/LC_MESSAGES/git.mo\n        MKDIR -p po/build/locale/es/LC_MESSAGES\n        MSGFMT po/build/locale/es/LC_MESSAGES/git.mo\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nAs noted in [1] this is the first of smaller topics that split-up and\nreplace the ab/make-dependency topic. Range-to the previous start of\nthe series below. The v4 of the old series is at [2].\n\nFor this commit there were no changes or outstanding comments.\n\n1. https://lore.kernel.org/git/211217.86a6h09km9.gmgdl@evledraar.gmail.com/\n2. https://lore.kernel.org/git/cover-v4-00.23-00000000000-20211117T101807Z-avarab@gmail.com/\n\nRange-diff:\n 1:  1621ca72c1d =  1:  58408f384e7 Makefile: don't invoke msgfmt with --statistics\n 2:  b7c36c9fea0 <  -:  ----------- Makefile: don't set up \"perl/build\" rules under NO_PERL=Y\n 3:  29b000eb0f1 <  -:  ----------- Makefile: use \"=\" not \":=\" for po/* and perl/*\n 4:  daead5ec293 <  -:  ----------- Makefile: clean perl/build/ even with NO_PERL=Y\n 5:  3c987590740 <  -:  ----------- Makefile: remove \"mv $@ $@+\" dance redundant to .DELETE_ON_ERROR\n 6:  b57f582ccd3 <  -:  ----------- Makefile: guard Perl-only variable assignments\n 7:  fcdee92f64c <  -:  ----------- Makefile: change \"ifndef NO_PERL\" to \"ifdef NO_PERL\"\n 8:  1e25b532ca2 <  -:  ----------- Makefile: adjust Perl-related comments & whitespace\n 9:  77d9855bfcf <  -:  ----------- Makefile: correct \"GIT-PERL-{DEFINES,HEADER}\" dependency graph\n10:  6004cdcd8d9 <  -:  ----------- Makefile: create a GIT-PYTHON-DEFINES, like \"PERL\"\n11:  17b30e96057 <  -:  ----------- Makefile: stop needing @@GIT_VERSION@@ in *.perl scripts\n12:  30ddf7da2c8 <  -:  ----------- Makefiles: add \"shared.mak\", move \".DELETE_ON_ERROR\" to it\n13:  f378a7dc35e <  -:  ----------- Makefile: move $(comma), $(empty) and $(space) to shared.mak\n14:  13cbb851d32 <  -:  ----------- Makefile: re-add and use the \"shellquote\" macros\n15:  337953e4994 <  -:  ----------- Makefile: add a \"TRACK_template\" for GIT-*{FLAGS,DEFINES,...}\n16:  5bb597c1993 <  -:  ----------- Makefile: add \"$(QUIET)\" boilerplate to shared.mak\n17:  3c4d0589667 <  -:  ----------- Makefile: use $(wspfx) for $(QUIET...) in shared.mak\n18:  be5882b2c99 <  -:  ----------- Makefiles: add and use wildcard \"mkdir -p\" template\n19:  2710f8af6cd <  -:  ----------- Makefile: correct the dependency graph of hook-list.h\n20:  59f22a0269a <  -:  ----------- Makefile: use $(file) I/O instead of \"FORCE\" when possible\n21:  dd569a59c74 <  -:  ----------- Makefile: disable GNU make built-in wildcard rules\n22:  4168a7e3b30 <  -:  ----------- Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)\n23:  48a3927d972 <  -:  ----------- Makefile: move \".SUFFIXES\" rule to shared.mak\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex 9c00a793e47..b9d0f063eff 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1880,7 +1880,7 @@ ifdef GIT_TEST_CMP_USE_COPIED_CONTEXT\n endif\n \n ifndef NO_MSGFMT_EXTENDED_OPTIONS\n-\tMSGFMT += --check --statistics\n+\tMSGFMT += --check\n endif\n \n ifdef HAVE_CLOCK_GETTIME\n-- \n2.34.1.1119.g7a3fc8778ee\n\n"}]}