{"thread":{"id":"57076","subject":"[PATCH] l10n: README: call more attention to plural strings","startedAt":"2021-12-13T19:56:13Z","lastAt":"2021-12-22T01:47:15Z","messageCount":9,"participants":["Josh Steadmon","Junio C Hamano","Jiang Xin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"444024","messageId":"25107068cbbf8c9ce6886e66e25dff19e072583f.1639425295.git.steadmon@google.com","threadId":"57076","inReplyTo":null,"subject":"[PATCH] l10n: README: call more attention to plural strings","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2021-12-13T19:56:09Z","receivedAt":"2021-12-13T19:56:13Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"In po/README.md, we point core developers to gettext's \"Preparing\nStrings\" documentation for advice on marking strings for translation.\nHowever, this doc doesn't really discuss the issues around plural form\ntranslation, which can make it seem that nothing special needs to be\ndone in this case.\n\nAdd a specific callout here about marking plural-form strings so that\nthe advice later on in the README is not overlooked.\n\nSigned-off-by: Josh Steadmon \n---\n po/README.md | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/po/README.md b/po/README.md\nindex dcd8436c25..fd1e024dd3 100644\n--- a/po/README.md\n+++ b/po/README.md\n@@ -219,7 +219,10 @@ General advice:\n they're part of Git's API.\n \n - Adjust the strings so that they're easy to translate. Most of the\n- advice in `info '(gettext)Preparing Strings'` applies here.\n+ advice in `info '(gettext)Preparing Strings'` applies here. Strings\n+ referencing numbers of items may need to be split into singular and\n+ plural forms; see the Q\\_() wrapper in the C sub-section below for an\n+ example.\n \n - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n comment to tell the translators what to make of it. These will be\n\nbase-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc\n-- \n2.34.1.173.g76aa8bc2d0-goog\n\n"},{"id":"444035","messageId":"xmqqa6h4b24o.fsf@gitster.g","threadId":"57076","inReplyTo":"25107068cbbf8c9ce6886e66e25dff19e072583f.1639425295.git.steadmon@google.com","subject":"Re: [PATCH] l10n: README: call more attention to plural strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-13T21:56:07Z","receivedAt":"2021-12-13T21:56:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Josh Steadmon writes:\n\n> In po/README.md, we point core developers to gettext's \"Preparing\n> Strings\" documentation for advice on marking strings for translation.\n> However, this doc doesn't really discuss the issues around plural form\n> translation, which can make it seem that nothing special needs to be\n> done in this case.\n>\n> Add a specific callout here about marking plural-form strings so that\n> the advice later on in the README is not overlooked.\n>\n> Signed-off-by: Josh Steadmon \n> ---\n> po/README.md | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/po/README.md b/po/README.md\n> index dcd8436c25..fd1e024dd3 100644\n> --- a/po/README.md\n> +++ b/po/README.md\n> @@ -219,7 +219,10 @@ General advice:\n> they're part of Git's API.\n> \n> - Adjust the strings so that they're easy to translate. Most of the\n> - advice in `info '(gettext)Preparing Strings'` applies here.\n> + advice in `info '(gettext)Preparing Strings'` applies here. Strings\n> + referencing numbers of items may need to be split into singular and\n> + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> + example.\n> \n> - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n> comment to tell the translators what to make of it. These will be\n\nSounds good to me, but I'd want an ack by those from the l10n\ndepartment.\n\nThanks.\n"},{"id":"444037","messageId":"YbfC5/+Q7lPp0G2i@google.com","threadId":"57076","inReplyTo":"xmqqa6h4b24o.fsf@gitster.g","subject":"Re: [PATCH] l10n: README: call more attention to plural strings","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2021-12-13T22:02:15Z","receivedAt":"2021-12-13T22:02:24Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"On 2021.12.13 13:56, Junio C Hamano wrote:\n> Josh Steadmon writes:\n> \n> > In po/README.md, we point core developers to gettext's \"Preparing\n> > Strings\" documentation for advice on marking strings for translation.\n> > However, this doc doesn't really discuss the issues around plural form\n> > translation, which can make it seem that nothing special needs to be\n> > done in this case.\n> >\n> > Add a specific callout here about marking plural-form strings so that\n> > the advice later on in the README is not overlooked.\n> >\n> > Signed-off-by: Josh Steadmon \n> > ---\n> > po/README.md | 5 ++++-\n> > 1 file changed, 4 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/po/README.md b/po/README.md\n> > index dcd8436c25..fd1e024dd3 100644\n> > --- a/po/README.md\n> > +++ b/po/README.md\n> > @@ -219,7 +219,10 @@ General advice:\n> > they're part of Git's API.\n> > \n> > - Adjust the strings so that they're easy to translate. Most of the\n> > - advice in `info '(gettext)Preparing Strings'` applies here.\n> > + advice in `info '(gettext)Preparing Strings'` applies here. Strings\n> > + referencing numbers of items may need to be split into singular and\n> > + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> > + example.\n> > \n> > - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n> > comment to tell the translators what to make of it. These will be\n> \n> Sounds good to me, but I'd want an ack by those from the l10n\n> department.\n> \n> Thanks.\n\nHmm, I meant to CC both Jiang and Bagas, not sure why it didn't go\nthrough.\n"},{"id":"444042","messageId":"xmqqr1ag9mig.fsf@gitster.g","threadId":"57076","inReplyTo":"YbfC5/+Q7lPp0G2i@google.com","subject":"Re: [PATCH] l10n: README: call more attention to plural strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-13T22:18:47Z","receivedAt":"2021-12-13T22:18:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Josh Steadmon writes:\n\n> On 2021.12.13 13:56, Junio C Hamano wrote:\n>> Josh Steadmon writes:\n>> \n>> > In po/README.md, we point core developers to gettext's \"Preparing\n>> > Strings\" documentation for advice on marking strings for translation.\n>> > However, this doc doesn't really discuss the issues around plural form\n>> > translation, which can make it seem that nothing special needs to be\n>> > done in this case.\n>> >\n>> > Add a specific callout here about marking plural-form strings so that\n>> > the advice later on in the README is not overlooked.\n>> >\n>> > Signed-off-by: Josh Steadmon \n>> > ---\n>> > po/README.md | 5 ++++-\n>> > 1 file changed, 4 insertions(+), 1 deletion(-)\n>> >\n>> > diff --git a/po/README.md b/po/README.md\n>> > index dcd8436c25..fd1e024dd3 100644\n>> > --- a/po/README.md\n>> > +++ b/po/README.md\n>> > @@ -219,7 +219,10 @@ General advice:\n>> > they're part of Git's API.\n>> > \n>> > - Adjust the strings so that they're easy to translate. Most of the\n>> > - advice in `info '(gettext)Preparing Strings'` applies here.\n>> > + advice in `info '(gettext)Preparing Strings'` applies here. Strings\n>> > + referencing numbers of items may need to be split into singular and\n>> > + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n>> > + example.\n>> > \n>> > - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n>> > comment to tell the translators what to make of it. These will be\n>> \n>> Sounds good to me, but I'd want an ack by those from the l10n\n>> department.\n>> \n>> Thanks.\n>\n> Hmm, I meant to CC both Jiang and Bagas, not sure why it didn't go\n> through.\n\nThat's OK. We watch each other's back ;-)\n"},{"id":"444192","messageId":"CANYiYbF31o-sQYU-OjJk=pQR5RHM0k7jqmEhiKGLeO3Suu1khQ@mail.gmail.com","threadId":"57076","inReplyTo":"YbfC5/+Q7lPp0G2i@google.com","subject":"Re: [PATCH] l10n: README: call more attention to plural strings","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-12-16T01:10:15Z","receivedAt":"2021-12-16T01:10:28Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Tue, Dec 14, 2021 at 6:02 AM Josh Steadmon wrote:\n>\n> On 2021.12.13 13:56, Junio C Hamano wrote:\n> > Josh Steadmon writes:\n> >\n> > > In po/README.md, we point core developers to gettext's \"Preparing\n> > > Strings\" documentation for advice on marking strings for translation.\n> > > However, this doc doesn't really discuss the issues around plural form\n> > > translation, which can make it seem that nothing special needs to be\n> > > done in this case.\n> > >\n> > > Add a specific callout here about marking plural-form strings so that\n> > > the advice later on in the README is not overlooked.\n> > >\n> > > Signed-off-by: Josh Steadmon \n> > > ---\n> > > po/README.md | 5 ++++-\n> > > 1 file changed, 4 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/po/README.md b/po/README.md\n> > > index dcd8436c25..fd1e024dd3 100644\n> > > --- a/po/README.md\n> > > +++ b/po/README.md\n> > > @@ -219,7 +219,10 @@ General advice:\n> > > they're part of Git's API.\n> > >\n> > > - Adjust the strings so that they're easy to translate. Most of the\n> > > - advice in `info '(gettext)Preparing Strings'` applies here.\n> > > + advice in `info '(gettext)Preparing Strings'` applies here. Strings\n> > > + referencing numbers of items may need to be split into singular and\n> > > + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> > > + example.\n\nWouldn't it be better if we add a new rule (\"Strings ... an example.\")\nafter this one?\n\n> > >\n> > > - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n> > > comment to tell the translators what to make of it. These will be\n> >\n> > Sounds good to me, but I'd want an ack by those from the l10n\n> > department.\n> >\n> > Thanks.\n>\n> Hmm, I meant to CC both Jiang and Bagas, not sure why it didn't go\n> through.\n\nYesterday I was interrupted by a meeting while reading this thread.\n\n--\nJiang Xin\n"},{"id":"444651","messageId":"a9453065c2e89d79fc117363fe41fa10986e06d1.1640113138.git.steadmon@google.com","threadId":"57076","inReplyTo":"25107068cbbf8c9ce6886e66e25dff19e072583f.1639425295.git.steadmon@google.com","subject":"[PATCH v2] l10n: README: call more attention to plural strings","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2021-12-21T19:00:42Z","receivedAt":"2021-12-21T19:00:47Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"In po/README.md, we point core developers to gettext's \"Preparing\nStrings\" documentation for advice on marking strings for translation.\nHowever, this doc doesn't really discuss the issues around plural form\ntranslation, which can make it seem that nothing special needs to be\ndone in this case.\n\nAdd a specific callout here about marking plural-form strings so that\nthe advice later on in the README is not overlooked.\n\nSigned-off-by: Josh Steadmon \n---\n po/README.md | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/po/README.md b/po/README.md\nindex dcd8436c25..19fabb4acf 100644\n--- a/po/README.md\n+++ b/po/README.md\n@@ -221,6 +221,10 @@ General advice:\n - Adjust the strings so that they're easy to translate. Most of the\n advice in `info '(gettext)Preparing Strings'` applies here.\n \n+- Strings referencing numbers of items may need to be split into singular and\n+ plural forms; see the Q\\_() wrapper in the C sub-section below for an\n+ example.\n+\n - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n comment to tell the translators what to make of it. These will be\n extracted by xgettext(1) and put in the \"po/\\*.po\" files, e.g. from\n\nbase-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc\n-- \n2.34.1.307.g9b7440fafd-goog\n\n"},{"id":"444652","messageId":"YcIkdXcLgzUk3+Jc@google.com","threadId":"57076","inReplyTo":"CANYiYbF31o-sQYU-OjJk=pQR5RHM0k7jqmEhiKGLeO3Suu1khQ@mail.gmail.com","subject":"Re: [PATCH] l10n: README: call more attention to plural strings","fromName":"Josh Steadmon","fromEmail":"steadmon@google.com","sentAt":"2021-12-21T19:01:09Z","receivedAt":"2021-12-21T19:01:17Z","isPatch":true,"sender":{"key":"steadmon@google.com","avatar":"https://avatars.githubusercontent.com/u/2654920?v=4"},"body":"On 2021.12.16 09:10, Jiang Xin wrote:\n> On Tue, Dec 14, 2021 at 6:02 AM Josh Steadmon wrote:\n> >\n> > On 2021.12.13 13:56, Junio C Hamano wrote:\n> > > Josh Steadmon writes:\n> > >\n> > > > In po/README.md, we point core developers to gettext's \"Preparing\n> > > > Strings\" documentation for advice on marking strings for translation.\n> > > > However, this doc doesn't really discuss the issues around plural form\n> > > > translation, which can make it seem that nothing special needs to be\n> > > > done in this case.\n> > > >\n> > > > Add a specific callout here about marking plural-form strings so that\n> > > > the advice later on in the README is not overlooked.\n> > > >\n> > > > Signed-off-by: Josh Steadmon \n> > > > ---\n> > > > po/README.md | 5 ++++-\n> > > > 1 file changed, 4 insertions(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/po/README.md b/po/README.md\n> > > > index dcd8436c25..fd1e024dd3 100644\n> > > > --- a/po/README.md\n> > > > +++ b/po/README.md\n> > > > @@ -219,7 +219,10 @@ General advice:\n> > > > they're part of Git's API.\n> > > >\n> > > > - Adjust the strings so that they're easy to translate. Most of the\n> > > > - advice in `info '(gettext)Preparing Strings'` applies here.\n> > > > + advice in `info '(gettext)Preparing Strings'` applies here. Strings\n> > > > + referencing numbers of items may need to be split into singular and\n> > > > + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> > > > + example.\n> \n> Wouldn't it be better if we add a new rule (\"Strings ... an example.\")\n> after this one?\n\nFixed in V2, thanks!\n"},{"id":"444661","messageId":"xmqq1r25ptjx.fsf@gitster.g","threadId":"57076","inReplyTo":"a9453065c2e89d79fc117363fe41fa10986e06d1.1640113138.git.steadmon@google.com","subject":"Re: [PATCH v2] l10n: README: call more attention to plural strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-21T20:54:58Z","receivedAt":"2021-12-21T20:55:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Josh Steadmon writes:\n\n> In po/README.md, we point core developers to gettext's \"Preparing\n> Strings\" documentation for advice on marking strings for translation.\n> However, this doc doesn't really discuss the issues around plural form\n> translation, which can make it seem that nothing special needs to be\n> done in this case.\n>\n> Add a specific callout here about marking plural-form strings so that\n> the advice later on in the README is not overlooked.\n>\n> Signed-off-by: Josh Steadmon \n> ---\n> po/README.md | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/po/README.md b/po/README.md\n> index dcd8436c25..19fabb4acf 100644\n> --- a/po/README.md\n> +++ b/po/README.md\n> @@ -221,6 +221,10 @@ General advice:\n> - Adjust the strings so that they're easy to translate. Most of the\n> advice in `info '(gettext)Preparing Strings'` applies here.\n> \n> +- Strings referencing numbers of items may need to be split into singular and\n> + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> + example.\n> +\n> - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n> comment to tell the translators what to make of it. These will be\n> extracted by xgettext(1) and put in the \"po/\\*.po\" files, e.g. from\n>\n> base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc\n\nLooks sensible to me.\n\nI do not mind taking this myself, instead of getting it via our i18n\nmanager, if Jiang is OK with it.\n\nThanks.\n"},{"id":"444692","messageId":"CANYiYbFmVRBUgwqKBcOvOz6LRLE8gRUoFfJUjVR7_YeQjjT2ig@mail.gmail.com","threadId":"57076","inReplyTo":"xmqq1r25ptjx.fsf@gitster.g","subject":"Re: [PATCH v2] l10n: README: call more attention to plural strings","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-12-22T01:46:59Z","receivedAt":"2021-12-22T01:47:15Z","isPatch":true,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Wed, Dec 22, 2021 at 4:55 AM Junio C Hamano wrote:\n>\n> Josh Steadmon writes:\n>\n> > In po/README.md, we point core developers to gettext's \"Preparing\n> > Strings\" documentation for advice on marking strings for translation.\n> > However, this doc doesn't really discuss the issues around plural form\n> > translation, which can make it seem that nothing special needs to be\n> > done in this case.\n> >\n> > Add a specific callout here about marking plural-form strings so that\n> > the advice later on in the README is not overlooked.\n> >\n> > Signed-off-by: Josh Steadmon \n> > ---\n> > po/README.md | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/po/README.md b/po/README.md\n> > index dcd8436c25..19fabb4acf 100644\n> > --- a/po/README.md\n> > +++ b/po/README.md\n> > @@ -221,6 +221,10 @@ General advice:\n> > - Adjust the strings so that they're easy to translate. Most of the\n> > advice in `info '(gettext)Preparing Strings'` applies here.\n> >\n> > +- Strings referencing numbers of items may need to be split into singular and\n> > + plural forms; see the Q\\_() wrapper in the C sub-section below for an\n> > + example.\n> > +\n> > - If something is unclear or ambiguous you can use a \"TRANSLATORS\"\n> > comment to tell the translators what to make of it. These will be\n> > extracted by xgettext(1) and put in the \"po/\\*.po\" files, e.g. from\n> >\n> > base-commit: cd3e606211bb1cf8bc57f7d76bab98cc17a150bc\n>\n> Looks sensible to me.\n>\n> I do not mind taking this myself, instead of getting it via our i18n\n> manager, if Jiang is OK with it.\n\nLook good to me, and please help merge, otherwise the patch will have\nto wait about 1 month for the next l10n window.\n\n--\nJiang Xin\n"}]}