{"thread":{"id":"5707","subject":"[PATCH] gitweb: Remove redundant \"tree\" link","startedAt":"2006-09-26T19:45:37Z","lastAt":"2006-09-26T20:27:24Z","messageCount":2,"participants":["Luben Tuikov","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27696","messageId":"20060926194538.46031.qmail@web31809.mail.mud.yahoo.com","threadId":"5707","inReplyTo":null,"subject":"[PATCH] gitweb: Remove redundant \"tree\" link","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-09-26T19:45:37Z","receivedAt":"2006-09-26T19:45:37Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"In \"tree\" view, remove redundant \"tree\" link in the tree\nlisting.  It is identical to simply clicking on the tree\nentry itself.\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |   16 ++++++----------\n 1 files changed, 6 insertions(+), 10 deletions(-)\n\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 959e3f9..8e9c827 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1631,18 +1631,14 @@ sub git_print_tree_entry {\n \t\tprint \"</td>\\n\";\n \n \t} elsif ($t->{'type'} eq \"tree\") {\n-\t\tprint \"<td class=\\\"list\\\">\" .\n-\t\t      $cgi->a({-href => href(action=>\"tree\", hash=>$t->{'hash'},\n-\t\t                             file_name=>\"$basedir$t->{'name'}\", %base_key)},\n-\t\t              esc_html($t->{'name'})) .\n-\t\t      \"</td>\\n\" .\n-\t\t      \"<td class=\\\"link\\\">\" .\n-\t\t      $cgi->a({-href => href(action=>\"tree\", hash=>$t->{'hash'},\n+\t\tprint \"<td class=\\\"list\\\">\";\n+\t\tprint $cgi->a({-href => href(action=>\"tree\", hash=>$t->{'hash'},\n \t\t                             file_name=>\"$basedir$t->{'name'}\", %base_key)},\n-\t\t              \"tree\");\n+\t\t              esc_html($t->{'name'}));\n+\t\tprint \"</td>\\n\";\n+\t\tprint \"<td class=\\\"link\\\">\";\n \t\tif (defined $hash_base) {\n-\t\t\tprint \" | \" .\n-\t\t\t      $cgi->a({-href => href(action=>\"history\", hash_base=>$hash_base,\n+\t\t\tprint $cgi->a({-href => href(action=>\"history\", hash_base=>$hash_base,\n \t\t\t                             file_name=>\"$basedir$t->{'name'}\")},\n \t\t\t              \"history\");\n \t\t}\n-- \n1.4.2.1.g893b0\n"},{"id":"27702","messageId":"efc2f5$eti$1@sea.gmane.org","threadId":"5707","inReplyTo":"20060926194538.46031.qmail@web31809.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: Remove redundant \"tree\" link","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-26T20:27:24Z","receivedAt":"2006-09-26T20:27:24Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Luben Tuikov wrote:\n\n> In \"tree\" view, remove redundant \"tree\" link in the tree\n> listing.  It is identical to simply clicking on the tree\n> entry itself.\n\nI'd rather have this redundancy.\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}