{"thread":{"id":"57045","subject":"Build race observed with git 2.34.1 - hook-list.h wasn't generated yet","startedAt":"2021-12-07T11:31:09Z","lastAt":"2021-12-07T17:39:59Z","messageCount":3,"participants":["Alexander Kanavin","Victoria Dye","Ævar Arnfjörð Bjarmason"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"443266","messageId":"20211207113101.69686-1-alex.kanavin@gmail.com","threadId":"57045","inReplyTo":null,"subject":"Build race observed with git 2.34.1 - hook-list.h wasn't generated yet","fromName":"Alexander Kanavin","fromEmail":"alex.kanavin@gmail.com","sentAt":"2021-12-07T11:31:01Z","receivedAt":"2021-12-07T11:31:09Z","isPatch":false,"sender":{"key":"alex.kanavin@gmail.com","avatar":null},"body":"Specifically:\n\n builtin/bugreport.c:7:10: fatal error: hook-list.h: No such file or directory\n|     7 | #include \"hook-list.h\"\n|       |          ^~~~~~~~~~~~~\n| compilation terminated.\n\nPlease see here for the full log:\nhttps://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/4427/steps/14/logs/stdio\n\nSeems like COMPUTE_HEADER_DEPENDENCIES isn't working quite right? I meanwhile have set it to\n'no'.\n\nThanks,\nAlexander\n"},{"id":"443285","messageId":"0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com","threadId":"57045","inReplyTo":"20211207113101.69686-1-alex.kanavin@gmail.com","subject":"Re: Build race observed with git 2.34.1 - hook-list.h wasn't generated yet","fromName":"Victoria Dye","fromEmail":"vdye@github.com","sentAt":"2021-12-07T14:34:37Z","receivedAt":"2021-12-07T14:34:47Z","isPatch":false,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"Alexander Kanavin wrote:\n> Specifically:\n> \n>  builtin/bugreport.c:7:10: fatal error: hook-list.h: No such file or directory\n> |     7 | #include \"hook-list.h\"\n> |       |          ^~~~~~~~~~~~~\n> | compilation terminated.\n> \n> Please see here for the full log:\n> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/4427/steps/14/logs/stdio\n> \n> Seems like COMPUTE_HEADER_DEPENDENCIES isn't working quite right? I meanwhile have set it to\n> 'no'.\n> \n> Thanks,\n> Alexander\n> \n\nI've encountered this as well, and it appears to be a dependency graph\nissue. For me, compilation was fixed by a patch [1] that isn't in next or\nmaster yet (\"Needs review\" - ab/make-dependency [2]). If this an important\nfix to fast-track (I'll defer to more experienced contributors to determine\nthat), it might speed up review to separate that patch from the rest of the\nseries?\n\n[1] https://lore.kernel.org/git/patch-v4-19.23-2710f8af6cd-20211117T101807Z-avarab@gmail.com/\n\n[2] https://lore.kernel.org/git/xmqqbl1xqheu.fsf@gitster.g/\n"},{"id":"443300","messageId":"211207.86sfv4nwk5.gmgdl@evledraar.gmail.com","threadId":"57045","inReplyTo":"0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com","subject":"Re: Build race observed with git 2.34.1 - hook-list.h wasn't generated yet","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-12-07T17:36:47Z","receivedAt":"2021-12-07T17:39:59Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Tue, Dec 07 2021, Victoria Dye wrote:\n\n> Alexander Kanavin wrote:\n>> Specifically:\n>> \n>>  builtin/bugreport.c:7:10: fatal error: hook-list.h: No such file or directory\n>> |     7 | #include \"hook-list.h\"\n>> |       |          ^~~~~~~~~~~~~\n>> | compilation terminated.\n>> \n>> Please see here for the full log:\n>> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/4427/steps/14/logs/stdio\n>> \n>> Seems like COMPUTE_HEADER_DEPENDENCIES isn't working quite right? I meanwhile have set it to\n>> 'no'.\n>> \n>> Thanks,\n>> Alexander\n>> \n>\n> I've encountered this as well, and it appears to be a dependency graph\n> issue. For me, compilation was fixed by a patch [1] that isn't in next or\n> master yet (\"Needs review\" - ab/make-dependency [2]). If this an important\n> fix to fast-track (I'll defer to more experienced contributors to determine\n> that), it might speed up review to separate that patch from the rest of the\n> series?\n>\n> [1] https://lore.kernel.org/git/patch-v4-19.23-2710f8af6cd-20211117T101807Z-avarab@gmail.com/\n>\n> [2] https://lore.kernel.org/git/xmqqbl1xqheu.fsf@gitster.g/\n\nAs the person who broke it sorry again about the bother.\n\nIf Junio would like to fast-track it that patch is cleanly\ncherry-pickable on top of master.\n\nI review by someone so that ab/make-dependency can move forward is also\nmost welcome.\n\nSuch a review can be done without any particular expertise of the\nMakefile or the \"GNU make\" language. Just check out\ngitster/ab/make-dependency and check if your normal build workflows work\nas expected.\n"}]}