{"thread":{"id":"56997","subject":"patch: change “Everything up-to-date” to “Already up to date.” (No-op messages for git-push and git-pull)","startedAt":"2021-11-30T00:04:17Z","lastAt":"2021-12-03T22:15:24Z","messageCount":4,"participants":["Anselm Schüler","Eric Sunshine","Ævar Arnfjörð Bjarmason","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"442586","messageId":"VUYC3R.9YCVE0AMVVIF@anselmschueler.com","threadId":"56997","inReplyTo":null,"subject":"patch: change “Everything up-to-date” to “Already up to date.” (No-op messages for git-push and git-pull)","fromName":"Anselm Schüler","fromEmail":"mail@anselmschueler.com","sentAt":"2021-11-30T00:04:07Z","receivedAt":"2021-11-30T00:04:17Z","isPatch":false,"sender":{"key":"mail@anselmschueler.com","avatar":"https://gravatar.com/avatar/fb911b2f7cf9596f7bbc61cd9799da5fe87733c0394d6ca79531e07368fd757f?d=mp&s=160"},"body":"Why are the no-op messages for git-push and git-pull (i.e. when remote \nand local are identical) so different, while describing something very \nsimilar? IMO the messages should be either identical or very similar.\ngit-pull results in “Already up to date.”, while git-push results \nin “Everything up-to-date”.\nNote the difference in the usage of “Already” vs. “Everything”, \ndashes vs. spcaes, and a period vs. no period. While I understand that \nthese aren’t saying the same thing and therefore some difference is \nwarranted, might I suggest that this difference be limited to the words \n“Already” and “Everything”?\n\nI have attached a patch—I hope this is a correct way of doing this.\n\nIt should be considered that other messages reading “Already up to \ndate.” seem to use a translation system, it might be better to use \nthat system here, too. Unfortunately, I don’t know how to do that \n(currently). At any rate, this patch could serve as a temporary \n“fix”.\n\n\n\nFrom 01d2df17c0055120f5e16f105effdeeb5d288566 Mon Sep 17 00:00:00 2001\nFrom: =?UTF-8?q?Anselm=20Sch=C3=BCler?= <mail@anselmschueler.com>\nDate: Mon, 29 Nov 2021 00:42:37 +0100\nSubject: [PATCH] =?UTF-8?q?Change=20=E2=80=9CEverything=20up-to-date?=\n =?UTF-8?q?=E2=80=9D=20to=20=E2=80=9CAlready=20up=20to=20date=E2=80=9D=20f?=\n =?UTF-8?q?or=20more=20consistency?=\nMIME-Version: 1.0\nContent-Type: text/plain; charset=UTF-8\nContent-Transfer-Encoding: 8bit\n\nSigned-off-by: Anselm Schüler <mail@anselmschueler.com>\n---\n builtin/send-pack.c | 2 +-\n transport.c         | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/send-pack.c b/builtin/send-pack.c\nindex 69c432ef1a..ad90fb0370 100644\n--- a/builtin/send-pack.c\n+++ b/builtin/send-pack.c\n@@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)\n \t}\n \n \tif (!ret && !transport_refs_pushed(remote_refs))\n-\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\tfprintf(stderr, \"Already up to date.\\n\");\n \n \treturn ret;\n }\ndiff --git a/transport.c b/transport.c\nindex e4f1decae2..1e224794cc 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -1401,7 +1401,7 @@ int transport_push(struct repository *r,\n \t\tif (porcelain && !push_ret)\n \t\t\tputs(\"Done\");\n \t\telse if (!quiet && !ret && !transport_refs_pushed(remote_refs))\n-\t\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\t\tfprintf(stderr, \"Already up to date.\\n\");\n \n \t\treturn ret;\n \t}\n-- \n2.33.1\n\n"},{"id":"442590","messageId":"CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com","threadId":"56997","inReplyTo":"VUYC3R.9YCVE0AMVVIF@anselmschueler.com","subject":"Re: patch: change “Everything up-to-date” to “Already up to date.” (No-op messages for git-push and git-pull)","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-11-30T00:19:12Z","receivedAt":"2021-11-30T00:19:24Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Nov 29, 2021 at 7:04 PM Anselm Schüler <mail@anselmschueler.com> wrote:\n> Why are the no-op messages for git-push and git-pull (i.e. when remote\n> and local are identical) so different, while describing something very\n> similar? IMO the messages should be either identical or very similar.\n> git-pull results in “Already up to date.”, while git-push results\n> in “Everything up-to-date”.\n>\n> It should be considered that other messages reading “Already up to\n> date.” seem to use a translation system, it might be better to use\n> that system here, too. Unfortunately, I don’t know how to do that\n> (currently). At any rate, this patch could serve as a temporary\n> “fix”.\n\nThis question/issue is raised from time to time, and the short answer\nis that send-pack is plumbing, thus there likely will be resistance to\nan arbitrary change of text. Denton goes into a bit more detail in his\nreply[1].\n\n[1]: https://lore.kernel.org/git/20191122180433.GA57478@generichostname/\n"},{"id":"442651","messageId":"211130.86a6hleo84.gmgdl@evledraar.gmail.com","threadId":"56997","inReplyTo":"CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com","subject":"Re: patch: change “Everything up-to-date” to “Already up to date.”(No-op messages for git-push and git-pull)","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-11-30T13:55:47Z","receivedAt":"2021-11-30T14:02:09Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Mon, Nov 29 2021, Eric Sunshine wrote:\n\n> On Mon, Nov 29, 2021 at 7:04 PM Anselm Schüler <mail@anselmschueler.com> wrote:\n>> Why are the no-op messages for git-push and git-pull (i.e. when remote\n>> and local are identical) so different, while describing something very\n>> similar? IMO the messages should be either identical or very similar.\n>> git-pull results in “Already up to date.”, while git-push results\n>> in “Everything up-to-date”.\n>>\n>> It should be considered that other messages reading “Already up to\n>> date.” seem to use a translation system, it might be better to use\n>> that system here, too. Unfortunately, I don’t know how to do that\n>> (currently). At any rate, this patch could serve as a temporary\n>> “fix”.\n>\n> This question/issue is raised from time to time, and the short answer\n> is that send-pack is plumbing, thus there likely will be resistance to\n> an arbitrary change of text. Denton goes into a bit more detail in his\n> reply[1].\n>\n> [1]: https://lore.kernel.org/git/20191122180433.GA57478@generichostname/\n\nYes, but this isn't really applicable to what Anselm really wants to\nchange.\n\nHere, i.e. yes the builtin/send-pack.c part of his patch mayb e suspect,\nbut we can simply skiip that and change the transport.c part, it's API\nthat only builtin/push.c uses.\n\nCurrently transport_push() returns -1 or 0. I think the best change\nthere would be to chang it and its callers to return an enum, so we\ncould have it indicate whether it pushed anything or not.\n\nProbably even better would be to make it stop printing output entirely,\nand to merely have the \"struct ref *\" of remote refs returned to the\ncaller. Then the caller could do the equivalent of\ntransport_refs_pushed() itself.\n\nI.e. we might want to print these in various mixtures of these\nscenarios:\n\n    Already up-to-date\n    Pushed all requested refs\n    Pushed X/Y refs, Y-X were already up-to-date\n\nAnselm: If you're interested in following-up please read\nDocumentation/SubmittingPatches, i.e. send your patch with\ngit-send-email or another method that doesn't send the patch as an\nattachment.\n"},{"id":"443042","messageId":"nycvar.QRO.7.76.6.2112032310300.63@tvgsbejvaqbjf.bet","threadId":"56997","inReplyTo":"CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com","subject":"Re: patch: change “Everything up-to-date” to “Already up to date.” (No-op messages for git-push and git-pull)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-12-03T22:15:10Z","receivedAt":"2021-12-03T22:15:24Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 29 Nov 2021, Eric Sunshine wrote:\n\n> On Mon, Nov 29, 2021 at 7:04 PM Anselm Schüler <mail@anselmschueler.com> wrote:\n> > Why are the no-op messages for git-push and git-pull (i.e. when remote\n> > and local are identical) so different, while describing something very\n> > similar? IMO the messages should be either identical or very similar.\n> > git-pull results in “Already up to date.”, while git-push results\n> > in “Everything up-to-date”.\n> >\n> > It should be considered that other messages reading “Already up to\n> > date.” seem to use a translation system, it might be better to use\n> > that system here, too. Unfortunately, I don’t know how to do that\n> > (currently). At any rate, this patch could serve as a temporary\n> > “fix”.\n>\n> This question/issue is raised from time to time, and the short answer\n> is that send-pack is plumbing, thus there likely will be resistance to\n> an arbitrary change of text. Denton goes into a bit more detail in his\n> reply[1].\n>\n> [1]: https://lore.kernel.org/git/20191122180433.GA57478@generichostname/\n\nAs an additional data point: changing the `git pull` message (actually,\nthe message comes from `merge-recursive.c`, I believe) from \"up-to-date\"\nto \"up to date\" in 7560f547e61 (treewide: correct several \"up-to-date\" to\n\"up to date\", 2017-08-23) broke applications parsing that message (IIRC\nVisual Studio was one of those who had to scramble to adjust their code\naccordingly).\n\nSo yes, we are pretty reluctant to change such central messages.\nSometimes, correct grammar ain't worth the cost it incurs.\n\nCiao,\nJohannes\n"}]}