{"thread":{"id":"5699","subject":"[PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1","startedAt":"2006-09-26T09:42:55Z","lastAt":"2006-09-26T18:14:02Z","messageCount":2,"participants":["Sergey Vlasov","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27673","messageId":"1159263775639-git-send-email-vsu@altlinux.ru","threadId":"5699","inReplyTo":null,"subject":"[PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1","fromName":"Sergey Vlasov","fromEmail":"vsu@altlinux.ru","sentAt":"2006-09-26T09:42:55Z","receivedAt":"2006-09-26T09:42:55Z","isPatch":true,"sender":{"key":"vsu@altlinux.ru","avatar":"https://avatars.githubusercontent.com/u/616082?v=4"},"body":"When using Subversion 1.3.1 without Perl bindings (GIT_SVN_NO_LIB=1),\n\"git-svn fetch --no-ignore-externals\" fails with errors like:\n\n  Tree (.../.git/svn/git-svn/tree) is not clean:\n  X      directory_with_external\n\nIn this case the 'X' lines in the \"svn status\" output are not a sign\nof unclean tree, and therefore should be ignored.\n\nSigned-off-by: Sergey Vlasov <vsu@altlinux.ru>\n---\n git-svn.perl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 0290850..2f5cf90 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1246,6 +1246,7 @@ sub assert_svn_wc_clean {\n \t}\n \tmy @status = grep(!/^Performing status on external/,(`svn status`));\n \t@status = grep(!/^\\s*$/,@status);\n+\t@status = grep(!/^X/,@status) if $_no_ignore_ext;\n \tif (scalar @status) {\n \t\tprint STDERR \"Tree ($SVN_WC) is not clean:\\n\";\n \t\tprint STDERR $_ foreach @status;\n-- \n1.4.2.1.ga8608c\n"},{"id":"27692","messageId":"20060926181401.GA1479@hand.yhbt.net","threadId":"5699","inReplyTo":"1159263775639-git-send-email-vsu@altlinux.ru","subject":"Re: [PATCH] git-svn: Fix fetch --no-ignore-externals with GIT_SVN_NO_LIB=1","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-09-26T18:14:02Z","receivedAt":"2006-09-26T18:14:02Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Sergey Vlasov <vsu@altlinux.ru> wrote:\n> When using Subversion 1.3.1 without Perl bindings (GIT_SVN_NO_LIB=1),\n> \"git-svn fetch --no-ignore-externals\" fails with errors like:\n> \n>   Tree (.../.git/svn/git-svn/tree) is not clean:\n>   X      directory_with_external\n> \n> In this case the 'X' lines in the \"svn status\" output are not a sign\n> of unclean tree, and therefore should be ignored.\n> \n> Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>\n\nAcked-by: Eric Wong <normalperson@yhbt.net>\n\n-- \nEric Wong\n"}]}