{"thread":{"id":"56966","subject":"\"format-patch\" command doesn't support SSH signing","startedAt":"2021-11-23T13:04:32Z","lastAt":"2021-11-24T00:49:49Z","messageCount":4,"participants":["Marcos Alano","Ævar Arnfjörð Bjarmason","Johannes Schindelin","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"442146","messageId":"710dc612-0e3f-bf10-b123-f9443e605d00@gmail.com","threadId":"56966","inReplyTo":null,"subject":"\"format-patch\" command doesn't support SSH signing","fromName":"Marcos Alano","fromEmail":"marcoshalano@gmail.com","sentAt":"2021-11-23T13:04:17Z","receivedAt":"2021-11-23T13:04:32Z","isPatch":false,"sender":{"key":"marcoshalano@gmail.com","avatar":"https://gravatar.com/avatar/e9d7f22abbfb2fcde753aab73d4ffb91d9a9df10f246fa7945ab3d3cc905684d?d=mp&s=160"},"body":"Hello,\n\nI was trying to generate a patch to send to a project (Linux \nspecifically) but when I generate the patch using \"format-patch\" I saw \nthere was no \"Signed-Off\" line, but my commit is signed using SSH. My \ngit version is the latest, 2.34.\n\nThank you.\n\n"},{"id":"442161","messageId":"211123.86wnkyuaeq.gmgdl@evledraar.gmail.com","threadId":"56966","inReplyTo":"710dc612-0e3f-bf10-b123-f9443e605d00@gmail.com","subject":"Re: \"format-patch\" command doesn't support SSH signing","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-11-23T16:02:07Z","receivedAt":"2021-11-23T16:03:30Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Tue, Nov 23 2021, Marcos Alano wrote:\n\n> Hello,\n>\n> I was trying to generate a patch to send to a project (Linux\n> specifically) but when I generate the patch using \"format-patch\" I saw \n> there was no \"Signed-Off\" line, but my commit is signed using SSH. My\n> git version is the latest, 2.34.\n\nThe Signed-off-by in commit messages doesn't have anything to do with\nSSH, GPG etc. signing, it's just a way of signaling that you're the\nauthor of the change, and/or can certify it as being includable in the\nproject for authorship & copyright reasons. It's mostly used in\nlinux.git and git.git, see a \"git grep Signed-off-by\" in those for more\ndetails.\n"},{"id":"442163","messageId":"nycvar.QRO.7.76.6.2111231712510.63@tvgsbejvaqbjf.bet","threadId":"56966","inReplyTo":"710dc612-0e3f-bf10-b123-f9443e605d00@gmail.com","subject":"Re: \"format-patch\" command doesn't support SSH signing","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-11-23T16:14:27Z","receivedAt":"2021-11-23T16:14:32Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Marcos,\n\nOn Tue, 23 Nov 2021, Marcos Alano wrote:\n\n> I was trying to generate a patch to send to a project (Linux specifically) but\n> when I generate the patch using \"format-patch\" I saw there was no \"Signed-Off\"\n> line, but my commit is signed using SSH. My git version is the latest, 2.34.\n\nA \"Sign-off\" is a convention for the commit message, but _signing a\ncommit_ is a cryptographic signature. They are two different things.\n\nYou can add the \"Signed-off-by:\" trailers via `git format-patch`'s\n`--signoff` option:\nhttps://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt---signoff\n\nCiao,\nJohannes\n"},{"id":"442217","messageId":"xmqqczmq5qdx.fsf@gitster.g","threadId":"56966","inReplyTo":"710dc612-0e3f-bf10-b123-f9443e605d00@gmail.com","subject":"Re: \"format-patch\" command doesn't support SSH signing","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-11-24T00:49:46Z","receivedAt":"2021-11-24T00:49:49Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marcos Alano <marcoshalano@gmail.com> writes:\n\n> I was trying to generate a patch to send to a project (Linux\n> specifically) but when I generate the patch using \"format-patch\" I saw \n> there was no \"Signed-Off\" line, but my commit is signed using SSH. My\n> git version is the latest, 2.34.\n\nSign-off in Linux kernel project is to certify that you have the\nright to contribute the change to the project under Developers\ncertificate of origin.  I believe in thier project, the document\nin Documentation/process/submitting-patches.rst describes the\nprocess (look for \"Sign your work\")\n\nThe \"commit -s\" signing has nothing to do with it.  It may prove it\nwas written by the key holder, but it does not prevent the key\nholder to steal intellectual property from their employer and\ncontribute it as if it is their own, and Sign-off exists as a\nseparate procedure to have you raise your right hand and swear that\nyour contribution is kosher wrt DCO.\n\n\n"}]}