{"thread":{"id":"56963","subject":"[PATCH] completion: add human and auto: date format","startedAt":"2021-11-23T11:27:59Z","lastAt":"2021-11-25T11:47:51Z","messageCount":2,"participants":["Yoichi NAKAYAMA via GitGitGadget","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"442107","messageId":"pull.1083.git.1637666875171.gitgitgadget@gmail.com","threadId":"56963","inReplyTo":null,"subject":"[PATCH] completion: add human and auto: date format","fromName":"Yoichi NAKAYAMA via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-11-23T11:27:55Z","receivedAt":"2021-11-23T11:27:59Z","isPatch":true,"sender":{"key":"yoichi.nakayama@gmail.com","avatar":"https://avatars.githubusercontent.com/u/107537?v=4"},"body":"From: Yoichi Nakayama <yoichi.nakayama@gmail.com>\n\nhuman was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc\nauto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182\n\nThose formats were missing when other values were added to completion\nat 5a59a2301f6ec9bcf1b101edb9ca33beb465842f\n\nSigned-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>\n---\n    completion: add human and auto: date format\n    \n    In bash/zsh completion for git log --date=, following values are\n    missing:\n    \n     * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)\n     * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)\n    \n    They did exist when other values were added to completion at\n    5a59a2301f6ec9bcf1b101edb9ca33beb465842f\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1083\n\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 7c3a75373a4..37fd5c4c885 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2001,7 +2001,7 @@ __git_log_shortlog_options=\"\n \"\n \n __git_log_pretty_formats=\"oneline short medium full fuller reference email raw format: tformat: mboxrd\"\n-__git_log_date_formats=\"relative iso8601 iso8601-strict rfc2822 short local default raw unix format:\"\n+__git_log_date_formats=\"relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:\"\n \n _git_log ()\n {\n\nbase-commit: 0ea906d20517145895193a99666d5f2860a04360\n-- \ngitgitgadget\n"},{"id":"442301","messageId":"nycvar.QRO.7.76.6.2111251245200.63@tvgsbejvaqbjf.bet","threadId":"56963","inReplyTo":"pull.1083.git.1637666875171.gitgitgadget@gmail.com","subject":"Re: [PATCH] completion: add human and auto: date format","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-11-25T11:45:45Z","receivedAt":"2021-11-25T11:47:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Yoichi,\n\nOn Tue, 23 Nov 2021, Yoichi NAKAYAMA via GitGitGadget wrote:\n\n> From: Yoichi Nakayama <yoichi.nakayama@gmail.com>\n>\n> human was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc\n> auto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182\n>\n> Those formats were missing when other values were added to completion\n> at 5a59a2301f6ec9bcf1b101edb9ca33beb465842f\n>\n> Signed-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>\n\nThe commit message and the patch look good to me.\n\nThanks!\nDscho\n\n> ---\n>     completion: add human and auto: date format\n>\n>     In bash/zsh completion for git log --date=, following values are\n>     missing:\n>\n>      * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)\n>      * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)\n>\n>     They did exist when other values were added to completion at\n>     5a59a2301f6ec9bcf1b101edb9ca33beb465842f\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1083\n>\n>  contrib/completion/git-completion.bash | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 7c3a75373a4..37fd5c4c885 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -2001,7 +2001,7 @@ __git_log_shortlog_options=\"\n>  \"\n>\n>  __git_log_pretty_formats=\"oneline short medium full fuller reference email raw format: tformat: mboxrd\"\n> -__git_log_date_formats=\"relative iso8601 iso8601-strict rfc2822 short local default raw unix format:\"\n> +__git_log_date_formats=\"relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:\"\n>\n>  _git_log ()\n>  {\n>\n> base-commit: 0ea906d20517145895193a99666d5f2860a04360\n> --\n> gitgitgadget\n>\n"}]}