{"thread":{"id":"56960","subject":"[PATCH] Doc: no midx and partial clone relation","startedAt":"2021-11-22T18:41:22Z","lastAt":"2021-11-22T19:29:48Z","messageCount":2,"participants":["Jonathan Tan","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"442005","messageId":"20211122184114.3328662-1-jonathantanmy@google.com","threadId":"56960","inReplyTo":null,"subject":"[PATCH] Doc: no midx and partial clone relation","fromName":"Jonathan Tan","fromEmail":"jonathantanmy@google.com","sentAt":"2021-11-22T18:41:14Z","receivedAt":"2021-11-22T18:41:22Z","isPatch":true,"sender":{"key":"jonathantanmy@fastmail.com","avatar":null},"body":"The multi-pack index treats promisor packfiles (that is, packfiles that\nhave an accompanying .promisor file) the same as other packfiles. Remove\na section in the documentation that seems to indicate otherwise.\n\nSigned-off-by: Jonathan Tan <jonathantanmy@google.com>\n---\nStolee, can you check if my understanding is correct?\n\nTo my recollection, midx does not treat promisor packfiles specially,\nand searching for \"promisor\" in midx.c seems to support that (the only\nresults are relating to selection of commits for midx bitmap creation).\n---\n Documentation/technical/multi-pack-index.txt | 5 -----\n 1 file changed, 5 deletions(-)\n\ndiff --git a/Documentation/technical/multi-pack-index.txt b/Documentation/technical/multi-pack-index.txt\nindex 86f40f2490..fc213cd1e6 100644\n--- a/Documentation/technical/multi-pack-index.txt\n+++ b/Documentation/technical/multi-pack-index.txt\n@@ -87,11 +87,6 @@ Future Work\n   helpful to organize packfiles by object type (commit, tree, blob,\n   etc.) and use this metadata to help that maintenance.\n \n-- The partial clone feature records special \"promisor\" packs that\n-  may point to objects that are not stored locally, but available\n-  on request to a server. The multi-pack-index does not currently\n-  track these promisor packs.\n-\n Related Links\n -------------\n [0] https://bugs.chromium.org/p/git/issues/detail?id=6\n-- \n2.34.0.rc2.393.gf8c9666880-goog\n\n"},{"id":"442014","messageId":"69e71cf4-ddab-4791-79e1-51ed990a0273@gmail.com","threadId":"56960","inReplyTo":"20211122184114.3328662-1-jonathantanmy@google.com","subject":"Re: [PATCH] Doc: no midx and partial clone relation","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2021-11-22T19:29:42Z","receivedAt":"2021-11-22T19:29:48Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 11/22/2021 1:41 PM, Jonathan Tan wrote:\n> The multi-pack index treats promisor packfiles (that is, packfiles that\n> have an accompanying .promisor file) the same as other packfiles. Remove\n> a section in the documentation that seems to indicate otherwise.\n> \n> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>\n> ---\n> Stolee, can you check if my understanding is correct?\n> \n> To my recollection, midx does not treat promisor packfiles specially,\n> and searching for \"promisor\" in midx.c seems to support that (the only\n> results are relating to selection of commits for midx bitmap creation).\n\nYes, you are correct that the promisor packfiles are included in\nthe multi-pack-index.\n\n> -- The partial clone feature records special \"promisor\" packs that\n> -  may point to objects that are not stored locally, but available\n> -  on request to a server. The multi-pack-index does not currently\n> -  track these promisor packs.\n> -\n\nThe intention of this paragraph was probably that the multi-pack-index\nfile does not track the properties of a pack-file such as whether a\n.promisor or .keep file exists. I think one thought was to eventually\nlet the multi-pack-index track those properties, but there wasn't much\nvalue in it.\n\nDeleting this paragraph is a suitable clarification.\n\nThanks,\n-Stolee\n"}]}