{"thread":{"id":"56929","subject":"git-gui bugs due to dependency on system Wish on MacOS","startedAt":"2021-11-17T19:06:55Z","lastAt":"2021-11-17T19:15:47Z","messageCount":2,"participants":["Glen Choo"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"441520","messageId":"kl6lzgq2ha9k.fsf@chooglen-macbookpro.roam.corp.google.com","threadId":"56929","inReplyTo":null,"subject":"git-gui bugs due to dependency on system Wish on MacOS","fromName":"Glen Choo","fromEmail":"chooglen@google.com","sentAt":"2021-11-17T19:06:47Z","receivedAt":"2021-11-17T19:06:55Z","isPatch":false,"sender":{"key":"glencbz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58092771?v=4"},"body":"\nHi! We've received reports that git-gui is showing black windows upon\nupgrading to MacOS Monterey. It seems to be the same issue as [1], but\nsomehow it's only appeared for our users on Monterey and not Mojave.\n\nTKFRAMEWORK = /Library/Frameworks/Tk.framework/Resources/Wish.app\n\n* Github Issue https://github.com/Homebrew/homebrew-core/issues/39987\n* git-gui formula https://formulae.brew.sh/formula/git-gui\n\n$ brew install tcl-tk\n$ PATH=/usr/local/opt/tcl-tk/bin:$PATH # This contains wish\n$ cd /path/to/git/git-gui/\n$ ./git-gui.sh\n\n[1] https://github.com/prati0100/git-gui/issues/48\nThat said, Homebrew seems to have worked around this problem altogether\nby including their own Tcl/Tk dependency.\n\nI dug a little deeper and I was able to fix the theming issues by using\na different version of wish:\n\nNote that I had to call git-gui.sh because that's the only entrypoint\nthat doesn't use the system Wish referenced in the Makefile.\n\nIs this a fix that we should make in the git-gui project?\n"},{"id":"441521","messageId":"kl6lwnl6h9uq.fsf@chooglen-macbookpro.roam.corp.google.com","threadId":"56929","inReplyTo":"kl6lzgq2ha9k.fsf@chooglen-macbookpro.roam.corp.google.com","subject":"Re: git-gui bugs due to dependency on system Wish on MacOS","fromName":"Glen Choo","fromEmail":"chooglen@google.com","sentAt":"2021-11-17T19:15:41Z","receivedAt":"2021-11-17T19:15:47Z","isPatch":false,"sender":{"key":"glencbz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58092771?v=4"},"body":"It looks like the previous message's formatting got messed up somehow...\nthe correct formatting is below:\n\nHi! We've received reports that git-gui is showing black windows upon\nupgrading to MacOS Monterey. It seems to be the same issue as [1], but\nsomehow it's only appeared for our users on Monterey and not Mojave.\n\nI dug a little deeper and I was able to fix the theming issues by using\na different version of wish:\n\n  $ brew install tcl-tk\n  $ PATH=/usr/local/opt/tcl-tk/bin:$PATH # This contains wish\n  $ cd /path/to/git/git-gui/\n  $ ./git-gui.sh\n\nNote that I had to call git-gui.sh because that's the only entrypoint\nthat doesn't use the system Wish referenced in the Makefile:\n\n  TKFRAMEWORK = /Library/Frameworks/Tk.framework/Resources/Wish.app\n\nThat said, Homebrew seems to have worked around this problem altogether\nby including their own Tcl/Tk dependency.\n\n* Github Issue https://github.com/Homebrew/homebrew-core/issues/39987\n* git-gui formula https://formulae.brew.sh/formula/git-gui\n\nIs this a fix that we should make in the git-gui project?\n\n[1] https://github.com/prati0100/git-gui/issues/48\n"}]}