{"thread":{"id":"56918","subject":"Need help in understanding how to submit a patch","startedAt":"2021-11-16T21:15:19Z","lastAt":"2021-11-18T22:00:17Z","messageCount":9,"participants":["Etienne Guillot","Philip Oakley","Pratyush Yadav","Taylor Blau","Jiang Xin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"441364","messageId":"127c9dbd-4861-beea-a85b-af7412ce141f@etguillot.fr","threadId":"56918","inReplyTo":null,"subject":"Need help in understanding how to submit a patch","fromName":"Etienne Guillot","fromEmail":"git@etguillot.fr","sentAt":"2021-11-16T21:15:14Z","receivedAt":"2021-11-16T21:15:19Z","isPatch":false,"sender":{"key":"git@etguillot.fr","avatar":null},"body":"Hi,\n\nI found a typo mistake in the french translation of git-gui.\nI did read the instructions on this page\nhttps://git-scm.com/docs/SubmittingPatches\nbut I still not sure where should I push the correction.\n\nThanks for your help\n\nEtienne Guillot\n"},{"id":"441504","messageId":"6fa0b1dd-ac20-ff55-95ea-1c22347f9199@iee.email","threadId":"56918","inReplyTo":"127c9dbd-4861-beea-a85b-af7412ce141f@etguillot.fr","subject":"Re: Need help in understanding how to submit a patch","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2021-11-17T15:47:21Z","receivedAt":"2021-11-17T15:47:26Z","isPatch":false,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 16/11/2021 21:15, Etienne Guillot wrote:\n> Hi,\n>\n> I found a typo mistake in the french translation of git-gui.\n> I did read the instructions on this page\n> https://git-scm.com/docs/SubmittingPatches\n> but I still not sure where should I push the correction.\n>\n> Thanks for your help\n>\n> Etienne Guillot\nHi Etienne\n\nThe Git Gui is managed by Pratyush Yadav (cc'd) and hosted at \nhttps://github.com/prati0100/git-gui\n\nNot sure what the latest is on contributing translations (not covered in\nthe GitHub Readme..).\n\nPhilip\n"},{"id":"441514","messageId":"20211117175149.7slohfqqwsmn3ua6@yadavpratyush.com","threadId":"56918","inReplyTo":"6fa0b1dd-ac20-ff55-95ea-1c22347f9199@iee.email","subject":"Re: Need help in understanding how to submit a patch","fromName":"Pratyush Yadav","fromEmail":"me@yadavpratyush.com","sentAt":"2021-11-17T17:51:49Z","receivedAt":"2021-11-17T17:51:58Z","isPatch":false,"sender":{"key":"me@yadavpratyush.com","avatar":"https://avatars.githubusercontent.com/u/8817931?v=4"},"body":"Hi Etienne,\n\nOn 17/11/21 03:47PM, Philip Oakley wrote:\n> On 16/11/2021 21:15, Etienne Guillot wrote:\n> > Hi,\n> >\n> > I found a typo mistake in the french translation of git-gui.\n> > I did read the instructions on this page\n> > https://git-scm.com/docs/SubmittingPatches\n> > but I still not sure where should I push the correction.\n> >\n> > Thanks for your help\n> >\n> > Etienne Guillot\n> Hi Etienne\n> \n> The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at \n> https://github.com/prati0100/git-gui\n> \n> Not sure what the latest is on contributing translations (not covered in\n> the GitHub Readme..).\n\nI usually ask people to post patches on this mailing list and I review \nthem here. But I make an exception for translation changes since they \nnever get any reviews anyway.\n\nSo I am fine with either a Pull Request on GitHub or a patch on the \nmailing list.\n\n-- \nRegards,\nPratyush Yadav\n"},{"id":"441515","messageId":"YZVB5hy4Xuim5K9B@nand.local","threadId":"56918","inReplyTo":"20211117175149.7slohfqqwsmn3ua6@yadavpratyush.com","subject":"Re: Need help in understanding how to submit a patch","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-11-17T17:54:46Z","receivedAt":"2021-11-17T17:55:06Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Jiang,\n\nOn Wed, Nov 17, 2021 at 11:21:49PM +0530, Pratyush Yadav wrote:\n> Hi Etienne,\n>\n> On 17/11/21 03:47PM, Philip Oakley wrote:\n> > On 16/11/2021 21:15, Etienne Guillot wrote:\n> > > Hi,\n> > >\n> > > I found a typo mistake in the french translation of git-gui.\n> > > I did read the instructions on this page\n> > > https://git-scm.com/docs/SubmittingPatches\n> > > but I still not sure where should I push the correction.\n> > >\n> > > Thanks for your help\n> > >\n> > > Etienne Guillot\n> > Hi Etienne\n> >\n> > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at \n> > https://github.com/prati0100/git-gui\n> >\n> > Not sure what the latest is on contributing translations (not covered in\n> > the GitHub Readme..).\n>\n> I usually ask people to post patches on this mailing list and I review\n> them here. But I make an exception for translation changes since they\n> never get any reviews anyway.\n>\n> So I am fine with either a Pull Request on GitHub or a patch on the\n> mailing list.\n\nSince Pratyush is the maintainer, does the po/TEAMS file in your tree\nneed updating?\n\nI'm not sure how up-to-date the file is in general, but the last commit\nwas made semi-recently back in August, so I assume that the entry for\nthe French translation is outdated.\n\nThanks,\nTaylor\n"},{"id":"441551","messageId":"CANYiYbG0CF0hC+yamdNFz8cytB+W4onRkqXusNoWR1xv2aqJzw@mail.gmail.com","threadId":"56918","inReplyTo":"20211117175149.7slohfqqwsmn3ua6@yadavpratyush.com","subject":"Re: Need help in understanding how to submit a patch","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-11-18T01:13:56Z","receivedAt":"2021-11-18T01:14:10Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Thu, Nov 18, 2021 at 3:34 AM Pratyush Yadav <me@yadavpratyush.com> wrote:\n>\n> Hi Etienne,\n>\n> On 17/11/21 03:47PM, Philip Oakley wrote:\n> > On 16/11/2021 21:15, Etienne Guillot wrote:\n> > > Hi,\n> > >\n> > > I found a typo mistake in the french translation of git-gui.\n> > > I did read the instructions on this page\n> > > https://git-scm.com/docs/SubmittingPatches\n> > > but I still not sure where should I push the correction.\n> > >\n> > > Thanks for your help\n> > >\n> > > Etienne Guillot\n> > Hi Etienne\n> >\n> > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at\n> > https://github.com/prati0100/git-gui\n> >\n> > Not sure what the latest is on contributing translations (not covered in\n> > the GitHub Readme..).\n>\n> I usually ask people to post patches on this mailing list and I review\n> them here. But I make an exception for translation changes since they\n> never get any reviews anyway.\n>\n> So I am fine with either a Pull Request on GitHub or a patch on the\n> mailing list.\n\nFor l10n of git project (not git-gui), different l10n teams use\ndifferent code review strategy, but at last all l10n team leaders will\nsend pull requests to \"git-l10n/git-po\" on GitHub. There are some sort\nof code reviews for l10n and most of them are basically focused on\ncommit logs and typos. See:\n\n    https://github.com/git-l10n/git-po/pulls?q=is%3Apr+is%3Aclosed\n\nStarting from the recent release cycle of git 2.34.0, l10n of git has\na CI workflow and the CI robot can give some review suggestions for\nl10n contributions using a helper program.\n\n    https://github.com/git-l10n/git-po/actions/workflows/l10n.yml?query=event%3Apull_request_target\n\nThe helper program can be rewrite to help l10n for git-gui project.\n\n    https://github.com/git-l10n/git-po-helper\n\n--\nJiang Xin\n"},{"id":"441554","messageId":"CANYiYbFq-SAq2VLcFFX8P=Y8-JzjqW63mJqTuOCgO+q+Zzf=DQ@mail.gmail.com","threadId":"56918","inReplyTo":"YZVB5hy4Xuim5K9B@nand.local","subject":"Re: Need help in understanding how to submit a patch","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-11-18T01:37:57Z","receivedAt":"2021-11-18T01:38:10Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Thu, Nov 18, 2021 at 1:54 AM Taylor Blau <me@ttaylorr.com> wrote:\n>\n> Jiang,\n>\n> On Wed, Nov 17, 2021 at 11:21:49PM +0530, Pratyush Yadav wrote:\n> > Hi Etienne,\n> >\n> > On 17/11/21 03:47PM, Philip Oakley wrote:\n> > > On 16/11/2021 21:15, Etienne Guillot wrote:\n> > > > Hi,\n> > > >\n> > > > I found a typo mistake in the french translation of git-gui.\n> > > > I did read the instructions on this page\n> > > > https://git-scm.com/docs/SubmittingPatches\n> > > > but I still not sure where should I push the correction.\n> > > >\n> > > > Thanks for your help\n> > > >\n> > > > Etienne Guillot\n> > > Hi Etienne\n> > >\n> > > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at\n> > > https://github.com/prati0100/git-gui\n> > >\n> > > Not sure what the latest is on contributing translations (not covered in\n> > > the GitHub Readme..).\n> >\n> > I usually ask people to post patches on this mailing list and I review\n> > them here. But I make an exception for translation changes since they\n> > never get any reviews anyway.\n> >\n> > So I am fine with either a Pull Request on GitHub or a patch on the\n> > mailing list.\n>\n> Since Pratyush is the maintainer, does the po/TEAMS file in your tree\n> need updating?\n\nGit Gui is a standalone project with its own workflow. The file\n\"po/TEAMS\" is only used for Git project, so I am a little confused how\nto update this file?\n\n> I'm not sure how up-to-date the file is in general, but the last commit\n> was made semi-recently back in August, so I assume that the entry for\n> the French translation is outdated.\n\nFrench l10n team is led by Jean-Noël Avila, and is very active.\n\n    git log --no-merges -- po/fr.po\n\nL10n for git-gui are maintained by different people though.  Because\n\"git-gui\" is merged into git using subtree merge strategy,  I cannot\nfind commit logs of \"git-gui/po/fr.po\" using the same command, and\nhave to find the original git-gui commit, and find commit logs from\n\"po/fr.po\" (which is quite different file from \"po/fr.po\" of Git).\n\n    git log 8a383db4b2 -- po/fr.po\n\n--\nJiang Xin\n"},{"id":"441555","messageId":"YZWvJdWcmhIl9DxR@nand.local","threadId":"56918","inReplyTo":"CANYiYbFq-SAq2VLcFFX8P=Y8-JzjqW63mJqTuOCgO+q+Zzf=DQ@mail.gmail.com","subject":"Re: Need help in understanding how to submit a patch","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-11-18T01:40:53Z","receivedAt":"2021-11-18T01:40:58Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Nov 18, 2021 at 09:37:57AM +0800, Jiang Xin wrote:\n> On Thu, Nov 18, 2021 at 1:54 AM Taylor Blau <me@ttaylorr.com> wrote:\n> >\n> > Jiang,\n> >\n> > On Wed, Nov 17, 2021 at 11:21:49PM +0530, Pratyush Yadav wrote:\n> > > Hi Etienne,\n> > >\n> > > On 17/11/21 03:47PM, Philip Oakley wrote:\n> > > > On 16/11/2021 21:15, Etienne Guillot wrote:\n> > > > > Hi,\n> > > > >\n> > > > > I found a typo mistake in the french translation of git-gui.\n> > > > > I did read the instructions on this page\n> > > > > https://git-scm.com/docs/SubmittingPatches\n> > > > > but I still not sure where should I push the correction.\n> > > > >\n> > > > > Thanks for your help\n> > > > >\n> > > > > Etienne Guillot\n> > > > Hi Etienne\n> > > >\n> > > > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at\n> > > > https://github.com/prati0100/git-gui\n> > > >\n> > > > Not sure what the latest is on contributing translations (not covered in\n> > > > the GitHub Readme..).\n> > >\n> > > I usually ask people to post patches on this mailing list and I review\n> > > them here. But I make an exception for translation changes since they\n> > > never get any reviews anyway.\n> > >\n> > > So I am fine with either a Pull Request on GitHub or a patch on the\n> > > mailing list.\n> >\n> > Since Pratyush is the maintainer, does the po/TEAMS file in your tree\n> > need updating?\n>\n> Git Gui is a standalone project with its own workflow. The file\n> \"po/TEAMS\" is only used for Git project, so I am a little confused how\n> to update this file?\n\nI misread Etienne's original message, I thought they were asking about\nthe French translation for Git, not git-gui.\n\n> > I'm not sure how up-to-date the file is in general, but the last commit\n> > was made semi-recently back in August, so I assume that the entry for\n> > the French translation is outdated.\n>\n> French l10n team is led by Jean-Noël Avila, and is very active.\n>\n>     git log --no-merges -- po/fr.po\n>\n> L10n for git-gui are maintained by different people though.  Because\n> \"git-gui\" is merged into git using subtree merge strategy,  I cannot\n> find commit logs of \"git-gui/po/fr.po\" using the same command, and\n> have to find the original git-gui commit, and find commit logs from\n> \"po/fr.po\" (which is quite different file from \"po/fr.po\" of Git).\n>\n>     git log 8a383db4b2 -- po/fr.po\n\nYes, clearly no update is necessary here. Sorry for the confusion.\n\nThanks,\nTaylor\n"},{"id":"441556","messageId":"CANYiYbGuR8WNvD_2Kw_M0XX9H027Z2m137S0zwrfL7oURSpTUw@mail.gmail.com","threadId":"56918","inReplyTo":"YZWvJdWcmhIl9DxR@nand.local","subject":"Re: Need help in understanding how to submit a patch","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2021-11-18T01:52:14Z","receivedAt":"2021-11-18T01:52:29Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Thu, Nov 18, 2021 at 9:40 AM Taylor Blau <me@ttaylorr.com> wrote:\n>\n> On Thu, Nov 18, 2021 at 09:37:57AM +0800, Jiang Xin wrote:\n> > On Thu, Nov 18, 2021 at 1:54 AM Taylor Blau <me@ttaylorr.com> wrote:\n> > >\n> > > Jiang,\n> > >\n> > > On Wed, Nov 17, 2021 at 11:21:49PM +0530, Pratyush Yadav wrote:\n> > > > Hi Etienne,\n> > > >\n> > > > On 17/11/21 03:47PM, Philip Oakley wrote:\n> > > > > On 16/11/2021 21:15, Etienne Guillot wrote:\n> > > > > > Hi,\n> > > > > >\n> > > > > > I found a typo mistake in the french translation of git-gui.\n> > > > > > I did read the instructions on this page\n> > > > > > https://git-scm.com/docs/SubmittingPatches\n> > > > > > but I still not sure where should I push the correction.\n> > > > > >\n> > > > > > Thanks for your help\n> > > > > >\n> > > > > > Etienne Guillot\n> > > > > Hi Etienne\n> > > > >\n> > > > > The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at\n> > > > > https://github.com/prati0100/git-gui\n> > > > >\n> > > > > Not sure what the latest is on contributing translations (not covered in\n> > > > > the GitHub Readme..).\n> > > >\n> > > > I usually ask people to post patches on this mailing list and I review\n> > > > them here. But I make an exception for translation changes since they\n> > > > never get any reviews anyway.\n> > > >\n> > > > So I am fine with either a Pull Request on GitHub or a patch on the\n> > > > mailing list.\n> > >\n> > > Since Pratyush is the maintainer, does the po/TEAMS file in your tree\n> > > need updating?\n> >\n> > Git Gui is a standalone project with its own workflow. The file\n> > \"po/TEAMS\" is only used for Git project, so I am a little confused how\n> > to update this file?\n>\n> I misread Etienne's original message, I thought they were asking about\n> the French translation for Git, not git-gui.\n>\n> > > I'm not sure how up-to-date the file is in general, but the last commit\n> > > was made semi-recently back in August, so I assume that the entry for\n> > > the French translation is outdated.\n> >\n> > French l10n team is led by Jean-Noël Avila, and is very active.\n> >\n> >     git log --no-merges -- po/fr.po\n> >\n> > L10n for git-gui are maintained by different people though.  Because\n> > \"git-gui\" is merged into git using subtree merge strategy,  I cannot\n> > find commit logs of \"git-gui/po/fr.po\" using the same command, and\n> > have to find the original git-gui commit, and find commit logs from\n> > \"po/fr.po\" (which is quite different file from \"po/fr.po\" of Git).\n> >\n> >     git log 8a383db4b2 -- po/fr.po\n>\n> Yes, clearly no update is necessary here. Sorry for the confusion.\n\nIt's really easy to confuse. No problem.\n\nBTW, what is the elegant way to find commit logs of a tree from a subtree merge?\n\nI have to run git-log on \"git-gui\" to find the 2nd parent commit ID of\nthe subtree merge, and run git-log on it.\n\n--\nJiang Xin\n"},{"id":"441662","messageId":"5a5ac5a9-dda8-ece6-2f35-6362e5085ed6@etguillot.fr","threadId":"56918","inReplyTo":"CANYiYbGuR8WNvD_2Kw_M0XX9H027Z2m137S0zwrfL7oURSpTUw@mail.gmail.com","subject":"Re: Need help in understanding how to submit a patch","fromName":"Etienne Guillot","fromEmail":"git@etguillot.fr","sentAt":"2021-11-18T21:54:54Z","receivedAt":"2021-11-18T22:00:17Z","isPatch":false,"sender":{"key":"git@etguillot.fr","avatar":null},"body":"\n\nOn 11/18/21 02:52, Jiang Xin wrote:\n> On Thu, Nov 18, 2021 at 9:40 AM Taylor Blau <me@ttaylorr.com> wrote:\n>>\n>> On Thu, Nov 18, 2021 at 09:37:57AM +0800, Jiang Xin wrote:\n>>> On Thu, Nov 18, 2021 at 1:54 AM Taylor Blau <me@ttaylorr.com> wrote:\n>>>>\n>>>> Jiang,\n>>>>\n>>>> On Wed, Nov 17, 2021 at 11:21:49PM +0530, Pratyush Yadav wrote:\n>>>>> Hi Etienne,\n>>>>>\n>>>>> On 17/11/21 03:47PM, Philip Oakley wrote:\n>>>>>> On 16/11/2021 21:15, Etienne Guillot wrote:\n>>>>>>> Hi,\n>>>>>>>\n>>>>>>> I found a typo mistake in the french translation of git-gui.\n>>>>>>> I did read the instructions on this page\n>>>>>>> https://git-scm.com/docs/SubmittingPatches\n>>>>>>> but I still not sure where should I push the correction.\n>>>>>>>\n>>>>>>> Thanks for your help\n>>>>>>>\n>>>>>>> Etienne Guillot\n>>>>>> Hi Etienne\n>>>>>>\n>>>>>> The Git Gui is managed by Pratyush Yadav (cc'd) and hosted at\n>>>>>> https://github.com/prati0100/git-gui\n>>>>>>\n>>>>>> Not sure what the latest is on contributing translations (not covered in\n>>>>>> the GitHub Readme..).\n>>>>>\n>>>>> I usually ask people to post patches on this mailing list and I review\n>>>>> them here. But I make an exception for translation changes since they\n>>>>> never get any reviews anyway.\n>>>>>\n>>>>> So I am fine with either a Pull Request on GitHub or a patch on the\n>>>>> mailing list.\n>>>>\n>>>> Since Pratyush is the maintainer, does the po/TEAMS file in your tree\n>>>> need updating?\n>>>\n>>> Git Gui is a standalone project with its own workflow. The file\n>>> \"po/TEAMS\" is only used for Git project, so I am a little confused how\n>>> to update this file?\n>>\n>> I misread Etienne's original message, I thought they were asking about\n>> the French translation for Git, not git-gui.\n>>\n>>>> I'm not sure how up-to-date the file is in general, but the last commit\n>>>> was made semi-recently back in August, so I assume that the entry for\n>>>> the French translation is outdated.\n>>>\n>>> French l10n team is led by Jean-Noël Avila, and is very active.\n>>>\n>>>      git log --no-merges -- po/fr.po\n>>>\n>>> L10n for git-gui are maintained by different people though.  Because\n>>> \"git-gui\" is merged into git using subtree merge strategy,  I cannot\n>>> find commit logs of \"git-gui/po/fr.po\" using the same command, and\n>>> have to find the original git-gui commit, and find commit logs from\n>>> \"po/fr.po\" (which is quite different file from \"po/fr.po\" of Git).\n>>>\n>>>      git log 8a383db4b2 -- po/fr.po\n>>\n>> Yes, clearly no update is necessary here. Sorry for the confusion.\n> \n> It's really easy to confuse. No problem.\n> \n> BTW, what is the elegant way to find commit logs of a tree from a subtree merge?\n> \n> I have to run git-log on \"git-gui\" to find the 2nd parent commit ID of\n> the subtree merge, and run git-log on it.\n> \n> --\n> Jiang Xin\n> \n\nThank you everyone for your answers.\nI choose the easy way and opened a pull request on github.\n\nEtienne Guillot\n"}]}