{"thread":{"id":"56803","subject":"[PATCH] t5310: drop lib-bundle.sh include","startedAt":"2021-10-28T19:20:30Z","lastAt":"2021-10-29T10:16:43Z","messageCount":3,"participants":["Jeff King","Junio C Hamano","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"439925","messageId":"YXr3+yqtXYGgaxnX@coredump.intra.peff.net","threadId":"56803","inReplyTo":null,"subject":"[PATCH] t5310: drop lib-bundle.sh include","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-10-28T19:20:27Z","receivedAt":"2021-10-28T19:20:30Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh,\n2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes\nlib-bundle.sh. Yet we don't use any of its functions, nor have anything\nto do with bundles. This is probably just a typo/copy-paste error, as\nlib-bundle.sh was added (correctly) to other scripts in the same series.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\nNot really hurting anything, just confusing.\n\n t/t5310-pack-bitmaps.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh\nindex 673baa5c3c..dcf03d324a 100755\n--- a/t/t5310-pack-bitmaps.sh\n+++ b/t/t5310-pack-bitmaps.sh\n@@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\n export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n \n . ./test-lib.sh\n-. \"$TEST_DIRECTORY\"/lib-bundle.sh\n . \"$TEST_DIRECTORY\"/lib-bitmap.sh\n \n # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in\n-- \n2.33.1.1409.g5a89a36363\n"},{"id":"439984","messageId":"xmqq35okmhv5.fsf@gitster.g","threadId":"56803","inReplyTo":"YXr3+yqtXYGgaxnX@coredump.intra.peff.net","subject":"Re: [PATCH] t5310: drop lib-bundle.sh include","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-29T07:04:46Z","receivedAt":"2021-10-29T07:04:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh,\n> 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes\n> lib-bundle.sh. Yet we don't use any of its functions, nor have anything\n> to do with bundles. This is probably just a typo/copy-paste error, as\n> lib-bundle.sh was added (correctly) to other scripts in the same series.\n>\n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> Not really hurting anything, just confusing.\n\nMakes sense to me.\n\nWill queue; thanks.\n\n\n>\n>  t/t5310-pack-bitmaps.sh | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh\n> index 673baa5c3c..dcf03d324a 100755\n> --- a/t/t5310-pack-bitmaps.sh\n> +++ b/t/t5310-pack-bitmaps.sh\n> @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\n>  export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n>  \n>  . ./test-lib.sh\n> -. \"$TEST_DIRECTORY\"/lib-bundle.sh\n>  . \"$TEST_DIRECTORY\"/lib-bitmap.sh\n>  \n>  # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in\n"},{"id":"439989","messageId":"211029.86fsskw2yh.gmgdl@evledraar.gmail.com","threadId":"56803","inReplyTo":"YXr3+yqtXYGgaxnX@coredump.intra.peff.net","subject":"Re: [PATCH] t5310: drop lib-bundle.sh include","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-29T10:16:14Z","receivedAt":"2021-10-29T10:16:43Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Oct 28 2021, Jeff King wrote:\n\n> Commit ddfe900612 (test-lib-functions: move function to lib-bitmap.sh,\n> 2021-02-09) meant to include lib-bitmap.sh in t5310, but also includes\n> lib-bundle.sh. Yet we don't use any of its functions, nor have anything\n> to do with bundles. This is probably just a typo/copy-paste error, as\n> lib-bundle.sh was added (correctly) to other scripts in the same series.\n>\n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> Not really hurting anything, just confusing.\n>\n>  t/t5310-pack-bitmaps.sh | 1 -\n>  1 file changed, 1 deletion(-)\n>\n> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh\n> index 673baa5c3c..dcf03d324a 100755\n> --- a/t/t5310-pack-bitmaps.sh\n> +++ b/t/t5310-pack-bitmaps.sh\n> @@ -5,7 +5,6 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master\n>  export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n>  \n>  . ./test-lib.sh\n> -. \"$TEST_DIRECTORY\"/lib-bundle.sh\n>  . \"$TEST_DIRECTORY\"/lib-bitmap.sh\n>  \n>  # t5310 deals only with single-pack bitmaps, so don't write MIDX bitmaps in\n\nThanks for cleaning that up, yes that wasn't intentional, but just some\ncopy/paste programming or something that managed to escape me & the\nlist. Thanks!\n"}]}