{"thread":{"id":"56794","subject":"[PATCH 0/2] fix up example code in MyFirstObjectWalk tutorial","startedAt":"2021-10-27T14:05:36Z","lastAt":"2021-10-30T07:49:53Z","messageCount":16,"participants":["John Cai via GitGitGadget","Eric Sunshine","Junio C Hamano","Bagas Sanjaya"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"439776","messageId":"pull.1063.git.1635343531.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":null,"subject":"[PATCH 0/2] fix up example code in MyFirstObjectWalk tutorial","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-27T14:05:29Z","receivedAt":"2021-10-27T14:05:36Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"MyFirstObjectWalk tutorial was missing directives to add some header files.\nAlso fixes some initialization code.\n\nJohn Cai (2):\n docs: fix places that break compliation in MyFirstObjectWalk\n docs: add headers in MyFirstObjectWalk\n\n Documentation/MyFirstObjectWalk.txt | 32 +++++++++++++++++++++++------\n 1 file changed, 26 insertions(+), 6 deletions(-)\n\n\nbase-commit: e9e5ba39a78c8f5057262d49e261b42a8660d5b9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1063%2Fjohn-cai%2Fjc-fix-my-first-object-walk-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1063/john-cai/jc-fix-my-first-object-walk-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1063\n-- \ngitgitgadget\n"},{"id":"439777","messageId":"6c95f11f110be63dafa10dde5067b6e7eeff1a53.1635343531.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.git.1635343531.gitgitgadget@gmail.com","subject":"[PATCH 1/2] docs: fix places that break compliation in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-27T14:05:30Z","receivedAt":"2021-10-27T14:05:37Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nTwo errors in the example code caused compilation failures due to\na missing semi-colon as well as initialization with an empty struct.\nThis commit fixes that to make the MyFirstObjectWalk tutorial easier to\nfollow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex 45eb84d8b48..bf0a7c1f766 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -65,7 +65,7 @@ int cmd_walken(int argc, const char **argv, const char *prefix)\n \tconst char * const walken_usage[] = {\n \t\tN_(\"git walken\"),\n \t\tNULL,\n-\t}\n+\t};\n \tstruct option options[] = {\n \t\tOPT_END()\n \t};\n@@ -697,7 +697,7 @@ First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n ----\n static void walken_object_walk(struct rev_info *rev)\n {\n-\tstruct list_objects_filter_options filter_options = {};\n+\tstruct list_objects_filter_options filter_options = { 0 };\n \n \t...\n ----\n-- \ngitgitgadget\n\n"},{"id":"439778","messageId":"33cd9b2e8a675bf79132d312da8b7d8f4a2b84a3.1635343531.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.git.1635343531.gitgitgadget@gmail.com","subject":"[PATCH 2/2] docs: add headers in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-27T14:05:31Z","receivedAt":"2021-10-27T14:05:38Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nIn several places, headers need to be included or else the code won't\ncompile. Since this is the first object walk, it would be nice to\ninclude them in the tutorial to make it easier to follow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 28 ++++++++++++++++++++++++----\n 1 file changed, 24 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex bf0a7c1f766..ba8cca91b97 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -57,9 +57,14 @@ command). So we will send our debug output to `trace_printf()` instead. When\n running, enable trace output by setting the environment variable `GIT_TRACE`.\n \n Add usage text and `-h` handling, like all subcommands should consistently do\n-(our test suite will notice and complain if you fail to do so).\n+(our test suite will notice and complain if you fail to do so). We'll need to include\n+the \"parse-options.h\" header.\n \n ----\n+#include \"parse-options.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \tconst char * const walken_usage[] = {\n@@ -195,9 +200,13 @@ Similarly to the default values, we don't have anything to do here yet\n ourselves; however, we should call `git_default_config()` if we aren't calling\n any other existing config callbacks.\n \n-Add a new function to `builtin/walken.c`:\n+Add a new function to `builtin/walken.c`. We'll also need to include the \"config.h\" header:\n \n ----\n+#include \"config.h\"\n+\n+...\n+\n static int git_walken_config(const char *var, const char *value, void *cb)\n {\n \t/*\n@@ -229,8 +238,14 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n struct.\n \n-Add the `struct rev_info` and the `repo_init_revisions()` call:\n+Add the `struct rev_info` and the `repo_init_revisions()` call. We'll also need to include\n+the \"revision.h\" header:\n+\n ----\n+#include \"revision.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \t/* This can go wherever you like in your declarations.*/\n@@ -624,9 +639,14 @@ static void walken_object_walk(struct rev_info *rev)\n ----\n \n Let's start by calling just the unfiltered walk and reporting our counts.\n-Complete your implementation of `walken_object_walk()`:\n+Complete your implementation of `walken_object_walk()`. We'll also need to\n+include the \"list-objects.h\" header.\n \n ----\n+#include \"list-objects.h\"\n+\n+...\n+\n \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n \n \tprintf(\"commits %d\\nblobs %d\\ntags %d\\ntrees %d\\n\", commit_count,\n-- \ngitgitgadget\n"},{"id":"439793","messageId":"CAPig+cTmHT9uZ=c4tGK487=K1905cYoFZcPfMRv7awbqoKHBfQ@mail.gmail.com","threadId":"56794","inReplyTo":"6c95f11f110be63dafa10dde5067b6e7eeff1a53.1635343531.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/2] docs: fix places that break compliation in MyFirstObjectWalk","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-10-27T17:05:08Z","receivedAt":"2021-10-27T17:05:25Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Oct 27, 2021 at 10:05 AM John Cai via GitGitGadget\n wrote:\n> docs: fix places that break compliation in MyFirstObjectWalk\n\ns/compliation/compilation/\n\n> Two errors in the example code caused compilation failures due to\n> a missing semi-colon as well as initialization with an empty struct.\n> This commit fixes that to make the MyFirstObjectWalk tutorial easier to\n> follow.\n\ns/semi-colon/semicolon/ would also be appropriate for the rest of the\nproject (but not terribly important in a commit message).\n\n> Signed-off-by: John Cai \n\nThe patch itself makes perfect sense. Thanks.\n"},{"id":"439794","messageId":"CAPig+cQxfJkV70sP8Ai3EQUrh3Y04WjkhjpG1zup7_gfg90jbg@mail.gmail.com","threadId":"56794","inReplyTo":"33cd9b2e8a675bf79132d312da8b7d8f4a2b84a3.1635343531.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-10-27T17:09:19Z","receivedAt":"2021-10-27T17:09:33Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Wed, Oct 27, 2021 at 10:05 AM John Cai via GitGitGadget\n wrote:\n> In several places, headers need to be included or else the code won't\n> compile. Since this is the first object walk, it would be nice to\n> include them in the tutorial to make it easier to follow.\n>\n> Signed-off-by: John Cai \n> ---\n> diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\n> @@ -57,9 +57,14 @@ command). So we will send our debug output to `trace_printf()` instead. When\n> Add usage text and `-h` handling, like all subcommands should consistently do\n> -(our test suite will notice and complain if you fail to do so).\n> +(our test suite will notice and complain if you fail to do so). We'll need to include\n> +the \"parse-options.h\" header.\n\nMakes sense, but we should probably typeset these consistently with\nbackticks rather than double quotes...\n\n> @@ -195,9 +200,13 @@ Similarly to the default values, we don't have anything to do here yet\n> -Add a new function to `builtin/walken.c`:\n> +Add a new function to `builtin/walken.c`. We'll also need to include the \"config.h\" header:\n\n... just as `builtin/walken.c` is typeset with backticks (as are other\npathnames in this document).\n\n> @@ -229,8 +238,14 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n> -Add the `struct rev_info` and the `repo_init_revisions()` call:\n> +Add the `struct rev_info` and the `repo_init_revisions()` call. We'll also need to include\n> +the \"revision.h\" header:\n\nAnd so on through the remainder of the patch.\n\nThanks.\n"},{"id":"439834","messageId":"xmqqk0hyupzo.fsf@gitster.g","threadId":"56794","inReplyTo":"33cd9b2e8a675bf79132d312da8b7d8f4a2b84a3.1635343531.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-27T21:17:31Z","receivedAt":"2021-10-27T21:17:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"John Cai via GitGitGadget\" writes:\n\n> Add usage text and `-h` handling, like all subcommands should consistently do\n> -(our test suite will notice and complain if you fail to do so).\n> +(our test suite will notice and complain if you fail to do so). We'll need to include\n> +the \"parse-options.h\" header.\n\nOK, but wrap this overlong line. All the lines updated by this\npatch, except the one in the last hunk, have become overly long.\n\n[jc: cc'ed the primary author of the document to sanity checking]\n\nThanks.\n\n> \n> ----\n> +#include \"parse-options.h\"\n> +\n> +...\n> +\n> int cmd_walken(int argc, const char **argv, const char *prefix)\n> {\n> \tconst char * const walken_usage[] = {\n> @@ -195,9 +200,13 @@ Similarly to the default values, we don't have anything to do here yet\n> ourselves; however, we should call `git_default_config()` if we aren't calling\n> any other existing config callbacks.\n> \n> -Add a new function to `builtin/walken.c`:\n> +Add a new function to `builtin/walken.c`. We'll also need to include the \"config.h\" header:\n> \n> ----\n> +#include \"config.h\"\n> +\n> +...\n> +\n> static int git_walken_config(const char *var, const char *value, void *cb)\n> {\n> \t/*\n> @@ -229,8 +238,14 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n> to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n> struct.\n> \n> -Add the `struct rev_info` and the `repo_init_revisions()` call:\n> +Add the `struct rev_info` and the `repo_init_revisions()` call. We'll also need to include\n> +the \"revision.h\" header:\n> +\n> ----\n> +#include \"revision.h\"\n> +\n> +...\n> +\n> int cmd_walken(int argc, const char **argv, const char *prefix)\n> {\n> \t/* This can go wherever you like in your declarations.*/\n> @@ -624,9 +639,14 @@ static void walken_object_walk(struct rev_info *rev)\n> ----\n> \n> Let's start by calling just the unfiltered walk and reporting our counts.\n> -Complete your implementation of `walken_object_walk()`:\n> +Complete your implementation of `walken_object_walk()`. We'll also need to\n> +include the \"list-objects.h\" header.\n> \n> ----\n> +#include \"list-objects.h\"\n> +\n> +...\n> +\n> \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n> \n> \tprintf(\"commits %d\\nblobs %d\\ntags %d\\ntrees %d\\n\", commit_count,\n"},{"id":"440031","messageId":"pull.1063.v2.git.1635530296.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.git.1635343531.gitgitgadget@gmail.com","subject":"[PATCH v2 0/2] fix up example code in MyFirstObjectWalk tutorial","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T17:58:14Z","receivedAt":"2021-10-29T17:58:21Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"MyFirstObjectWalk tutorial was missing directives to add some header files.\nAlso fixes some initialization code.\n\nChanges since v1:\n\n * added back ticks to header file names\n * wrapped overly long lines\n\nJohn Cai (2):\n docs: fix places that break compilation in MyFirstObjectWalk\n docs: add headers in MyFirstObjectWalk\n\n Documentation/MyFirstObjectWalk.txt | 31 ++++++++++++++++++++++++-----\n 1 file changed, 26 insertions(+), 5 deletions(-)\n\n\nbase-commit: e9e5ba39a78c8f5057262d49e261b42a8660d5b9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1063%2Fjohn-cai%2Fjc-fix-my-first-object-walk-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1063/john-cai/jc-fix-my-first-object-walk-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/1063\n\nRange-diff vs v1:\n\n 1: 6c95f11f110 ! 1: 5c9deaf0bcc docs: fix places that break compliation in MyFirstObjectWalk\n @@ Metadata\n Author: John Cai \n \n ## Commit message ##\n - docs: fix places that break compliation in MyFirstObjectWalk\n + docs: fix places that break compilation in MyFirstObjectWalk\n \n Two errors in the example code caused compilation failures due to\n - a missing semi-colon as well as initialization with an empty struct.\n + a missing semicolon as well as initialization with an empty struct.\n This commit fixes that to make the MyFirstObjectWalk tutorial easier to\n follow.\n \n Signed-off-by: John Cai \n \n ## Documentation/MyFirstObjectWalk.txt ##\n +@@ Documentation/MyFirstObjectWalk.txt: running, enable trace output by setting the environment variable `GIT_TRACE`.\n + \n + Add usage text and `-h` handling, like all subcommands should consistently do\n + (our test suite will notice and complain if you fail to do so).\n ++We'll need to include the `parse-options.h` header.\n + \n + ----\n + int cmd_walken(int argc, const char **argv, const char *prefix)\n @@ Documentation/MyFirstObjectWalk.txt: int cmd_walken(int argc, const char **argv, const char *prefix)\n \tconst char * const walken_usage[] = {\n \t\tN_(\"git walken\"),\n @@ Documentation/MyFirstObjectWalk.txt: int cmd_walken(int argc, const char **argv,\n \tstruct option options[] = {\n \t\tOPT_END()\n \t};\n +@@ Documentation/MyFirstObjectWalk.txt: Similarly to the default values, we don't have anything to do here yet\n + ourselves; however, we should call `git_default_config()` if we aren't calling\n + any other existing config callbacks.\n + \n +-Add a new function to `builtin/walken.c`:\n ++Add a new function to `builtin/walken.c`.\n ++We'll also need to include the `config.h` header:\n + \n + ----\n + static int git_walken_config(const char *var, const char *value, void *cb)\n +@@ Documentation/MyFirstObjectWalk.txt: typically done by calling `repo_init_revisions()` with the repository you intend\n + to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n + struct.\n + \n +-Add the `struct rev_info` and the `repo_init_revisions()` call:\n ++Add the `struct rev_info` and the `repo_init_revisions()` call.\n ++We'll also need to include the `revision.h` header:\n ++\n + ----\n + int cmd_walken(int argc, const char **argv, const char *prefix)\n + {\n +@@ Documentation/MyFirstObjectWalk.txt: static void walken_object_walk(struct rev_info *rev)\n + ----\n + \n + Let's start by calling just the unfiltered walk and reporting our counts.\n +-Complete your implementation of `walken_object_walk()`:\n ++Complete your implementation of `walken_object_walk()`.\n ++We'll also need to include the `list-objects.h` header.\n + \n + ----\n + \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n @@ Documentation/MyFirstObjectWalk.txt: First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n ----\n static void walken_object_walk(struct rev_info *rev)\n 2: 33cd9b2e8a6 ! 2: 7268f00c11f docs: add headers in MyFirstObjectWalk\n @@ Commit message\n Signed-off-by: John Cai \n \n ## Documentation/MyFirstObjectWalk.txt ##\n -@@ Documentation/MyFirstObjectWalk.txt: command). So we will send our debug output to `trace_printf()` instead. When\n - running, enable trace output by setting the environment variable `GIT_TRACE`.\n - \n - Add usage text and `-h` handling, like all subcommands should consistently do\n --(our test suite will notice and complain if you fail to do so).\n -+(our test suite will notice and complain if you fail to do so). We'll need to include\n -+the \"parse-options.h\" header.\n +@@ Documentation/MyFirstObjectWalk.txt: Add usage text and `-h` handling, like all subcommands should consistently do\n + We'll need to include the `parse-options.h` header.\n \n ----\n +#include \"parse-options.h\"\n @@ Documentation/MyFirstObjectWalk.txt: command). So we will send our debug output\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \tconst char * const walken_usage[] = {\n -@@ Documentation/MyFirstObjectWalk.txt: Similarly to the default values, we don't have anything to do here yet\n - ourselves; however, we should call `git_default_config()` if we aren't calling\n - any other existing config callbacks.\n - \n --Add a new function to `builtin/walken.c`:\n -+Add a new function to `builtin/walken.c`. We'll also need to include the \"config.h\" header:\n +@@ Documentation/MyFirstObjectWalk.txt: Add a new function to `builtin/walken.c`.\n + We'll also need to include the `config.h` header:\n \n ----\n +#include \"config.h\"\n @@ Documentation/MyFirstObjectWalk.txt: Similarly to the default values, we don't h\n static int git_walken_config(const char *var, const char *value, void *cb)\n {\n \t/*\n -@@ Documentation/MyFirstObjectWalk.txt: typically done by calling `repo_init_revisions()` with the repository you intend\n - to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n - struct.\n +@@ Documentation/MyFirstObjectWalk.txt: Add the `struct rev_info` and the `repo_init_revisions()` call.\n + We'll also need to include the `revision.h` header:\n \n --Add the `struct rev_info` and the `repo_init_revisions()` call:\n -+Add the `struct rev_info` and the `repo_init_revisions()` call. We'll also need to include\n -+the \"revision.h\" header:\n -+\n ----\n +#include \"revision.h\"\n +\n @@ Documentation/MyFirstObjectWalk.txt: typically done by calling `repo_init_revisi\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \t/* This can go wherever you like in your declarations.*/\n -@@ Documentation/MyFirstObjectWalk.txt: static void walken_object_walk(struct rev_info *rev)\n - ----\n - \n - Let's start by calling just the unfiltered walk and reporting our counts.\n --Complete your implementation of `walken_object_walk()`:\n -+Complete your implementation of `walken_object_walk()`. We'll also need to\n -+include the \"list-objects.h\" header.\n +@@ Documentation/MyFirstObjectWalk.txt: Complete your implementation of `walken_object_walk()`.\n + We'll also need to include the `list-objects.h` header.\n \n ----\n +#include \"list-objects.h\"\n\n-- \ngitgitgadget\n"},{"id":"440032","messageId":"5c9deaf0bccfe158c7f410f084529850a33b7fd0.1635530296.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.v2.git.1635530296.gitgitgadget@gmail.com","subject":"[PATCH v2 1/2] docs: fix places that break compilation in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T17:58:15Z","receivedAt":"2021-10-29T17:58:22Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nTwo errors in the example code caused compilation failures due to\na missing semicolon as well as initialization with an empty struct.\nThis commit fixes that to make the MyFirstObjectWalk tutorial easier to\nfollow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex 45eb84d8b48..e22615105c0 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -58,6 +58,7 @@ running, enable trace output by setting the environment variable `GIT_TRACE`.\n \n Add usage text and `-h` handling, like all subcommands should consistently do\n (our test suite will notice and complain if you fail to do so).\n+We'll need to include the `parse-options.h` header.\n \n ----\n int cmd_walken(int argc, const char **argv, const char *prefix)\n@@ -65,7 +66,7 @@ int cmd_walken(int argc, const char **argv, const char *prefix)\n \tconst char * const walken_usage[] = {\n \t\tN_(\"git walken\"),\n \t\tNULL,\n-\t}\n+\t};\n \tstruct option options[] = {\n \t\tOPT_END()\n \t};\n@@ -195,7 +196,8 @@ Similarly to the default values, we don't have anything to do here yet\n ourselves; however, we should call `git_default_config()` if we aren't calling\n any other existing config callbacks.\n \n-Add a new function to `builtin/walken.c`:\n+Add a new function to `builtin/walken.c`.\n+We'll also need to include the `config.h` header:\n \n ----\n static int git_walken_config(const char *var, const char *value, void *cb)\n@@ -229,7 +231,9 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n struct.\n \n-Add the `struct rev_info` and the `repo_init_revisions()` call:\n+Add the `struct rev_info` and the `repo_init_revisions()` call.\n+We'll also need to include the `revision.h` header:\n+\n ----\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n@@ -624,7 +628,8 @@ static void walken_object_walk(struct rev_info *rev)\n ----\n \n Let's start by calling just the unfiltered walk and reporting our counts.\n-Complete your implementation of `walken_object_walk()`:\n+Complete your implementation of `walken_object_walk()`.\n+We'll also need to include the `list-objects.h` header.\n \n ----\n \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n@@ -697,7 +702,7 @@ First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n ----\n static void walken_object_walk(struct rev_info *rev)\n {\n-\tstruct list_objects_filter_options filter_options = {};\n+\tstruct list_objects_filter_options filter_options = { 0 };\n \n \t...\n ----\n-- \ngitgitgadget\n\n"},{"id":"440033","messageId":"7268f00c11fc0b9ece99f6a2940c124892791768.1635530296.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.v2.git.1635530296.gitgitgadget@gmail.com","subject":"[PATCH v2 2/2] docs: add headers in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T17:58:16Z","receivedAt":"2021-10-29T17:58:27Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nIn several places, headers need to be included or else the code won't\ncompile. Since this is the first object walk, it would be nice to\ninclude them in the tutorial to make it easier to follow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex e22615105c0..ca267941f3e 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -61,6 +61,10 @@ Add usage text and `-h` handling, like all subcommands should consistently do\n We'll need to include the `parse-options.h` header.\n \n ----\n+#include \"parse-options.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \tconst char * const walken_usage[] = {\n@@ -200,6 +204,10 @@ Add a new function to `builtin/walken.c`.\n We'll also need to include the `config.h` header:\n \n ----\n+#include \"config.h\"\n+\n+...\n+\n static int git_walken_config(const char *var, const char *value, void *cb)\n {\n \t/*\n@@ -235,6 +243,10 @@ Add the `struct rev_info` and the `repo_init_revisions()` call.\n We'll also need to include the `revision.h` header:\n \n ----\n+#include \"revision.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \t/* This can go wherever you like in your declarations.*/\n@@ -632,6 +644,10 @@ Complete your implementation of `walken_object_walk()`.\n We'll also need to include the `list-objects.h` header.\n \n ----\n+#include \"list-objects.h\"\n+\n+...\n+\n \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n \n \tprintf(\"commits %d\\nblobs %d\\ntags %d\\ntrees %d\\n\", commit_count,\n-- \ngitgitgadget\n"},{"id":"440034","messageId":"CAPig+cRzdzK7f=+38u-RuwL80WPoPvX8pwr8GK5vebvuQH5yUg@mail.gmail.com","threadId":"56794","inReplyTo":"5c9deaf0bccfe158c7f410f084529850a33b7fd0.1635530296.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 1/2] docs: fix places that break compilation in MyFirstObjectWalk","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-10-29T18:04:48Z","receivedAt":"2021-10-29T18:05:01Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Oct 29, 2021 at 1:58 PM John Cai via GitGitGadget\n wrote:\n> Two errors in the example code caused compilation failures due to\n> a missing semicolon as well as initialization with an empty struct.\n> This commit fixes that to make the MyFirstObjectWalk tutorial easier to\n> follow.\n>\n> Signed-off-by: John Cai \n> ---\n> diff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\n> @@ -58,6 +58,7 @@ running, enable trace output by setting the environment variable `GIT_TRACE`.\n> Add usage text and `-h` handling, like all subcommands should consistently do\n> (our test suite will notice and complain if you fail to do so).\n> +We'll need to include the `parse-options.h` header.\n\nIt seems like this change belongs in patch [2/2].\n\n> @@ -65,7 +66,7 @@ int cmd_walken(int argc, const char **argv, const char *prefix)\n> const char * const walken_usage[] = {\n> N_(\"git walken\"),\n> NULL,\n> - }\n> + };\n\nWhereas, this change correctly resides in patch [1/2].\n\n> struct option options[] = {\n> OPT_END()\n> };\n> @@ -195,7 +196,8 @@ Similarly to the default values, we don't have anything to do here yet\n> ourselves; however, we should call `git_default_config()` if we aren't calling\n> any other existing config callbacks.\n>\n> -Add a new function to `builtin/walken.c`:\n> +Add a new function to `builtin/walken.c`.\n> +We'll also need to include the `config.h` header:\n\nShould be in patch [2/2].\n\n> @@ -229,7 +231,9 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n> to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n> struct.\n>\n> -Add the `struct rev_info` and the `repo_init_revisions()` call:\n> +Add the `struct rev_info` and the `repo_init_revisions()` call.\n> +We'll also need to include the `revision.h` header:\n\nPatch [2/2].\n\n> @@ -624,7 +628,8 @@ static void walken_object_walk(struct rev_info *rev)\n> Let's start by calling just the unfiltered walk and reporting our counts.\n> -Complete your implementation of `walken_object_walk()`:\n> +Complete your implementation of `walken_object_walk()`.\n> +We'll also need to include the `list-objects.h` header.\n\nAlso patch [2/2].\n\n> @@ -697,7 +702,7 @@ First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n> static void walken_object_walk(struct rev_info *rev)\n> {\n> - struct list_objects_filter_options filter_options = {};\n> + struct list_objects_filter_options filter_options = { 0 };\n\nGood, this change belongs here in patch [1/2].\n"},{"id":"440051","messageId":"pull.1063.v3.git.1635537163.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.v2.git.1635530296.gitgitgadget@gmail.com","subject":"[PATCH v3 0/2] fix up example code in MyFirstObjectWalk tutorial","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T19:52:41Z","receivedAt":"2021-10-29T19:52:48Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"MyFirstObjectWalk tutorial was missing directives to add some header files.\nAlso fixes some initialization code.\n\nChanges since v1:\n\n * added back ticks to header file names\n * wrapped overly long lines\n\nChanges since v2:\n\n * fixed commit organization\n\nJohn Cai (2):\n docs: fix places that break compilation in MyFirstObjectWalk\n docs: add headers in MyFirstObjectWalk\n\n Documentation/MyFirstObjectWalk.txt | 31 ++++++++++++++++++++++++-----\n 1 file changed, 26 insertions(+), 5 deletions(-)\n\n\nbase-commit: e9e5ba39a78c8f5057262d49e261b42a8660d5b9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1063%2Fjohn-cai%2Fjc-fix-my-first-object-walk-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1063/john-cai/jc-fix-my-first-object-walk-v3\nPull-Request: https://github.com/gitgitgadget/git/pull/1063\n\nRange-diff vs v2:\n\n 1: 5c9deaf0bcc ! 1: f9481c77e2d docs: fix places that break compilation in MyFirstObjectWalk\n @@ Commit message\n Signed-off-by: John Cai \n \n ## Documentation/MyFirstObjectWalk.txt ##\n -@@ Documentation/MyFirstObjectWalk.txt: running, enable trace output by setting the environment variable `GIT_TRACE`.\n - \n - Add usage text and `-h` handling, like all subcommands should consistently do\n - (our test suite will notice and complain if you fail to do so).\n -+We'll need to include the `parse-options.h` header.\n - \n - ----\n - int cmd_walken(int argc, const char **argv, const char *prefix)\n @@ Documentation/MyFirstObjectWalk.txt: int cmd_walken(int argc, const char **argv, const char *prefix)\n \tconst char * const walken_usage[] = {\n \t\tN_(\"git walken\"),\n @@ Documentation/MyFirstObjectWalk.txt: int cmd_walken(int argc, const char **argv,\n \tstruct option options[] = {\n \t\tOPT_END()\n \t};\n -@@ Documentation/MyFirstObjectWalk.txt: Similarly to the default values, we don't have anything to do here yet\n - ourselves; however, we should call `git_default_config()` if we aren't calling\n - any other existing config callbacks.\n - \n --Add a new function to `builtin/walken.c`:\n -+Add a new function to `builtin/walken.c`.\n -+We'll also need to include the `config.h` header:\n - \n - ----\n - static int git_walken_config(const char *var, const char *value, void *cb)\n -@@ Documentation/MyFirstObjectWalk.txt: typically done by calling `repo_init_revisions()` with the repository you intend\n - to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n - struct.\n - \n --Add the `struct rev_info` and the `repo_init_revisions()` call:\n -+Add the `struct rev_info` and the `repo_init_revisions()` call.\n -+We'll also need to include the `revision.h` header:\n -+\n - ----\n - int cmd_walken(int argc, const char **argv, const char *prefix)\n - {\n -@@ Documentation/MyFirstObjectWalk.txt: static void walken_object_walk(struct rev_info *rev)\n - ----\n - \n - Let's start by calling just the unfiltered walk and reporting our counts.\n --Complete your implementation of `walken_object_walk()`:\n -+Complete your implementation of `walken_object_walk()`.\n -+We'll also need to include the `list-objects.h` header.\n - \n - ----\n - \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n @@ Documentation/MyFirstObjectWalk.txt: First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n ----\n static void walken_object_walk(struct rev_info *rev)\n 2: 7268f00c11f ! 2: 1535671dd6a docs: add headers in MyFirstObjectWalk\n @@ Commit message\n Signed-off-by: John Cai \n \n ## Documentation/MyFirstObjectWalk.txt ##\n -@@ Documentation/MyFirstObjectWalk.txt: Add usage text and `-h` handling, like all subcommands should consistently do\n - We'll need to include the `parse-options.h` header.\n +@@ Documentation/MyFirstObjectWalk.txt: running, enable trace output by setting the environment variable `GIT_TRACE`.\n + \n + Add usage text and `-h` handling, like all subcommands should consistently do\n + (our test suite will notice and complain if you fail to do so).\n ++We'll need to include the `parse-options.h` header.\n \n ----\n +#include \"parse-options.h\"\n @@ Documentation/MyFirstObjectWalk.txt: Add usage text and `-h` handling, like all\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \tconst char * const walken_usage[] = {\n -@@ Documentation/MyFirstObjectWalk.txt: Add a new function to `builtin/walken.c`.\n - We'll also need to include the `config.h` header:\n +@@ Documentation/MyFirstObjectWalk.txt: Similarly to the default values, we don't have anything to do here yet\n + ourselves; however, we should call `git_default_config()` if we aren't calling\n + any other existing config callbacks.\n + \n +-Add a new function to `builtin/walken.c`:\n ++Add a new function to `builtin/walken.c`.\n ++We'll also need to include the `config.h` header:\n \n ----\n +#include \"config.h\"\n @@ Documentation/MyFirstObjectWalk.txt: Add a new function to `builtin/walken.c`.\n static int git_walken_config(const char *var, const char *value, void *cb)\n {\n \t/*\n -@@ Documentation/MyFirstObjectWalk.txt: Add the `struct rev_info` and the `repo_init_revisions()` call.\n - We'll also need to include the `revision.h` header:\n +@@ Documentation/MyFirstObjectWalk.txt: typically done by calling `repo_init_revisions()` with the repository you intend\n + to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n + struct.\n \n +-Add the `struct rev_info` and the `repo_init_revisions()` call:\n ++Add the `struct rev_info` and the `repo_init_revisions()` call.\n ++We'll also need to include the `revision.h` header:\n ++\n ----\n +#include \"revision.h\"\n +\n @@ Documentation/MyFirstObjectWalk.txt: Add the `struct rev_info` and the `repo_ini\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \t/* This can go wherever you like in your declarations.*/\n -@@ Documentation/MyFirstObjectWalk.txt: Complete your implementation of `walken_object_walk()`.\n - We'll also need to include the `list-objects.h` header.\n +@@ Documentation/MyFirstObjectWalk.txt: static void walken_object_walk(struct rev_info *rev)\n + ----\n + \n + Let's start by calling just the unfiltered walk and reporting our counts.\n +-Complete your implementation of `walken_object_walk()`:\n ++Complete your implementation of `walken_object_walk()`.\n ++We'll also need to include the `list-objects.h` header.\n \n ----\n +#include \"list-objects.h\"\n\n-- \ngitgitgadget\n"},{"id":"440052","messageId":"f9481c77e2d42038196a587b4a637f4277f0dda7.1635537163.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.v3.git.1635537163.gitgitgadget@gmail.com","subject":"[PATCH v3 1/2] docs: fix places that break compilation in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T19:52:42Z","receivedAt":"2021-10-29T19:52:49Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nTwo errors in the example code caused compilation failures due to\na missing semicolon as well as initialization with an empty struct.\nThis commit fixes that to make the MyFirstObjectWalk tutorial easier to\nfollow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex 45eb84d8b48..bf0a7c1f766 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -65,7 +65,7 @@ int cmd_walken(int argc, const char **argv, const char *prefix)\n \tconst char * const walken_usage[] = {\n \t\tN_(\"git walken\"),\n \t\tNULL,\n-\t}\n+\t};\n \tstruct option options[] = {\n \t\tOPT_END()\n \t};\n@@ -697,7 +697,7 @@ First, we'll need to `#include \"list-objects-filter-options.h\"` and set up the\n ----\n static void walken_object_walk(struct rev_info *rev)\n {\n-\tstruct list_objects_filter_options filter_options = {};\n+\tstruct list_objects_filter_options filter_options = { 0 };\n \n \t...\n ----\n-- \ngitgitgadget\n\n"},{"id":"440053","messageId":"1535671dd6af917246ba642b00fc51f7a8f29edf.1635537163.git.gitgitgadget@gmail.com","threadId":"56794","inReplyTo":"pull.1063.v3.git.1635537163.gitgitgadget@gmail.com","subject":"[PATCH v3 2/2] docs: add headers in MyFirstObjectWalk","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-10-29T19:52:43Z","receivedAt":"2021-10-29T19:52:51Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai \n\nIn several places, headers need to be included or else the code won't\ncompile. Since this is the first object walk, it would be nice to\ninclude them in the tutorial to make it easier to follow.\n\nSigned-off-by: John Cai \n---\n Documentation/MyFirstObjectWalk.txt | 27 ++++++++++++++++++++++++---\n 1 file changed, 24 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/MyFirstObjectWalk.txt b/Documentation/MyFirstObjectWalk.txt\nindex bf0a7c1f766..ca267941f3e 100644\n--- a/Documentation/MyFirstObjectWalk.txt\n+++ b/Documentation/MyFirstObjectWalk.txt\n@@ -58,8 +58,13 @@ running, enable trace output by setting the environment variable `GIT_TRACE`.\n \n Add usage text and `-h` handling, like all subcommands should consistently do\n (our test suite will notice and complain if you fail to do so).\n+We'll need to include the `parse-options.h` header.\n \n ----\n+#include \"parse-options.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \tconst char * const walken_usage[] = {\n@@ -195,9 +200,14 @@ Similarly to the default values, we don't have anything to do here yet\n ourselves; however, we should call `git_default_config()` if we aren't calling\n any other existing config callbacks.\n \n-Add a new function to `builtin/walken.c`:\n+Add a new function to `builtin/walken.c`.\n+We'll also need to include the `config.h` header:\n \n ----\n+#include \"config.h\"\n+\n+...\n+\n static int git_walken_config(const char *var, const char *value, void *cb)\n {\n \t/*\n@@ -229,8 +239,14 @@ typically done by calling `repo_init_revisions()` with the repository you intend\n to target, as well as the `prefix` argument of `cmd_walken` and your `rev_info`\n struct.\n \n-Add the `struct rev_info` and the `repo_init_revisions()` call:\n+Add the `struct rev_info` and the `repo_init_revisions()` call.\n+We'll also need to include the `revision.h` header:\n+\n ----\n+#include \"revision.h\"\n+\n+...\n+\n int cmd_walken(int argc, const char **argv, const char *prefix)\n {\n \t/* This can go wherever you like in your declarations.*/\n@@ -624,9 +640,14 @@ static void walken_object_walk(struct rev_info *rev)\n ----\n \n Let's start by calling just the unfiltered walk and reporting our counts.\n-Complete your implementation of `walken_object_walk()`:\n+Complete your implementation of `walken_object_walk()`.\n+We'll also need to include the `list-objects.h` header.\n \n ----\n+#include \"list-objects.h\"\n+\n+...\n+\n \ttraverse_commit_list(rev, walken_show_commit, walken_show_object, NULL);\n \n \tprintf(\"commits %d\\nblobs %d\\ntags %d\\ntrees %d\\n\", commit_count,\n-- \ngitgitgadget\n"},{"id":"440081","messageId":"CAPig+cQzqUrbu6gdO-0atxP8E5wGUnQQC-ytCKqL+3u_NpXMbQ@mail.gmail.com","threadId":"56794","inReplyTo":"pull.1063.v3.git.1635537163.gitgitgadget@gmail.com","subject":"Re: [PATCH v3 0/2] fix up example code in MyFirstObjectWalk tutorial","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-10-29T21:28:16Z","receivedAt":"2021-10-29T21:28:31Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Oct 29, 2021 at 3:52 PM John Cai via GitGitGadget\n wrote:\n> MyFirstObjectWalk tutorial was missing directives to add some header files.\n> Also fixes some initialization code.\n>\n> Changes since v1:\n>\n> * added back ticks to header file names\n> * wrapped overly long lines\n>\n> Changes since v2:\n>\n> * fixed commit organization\n\nThis version looks better. Thanks.\n"},{"id":"440117","messageId":"224a256e-8700-047d-bc12-834524a3c8f3@gmail.com","threadId":"56794","inReplyTo":"33cd9b2e8a675bf79132d312da8b7d8f4a2b84a3.1635343531.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-10-30T07:33:16Z","receivedAt":"2021-10-30T07:33:21Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 27/10/21 21.05, John Cai via GitGitGadget wrote:\n> From: John Cai \n> \n> In several places, headers need to be included or else the code won't\n> compile. Since this is the first object walk, it would be nice to\n> include them in the tutorial to make it easier to follow.\n> \n\nPatch title should be \"#include missing headers\" (dunno?)\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"440118","messageId":"CAPig+cQ2TXZtZphdkWQP9W218YUpL3mFbDo1j4Z+SjmACMfDEg@mail.gmail.com","threadId":"56794","inReplyTo":"224a256e-8700-047d-bc12-834524a3c8f3@gmail.com","subject":"Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-10-30T07:49:40Z","receivedAt":"2021-10-30T07:49:53Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sat, Oct 30, 2021 at 3:33 AM Bagas Sanjaya wrote:\n> On 27/10/21 21.05, John Cai via GitGitGadget wrote:\n> > In several places, headers need to be included or else the code won't\n> > compile. Since this is the first object walk, it would be nice to\n> > include them in the tutorial to make it easier to follow.\n>\n> Patch title should be \"#include missing headers\" (dunno?)\n\nIf the series was being rerolled for some other reason, making the\ncommit subject slightly more precise like that might make sense, but\nrerolling only for that reason is probably not worth the extra work\nfor the submitter, the maintainer, and reviewers.\n"}]}