{"thread":{"id":"56771","subject":"[PATCH] command-list.txt: remove 'sparse-index' from main help","startedAt":"2021-10-24T17:07:39Z","lastAt":"2021-10-25T16:10:12Z","messageCount":4,"participants":["SZEDER Gábor","Martin Ågren","Derrick Stolee","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"439490","messageId":"20211024170730.3428123-1-szeder.dev@gmail.com","threadId":"56771","inReplyTo":null,"subject":"[PATCH] command-list.txt: remove 'sparse-index' from main help","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2021-10-24T17:07:30Z","receivedAt":"2021-10-24T17:07:39Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Ever since 'git sparse-checkout' was introduced [1] it is included in\n'git --help' in the section \"work on the current change\" along with\nthe commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't\nbelong to that group, moreover it can't be considered such a common\ncommand to belong to 'git --help' in the first place, so remove it\nfrom there.\n\n[1] 94c0956b60 (sparse-checkout: create builtin with 'list'\n subcommand, 2019-11-21)\n\nSigned-off-by: SZEDER Gábor \n---\n command-list.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/command-list.txt b/command-list.txt\nindex a289f09ed6..eb9cee8dee 100644\n--- a/command-list.txt\n+++ b/command-list.txt\n@@ -168,7 +168,7 @@ git-show-index plumbinginterrogators\n git-show-ref plumbinginterrogators\n git-sh-i18n purehelpers\n git-sh-setup purehelpers\n-git-sparse-checkout mainporcelain worktree\n+git-sparse-checkout mainporcelain\n git-stash mainporcelain\n git-stage complete\n git-status mainporcelain info\n-- \n2.33.1.1176.g03b4fe3d2b\n\n"},{"id":"439500","messageId":"CAN0heSr9atBArKnXyoJ8H0fHFaU3-+Zw9ueNsS0S2wwT+Fe7DA@mail.gmail.com","threadId":"56771","inReplyTo":"20211024170730.3428123-1-szeder.dev@gmail.com","subject":"Re: [PATCH] command-list.txt: remove 'sparse-index' from main help","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2021-10-24T17:27:43Z","receivedAt":"2021-10-24T17:28:00Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"On Sun, 24 Oct 2021 at 19:08, SZEDER Gábor wrote:\n>\n> Ever since 'git sparse-checkout' was introduced [1] it is included in\n> 'git --help' in the section \"work on the current change\" along with\n> the commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't\n> belong to that group, moreover it can't be considered such a common\n> command to belong to 'git --help' in the first place, so remove it\n> from there.\n\nI actually spotted this in `git --help` just the other day and reacted\nalong the same line. So for what it's worth, this patch makes sense to\nme.\n\nIncidentally, this drops quite some indentation in `git --help` (because\n\"sparse-checkout\" is by far the longest subcommand listed there). After\nthis patch, we're back within 80 columns again.\n\nMartin\n"},{"id":"439549","messageId":"f816eec1-cac9-7ed5-18ce-37665c11d571@gmail.com","threadId":"56771","inReplyTo":"20211024170730.3428123-1-szeder.dev@gmail.com","subject":"Re: [PATCH] command-list.txt: remove 'sparse-index' from main help","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2021-10-25T15:33:56Z","receivedAt":"2021-10-25T15:34:00Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 10/24/2021 1:07 PM, SZEDER Gábor wrote:\n> Ever since 'git sparse-checkout' was introduced [1] it is included in\n> 'git --help' in the section \"work on the current change\" along with\n> the commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't\n> belong to that group, moreover it can't be considered such a common\n> command to belong to 'git --help' in the first place, so remove it\n> from there.\n> \n> [1] 94c0956b60 (sparse-checkout: create builtin with 'list'\n> subcommand, 2019-11-21)\n> -git-sparse-checkout mainporcelain worktree\n> +git-sparse-checkout mainporcelain\n\nThanks! I didn't realize what a pain it would be to include the\n'worktree' grouping here.\n\n-Stolee\n"},{"id":"439552","messageId":"xmqqmtmx2iht.fsf@gitster.g","threadId":"56771","inReplyTo":"20211024170730.3428123-1-szeder.dev@gmail.com","subject":"Re: [PATCH] command-list.txt: remove 'sparse-index' from main help","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-25T16:10:06Z","receivedAt":"2021-10-25T16:10:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"SZEDER Gábor writes:\n\n> Ever since 'git sparse-checkout' was introduced [1] it is included in\n> 'git --help' in the section \"work on the current change\" along with\n> the commands 'add', 'mv', 'restore', and 'rm'. It clearly doesn't\n> belong to that group, moreover it can't be considered such a common\n> command to belong to 'git --help' in the first place, so remove it\n> from there.\n>\n> [1] 94c0956b60 (sparse-checkout: create builtin with 'list'\n> subcommand, 2019-11-21)\n>\n> Signed-off-by: SZEDER Gábor \n> ---\n> command-list.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nRedirecting to Stolee just in case for an Ack.\n\nI tend to agree that this is a housekeeping command for a local\nrepository to control what are and what are not materialized in the\nworking tree. It does not directly affect the history produced from\nthere, similar to \"git gc\" is, so in that sense, I do not think we\nwould miss it in the \"list of usual commands\".\n\nIf I had to have it in some category, I do agree with the current\ncode that it belongs to the \"worktree\" family, though.\n\nThanks, will queue.\n\n> diff --git a/command-list.txt b/command-list.txt\n> index a289f09ed6..eb9cee8dee 100644\n> --- a/command-list.txt\n> +++ b/command-list.txt\n> @@ -168,7 +168,7 @@ git-show-index plumbinginterrogators\n> git-show-ref plumbinginterrogators\n> git-sh-i18n purehelpers\n> git-sh-setup purehelpers\n> -git-sparse-checkout mainporcelain worktree\n> +git-sparse-checkout mainporcelain\n> git-stash mainporcelain\n> git-stage complete\n> git-status mainporcelain info\n"}]}