{"thread":{"id":"56720","subject":"[PATCH 0/4] doc lint: fix recent regression, make non-.PHONY","startedAt":"2021-10-15T12:39:54Z","lastAt":"2021-10-16T05:14:35Z","messageCount":8,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano","Bagas Sanjaya"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"438841","messageId":"cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com","threadId":"56720","inReplyTo":null,"subject":"[PATCH 0/4] doc lint: fix recent regression, make non-.PHONY","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-15T12:39:10Z","receivedAt":"2021-10-15T12:39:54Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Recent patches of mine broke the \"check-docs\" target by using\n;-chaining instead of &&-chaining, d'oh! That's currently hiding a\nbreakage in \"seen\"[1], sorry!\n\nIn 1/4 that's fixed, 2/4 emits errors to STDERR instead of STDOUT, 3/4\nspeeds up the target by ~2x by skipping unnecessary work, and 4/4\nmakes it non-.PHONY.\n\nThe technique in 4/4 of exhaustively generating a dependency graph\nper-file is something I'm also using in some yet-to-be-submitted\nseries of other Makefile fixes, that similarly speed things up.\n\n1. https://lore.kernel.org/git/87lf2ueafl.fsf@evledraar.gmail.com/\n\nÆvar Arnfjörð Bjarmason (4):\n  doc lint: fix error-hiding regression\n  doc lint: emit errors on STDERR\n  doc build: speed up \"make lint-docs\"\n  doc lint: make \"lint-docs\" non-.PHONY\n\n Documentation/.gitignore                  |  1 +\n Documentation/Makefile                    | 67 ++++++++++++++++++++---\n Documentation/lint-gitlink.perl           | 10 ++--\n Documentation/lint-man-end-blurb.perl     |  2 +-\n Documentation/lint-man-section-order.perl |  2 +-\n 5 files changed, 69 insertions(+), 13 deletions(-)\n\n-- \n2.33.1.1338.g20da966911a\n\n"},{"id":"438842","messageId":"patch-1.4-a6461f6e486-20211015T123619Z-avarab@gmail.com","threadId":"56720","inReplyTo":"cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com","subject":"[PATCH 1/4] doc lint: fix error-hiding regression","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-15T12:39:11Z","receivedAt":"2021-10-15T12:39:57Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Fix the broken \"make lint-docs\" (or \"make check-docs\" at the\ntop-level) target, which has been broken since my cafd9828e89 (doc\nlint: lint and fix missing \"GIT\" end sections, 2021-04-09).\n\nThe CI for \"seen\" is emitting an error about a broken gitlink, but due\nto there being 3x scripts chained via \";\" instead of \"&&\" we're not\ncarrying forward the non-zero exit code.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Documentation/Makefile | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex f5605b7767f..78324934d9f 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -461,9 +461,9 @@ lint-docs::\n \t\t$(HOWTO_TXT) $(DOC_DEP_TXT) \\\n \t\t--section=1 $(MAN1_TXT) \\\n \t\t--section=5 $(MAN5_TXT) \\\n-\t\t--section=7 $(MAN7_TXT); \\\n-\t$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT); \\\n-\t$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT);\n+\t\t--section=7 $(MAN7_TXT) && \\\n+\t$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT) && \\\n+\t$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT)\n \n ifeq ($(wildcard po/Makefile),po/Makefile)\n doc-l10n install-l10n::\n-- \n2.33.1.1338.g20da966911a\n\n"},{"id":"438843","messageId":"patch-2.4-3e44cdc86a7-20211015T123619Z-avarab@gmail.com","threadId":"56720","inReplyTo":"cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com","subject":"[PATCH 2/4] doc lint: emit errors on STDERR","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-15T12:39:12Z","receivedAt":"2021-10-15T12:40:02Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Have all of the scripts invoked by \"make check-docs\" emit their output\non STDERR. This does not currently matter due to the way we're\ninvoking them, but will in a subsequent change. It's a good idea to do\nthis in any case for consistency with other tools we invoke.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Documentation/lint-gitlink.perl           | 4 ++--\n Documentation/lint-man-end-blurb.perl     | 2 +-\n Documentation/lint-man-section-order.perl | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/lint-gitlink.perl b/Documentation/lint-gitlink.perl\nindex b22a367844a..076701ccfac 100755\n--- a/Documentation/lint-gitlink.perl\n+++ b/Documentation/lint-gitlink.perl\n@@ -30,8 +30,8 @@ sub report {\n \tmy ($pos, $line, $target, $msg) = @_;\n \tsubstr($line, $pos) = \"' <-- HERE\";\n \t$line =~ s/^\\s+//;\n-\tprint \"$ARGV:$.: error: $target: $msg, shown with 'HERE' below:\\n\";\n-\tprint \"$ARGV:$.:\\t'$line\\n\";\n+\tprint STDERR \"$ARGV:$.: error: $target: $msg, shown with 'HERE' below:\\n\";\n+\tprint STDERR \"$ARGV:$.:\\t'$line\\n\";\n \t$exit_code = 1;\n }\n \ndiff --git a/Documentation/lint-man-end-blurb.perl b/Documentation/lint-man-end-blurb.perl\nindex d69312e5db5..6bdb13ad9fd 100755\n--- a/Documentation/lint-man-end-blurb.perl\n+++ b/Documentation/lint-man-end-blurb.perl\n@@ -6,7 +6,7 @@\n my $exit_code = 0;\n sub report {\n \tmy ($target, $msg) = @_;\n-\tprint \"error: $target: $msg\\n\";\n+\tprint STDERR \"error: $target: $msg\\n\";\n \t$exit_code = 1;\n }\n \ndiff --git a/Documentation/lint-man-section-order.perl b/Documentation/lint-man-section-order.perl\nindex b05f9156dd9..425377dfeb7 100755\n--- a/Documentation/lint-man-section-order.perl\n+++ b/Documentation/lint-man-section-order.perl\n@@ -46,7 +46,7 @@\n my $exit_code = 0;\n sub report {\n \tmy ($msg) = @_;\n-\tprint \"$ARGV:$.: $msg\\n\";\n+\tprint STDERR \"$ARGV:$.: $msg\\n\";\n \t$exit_code = 1;\n }\n \n-- \n2.33.1.1338.g20da966911a\n\n"},{"id":"438844","messageId":"patch-4.4-800d7d81d42-20211015T123619Z-avarab@gmail.com","threadId":"56720","inReplyTo":"cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com","subject":"[PATCH 4/4] doc lint: make \"lint-docs\" non-.PHONY","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-15T12:39:14Z","receivedAt":"2021-10-15T12:40:14Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Speed up the \"lint-docs\" target by making it non-.PHONY. Similar to my\nc234e8a0ecf (Makefile: make the \"sparse\" target non-.PHONY,\n2021-09-23). We'll now create empty files corresponding to a\ndependency graph for each of these lint scripts.\n\nThis speeds things up a bit[1], and makes the output correspond to any\nin-tree changes we have:\n\n    $ touch git-add.txt; make lint-docs; make lint-docs\n        GEN cmd-list.made\n        GEN doc.dep\n        LINT GITLINK git-add.txt\n        LINT MAN END git-add.txt\n        LINT MAN SEC git-add.txt\n    make: Nothing to be done for 'lint-docs'.\n\nAs with the \"sparse\" target changes this has a hard dependency on the\nuse of \".DELETE_ON_ERROR\" in the Makefile, added here in\ndb10fc6c09f (doc: simplify Makefile using .DELETE_ON_ERROR,\n2021-05-21). This method also depends on the output for us emitting\nany errors on STDERR (fixed in a preceding commit), as well us these\nscripts exiting with non-zero on any errors (which they were already\ndoing).\n\n1.\n$ git show HEAD~:Documentation/Makefile >Makefile.old\n$ hyperfine --warmup 2 -L f \",.old\" 'make -j1 -f Makefile{f} lint-docs'\nBenchmark #1: make -j1 -f Makefile lint-docs\n  Time (mean ± σ):      60.8 ms ±   1.4 ms    [User: 58.7 ms, System: 2.5 ms]\n  Range (min … max):    58.9 ms …  64.0 ms    48 runs\n\nBenchmark #2: make -j1 -f Makefile.old lint-docs\n  Time (mean ± σ):      84.0 ms ±   1.5 ms    [User: 78.6 ms, System: 5.7 ms]\n  Range (min … max):    81.8 ms …  87.8 ms    35 runs\n\nSummary\n  'make -j1 -f Makefile lint-docs' ran\n    1.38 ± 0.04 times faster than 'make -j1 -f Makefile.old lint-docs'\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Documentation/.gitignore        |  1 +\n Documentation/Makefile          | 65 ++++++++++++++++++++++++++++++---\n Documentation/lint-gitlink.perl |  6 ++-\n 3 files changed, 64 insertions(+), 8 deletions(-)\n\ndiff --git a/Documentation/.gitignore b/Documentation/.gitignore\nindex 9022d483554..1c3771e7d72 100644\n--- a/Documentation/.gitignore\n+++ b/Documentation/.gitignore\n@@ -14,4 +14,5 @@ manpage-base-url.xsl\n SubmittingPatches.txt\n tmp-doc-diff/\n GIT-ASCIIDOCFLAGS\n+/.build/\n /GIT-EXCLUDED-PROGRAMS\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex e8e54e053a6..46c91f32566 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -225,6 +225,7 @@ endif\n \n ifneq ($(findstring $(MAKEFLAGS),s),s)\n ifndef V\n+\tQUIET\t\t= @\n \tQUIET_ASCIIDOC\t= @echo '   ' ASCIIDOC $@;\n \tQUIET_XMLTO\t= @echo '   ' XMLTO $@;\n \tQUIET_DB2TEXI\t= @echo '   ' DB2TEXI $@;\n@@ -232,11 +233,15 @@ ifndef V\n \tQUIET_DBLATEX\t= @echo '   ' DBLATEX $@;\n \tQUIET_XSLTPROC\t= @echo '   ' XSLTPROC $@;\n \tQUIET_GEN\t= @echo '   ' GEN $@;\n-\tQUIET_LINT\t= @echo '   ' LINT $@;\n \tQUIET_STDERR\t= 2> /dev/null\n \tQUIET_SUBDIR0\t= +@subdir=\n \tQUIET_SUBDIR1\t= ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \\\n \t\t\t  $(MAKE) $(PRINT_DIR) -C $$subdir\n+\n+\tQUIET_LINT_GITLINK\t= @echo '   ' LINT GITLINK $<;\n+\tQUIET_LINT_MANSEC\t= @echo '   ' LINT MAN SEC $<;\n+\tQUIET_LINT_MANEND\t= @echo '   ' LINT MAN END $<;\n+\n \texport V\n endif\n endif\n@@ -343,6 +348,7 @@ GIT-ASCIIDOCFLAGS: FORCE\n             fi\n \n clean:\n+\t$(RM) -rf .build/\n \t$(RM) *.xml *.xml+ *.html *.html+ *.1 *.5 *.7\n \t$(RM) *.texi *.texi+ *.texi++ git.info gitman.info\n \t$(RM) *.pdf\n@@ -456,14 +462,61 @@ quick-install-html: require-htmlrepo\n print-man1:\n \t@for i in $(MAN1_TXT); do echo $$i; done\n \n-lint-docs::\n-\t$(QUIET_LINT)$(PERL_PATH) lint-gitlink.perl \\\n+## Lint: Common\n+.build:\n+\t$(QUIET)mkdir $@\n+.build/lint-docs: | .build\n+\t$(QUIET)mkdir $@\n+\n+## Lint: gitlink\n+.build/lint-docs/gitlink: | .build/lint-docs\n+\t$(QUIET)mkdir $@\n+.build/lint-docs/gitlink/howto: | .build/lint-docs\n+\t$(QUIET)mkdir $@\n+.build/lint-docs/gitlink/config: | .build/lint-docs\n+\t$(QUIET)mkdir $@\n+LINT_DOCS_GITLINK = $(patsubst %.txt,.build/lint-docs/gitlink/%.ok,$(HOWTO_TXT) $(DOC_DEP_TXT))\n+$(LINT_DOCS_GITLINK): | .build/lint-docs/gitlink\n+$(LINT_DOCS_GITLINK): | .build/lint-docs/gitlink/howto\n+$(LINT_DOCS_GITLINK): | .build/lint-docs/gitlink/config\n+$(LINT_DOCS_GITLINK): lint-gitlink.perl\n+$(LINT_DOCS_GITLINK): .build/lint-docs/gitlink/%.ok: %.txt\n+\t$(QUIET_LINT_GITLINK)$(PERL_PATH) lint-gitlink.perl \\\n+\t\t$< \\\n \t\t$(HOWTO_TXT) $(DOC_DEP_TXT) \\\n \t\t--section=1 $(MAN1_TXT) \\\n \t\t--section=5 $(MAN5_TXT) \\\n-\t\t--section=7 $(MAN7_TXT) && \\\n-\t$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT) && \\\n-\t$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT)\n+\t\t--section=7 $(MAN7_TXT) >$@\n+.PHONY: lint-docs-gitlink\n+lint-docs-gitlink: $(LINT_DOCS_GITLINK)\n+\n+## Lint: man-end-blurb\n+.build/lint-docs/man-end-blurb: | .build/lint-docs\n+\t$(QUIET)mkdir $@\n+LINT_DOCS_MAN_END_BLURB = $(patsubst %.txt,.build/lint-docs/man-end-blurb/%.ok,$(MAN_TXT))\n+$(LINT_DOCS_MAN_END_BLURB): | .build/lint-docs/man-end-blurb\n+$(LINT_DOCS_MAN_END_BLURB): lint-man-end-blurb.perl\n+$(LINT_DOCS_MAN_END_BLURB): .build/lint-docs/man-end-blurb/%.ok: %.txt\n+\t$(QUIET_LINT_MANEND)$(PERL_PATH) lint-man-end-blurb.perl $< >$@\n+.PHONY: lint-docs-man-end-blurb\n+lint-docs-man-end-blurb: $(LINT_DOCS_MAN_END_BLURB)\n+\n+## Lint: man-section-order\n+.build/lint-docs/man-section-order: | .build/lint-docs\n+\t$(QUIET)mkdir $@\n+LINT_DOCS_MAN_SECTION_ORDER = $(patsubst %.txt,.build/lint-docs/man-section-order/%.ok,$(MAN_TXT))\n+$(LINT_DOCS_MAN_SECTION_ORDER): | .build/lint-docs/man-section-order\n+$(LINT_DOCS_MAN_SECTION_ORDER): lint-man-section-order.perl\n+$(LINT_DOCS_MAN_SECTION_ORDER): .build/lint-docs/man-section-order/%.ok: %.txt\n+\t$(QUIET_LINT_MANSEC)$(PERL_PATH) lint-man-section-order.perl $< >$@\n+.PHONY: lint-docs-man-section-order\n+lint-docs-man-section-order: $(LINT_DOCS_MAN_SECTION_ORDER)\n+\n+## Lint: list of targets above\n+.PHONY: lint-docs\n+lint-docs: lint-docs-gitlink\n+lint-docs: lint-docs-man-end-blurb\n+lint-docs: lint-docs-man-section-order\n \n ifeq ($(wildcard po/Makefile),po/Makefile)\n doc-l10n install-l10n::\ndiff --git a/Documentation/lint-gitlink.perl b/Documentation/lint-gitlink.perl\nindex 076701ccfac..1c61dd9512b 100755\n--- a/Documentation/lint-gitlink.perl\n+++ b/Documentation/lint-gitlink.perl\n@@ -5,11 +5,12 @@\n \n # Parse arguments, a simple state machine for input like:\n #\n-# howto/*.txt config/*.txt --section=1 git.txt git-add.txt [...] --to-lint git-add.txt a-file.txt [...]\n+# <file-to-check.txt> <valid-files-to-link-to> --section=1 git.txt git-add.txt [...] --to-lint git-add.txt a-file.txt [...]\n my %TXT;\n my %SECTION;\n my $section;\n my $lint_these = 0;\n+my $to_check = shift @ARGV;\n for my $arg (@ARGV) {\n \tif (my ($sec) = $arg =~ /^--section=(\\d+)$/s) {\n \t\t$section = $sec;\n@@ -36,7 +37,8 @@ sub report {\n }\n \n @ARGV = sort values %TXT;\n-die \"BUG: Nothing to process!\" unless @ARGV;\n+die \"BUG: No list of valid linkgit:* files given\" unless @ARGV;\n+@ARGV = $to_check;\n while (<>) {\n \tmy $line = $_;\n \twhile ($line =~ m/linkgit:((.*?)\\[(\\d)\\])/g) {\n-- \n2.33.1.1338.g20da966911a\n\n"},{"id":"438845","messageId":"patch-3.4-a02a668ebb3-20211015T123619Z-avarab@gmail.com","threadId":"56720","inReplyTo":"cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com","subject":"[PATCH 3/4] doc build: speed up \"make lint-docs\"","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-15T12:39:13Z","receivedAt":"2021-10-15T12:40:38Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Extend the trick we use to speed up the \"clean\" target to also extend\nto the \"lint-docs\" target. See 54df87555b1 (Documentation/Makefile:\nconditionally include doc.dep, 2020-12-08) for the \"clean\"\nimplementation.\n\nThe \"doc-lint\" target only depends on *.txt files, so we don't need to\ngenerate GIT-VERSION-FILE etc. if that's all we're doing. This makes\nthe \"make lint-docs\" target more than 2x as fast:\n\n$ git show HEAD~:Documentation/Makefile >Makefile.old\n$ hyperfine -L f \",.old\" 'make -f Makefile{f} lint-docs'\nBenchmark #1: make -f Makefile lint-docs\n  Time (mean ± σ):     100.2 ms ±   1.3 ms    [User: 93.7 ms, System: 6.7 ms]\n  Range (min … max):    98.4 ms … 103.1 ms    29 runs\n\nBenchmark #2: make -f Makefile.old lint-docs\n  Time (mean ± σ):     220.0 ms ±  20.0 ms    [User: 206.0 ms, System: 18.0 ms]\n  Range (min … max):   206.6 ms … 267.5 ms    11 runs\n\nSummary\n  'make -f Makefile lint-docs' ran\n    2.19 ± 0.20 times faster than 'make -f Makefile.old lint-docs'\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Documentation/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 78324934d9f..e8e54e053a6 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -284,7 +284,7 @@ install-html: html\n ../GIT-VERSION-FILE: FORCE\n \t$(QUIET_SUBDIR0)../ $(QUIET_SUBDIR1) GIT-VERSION-FILE\n \n-ifneq ($(MAKECMDGOALS),clean)\n+ifneq ($(filter-out lint-docs clean,$(MAKECMDGOALS)),)\n -include ../GIT-VERSION-FILE\n endif\n \n-- \n2.33.1.1338.g20da966911a\n\n"},{"id":"438884","messageId":"xmqqk0ie6w6w.fsf@gitster.g","threadId":"56720","inReplyTo":"patch-3.4-a02a668ebb3-20211015T123619Z-avarab@gmail.com","subject":"Re: [PATCH 3/4] doc build: speed up \"make lint-docs\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-15T17:21:11Z","receivedAt":"2021-10-15T17:21:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:\n\n> Extend the trick we use to speed up the \"clean\" target to also extend\n> to the \"lint-docs\" target. See 54df87555b1 (Documentation/Makefile:\n> conditionally include doc.dep, 2020-12-08) for the \"clean\"\n> implementation.\n>\n> The \"doc-lint\" target only depends on *.txt files, so we don't need to\n> generate GIT-VERSION-FILE etc. if that's all we're doing. This makes\n> the \"make lint-docs\" target more than 2x as fast:\n\nNice. 0.2s down to 0.1 is a 2x speedup.\n\n> $ git show HEAD~:Documentation/Makefile >Makefile.old\n> $ hyperfine -L f \",.old\" 'make -f Makefile{f} lint-docs'\n> Benchmark #1: make -f Makefile lint-docs\n>   Time (mean ± σ):     100.2 ms ±   1.3 ms    [User: 93.7 ms, System: 6.7 ms]\n>   Range (min … max):    98.4 ms … 103.1 ms    29 runs\n>\n> Benchmark #2: make -f Makefile.old lint-docs\n>   Time (mean ± σ):     220.0 ms ±  20.0 ms    [User: 206.0 ms, System: 18.0 ms]\n>   Range (min … max):   206.6 ms … 267.5 ms    11 runs\n>\n> Summary\n>   'make -f Makefile lint-docs' ran\n>     2.19 ± 0.20 times faster than 'make -f Makefile.old lint-docs'\n>\n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n>  Documentation/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index 78324934d9f..e8e54e053a6 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -284,7 +284,7 @@ install-html: html\n>  ../GIT-VERSION-FILE: FORCE\n>  \t$(QUIET_SUBDIR0)../ $(QUIET_SUBDIR1) GIT-VERSION-FILE\n>  \n> -ifneq ($(MAKECMDGOALS),clean)\n> +ifneq ($(filter-out lint-docs clean,$(MAKECMDGOALS)),)\n>  -include ../GIT-VERSION-FILE\n>  endif\n"},{"id":"438918","messageId":"438804d8-eedc-cca5-acbd-5534df601b24@gmail.com","threadId":"56720","inReplyTo":"patch-4.4-800d7d81d42-20211015T123619Z-avarab@gmail.com","subject":"Re: [PATCH 4/4] doc lint: make \"lint-docs\" non-.PHONY","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-10-16T01:57:21Z","receivedAt":"2021-10-16T01:57:49Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 15/10/21 19.39, Ævar Arnfjörð Bjarmason wrote:\n> @@ -343,6 +348,7 @@ GIT-ASCIIDOCFLAGS: FORCE\n>               fi\n>   \n>   clean:\n> +\t$(RM) -rf .build/\n>   \t$(RM) *.xml *.xml+ *.html *.html+ *.1 *.5 *.7\n>   \t$(RM) *.texi *.texi+ *.texi++ git.info gitman.info\n>   \t$(RM) *.pdf\n\nWhy did you clean the build directory?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"438919","messageId":"878ryteekt.fsf@evledraar.gmail.com","threadId":"56720","inReplyTo":"438804d8-eedc-cca5-acbd-5534df601b24@gmail.com","subject":"Re: [PATCH 4/4] doc lint: make \"lint-docs\" non-.PHONY","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-16T05:13:28Z","receivedAt":"2021-10-16T05:14:35Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Sat, Oct 16 2021, Bagas Sanjaya wrote:\n\n> On 15/10/21 19.39, Ævar Arnfjörð Bjarmason wrote:\n>> @@ -343,6 +348,7 @@ GIT-ASCIIDOCFLAGS: FORCE\n>>               fi\n>>     clean:\n>> +\t$(RM) -rf .build/\n>>   \t$(RM) *.xml *.xml+ *.html *.html+ *.1 *.5 *.7\n>>   \t$(RM) *.texi *.texi+ *.texi++ git.info gitman.info\n>>   \t$(RM) *.pdf\n>\n> Why did you clean the build directory?\n\nThe Documentation/.build directory is added by this patch, for the lint\nscratch files, but the structure is such that it can be used by other\nthings in the future.\n"}]}