{"thread":{"id":"5669","subject":"builtin-upload-archive.c broken on openbsd","startedAt":"2006-09-24T00:20:45Z","lastAt":"2006-09-24T00:20:45Z","messageCount":1,"participants":["Randal L. Schwartz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"27526","messageId":"864puyglnm.fsf@blue.stonehenge.com","threadId":"5669","inReplyTo":null,"subject":"builtin-upload-archive.c broken on openbsd","fromName":"Randal L. Schwartz","fromEmail":"merlyn@stonehenge.com","sentAt":"2006-09-24T00:20:45Z","receivedAt":"2006-09-24T00:20:45Z","isPatch":false,"sender":{"key":"merlyn@stonehenge.com","avatar":"https://gravatar.com/avatar/dc528d210743ff0333e6213f9ee7b33b23f1b7bc1f3c5a8c2d819074ecd7ab19?d=mp&s=160"},"body":"\nLooks like ctype again. Gotta be careful with that on BSD releases:\n\n    $ gmake prefix=/opt/git all\n    GIT_VERSION = 1.4.2.GIT\n    gcc -o builtin-upload-archive.o -c -g -O2 -Wall -I/usr/local/include -DSHA1_HEADER='<openssl/sha.h>' -DNO_STRCASESTR builtin-upload-archive.c\n    In file included from /usr/include/sys/poll.h:54,\n                     from builtin-upload-archive.c:11:\n    /usr/include/ctype.h:68: error: syntax error before ']' token\n    /usr/include/ctype.h:69: error: syntax error before ']' token\n    /usr/include/ctype.h:71: error: syntax error before ']' token\n    /usr/include/ctype.h:76: error: syntax error before ']' token\n    /usr/include/ctype.h:79: error: syntax error before '(' token\n    /usr/include/ctype.h:80: error: syntax error before '(' token\n    /usr/include/ctype.h:98: error: syntax error before \"c\"\n    In file included from /usr/include/sys/poll.h:54,\n                     from builtin-upload-archive.c:11:\n    /usr/include/ctype.h:96:1: unterminated #if  \n    /usr/include/ctype.h:40:1: unterminated #ifndef\n    In file included from builtin-upload-archive.c:11:\n    /usr/include/sys/poll.h:53:1: unterminated #ifndef\n    /usr/include/sys/poll.h:28:1: unterminated #ifndef\n    gmake: *** [builtin-upload-archive.o] Error 1\n\nThis fixes it:\n\n>From 5a7951c5294fc05e2754a1b6f503e36cd7b2a2f0 Mon Sep 17 00:00:00 2001\nFrom: Charlie <root@blue.stonehenge.com>\nDate: Sat, 23 Sep 2006 17:19:53 -0700\nSubject: [PATCH] local patch for openbsd\n\n---\n builtin-upload-archive.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-upload-archive.c b/builtin-upload-archive.c\nindex 0596865..45c92e1 100644\n--- a/builtin-upload-archive.c\n+++ b/builtin-upload-archive.c\n@@ -2,13 +2,13 @@\n  * Copyright (c) 2006 Franck Bui-Huu\n  */\n #include <time.h>\n+#include <sys/wait.h>\n+#include <sys/poll.h>\n #include \"cache.h\"\n #include \"builtin.h\"\n #include \"archive.h\"\n #include \"pkt-line.h\"\n #include \"sideband.h\"\n-#include <sys/wait.h>\n-#include <sys/poll.h>\n\n static const char upload_archive_usage[] =\n        \"git-upload-archive <repo>\";\n--\n1.4.2.1.g3d5c-dirty\n\n\n\n-- \nRandal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095\n<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>\nPerl/Unix/security consulting, Technical writing, Comedy, etc. etc.\nSee PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!\n"}]}