{"thread":{"id":"56628","subject":"[PATCH] p5326: create tag needed for shared tests","startedAt":"2021-10-02T17:22:55Z","lastAt":"2021-10-03T05:00:57Z","messageCount":2,"participants":["René Scharfe","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"437770","messageId":"ad6777d3-73d0-54d9-200b-88aad2d265b4@web.de","threadId":"56628","inReplyTo":null,"subject":"[PATCH] p5326: create tag needed for shared tests","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2021-10-02T17:22:35Z","receivedAt":"2021-10-02T17:22:55Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"p5326 fails with the following error:\n\n   perf 8 - rev-list with tag negated via --not --all (objects):\n   running:\n   \t\tgit rev-list perf-tag --not --all --use-bitmap-index --objects >/dev/null\n\n   fatal: ambiguous argument 'perf-tag': unknown revision or path not in the working tree.\n   Use '--' to separate paths from revisions, like this:\n   'git <command> [<revision>...] -- [<file>...]'\n\nReason: 540cdc11ad (pack-bitmap: avoid traversal of objects referenced\nby uninteresting tag, 2021-03-22) added two tests and created a tag as a\nprerequisite for them.  9387fbd646 (p5310: extract full and partial\nbitmap tests, 2021-08-31) moved the two tests (and others) to\nt/perf/lib-bitmap.sh, but not the code for creating the tag.  2d59597333\n(p5326: perf tests for MIDX bitmaps, 2021-08-31) used this library, but\ndidn't create the tag.\n\nCreate the neccesary tag in p5326 using the code from p5310.\n\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\n t/perf/p5326-multi-pack-bitmaps.sh | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/t/perf/p5326-multi-pack-bitmaps.sh b/t/perf/p5326-multi-pack-bitmaps.sh\nindex 5845109ac7..51b5636259 100755\n--- a/t/perf/p5326-multi-pack-bitmaps.sh\n+++ b/t/perf/p5326-multi-pack-bitmaps.sh\n@@ -10,6 +10,12 @@ test_expect_success 'enable multi-pack index' '\n \tgit config core.multiPackIndex true\n '\n\n+# we need to create the tag up front such that it is covered by the repack and\n+# thus by generated bitmaps.\n+test_expect_success 'create tags' '\n+\tgit tag --message=\"tag pointing to HEAD\" perf-tag HEAD\n+'\n+\n test_perf 'setup multi-pack index' '\n \tgit repack -ad &&\n \tgit multi-pack-index write --bitmap\n--\n2.33.0\n"},{"id":"437798","messageId":"YVk4Z/3X4xC2m58n@nand.local","threadId":"56628","inReplyTo":"ad6777d3-73d0-54d9-200b-88aad2d265b4@web.de","subject":"Re: [PATCH] p5326: create tag needed for shared tests","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-10-03T04:58:15Z","receivedAt":"2021-10-03T05:00:57Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi René,\n\nOn Sat, Oct 02, 2021 at 07:22:35PM +0200, René Scharfe wrote:\n> p5326 fails with the following error:\n\nThanks for noticing; this is indeed my error, and your reasoning is\naccurate.\n\nThis came up during my series to propagate namehash values into MIDX\nbitmaps here:\n\n    https://lore.kernel.org/git/a8c6e845adf559a96e37c973fea16da8a42e7cba.1631913631.git.me@ttaylorr.com/\n\nand is in next as 2082224f17 (p5326: create missing 'perf-tag' tag,\n2021-09-14).\n\nThanks,\nTaylor\n"}]}