{"thread":{"id":"56621","subject":"[PATCH 0/4] *.h: remove dead function declarations","startedAt":"2021-10-01T10:37:57Z","lastAt":"2021-10-01T21:39:37Z","messageCount":6,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"437675","messageId":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","threadId":"56621","inReplyTo":null,"subject":"[PATCH 0/4] *.h: remove dead function declarations","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T10:37:39Z","receivedAt":"2021-10-01T10:37:57Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"A trivial series to remove some long-dead code, the oldest is\nsomething we've been carrying since 2006!\n\nÆvar Arnfjörð Bjarmason (4):\n builtin.h: remove cmd_tar_tree() declaration\n grep.h: remove unused grep_threads_ok() declaration\n log-tree.h: remove unused function declarations\n config.h: remove unused git_config_get_untracked_cache() declaration\n\n builtin.h | 1 -\n config.h | 1 -\n grep.h | 1 -\n log-tree.h | 2 --\n 4 files changed, 5 deletions(-)\n\n-- \n2.33.0.1340.ge9f77250f2b\n\n"},{"id":"437676","messageId":"patch-1.4-bba00811a2b-20210928T125228Z-avarab@gmail.com","threadId":"56621","inReplyTo":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","subject":"[PATCH 1/4] builtin.h: remove cmd_tar_tree() declaration","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T10:37:40Z","receivedAt":"2021-10-01T10:38:06Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The cmd_tar_tree() function itself was removed in\n925ceccf050 (tar-tree: remove deprecated command, 2013-11-10).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n builtin.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin.h b/builtin.h\nindex 16ecd5586f0..8a58743ed63 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -225,7 +225,6 @@ int cmd_submodule__helper(int argc, const char **argv, const char *prefix);\n int cmd_switch(int argc, const char **argv, const char *prefix);\n int cmd_symbolic_ref(int argc, const char **argv, const char *prefix);\n int cmd_tag(int argc, const char **argv, const char *prefix);\n-int cmd_tar_tree(int argc, const char **argv, const char *prefix);\n int cmd_unpack_file(int argc, const char **argv, const char *prefix);\n int cmd_unpack_objects(int argc, const char **argv, const char *prefix);\n int cmd_update_index(int argc, const char **argv, const char *prefix);\n-- \n2.33.0.1340.ge9f77250f2b\n\n"},{"id":"437677","messageId":"patch-2.4-1aa29533277-20210928T125228Z-avarab@gmail.com","threadId":"56621","inReplyTo":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","subject":"[PATCH 2/4] grep.h: remove unused grep_threads_ok() declaration","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T10:37:41Z","receivedAt":"2021-10-01T10:38:08Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This function was removed in 0579f91dd74 (grep: enable threading with\n-p and -W using lazy attribute lookup, 2011-12-12), but not its\ncorresponding *.h declaration.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n grep.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/grep.h b/grep.h\nindex 128007db655..a68dce5dfa5 100644\n--- a/grep.h\n+++ b/grep.h\n@@ -223,7 +223,6 @@ void grep_source_load_driver(struct grep_source *gs,\n int grep_source(struct grep_opt *opt, struct grep_source *gs);\n \n struct grep_opt *grep_opt_dup(const struct grep_opt *opt);\n-int grep_threads_ok(const struct grep_opt *opt);\n \n /*\n * Mutex used around access to the attributes machinery if\n-- \n2.33.0.1340.ge9f77250f2b\n\n"},{"id":"437678","messageId":"patch-3.4-899d5d1c5e4-20210928T125228Z-avarab@gmail.com","threadId":"56621","inReplyTo":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","subject":"[PATCH 3/4] log-tree.h: remove unused function declarations","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T10:37:42Z","receivedAt":"2021-10-01T10:38:09Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The init_log_tree_opt() and log_tree_opt_parse() functions were\nremoved in cd2bdc53094 (Common option parsing for \"git log --diff\" and\nfriends, 2006-04-14), but not their corresponding *.h declaration.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n log-tree.h | 2 --\n 1 file changed, 2 deletions(-)\n\ndiff --git a/log-tree.h b/log-tree.h\nindex 1e8c91dbf21..e7e4641cf83 100644\n--- a/log-tree.h\n+++ b/log-tree.h\n@@ -14,10 +14,8 @@ struct decoration_filter {\n };\n \n int parse_decorate_color_config(const char *var, const char *slot_name, const char *value);\n-void init_log_tree_opt(struct rev_info *);\n int log_tree_diff_flush(struct rev_info *);\n int log_tree_commit(struct rev_info *, struct commit *);\n-int log_tree_opt_parse(struct rev_info *, const char **, int);\n void show_log(struct rev_info *opt);\n void format_decorations_extended(struct strbuf *sb, const struct commit *commit,\n \t\t\t int use_color,\n-- \n2.33.0.1340.ge9f77250f2b\n\n"},{"id":"437679","messageId":"patch-4.4-01d53ae63b6-20210928T125228Z-avarab@gmail.com","threadId":"56621","inReplyTo":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","subject":"[PATCH 4/4] config.h: remove unused git_config_get_untracked_cache() declaration","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T10:37:43Z","receivedAt":"2021-10-01T10:38:11Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This function was removed in ad0fb659993 (repo-settings: parse\ncore.untrackedCache, 2019-08-13), but not its corresponding *.h entry.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n config.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/config.h b/config.h\nindex 147f5e0490e..7378fc165fb 100644\n--- a/config.h\n+++ b/config.h\n@@ -609,7 +609,6 @@ int git_config_get_maybe_bool(const char *key, int *dest);\n int git_config_get_pathname(const char *key, const char **dest);\n \n int git_config_get_index_threads(int *dest);\n-int git_config_get_untracked_cache(void);\n int git_config_get_split_index(void);\n int git_config_get_max_percent_split_change(void);\n int git_config_get_fsmonitor(void);\n-- \n2.33.0.1340.ge9f77250f2b\n\n"},{"id":"437734","messageId":"xmqqfstk4e7h.fsf@gitster.g","threadId":"56621","inReplyTo":"cover-0.4-00000000000-20210928T125228Z-avarab@gmail.com","subject":"Re: [PATCH 0/4] *.h: remove dead function declarations","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-01T21:39:30Z","receivedAt":"2021-10-01T21:39:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> A trivial series to remove some long-dead code, the oldest is\n> something we've been carrying since 2006!\n\nNice. Thanks.\n"}]}