{"thread":{"id":"56617","subject":"What's cooking in git.git (Sep 2021, #09; Thu, 30)","startedAt":"2021-10-01T01:01:05Z","lastAt":"2021-10-01T17:05:17Z","messageCount":15,"participants":["Junio C Hamano","Elijah Newren","Jeff King","Ævar Arnfjörð Bjarmason","Jeff Hostetler"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"437590","messageId":"xmqqh7e18soj.fsf@gitster.g","threadId":"56617","inReplyTo":null,"subject":"What's cooking in git.git (Sep 2021, #09; Thu, 30)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-01T01:01:00Z","receivedAt":"2021-10-01T01:01:05Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree.  Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release).  Commits prefixed with '-' are only in 'seen',\nwhich means nothing more than that I have found them of interest for\nsome reason (like \"it may have hard-to-resolve conflicts with\nanother topic already in flight\" or \"this may turn out to be\nuseful\").  Do not read too much into a topic being in (or not in)\n'seen'.  The ones marked with '.' do not appear in any of the\nintegration branches, but I am still holding onto them.\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors.  Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-vcs/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* cb/unicode-14 (2021-09-17) 1 commit\n  (merged to 'next' on 2021-09-20 at 7873b310ad)\n + unicode: update the width tables to Unicode 14\n\n The unicode character width table (used for output alignment) has\n been updated.\n\n\n* en/typofixes (2021-09-20) 2 commits\n  (merged to 'next' on 2021-09-20 at 48648dafa3)\n + merge-ort: fix completely wrong comment\n + trace2.h: fix trivial comment typo\n\n Typofixes.\n\n\n* jk/reduce-malloc-in-v2-servers (2021-09-15) 12 commits\n  (merged to 'next' on 2021-09-16 at 40cfe41efc)\n + ls-refs: reject unknown arguments\n + serve: reject commands used as capabilities\n + serve: reject bogus v2 \"command=ls-refs=foo\"\n + docs/protocol-v2: clarify some ls-refs ref-prefix details\n + ls-refs: ignore very long ref-prefix counts\n + serve: drop \"keys\" strvec\n + serve: provide \"receive\" function for session-id capability\n + serve: provide \"receive\" function for object-format capability\n + serve: add \"receive\" method for v2 capabilities table\n + serve: return capability \"value\" from get_capability()\n + serve: rename is_command() to parse_command()\n + Merge branch 'ab/serve-cleanup' into jk/reduce-malloc-in-v2-servers\n\n Code cleanup to limit memory consumption and tighten protocol\n message parsing.\n\n--------------------------------------------------\n[New Topics]\n\n* ab/designated-initializers (2021-09-27) 5 commits\n - cbtree.h: define cb_init() in terms of CBTREE_INIT\n - *.h: move some *_INIT to designated initializers\n - *.h _INIT macros: don't specify fields equal to 0\n - *.[ch] *_INIT macros: use { 0 } for a \"zero out\" idiom\n - submodule-config.h: remove unused SUBMODULE_INIT macro\n (this branch is used by ab/designated-initializers-more.)\n\n Code clean-up.\n\n Will merge to 'next'.\n\n\n* ab/designated-initializers-more (2021-09-27) 6 commits\n - builtin/remote.c: add and use SHOW_INFO_INIT\n - builtin/remote.c: add and use a REF_STATES_INIT\n - urlmatch.[ch]: add and use URLMATCH_CONFIG_INIT\n - builtin/blame.c: refactor commit_info_init() to COMMIT_INFO_INIT macro\n - daemon.c: refactor hostinfo_init() to HOSTINFO_INIT macro\n - Merge branch 'ab/designated-initializers' into ab/designated-initializers-more\n (this branch uses ab/designated-initializers.)\n\n Code clean-up.\n\n What's the status of this one?  Meh?\n\n\n* lh/systemd-timers (2021-09-27) 1 commit\n - maintenance: fix test t7900-maintenance.sh\n\n Testfix.\n\n Will merge to 'next'.\n\n\n* os/status-docfix (2021-09-28) 1 commit\n - doc: fix capitalization in \"git status --porcelain=v2\" description\n\n Docfix.\n\n Will merge to 'next'.\n\n\n* ab/parse-options-cleanup (2021-09-28) 10 commits\n - parse-options: change OPT_{SHORT,UNSET} to an enum\n - parse-options tests: test optname() output\n - parse-options.[ch]: make opt{bug,name}() \"static\"\n - commit-graph: stop using optname()\n - parse-options.c: move optname() earlier in the file\n - parse-options.h: make the \"flags\" in \"struct option\" an enum\n - parse-options.c: use exhaustive \"case\" arms for \"enum parse_opt_type\"\n - parse-options.[ch]: consistently use \"enum parse_opt_result\"\n - parse-options.[ch]: consistently use \"enum parse_opt_flags\"\n - parse-options.h: move PARSE_OPT_SHELL_EVAL between enums\n\n Random changes to parse-options implementation.\n\n What's the status of this one?  Meh?\n\n\n* ab/retire-git-config-key-is-valid (2021-09-28) 1 commit\n - config.c: remove unused git_config_key_is_valid()\n\n Code cleanup.\n\n Will merge to 'next'.\n\n\n* ab/retire-refs-unused-funcs (2021-09-28) 5 commits\n - refs/ref-cache.[ch]: remove \"incomplete\" from create_dir_entry()\n - refs/ref-cache.c: remove \"mkdir\" parameter from find_containing_dir()\n - refs/ref-cache.[ch]: remove unused add_ref_entry()\n - refs/ref-cache.[ch]: remove unused remove_entry_from_dir()\n - refs.[ch]: remove unused ref_storage_backend_exists()\n\n Code cleanup.\n\n Will merge to 'next'.\n\n\n* ab/retire-string-list-init (2021-09-28) 1 commit\n - string-list.[ch]: remove string_list_init() compatibility function\n\n Code cleanup.\n\n Will merge to 'next'.\n\n\n* mt/grep-submodule-textconv (2021-09-29) 1 commit\n - grep: demonstrate bug with textconv attributes and submodules\n\n \"git grep --recurse-submodules\" takes trees and blobs from the\n submodule repository, but the textconv settings when processing a\n blob from the submodule is not taken from the submodule repository.\n A demonstration is added to demonstrate the issue, without fixing\n it.\n\n Will merge to 'next'.\n\n--------------------------------------------------\n[Stalled]\n\n* ar/submodule-update (2021-09-20) 8 commits\n . submodule--helper: rename helper functions\n . submodule--helper: remove unused helpers\n . submodule--helper: remove update-clone subcommand\n . submodule: move core cmd_update() logic to C\n . submodule--helper: refactor get_submodule_displaypath()\n . submodule--helper: rename helpers for update-clone\n . submodule--helper: get remote names from any repository\n . submodule--helper: split up ensure_core_worktree()\n\n Rewrite of \"git submodule update\" in C.\n\n Kicked out of 'seen' to make room for es/superproject-aware-submodules\n which is among the topics this topic stomps on.\n\n--------------------------------------------------\n[Cooking]\n\n* es/superproject-aware-submodules (2021-08-19) 5 commits\n - fixup! introduce submodule.superprojectGitDir record\n - submodule: record superproject gitdir during 'update'\n - submodule: record superproject gitdir during absorbgitdirs\n - introduce submodule.superprojectGitDir record\n - t7400-submodule-basic: modernize inspect() helper\n\n A configuration variable in a submodule points at the location of\n the superproject it is bound to (RFC).\n\n Brought back to 'seen' to see if it still plays well with the rest\n of 'seen', without the conflicting ar/submodule-update topic.\n\n\n* ab/fsck-unexpected-type (2021-09-30) 17 commits\n - fsck: report invalid object type-path combinations\n - fsck: don't hard die on invalid object types\n - object-file.c: stop dying in parse_loose_header()\n - object-file.c: return ULHR_TOO_LONG on \"header too long\"\n - object-file.c: use \"enum\" return type for unpack_loose_header()\n - object-file.c: simplify unpack_loose_short_header()\n - object-file.c: make parse_loose_header_extended() public\n - object-file.c: return -1, not \"status\" from unpack_loose_header()\n - object-file.c: don't set \"typep\" when returning non-zero\n - cat-file tests: test for current --allow-unknown-type behavior\n - cat-file tests: add corrupt loose object test\n - cat-file tests: test for missing/bogus object with -t, -s and -p\n - cat-file tests: move bogus_* variable declarations earlier\n - fsck tests: test for garbage appended to a loose object\n - fsck tests: test current hash/type mismatch behavior\n - fsck tests: refactor one test to use a sub-repo\n - fsck tests: add test for fsck-ing an unknown type\n\n \"git fsck\" has been taught to report mismatch between expected and\n actual types of an object better.\n\n Will merge to 'next'?\n\n\n* ab/bundle-remove-verbose-option (2021-09-23) 1 commit\n  (merged to 'next' on 2021-09-28 at 8251d269a2)\n + bundle: remove ignored & undocumented \"--verbose\" flag\n\n Doc update.\n\n Will merge to 'master'.\n\n\n* ab/config-based-hooks-1 (2021-09-27) 8 commits\n - hook-list.h: add a generated list of hooks, like config-list.h\n - hook.c users: use \"hook_exists()\" instead of \"find_hook()\"\n - hook.c: add a hook_exists() wrapper and use it in bugreport.c\n - hook.[ch]: move find_hook() from run-command.c to hook.c\n - Makefile: remove an out-of-date comment\n - Makefile: don't perform \"mv $@+ $@\" dance for $(GENERATED_H)\n - Makefile: stop hardcoding {command,config}-list.h\n - Makefile: mark \"check\" target as .PHONY\n\n Mostly preliminary clean-up in the hook API.\n\n\n* ab/http-pinned-public-key-mismatch (2021-09-27) 1 commit\n - http: check CURLE_SSL_PINNEDPUBKEYNOTMATCH when emitting errors\n\n HTTPS error handling updates.\n\n Will merge to 'next'.\n\n\n* ab/make-compdb-fix (2021-09-27) 1 commit\n  (merged to 'next' on 2021-09-29 at b3439753df)\n + Makefile: pass -Wno-pendantic under GENERATE_COMPILATION_DATABASE=yes\n\n Build update.\n\n Will merge to 'master'.\n\n\n* jk/ref-paranoia (2021-09-27) 16 commits\n - refs: drop \"broken\" flag from for_each_fullref_in()\n - ref-filter: drop broken-ref code entirely\n - ref-filter: stop setting FILTER_REFS_INCLUDE_BROKEN\n - repack, prune: drop GIT_REF_PARANOIA settings\n - refs: turn on GIT_REF_PARANOIA by default\n - refs: omit dangling symrefs when using GIT_REF_PARANOIA\n - refs: add DO_FOR_EACH_OMIT_DANGLING_SYMREFS flag\n - refs-internal.h: reorganize DO_FOR_EACH_* flag documentation\n - refs-internal.h: move DO_FOR_EACH_* flags next to each other\n - t5312: be more assertive about command failure\n - t5312: test non-destructive repack\n - t5312: create bogus ref as necessary\n - t5312: drop \"verbose\" helper\n - t5600: provide detached HEAD for corruption failures\n - t5516: don't use HEAD ref for invalid ref-deletion tests\n - t7900: clean up some more broken refs\n (this branch is used by jt/no-abuse-alternate-odb-for-submodules.)\n\n The ref iteration code used to optionally allow dangling refs to be\n shown, which has been tightened up.\n\n Will merge to 'next'.\n\n\n* pw/rebase-reread-todo-after-editing (2021-09-24) 2 commits\n  (merged to 'next' on 2021-09-28 at c67d5e383e)\n + rebase: fix todo-list rereading\n + sequencer.c: factor out a function\n\n The code to re-read the edited todo list in \"git rebase -i\" was\n made more robust.\n\n Will merge to 'master'.\n\n\n* rs/close-pack-leakfix (2021-09-24) 1 commit\n  (merged to 'next' on 2021-09-28 at b14502faa0)\n + packfile: release bad_objects in close_pack()\n\n Leakfix.\n\n Will merge to 'master'.\n\n\n* ab/make-clean-depend-dirs (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-28 at 20483ade7d)\n + Makefile: clean .depend dirs under COMPUTE_HEADER_DEPENDENCIES != yes\n\n \"make clean\" has been updated to remove leftover .depend/\n directories, even when it is not told to use them to compute header\n dependencies.\n\n Will merge to 'master'.\n\n\n* bs/ls-files-opt-help-text-update (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-28 at d27c228644)\n + ls-files: use imperative mood for -X and -z option description\n\n Help text for \"ls-files\" options have been updated.\n\n Will merge to 'master'.\n\n\n* ds/perf-test-built-path-fix (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-28 at 18a21483d9)\n + t/perf/run: fix bin-wrappers computation\n\n Perf test fix.\n\n Will merge to 'master'.\n\n\n* gc/doc-first-contribution-reroll (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-29 at b7dea55eae)\n + MyFirstContribution: Document --range-diff option when writing v2\n\n Doc update.\n\n Will merge to 'master'.\n\n\n* jk/grep-haystack-is-read-only (2021-09-22) 5 commits\n  (merged to 'next' on 2021-09-28 at 1660a6be89)\n + grep: store grep_source buffer as const\n + grep: mark \"haystack\" buffers as const\n + grep: stop modifying buffer in grep_source_1()\n + grep: stop modifying buffer in show_line()\n + grep: stop modifying buffer in strip_timestamp\n (this branch is used by hm/paint-hits-in-log-grep.)\n\n Code clean-up in the \"grep\" machinery.\n\n Will merge to 'master'.\n\n\n* jk/http-redact-fix (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-28 at ef4570a5d1)\n + http: match headers case-insensitively when redacting\n\n Sensitive data in the HTTP trace were supposed to be redacted, but\n we failed to do so in HTTP/2 requests.\n\n Will merge to 'master'.\n\n\n* js/win-lazyload-buildfix (2021-09-28) 3 commits\n - Makefile: restrict -Wpedantic and -Wno-pedantic-ms-format better\n - lazyload.h: use an even more generic function pointer than FARPROC\n - lazyload.h: fix warnings about mismatching function pointer types\n\n Compilation fix.\n\n Will merge to 'next'.\n\n\n* ab/auto-depend-with-pedantic (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-28 at 532f2aa26e)\n + Makefile: make COMPUTE_HEADER_DEPENDENCIES=auto work with DEVOPTS=pedantic\n\n Improve build procedure for developers.\n\n Will merge to 'master'.\n\n\n* ab/make-sparse-for-real (2021-09-22) 1 commit\n - Makefile: make the \"sparse\" target non-.PHONY\n\n Prevent \"make sparse\" from running for the source files that\n haven't been modified.\n\n Will merge to 'next'?\n\n\n* bs/difftool-msg-tweak (2021-09-22) 1 commit\n  (merged to 'next' on 2021-09-29 at 22d485e560)\n + difftool: fix word spacing in the usage strings\n\n Message tweak.\n\n Will merge to 'master'.\n\n\n* ew/midx-doc-update (2021-09-24) 1 commit\n  (merged to 'next' on 2021-09-28 at f2cbe598eb)\n + doc/technical: update note about core.multiPackIndex\n\n Doc tweak.\n\n Will merge to 'master'.\n\n\n* jt/no-abuse-alternate-odb-for-submodules (2021-09-29) 9 commits\n - submodule: trace adding submodule ODB as alternate\n - submodule: pass repo to check_has_commit()\n - object-file: only register submodule ODB if needed\n - merge-{ort,recursive}: remove add_submodule_odb()\n - refs: peeling non-the_repository iterators is BUG\n - refs: teach arbitrary repo support to iterators\n - refs: plumb repo into ref stores\n - Merge branch 'jk/ref-paranoia' into jt/no-abuse-alternate-odb-for-submodules\n - Merge branch 'jt/add-submodule-odb-clean-up' into jt/no-abuse-alternate-odb-for-submodules\n (this branch uses jk/ref-paranoia and jt/add-submodule-odb-clean-up.)\n\n Follow through the work to use the repo interface to access\n submodule objects in-process, instead of abusing the alternate\n object database interface.\n\n\n* tp/send-email-completion (2021-09-22) 3 commits\n - send-email docs: add format-patch options\n - send-email: move bash completions to core script\n - send-email: terminate --git-completion-helper with LF\n\n The command line complation for \"git send-email\" options have been\n tweaked to make it easier to keep it in sync with the command itself.\n\n Stalled.\n cf. <YU6+BWC+xvGJP3b0@carlos-mbp.lan>\n\n\n* hm/paint-hits-in-log-grep (2021-09-29) 3 commits\n - pretty: colorize pattern matches in commit messages\n - grep: refactor next_match() and match_one_pattern() for external use\n - Merge branch 'jk/grep-haystack-is-read-only' into hm/paint-hits-in-log-grep\n (this branch uses jk/grep-haystack-is-read-only.)\n\n \"git log --grep=string --author=name\" learns to highlight hits just\n like \"git grep string\" does.\n\n Will merge to 'next'?\n\n\n* ab/repo-settings-cleanup (2021-09-22) 5 commits\n  (merged to 'next' on 2021-09-28 at 43d70c31e1)\n + repository.h: don't use a mix of int and bitfields\n + repo-settings.c: simplify the setup\n + read-cache & fetch-negotiator: check \"enum\" values in switch()\n + environment.c: remove test-specific \"ignore_untracked...\" variable\n + wrapper.c: add x{un,}setenv(), and use xsetenv() in environment.c\n\n Code cleanup.\n\n Will merge to 'master'.\n\n\n* ah/connect-parse-feature-v0-fix (2021-09-27) 1 commit\n  (merged to 'next' on 2021-09-29 at 93a45727a2)\n + connect: also update offset for features without values\n\n Protocol v0 clients can get stuck parsing a malformed feature line.\n\n Will merge to 'master'.\n\n\n* da/difftool (2021-09-30) 7 commits\n - difftool: remove an unnecessary call to strbuf_release()\n - difftool: refactor dir-diff to write files using a helper function\n - difftool: avoid returning -1 to cmd_main() from run_dir_diff()\n - difftool: add a missing space to the run_dir_diff() comments\n - difftool: create a tmpdir path without repeated slashes\n - Merge branch 'da/difftool-dir-diff-symlink-fix' into da/difftool\n - Merge branch 'ab/retire-option-argument' into da/difftool\n (this branch uses da/difftool-dir-diff-symlink-fix.)\n\n Code clean-up in \"git difftool\".\n\n\n* da/difftool-dir-diff-symlink-fix (2021-09-23) 1 commit\n  (merged to 'next' on 2021-09-28 at e2170ed0d7)\n + difftool: fix symlink-file writing in dir-diff mode\n (this branch is used by da/difftool.)\n\n \"git difftool --dir-diff\" mishandled symbolic links.\n\n Will merge to 'master'.\n\n\n* en/removing-untracked-fixes (2021-09-27) 12 commits\n - Documentation: call out commands that nuke untracked files/directories\n - Comment important codepaths regarding nuking untracked files/dirs\n - unpack-trees: avoid nuking untracked dir in way of locally deleted file\n - unpack-trees: avoid nuking untracked dir in way of unmerged file\n - Change unpack_trees' 'reset' flag into an enum\n - Remove ignored files by default when they are in the way\n - unpack-trees: make dir an internal-only struct\n - unpack-trees: introduce preserve_ignored to unpack_trees_options\n - read-tree, merge-recursive: overwrite ignored files by default\n - checkout, read-tree: fix leak of unpack_trees_options.dir\n - t2500: add various tests for nuking untracked files\n - Merge branch 'en/am-abort-fix' into en/removing-untracked-fixes\n\n Various fixes in code paths that move untracked files away to make room.\n\n Will merge to 'next'?\n\n\n* ks/submodule-add-message-fix (2021-09-20) 1 commit\n - submodule--helper: fix incorrect newlines in an error message\n\n Message regression fix.\n\n Waiting for a response.\n cf. <m27df9lvm1.fsf@gmail.com>\n\n\n* tb/commit-graph-usage-fix (2021-09-22) 2 commits\n  (merged to 'next' on 2021-09-28 at f021339c39)\n + builtin/multi-pack-index.c: disable top-level --[no-]progress\n + builtin/commit-graph.c: don't accept common --[no-]progress\n\n Regression in \"git commit-graph\" command line parsing has been\n corrected.\n\n Will merge to 'master'.\n\n\n* ws/refer-to-forkpoint-config-in-rebase-doc (2021-09-20) 1 commit\n  (merged to 'next' on 2021-09-29 at 49181eaafb)\n + Document `rebase.forkpoint` in rebase man page\n\n Doc update.\n\n Will merge to 'master'.\n\n\n* jk/clone-unborn-head-in-bare (2021-09-20) 1 commit\n  (merged to 'next' on 2021-09-20 at 93c93b8d51)\n + clone: handle unborn branch in bare repos\n\n \"git clone\" from a repository whose HEAD is unborn into a bare\n repository didn't follow the branch name the other side used, which\n is corrected.\n\n Will merge to 'master'.\n\n\n* ns/batched-fsync (2021-09-27) 8 commits\n - core.fsyncobjectfiles: performance tests for add and stash\n - core.fsyncobjectfiles: tests for batch mode\n - unpack-objects: use the bulk-checkin infrastructure\n - update-index: use the bulk-checkin infrastructure\n - core.fsyncobjectfiles: add windows support for batch mode\n - core.fsyncobjectfiles: batched disk flushes\n - bulk-checkin: rename 'state' variable and separate 'plugged' boolean\n - object-file.c: do not rename in a temp odb\n\n The \"core.fsyncobjectfiles\" configuration variable can now be set\n to \"batch\" for improved performance.\n\n Under discussion.\n Handling of temporary object directory may be iffy.\n\n\n* jh/builtin-fsmonitor-part1 (2021-09-20) 7 commits\n - t/helper/simple-ipc: convert test-simple-ipc to use start_bg_command\n - run-command: create start_bg_command\n - simple-ipc/ipc-win32: add Windows ACL to named pipe\n - simple-ipc/ipc-win32: add trace2 debugging\n - simple-ipc: move definition of ipc_active_state outside of ifdef\n - simple-ipc: preparations for supporting binary messages.\n - trace2: add trace2_child_ready() to report on background children\n\n Built-in fsmonitor (part 1).\n\n\n* cb/cvsserver (2021-09-16) 3 commits\n  (merged to 'next' on 2021-09-23 at 98f5f3f9cf)\n + Documentation: cleanup git-cvsserver\n + git-cvsserver: protect against NULL in crypt(3)\n + git-cvsserver: use crypt correctly to compare password hashes\n\n \"git cvsserver\" had a long-standing bug in its authentication code,\n which has finally been corrected (it is unclear and is a separate\n question if anybody is seriously using it, though).\n\n Will merge to 'master'.\n\n\n* ab/align-parse-options-help (2021-09-22) 4 commits\n - parse-options: properly align continued usage output\n - git rev-parse --parseopt tests: add more usagestr tests\n - send-pack: properly use parse_options() API for usage string\n - parse-options API users: align usage output in C-strings\n\n When \"git cmd -h\" shows more than one line of usage text (e.g.\n the cmd subcommand may take sub-sub-command), parse-options API\n learned to align these lines, even across i18n/l10n.\n\n Will merge to 'next'?\n\n\n* ab/help-config-vars (2021-09-23) 9 commits\n - help: move column config discovery to help.c library\n - help / completion: make \"git help\" do the hard work\n - help tests: test --config-for-completion option & output\n - help: simplify by moving to OPT_CMDMODE()\n - help: correct logic error in combining --all and --guides\n - help: correct logic error in combining --all and --config\n - help tests: add test for --config output\n - help: correct usage & behavior of \"git help --guides\"\n - help: correct the usage string in -h and documentation\n\n Teach \"git help -c\" into helping the command line completion of\n configuration variables.\n\n Will merge to 'next'?\n\n\n* tb/repack-write-midx (2021-09-28) 9 commits\n - builtin/repack.c: pass `--refs-snapshot` when writing bitmaps\n - builtin/repack.c: make largest pack preferred\n - builtin/repack.c: support writing a MIDX while repacking\n - builtin/repack.c: extract showing progress to a variable\n - builtin/repack.c: rename variables that deal with non-kept packs\n - builtin/repack.c: keep track of existing packs unconditionally\n - midx: preliminary support for `--refs-snapshot`\n - builtin/multi-pack-index.c: support `--stdin-packs` mode\n - midx: expose `write_midx_file_only()` publicly\n\n \"git repack\" has been taught to generate multi-pack reachability\n bitmaps.\n\n\n* ds/add-rm-with-sparse-index (2021-09-28) 13 commits\n - advice: update message to suggest '--sparse'\n - mv: refuse to move sparse paths\n - rm: skip sparse paths with missing SKIP_WORKTREE\n - rm: add --sparse option\n - add: update --renormalize to skip sparse paths\n - add: update --chmod to skip sparse paths\n - add: implement the --sparse option\n - add: skip tracked paths outside sparse-checkout cone\n - add: fail when adding an untracked sparse file\n - dir: fix pattern matching on dirs\n - dir: select directories correctly\n - t1092: behavior for adding sparse files\n - t3705: test that 'sparse_entry' is unstaged\n\n \"git add\", \"git mv\", and \"git rm\" have been adjusted to avoid\n updating paths outside of the sparse-checkout definition unless\n the user specifies a \"--sparse\" option.\n\n Will merge to 'next'.\n\n\n* tb/midx-write-propagate-namehash (2021-09-17) 7 commits\n  (merged to 'next' on 2021-09-29 at 24732fcfc8)\n + t5326: test propagating hashcache values\n + p5326: generate pack bitmaps before writing the MIDX bitmap\n + p5326: don't set core.multiPackIndex unnecessarily\n + p5326: create missing 'perf-tag' tag\n + midx.c: respect 'pack.writeBitmapHashcache' when writing bitmaps\n + pack-bitmap.c: propagate namehash values from existing bitmaps\n + t/helper/test-bitmap.c: add 'dump-hashes' mode\n\n \"git multi-pack-index write --bitmap\" learns to propagate the\n hashcache from original bitmap to resulting bitmap.\n\n Will merge to 'master'.\n\n\n* pw/rebase-of-a-tag-fix (2021-09-22) 10 commits\n  (merged to 'next' on 2021-09-28 at 980add2a67)\n + rebase: dereference tags\n + rebase: use lookup_commit_reference_by_name()\n + rebase: use our standard error return value\n + t3407: rework rebase --quit tests\n + t3407: strengthen rebase --abort tests\n + t3407: use test_path_is_missing\n + t3407: rename a variable\n + t3407: use test_cmp_rev\n + t3407: use test_commit\n + t3407: run tests in $TEST_DIRECTORY\n\n \"git rebase <upstream> <tag>\" failed when aborted in the middle, as\n it mistakenly tried to write the tag object instead of peeling it\n to HEAD.\n\n Will merge to 'master'.\n\n\n* en/zdiff3 (2021-09-20) 2 commits\n - update documentation for new zdiff3 conflictStyle\n - xdiff: implement a zealous diff3, or \"zdiff3\"\n\n \"Zealous diff3\" style of merge conflict presentation has been added.\n\n\n* en/stash-df-fix (2021-09-10) 3 commits\n  (merged to 'next' on 2021-09-20 at 513c11fb11)\n + stash: restore untracked files AFTER restoring tracked files\n + stash: avoid feeding directories to update-index\n + t3903: document a pair of directory/file bugs\n\n Fix \"git stash\" corner case where the tentative change involves\n changing a directory to a file (or vice versa).\n\n Will merge to 'master'.\n\n\n* jt/add-submodule-odb-clean-up (2021-09-09) 3 commits\n  (merged to 'next' on 2021-09-28 at 4d843448be)\n + revision: remove \"submodule\" from opt struct\n + repository: support unabsorbed in repo_submodule_init\n + submodule: remove unnecessary unabsorbed fallback\n (this branch is used by jt/no-abuse-alternate-odb-for-submodules.)\n\n More code paths that use the hack to add submodule's object\n database to the set of alternate object store have been cleaned up.\n\n Will merge to 'master'.\n\n\n* jx/ci-l10n (2021-09-09) 1 commit\n  (merged to 'next' on 2021-09-23 at b2d7f5eecb)\n + ci: new github-action for git-l10n code review\n\n CI help for l10n.\n\n Will merge to 'master'.\n\n\n* js/scalar (2021-09-14) 15 commits\n - scalar: accept -C and -c options before the subcommand\n - scalar: implement the `version` command\n - scalar: implement the `delete` command\n - scalar: teach 'reconfigure' to optionally handle all registered enlistments\n - scalar: allow reconfiguring an existing enlistment\n - scalar: implement the `run` command\n - scalar: teach 'clone' to support the --single-branch option\n - scalar: implement the `clone` subcommand\n - scalar: implement 'scalar list'\n - scalar: let 'unregister' handle a deleted enlistment directory gracefully\n - scalar: 'unregister' stops background maintenance\n - scalar: 'register' sets recommended config and starts maintenance\n - scalar: create test infrastructure\n - scalar: start documenting the command\n - scalar: create a rudimentary executable\n\n Add pieces from \"scalar\" to contrib/.\n\n Waiting for a response.\n cf. <pull.1005.v4.git.1631630356.gitgitgadget@gmail.com>\n\n\n* ab/sanitize-leak-ci (2021-09-23) 2 commits\n - tests: add a test mode for SANITIZE=leak, run it in CI\n - Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONS\n\n CI learns to run the leak sanitizer builds.\n\n Will merge to 'next'.\n\n\n* ms/customizable-ident-expansion (2021-09-01) 1 commit\n - keyword expansion: make \"$Id$\" string configurable\n\n Instead of \"$Id$\", user-specified string (like $FreeBSD$) can be\n used as an in-blob placeholder for keyword expansion.\n\n\n* js/retire-preserve-merges (2021-09-07) 11 commits\n  (merged to 'next' on 2021-09-10 at f645ffd7a3)\n + sequencer: restrict scope of a formerly public function\n + rebase: remove a no-longer-used function\n + rebase: stop mentioning the -p option in comments\n + rebase: remove obsolete code comment\n + rebase: drop the internal `rebase--interactive` command\n + git-svn: drop support for `--preserve-merges`\n + rebase: drop support for `--preserve-merges`\n + pull: remove support for `--rebase=preserve`\n + tests: stop testing `git rebase --preserve-merges`\n + remote: warn about unhandled branch.<name>.rebase values\n + t5520: do not use `pull.rebase=preserve`\n\n The \"--preserve-merges\" option of \"git rebase\" has been removed.\n\n Will cook in 'next'.\n\n\n* en/remerge-diff (2021-08-31) 7 commits\n - doc/diff-options: explain the new --remerge-diff option\n - show, log: provide a --remerge-diff capability\n - tmp-objdir: new API for creating and removing primary object dirs\n - merge-ort: capture and print ll-merge warnings in our preferred fashion\n - ll-merge: add API for capturing warnings in a strbuf instead of stderr\n - merge-ort: add ability to record conflict messages in a file\n - merge-ort: mark a few more conflict messages as omittable\n\n A new presentation for two-parent merge \"--remerge-diff\" can be\n used to show the difference between mechanical (and possibly\n conflicted) merge results and the recorded resolution.\n\n Will merge to 'next'?\n\n\n* sg/test-split-index-fix (2021-09-07) 7 commits\n  (merged to 'next' on 2021-09-29 at 661ae75778)\n + read-cache: fix GIT_TEST_SPLIT_INDEX\n + tests: disable GIT_TEST_SPLIT_INDEX for sparse index tests\n + read-cache: look for shared index files next to the index, too\n + t1600-index: disable GIT_TEST_SPLIT_INDEX\n + t1600-index: don't run git commands upstream of a pipe\n + t1600-index: remove unnecessary redirection\n + Merge branch 'ds/sparse-index-ignored-files' into sg/test-split-index-fix\n\n Test updates.\n\n Will merge to 'master'.\n\n\n* ab/refs-errno-cleanup (2021-08-25) 4 commits\n - refs: make errno output explicit for refs_resolve_ref_unsafe\n - refs: explicitly return failure_errno from parse_loose_ref_contents\n - branch tests: test for errno propagating on failing read\n - refs: add failure_errno to refs_read_raw_ref() signature\n (this branch uses ab/refs-files-cleanup and hn/refs-errno-cleanup.)\n\n The \"remainder\" of hn/refs-errno-cleanup topic.\n\n What's the status of this one?  Meh?\n\n\n* ab/lib-subtest (2021-09-22) 9 commits\n - test-lib tests: get rid of copy/pasted mock test code\n - test-lib tests: assert 1 exit code, not non-zero\n - test-lib tests: refactor common part of check_sub_test_lib_test*()\n - test-lib tests: avoid subshell for \"test_cmp\" for readability\n - test-lib tests: don't provide a description for the sub-tests\n - test-lib tests: split up \"write and run\" into two functions\n - test-lib tests: move \"run_sub_test\" to a new lib-subtest.sh\n - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest\n - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest\n\n Updates to the tests in t0000 to test the test framework.\n\n Will merge to 'next'?\n\n\n* ab/only-single-progress-at-once (2021-09-22) 8 commits\n - progress.c: add & assert a \"global_progress\" variable\n - pack-bitmap-write.c: add a missing stop_progress()\n - progress.c: add temporary variable from progress struct\n - progress.c: stop eagerly fflush(stderr) when not a terminal\n - progress.c: call progress_interval() from progress_test_force_update()\n - progress.c: move signal handler functions lower\n - progress.c tests: test some invalid usage\n - progress.c tests: make start/stop verbs on stdin\n\n Further tweaks on progress API.\n\n\n* fs/ssh-signing (2021-09-10) 9 commits\n - ssh signing: test that gpg fails for unknown keys\n - ssh signing: tests for logs, tags & push certs\n - ssh signing: duplicate t7510 tests for commits\n - ssh signing: verify signatures using ssh-keygen\n - ssh signing: provide a textual signing_key_id\n - ssh signing: retrieve a default key from ssh-agent\n - ssh signing: add ssh key format and signing code\n - ssh signing: add test prereqs\n - ssh signing: preliminary refactoring and clean-up\n\n Use ssh public crypto for object and push-cert signing.\n\n Will merge to 'next'?\n\n\n* cf/fetch-set-upstream-while-detached (2021-07-06) 1 commit\n - fetch: fix segfault on --set-upstream while on a detached HEAD\n\n \"git fetch --set-upstream\" while on detached HEAD segfaulted\n instead of noticing that such an operation did not make sense.\n\n Expecting a reroll.\n cf. <xmqqsg0ri5mq.fsf@gitster.g>\n\n\n* pw/diff-color-moved-fix (2021-08-05) 13 commits\n - diff: drop unused options parameter from cmp_in_block_with_wsd()\n - diff --color-moved: intern strings\n - diff: use designated initializers for emitted_diff_symbol\n - diff --color-moved-ws=allow-indentation-change: improve hash lookups\n - diff --color-moved: stop clearing potential moved blocks\n - diff --color-moved: shrink potential moved blocks as we go\n - diff --color-moved: unify moved block growth functions\n - diff --color-moved: call comparison function directly\n - diff --color-moved-ws=allow-indentation-change: simplify and optimize\n - diff: simplify allow-indentation-change delta calculation\n - diff --color-moved: avoid false short line matches and bad zerba coloring\n - diff --color-moved=zebra: fix alternate coloring\n - diff --color-moved: add perf tests\n\n Originally merged to 'next' on 2021-08-05\n\n Long-overdue correctness and performance update to \"diff\n --color-moved\" feature.\n\n Expecting a reroll.\n cf. <8bec1a6d-5052-50c3-4100-e6348289d581@gmail.com>\n\n\n* hn/reftable (2021-09-28) 19 commits\n - Add \"test-tool dump-reftable\" command.\n - reftable: add dump utility\n - reftable: implement stack, a mutable database of reftable files.\n - reftable: implement refname validation\n - reftable: add merged table view\n - reftable: add a heap-based priority queue for reftable records\n - reftable: reftable file level tests\n - reftable: read reftable files\n - reftable: generic interface to tables\n - reftable: write reftable files\n - reftable: a generic binary tree implementation\n - reftable: reading/writing blocks\n - Provide zlib's uncompress2 from compat/zlib-compat.c\n - reftable: (de)serialization for the polymorphic record type.\n - reftable: add blocksource, an abstraction for random access reads\n - reftable: utility functions\n - reftable: add error related functionality\n - reftable: RFC: add LICENSE\n - hash.h: provide constants for the hash IDs\n\n The \"reftable\" backend for the refs API, without integrating into\n the refs subsystem.\n\n Will merge to 'next'.\n\n\n* ab/refs-files-cleanup (2021-08-25) 13 commits\n  (merged to 'next' on 2021-09-23 at eb5668523f)\n + refs/files: remove unused \"errno != ENOTDIR\" condition\n + refs/files: remove unused \"errno == EISDIR\" code\n + refs/files: remove unused \"oid\" in lock_ref_oid_basic()\n + refs API: remove OID argument to reflog_expire()\n + reflog expire: don't lock reflogs using previously seen OID\n + refs/files: add a comment about refs_reflog_exists() call\n + refs: make repo_dwim_log() accept a NULL oid\n + refs/debug: re-indent argument list for \"prepare\"\n + refs/files: remove unused \"skip\" in lock_raw_ref() too\n + refs/files: remove unused \"extras/skip\" in lock_ref_oid_basic()\n + refs: drop unused \"flags\" parameter to lock_ref_oid_basic()\n + refs/files: remove unused REF_DELETING in lock_ref_oid_basic()\n + refs/packet: add missing BUG() invocations to reflog callbacks\n (this branch is used by ab/refs-errno-cleanup and hn/refs-errno-cleanup.)\n\n Continued work on top of the hn/refs-errno-cleanup topic.\n\n Will merge to 'master'.\n\n\n* hn/refs-errno-cleanup (2021-08-25) 4 commits\n  (merged to 'next' on 2021-09-23 at 502e6b6b08)\n + refs: make errno output explicit for read_raw_ref_fn\n + refs/files-backend: stop setting errno from lock_ref_oid_basic\n + refs: remove EINVAL errno output from specification of read_raw_ref_fn\n + refs file backend: move raceproof_create_file() here\n (this branch is used by ab/refs-errno-cleanup; uses ab/refs-files-cleanup.)\n\n Futz with the way 'errno' is relied on in the refs API to carry the\n failure modes up the call chain.\n\n Will merge to 'master'.\n\n--------------------------------------------------\n[Discarded]\n\n* ao/p4-avoid-decoding (2021-04-12) 2 commits\n . git-p4: do not decode data from perforce by default\n . git-p4: avoid decoding more data from perforce\n\n \"git p4\" in Python-2 days used to accept a lot more kinds of data\n from Perforce server as uninterrupted byte sequence, but after\n switching to Python-3, too many things are expected to be in UTF-8,\n which broke traditional use cases.\n\n Have been stalled for too long.\n cf. <20210504220153.1d9f0cb2@ado-tr>\n\n\n* tv/p4-fallback-encoding (2021-04-30) 1 commit\n . git-p4: git-p4.fallbackEncoding to specify non UTF-8 charset\n\n \"git p4\" learns the fallbackEncoding configuration variable to\n safely accept changeset descriptions that aren't written in UTF-8.\n\n Have been stalled for too long.\n cf. <CAKu1iLUaLuAZWqjNK4tfhhR=YaSt4MdQ+90ZY-JcEh_SeHyYCw@mail.gmail.com>\n\n\n* jh/builtin-fsmonitor (2021-09-03) 37 commits\n . fixup! fsmonitor--daemon: implement handle_client callback\n . SQUASH??? https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136\n . BANDAID: sparse fixes\n . t7527: test FS event reporing on MacOS WRT case and Unicode\n . fsmonitor: handle shortname for .git\n . t7527: test status with untracked-cache and fsmonitor--daemon\n . fsmonitor: force update index after large responses\n . fsmonitor: enhance existing comments\n . fsmonitor--daemon: use a cookie file to sync with file system\n . fsmonitor--daemon: periodically truncate list of modified files\n . t7527: create test for fsmonitor--daemon\n . t/perf/p7519: add fsmonitor--daemon test cases\n . t/perf: avoid copying builtin fsmonitor files into test repo\n . t/perf/p7519: speed up test using \"test-tool touch\"\n . t/helper/test-touch: add helper to touch a series of files\n . fsmonitor--daemon: implement handle_client callback\n . fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS\n . fsmonitor-fs-listen-macos: add macos header files for FSEvent\n . fsmonitor-fs-listen-win32: implement FSMonitor backend on Windows\n . fsmonitor--daemon: create token-based changed path cache\n . fsmonitor--daemon: define token-ids\n . fsmonitor--daemon: add pathname classification\n . fsmonitor: do not try to operate on bare repos\n . fsmonitor--daemon: implement 'start' command\n . fsmonitor--daemon: implement 'run' command\n . fsmonitor-fs-listen-macos: stub in backend for MacOS\n . fsmonitor-fs-listen-win32: stub in backend for Windows\n . t/helper/fsmonitor-client: create IPC client to talk to FSMonitor Daemon\n . fsmonitor--daemon: implement 'stop' and 'status' commands\n . fsmonitor--daemon: add a built-in fsmonitor daemon\n . fsmonitor: use IPC to query the builtin FSMonitor daemon\n . fsmonitor: config settings are repository-specific\n . help: include fsmonitor--daemon feature flag in version info\n . fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n . fsmonitor--daemon: update fsmonitor documentation\n . fsmonitor--daemon: man page\n . simple-ipc: preparations for supporting binary messages.\n\n An attempt to write and ship with a watchman equivalent tailored\n for our use.\n\n Will be rerolled in pieces.\n\n\n* ab/config-based-hooks-base (2021-09-09) 36 commits\n . hooks: fix a TOCTOU in \"did we run a hook?\" heuristic\n . receive-pack: convert receive hooks to hook.h\n . post-update: use hook.h library\n . receive-pack: convert 'update' hook to hook.h\n . hooks: allow callers to capture output\n . run-command: allow capturing of collated output\n . reference-transaction: use hook.h to run hooks\n . hook tests: use a modern style for \"pre-push\" tests\n . hook tests: test for exact \"pre-push\" hook input\n . transport: convert pre-push hook to hook.h\n . hook: convert 'post-rewrite' hook in sequencer.c to hook.h\n . hook: provide stdin by string_list or callback\n . run-command: add stdin callback for parallelization\n . am: convert 'post-rewrite' hook to hook.h\n . hook: support passing stdin to hooks\n . run-command: allow stdin for run_processes_parallel\n . run-command: remove old run_hook_{le,ve}() hook API\n . receive-pack: convert push-to-checkout hook to hook.h\n . read-cache: convert post-index-change to use hook.h\n . commit: convert {pre-commit,prepare-commit-msg} hook to hook.h\n . git-p4: use 'git hook' to run hooks\n . send-email: use 'git hook run' for 'sendemail-validate'\n . git hook run: add an --ignore-missing flag\n . merge: convert post-merge to use hook.h\n . hooks: convert 'post-checkout' hook to hook library\n . am: convert applypatch to use hook.h\n . rebase: convert pre-rebase to use hook.h\n . gc: use hook library for pre-auto-gc hook\n . hook: add 'run' subcommand\n . hook-list.h: add a generated list of hooks, like config-list.h\n . hook.c users: use \"hook_exists()\" instead of \"find_hook()\"\n . hook.c: add a hook_exists() wrapper and use it in bugreport.c\n . hook.[ch]: move find_hook() from run-command.c to hook.c\n . Makefile: remove an out-of-date comment\n . Makefile: stop hardcoding {command,config}-list.h\n . Makefile: mark \"check\" target as .PHONY\n (this branch is used by es/config-based-hooks.)\n\n Restructuring of (a subset of) Emily's config-based-hooks series,\n to demonstrate that a series can be presented as a more logical and\n focused progression.\n\n Will be rerolled in pieces.\n\n\n* es/config-based-hooks (2021-09-09) 6 commits\n . hook: allow out-of-repo 'git hook' invocations\n . hook: include hooks from the config\n . hook: introduce \"git hook list\"\n . hook: allow parallel hook execution\n . fixup! hook: run a list of hooks instead\n . hook: run a list of hooks instead\n (this branch uses ab/config-based-hooks-base.)\n\n Revamp the hooks subsystem to allow multiple of them to trigger\n upon the same event and control via the configuration variables.\n\n\n* cb/make-compdb-fix (2021-09-22) 1 commit\n . Makefile: avoid breaking compilation database generation with DEVELOPER\n\n Adjust to recent change to use -pedantic for developer builds.\n\n Replaced by the ab/make-compdb-fix topic that uses the same\n approach as the ab/auto-depend-with-pedantic topic.\n\n\n* ab/pack-objects-stdin (2021-07-09) 5 commits\n . pack-objects.c: make use of REV_INFO_STDIN_LINE_PROCESS\n . pack-objects.c: do stdin parsing via revision.c's API\n . revision.[ch]: add a \"handle_stdin_line\" API\n . revision.h: refactor \"disable_stdin\" and \"read_from_stdin\"\n . upload-pack: run is_repository_shallow() before setup_revisions()\n\n Introduce handle_stdin_line callback to revision API and uses it.\n\n Retracted for now.\n\n\n* ah/unleak-revisions (2021-09-20) 2 commits\n . log: UNLEAK original pending objects\n . log: UNLEAK rev to silence a large number of leaks\n\n Mark a few structures with UNLEAK() to help leak detection CI jobs.\n\n Retracted.\n cf. <05754f9c-cd58-30f5-e2d3-58b9221d2770@ahunt.org>\n"},{"id":"437612","messageId":"CABPp-BHKOt+x+B3DGh3BJV_voP64pvTrL5B-w4hWqHNKfr2K3w@mail.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"en/removing-untracked-fixes [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)]","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2021-10-01T06:20:02Z","receivedAt":"2021-10-01T06:20:18Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, Sep 30, 2021 at 6:09 PM Junio C Hamano <gitster@pobox.com> wrote:\n\n> * en/removing-untracked-fixes (2021-09-27) 12 commits\n>  - Documentation: call out commands that nuke untracked files/directories\n>  - Comment important codepaths regarding nuking untracked files/dirs\n>  - unpack-trees: avoid nuking untracked dir in way of locally deleted file\n>  - unpack-trees: avoid nuking untracked dir in way of unmerged file\n>  - Change unpack_trees' 'reset' flag into an enum\n>  - Remove ignored files by default when they are in the way\n>  - unpack-trees: make dir an internal-only struct\n>  - unpack-trees: introduce preserve_ignored to unpack_trees_options\n>  - read-tree, merge-recursive: overwrite ignored files by default\n>  - checkout, read-tree: fix leak of unpack_trees_options.dir\n>  - t2500: add various tests for nuking untracked files\n>  - Merge branch 'en/am-abort-fix' into en/removing-untracked-fixes\n>\n>  Various fixes in code paths that move untracked files away to make room.\n>\n>  Will merge to 'next'?\n\nPhillip (Wood) just recently acked the series[1].\n\nÆvar made multiple good suggestions on an earlier round that I\nincorporated.  A few others commented as well and I incorporated each\nor responded why it didn't make sense, I believe to the individuals'\nsatisfaction.\n\nHowever, on the latest series, Ævar has tried to suggest some changes\naround the 'dir' member that he seems to want to see squashed in.\nThere's multiple reasons I don't like those changes, and even if we\nended up adopting them, I think they'd need a separate commit with a\ngood explanation of the assumptions being added by those changes[2].\nI think such a change, if others want it, could and likely should be\nsubmitted separately from this series.  And I suspect he's struggling\njust as hard to see my point of view as I am to see his.\n\nSo...maybe I reroll the series with Phillip's Acked-by, and give it a\nfew days to see if either Ævar or I can convince the other?\n\n[1] https://lore.kernel.org/git/b23bb983-39e6-75ad-0cb5-d9a5ba2cd4d8@gmail.com/\n[2] https://lore.kernel.org/git/CABPp-BGi03JunRaMF_8SJKC00byOnq1kL3JyYhKWatz8-B4RsA@mail.gmail.com/\n"},{"id":"437614","messageId":"CABPp-BH2C5HFw_=NtK71oNGXkntzcJd2un0TgMb=UnJ5yJxAAA@mail.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"en/remerge-diff [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)]","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2021-10-01T06:31:32Z","receivedAt":"2021-10-01T06:31:53Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Thu, Sep 30, 2021 at 6:09 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n> * en/remerge-diff (2021-08-31) 7 commits\n>  - doc/diff-options: explain the new --remerge-diff option\n>  - show, log: provide a --remerge-diff capability\n>  - tmp-objdir: new API for creating and removing primary object dirs\n>  - merge-ort: capture and print ll-merge warnings in our preferred fashion\n>  - ll-merge: add API for capturing warnings in a strbuf instead of stderr\n>  - merge-ort: add ability to record conflict messages in a file\n>  - merge-ort: mark a few more conflict messages as omittable\n>\n>  A new presentation for two-parent merge \"--remerge-diff\" can be\n>  used to show the difference between mechanical (and possibly\n>  conflicted) merge results and the recorded resolution.\n>\n>  Will merge to 'next'?\n\nNo, please mark it as expecting an update.  Peff made multiple good\nsuggestions in his recent review:\n\n  * Modify the ll-merge API to return an enum status instead of\nprinting warning messages about binary files, and let callers handle\nit\n  * Replace the new auxiliary files containing conflict messages, with\nauxiliary diff headers containing conflict messages\n  * Do something different with the tmp-objdir usage or use\npretend_object_file().  I'm slightly worried the latter was only\ndesigned for a few files that all fit into memory, which may not be\nvalid for this usecase.\n\nAnd ns/batched-fsync now semantically conflicts slightly in that we\nboth extended the tmp-objdir API in similar but slightly different\nways.  So that needs to be worked out...\n"},{"id":"437616","messageId":"YVayMiOJPLFcTlY9@coredump.intra.peff.net","threadId":"56617","inReplyTo":"CABPp-BH2C5HFw_=NtK71oNGXkntzcJd2un0TgMb=UnJ5yJxAAA@mail.gmail.com","subject":"Re: en/remerge-diff [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)]","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-10-01T07:01:06Z","receivedAt":"2021-10-01T07:01:53Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Sep 30, 2021 at 11:31:32PM -0700, Elijah Newren wrote:\n\n>   * Do something different with the tmp-objdir usage or use\n> pretend_object_file().  I'm slightly worried the latter was only\n> designed for a few files that all fit into memory, which may not be\n> valid for this usecase.\n\nJust to make sure I was being clear on this final point: the\npretend_object_file() interface _now_ is definitely not suitable for the\nsizes you'd want. I think you'd need to:\n\n  - have it handle pointers to non-duplicated storage, instead of owning\n    all buffers (and then the remerge-diff code would do something\n    clever with mmaps and tempfiles).\n\n  - use something better than the linear cached_objects array for\n    storing the entries, so lookup doesn't suffer with many objects.\n    Perhaps an oidmap.\n\n  - teach it to remove objects. For your purposes, a complete clear\n    function would be sufficient.\n\n-Peff\n"},{"id":"437624","messageId":"87fstlrumj.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"CABPp-BHKOt+x+B3DGh3BJV_voP64pvTrL5B-w4hWqHNKfr2K3w@mail.gmail.com","subject":"Re: en/removing-untracked-fixes [Was: Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)]","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T08:51:33Z","receivedAt":"2021-10-01T08:56:27Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Elijah Newren wrote:\n\n> On Thu, Sep 30, 2021 at 6:09 PM Junio C Hamano <gitster@pobox.com> wrote:\n>\n>> * en/removing-untracked-fixes (2021-09-27) 12 commits\n>>  - Documentation: call out commands that nuke untracked files/directories\n>>  - Comment important codepaths regarding nuking untracked files/dirs\n>>  - unpack-trees: avoid nuking untracked dir in way of locally deleted file\n>>  - unpack-trees: avoid nuking untracked dir in way of unmerged file\n>>  - Change unpack_trees' 'reset' flag into an enum\n>>  - Remove ignored files by default when they are in the way\n>>  - unpack-trees: make dir an internal-only struct\n>>  - unpack-trees: introduce preserve_ignored to unpack_trees_options\n>>  - read-tree, merge-recursive: overwrite ignored files by default\n>>  - checkout, read-tree: fix leak of unpack_trees_options.dir\n>>  - t2500: add various tests for nuking untracked files\n>>  - Merge branch 'en/am-abort-fix' into en/removing-untracked-fixes\n>>\n>>  Various fixes in code paths that move untracked files away to make room.\n>>\n>>  Will merge to 'next'?\n>\n> Phillip (Wood) just recently acked the series[1].\n>\n> Ævar made multiple good suggestions on an earlier round that I\n> incorporated.  A few others commented as well and I incorporated each\n> or responded why it didn't make sense, I believe to the individuals'\n> satisfaction.\n>\n> However, on the latest series, Ævar has tried to suggest some changes\n> around the 'dir' member that he seems to want to see squashed in.\n> There's multiple reasons I don't like those changes, and even if we\n> ended up adopting them, I think they'd need a separate commit with a\n> good explanation of the assumptions being added by those changes[2].\n> I think such a change, if others want it, could and likely should be\n> submitted separately from this series.  And I suspect he's struggling\n> just as hard to see my point of view as I am to see his.\n>\n> So...maybe I reroll the series with Phillip's Acked-by, and give it a\n> few days to see if either Ævar or I can convince the other?\n>\n> [1] https://lore.kernel.org/git/b23bb983-39e6-75ad-0cb5-d9a5ba2cd4d8@gmail.com/\n> [2] https://lore.kernel.org/git/CABPp-BGi03JunRaMF_8SJKC00byOnq1kL3JyYhKWatz8-B4RsA@mail.gmail.com/\n\nA tl;dr of the relevant reply from me[1] is that I'm fine with this\nbeing merged down as-is.\n\nAs noted I should have been clearer from the beginning, it was really a\n\"oh interesting, on my larger topic of memory leaks I did XYZ\ndifferently\" than \"your XYZ here needs to be an ABC\". Should the \"ABC\"\nbe worthwhile I can submit that on top.\n\nI did suggest in [1] that maybe the question of \"ABC\" v.s. \"XYZ\" would\nbe better dealt with in some other series, i.e. just ejecting (if\npossible) the memory leak fixes while at it from this larger\nmostly-unrelated topic. But again, I'll leave whether you'd like to do\nthat to your judgement after you've caught up on mail.\n\n1. https://lore.kernel.org/git/87k0ixrv23.fsf@evledraar.gmail.com/\n"},{"id":"437684","messageId":"8735plrlql.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T12:05:20Z","receivedAt":"2021-10-01T12:08:27Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n[I figure for this topic update of mine I'll do the split E-Mails as\ndicussed in last What's Cooking, also maybe my relatively long updates\nto past ones have discouraged reading...]\n\n> * ab/designated-initializers-more (2021-09-27) 6 commits\n>  - builtin/remote.c: add and use SHOW_INFO_INIT\n>  - builtin/remote.c: add and use a REF_STATES_INIT\n>  - urlmatch.[ch]: add and use URLMATCH_CONFIG_INIT\n>  - builtin/blame.c: refactor commit_info_init() to COMMIT_INFO_INIT macro\n>  - daemon.c: refactor hostinfo_init() to HOSTINFO_INIT macro\n>  - Merge branch 'ab/designated-initializers' into ab/designated-initializers-more\n>  (this branch uses ab/designated-initializers.)\n>\n>  Code clean-up.\n>\n>  What's the status of this one?  Meh?\n\nI just re-rolled this as\nhttps://lore.kernel.org/git/cover-v3-0.6-00000000000-20211001T102056Z-avarab@gmail.com/\n\nAs noted there I've got meaningful leak fixes that in some cases\nsemi-depend on this, but I did more conversions than strictly needed for\nimmediate follow-up I have. I'd prefer to just got this particular churn\nover with if there's more memset()->*_INIT migrations needed.\n\nSo it would be great if that would be a s/Meh/grudging acceptance for\n'next'/. I promise I'm taking it somewhere worthwhile :)\n"},{"id":"437685","messageId":"87y27dq70e.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/fsck-unexpected-type","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T12:08:31Z","receivedAt":"2021-10-01T12:11:51Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n[Forgot to adjust the subject for\nhttps://lore.kernel.org/git/8735plrlql.fsf@evledraar.gmail.com/]\n\n> * ab/fsck-unexpected-type (2021-09-30) 17 commits\n>  - fsck: report invalid object type-path combinations\n>  - fsck: don't hard die on invalid object types\n>  - object-file.c: stop dying in parse_loose_header()\n>  - object-file.c: return ULHR_TOO_LONG on \"header too long\"\n>  - object-file.c: use \"enum\" return type for unpack_loose_header()\n>  - object-file.c: simplify unpack_loose_short_header()\n>  - object-file.c: make parse_loose_header_extended() public\n>  - object-file.c: return -1, not \"status\" from unpack_loose_header()\n>  - object-file.c: don't set \"typep\" when returning non-zero\n>  - cat-file tests: test for current --allow-unknown-type behavior\n>  - cat-file tests: add corrupt loose object test\n>  - cat-file tests: test for missing/bogus object with -t, -s and -p\n>  - cat-file tests: move bogus_* variable declarations earlier\n>  - fsck tests: test for garbage appended to a loose object\n>  - fsck tests: test current hash/type mismatch behavior\n>  - fsck tests: refactor one test to use a sub-repo\n>  - fsck tests: add test for fsck-ing an unknown type\n>\n>  \"git fsck\" has been taught to report mismatch between expected and\n>  actual types of an object better.\n>\n>  Will merge to 'next'?\n\nI re-rolled a v10 that hopefully gets rid of the last bugs in the recent\nupdates:\nhttps://lore.kernel.org/git/cover-v10-00.17-00000000000-20211001T091051Z-avarab@gmail.com/;\nI think it should be ready.\n"},{"id":"437700","messageId":"87mtnsrf06.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/parse-options-cleanup","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T14:32:26Z","receivedAt":"2021-10-01T14:33:51Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/parse-options-cleanup (2021-09-28) 10 commits\n>  - parse-options: change OPT_{SHORT,UNSET} to an enum\n>  - parse-options tests: test optname() output\n>  - parse-options.[ch]: make opt{bug,name}() \"static\"\n>  - commit-graph: stop using optname()\n>  - parse-options.c: move optname() earlier in the file\n>  - parse-options.h: make the \"flags\" in \"struct option\" an enum\n>  - parse-options.c: use exhaustive \"case\" arms for \"enum parse_opt_type\"\n>  - parse-options.[ch]: consistently use \"enum parse_opt_result\"\n>  - parse-options.[ch]: consistently use \"enum parse_opt_flags\"\n>  - parse-options.h: move PARSE_OPT_SHELL_EVAL between enums\n>\n>  Random changes to parse-options implementation.\n>\n>  What's the status of this one?  Meh?\n\nRe-rolled just now at\nhttps://lore.kernel.org/git/cover-v2-00.11-00000000000-20211001T142631Z-avarab@gmail.com/\n\nI could rebase on it being ejected, but I've got some niceties in\nparse_options() currently depending on it, and as notedi in the updated\n02/11 I think that \"enum bitfield\" pattern is worth it under\ndebuggers. So it would be great if it could advance. Thanks!\n"},{"id":"437701","messageId":"87ilygrep8.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/sanitize-leak-ci & more leak fixes soon-or-not","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T14:35:17Z","receivedAt":"2021-10-01T14:40:25Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/sanitize-leak-ci (2021-09-23) 2 commits\n>  - tests: add a test mode for SANITIZE=leak, run it in CI\n>  - Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONS\n>\n>  CI learns to run the leak sanitizer builds.\n>\n>  Will merge to 'next'.\n\nYay! I've got some post-cleanup work, leak fixes etc. that were waiting\non this.\n\nI've been careful to only change things that don't textually or\nsemantically conflict with \"seen\" (and don't cause any CI smoke there),\nso e.g. marking up tests as passing, fixing leaks etc. should go pretty\nsmoothly as far as those topics graduating.\n\nBut it's not in any way urgent, we've had most of those leaks for ages,\nbut I figured since we're in week 6/12 of 2.34 it might be a good time\nto get them in sooner than later.\n\nBut you've been frustrated by some past cleanup topics of mine, so I\nwanted to ask. Would you prefer to wait until it's in \"master\" until\nthose trickle in, or hold them off entirely for a while etc?\n"},{"id":"437703","messageId":"31c4b5fe-a233-2453-f7aa-12a7b670c204@jeffhostetler.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"Re: What's cooking in git.git (Sep 2021, #09; Thu, 30)","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2021-10-01T14:56:34Z","receivedAt":"2021-10-01T14:56:40Z","isPatch":false,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 9/30/21 9:01 PM, Junio C Hamano wrote:\n> \n> * jh/builtin-fsmonitor-part1 (2021-09-20) 7 commits\n>   - t/helper/simple-ipc: convert test-simple-ipc to use start_bg_command\n>   - run-command: create start_bg_command\n>   - simple-ipc/ipc-win32: add Windows ACL to named pipe\n>   - simple-ipc/ipc-win32: add trace2 debugging\n>   - simple-ipc: move definition of ipc_active_state outside of ifdef\n>   - simple-ipc: preparations for supporting binary messages.\n>   - trace2: add trace2_child_ready() to report on background children\n> \n>   Built-in fsmonitor (part 1).\n> \n\nI think part 1 has settled down if there are no further comments.\n\nI'm going to need to re-roll my part 2 [1] because of conflicts with\n\"ab/repo-settings-cleanup (2021-09-22) 5 commits\" in repo-settings.c\n\nJeff\n\n[1] \nhttps://lore.kernel.org/all/pull.1041.git.1631822063.gitgitgadget@gmail.com/\n\n"},{"id":"437704","messageId":"87ee94rdq7.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/refs-errno-cleanup","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T14:48:56Z","receivedAt":"2021-10-01T15:01:38Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/refs-errno-cleanup (2021-08-25) 4 commits\n>  - refs: make errno output explicit for refs_resolve_ref_unsafe\n>  - refs: explicitly return failure_errno from parse_loose_ref_contents\n>  - branch tests: test for errno propagating on failing read\n>  - refs: add failure_errno to refs_read_raw_ref() signature\n>  (this branch uses ab/refs-files-cleanup and hn/refs-errno-cleanup.)\n>\n>  The \"remainder\" of hn/refs-errno-cleanup topic.\n>\n>  What's the status of this one?  Meh?\n\nI'v got two topics that have been waiting on ab/refs-files-cleanup &\nhn/refs-errno-cleanup graduating:\n\nA. Post-ab/refs-files-cleanup: cleanup builtin/reflog.c for the state of\n   the new API, I did a bare minimum of fixes there in\n   ab/refs-files-cleanup, but the end-state doesn't make much sense if\n   you aren't considering the history of now-gone OID locking \"features\".\n\nB. Post-ab/refs-errno-cleanup: Reach the end-state of no refs.c APIs\n   relying on, or pretending to rely on \"errno\" being returned\n   upwards. This was previously submitted as[1], but the topic was since\n   slimmed down into the current ab/refs-errno-cleanup.\n\nThe \"B\" needs this ab/refs-errno-cleanup. I think (and I think Han-Wen\nwould agree) that it leaves the refs API in a much better state for\nreftable integration.\n\n1. https://lore.kernel.org/git/cover-00.17-00000000000-20210711T162803Z-avarab@gmail.com/\n"},{"id":"437706","messageId":"87a6jsrdj0.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/align-parse-options-help & ab/help-config-vars","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T15:01:38Z","receivedAt":"2021-10-01T15:06:07Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/align-parse-options-help (2021-09-22) 4 commits\n>  - parse-options: properly align continued usage output\n>  - git rev-parse --parseopt tests: add more usagestr tests\n>  - send-pack: properly use parse_options() API for usage string\n>  - parse-options API users: align usage output in C-strings\n>\n>  When \"git cmd -h\" shows more than one line of usage text (e.g.\n>  the cmd subcommand may take sub-sub-command), parse-options API\n>  learned to align these lines, even across i18n/l10n.\n>\n>  Will merge to 'next'?\n>\n>\n> * ab/help-config-vars (2021-09-23) 9 commits\n>  - help: move column config discovery to help.c library\n>  - help / completion: make \"git help\" do the hard work\n>  - help tests: test --config-for-completion option & output\n>  - help: simplify by moving to OPT_CMDMODE()\n>  - help: correct logic error in combining --all and --guides\n>  - help: correct logic error in combining --all and --config\n>  - help tests: add test for --config output\n>  - help: correct usage & behavior of \"git help --guides\"\n>  - help: correct the usage string in -h and documentation\n>\n>  Teach \"git help -c\" into helping the command line completion of\n>  configuration variables.\n>\n>  Will merge to 'next'?\n\nI think the v5[1] and v3[2] of these have, respectively, reached an\n\"addressed all feedback\" and \"should be good enough\". I.e. had some\nfeedback on [2] that I'm choosing to read as some post-cleanup\nsuggestions :)\n\nThe reason I wanted [2] was for some user-facing documentation query\nimprovements in \"git help\", so having it go forward would be\ngreat. Thanks!\n\n1. https://lore.kernel.org/git/cover-v5-0.4-00000000000-20210921T132350Z-avarab@gmail.com/\n2. https://lore.kernel.org/git/cover-v3-0.9-00000000000-20210921T223223Z-avarab@gmail.com/\n"},{"id":"437707","messageId":"875yugrdfw.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/lib-subtest","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T15:05:55Z","receivedAt":"2021-10-01T15:07:47Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/lib-subtest (2021-09-22) 9 commits\n>  - test-lib tests: get rid of copy/pasted mock test code\n>  - test-lib tests: assert 1 exit code, not non-zero\n>  - test-lib tests: refactor common part of check_sub_test_lib_test*()\n>  - test-lib tests: avoid subshell for \"test_cmp\" for readability\n>  - test-lib tests: don't provide a description for the sub-tests\n>  - test-lib tests: split up \"write and run\" into two functions\n>  - test-lib tests: move \"run_sub_test\" to a new lib-subtest.sh\n>  - Merge branch 'ps/t0000-output-directory-fix' into ab/lib-subtest\n>  - Merge branch 'jk/t0000-subtests-fix' into ab/lib-subtest\n>\n>  Updates to the tests in t0000 to test the test framework.\n>\n>  Will merge to 'next'?\n\nI think it's ready, Carlo (CC'd) gave it a look and I re-rolled\naddressing his feedback:\nhttps://lore.kernel.org/git/cover-v4-0.7-00000000000-20210922T111734Z-avarab@gmail.com/\n\nIt's something I have some test-lib.sh UX improvements/simplification\nwaiting on, so having it go forward would be great :) Thanks!\n"},{"id":"437708","messageId":"871r54rd9c.fsf@evledraar.gmail.com","threadId":"56617","inReplyTo":"xmqqh7e18soj.fsf@gitster.g","subject":"ab/config-based-hooks-1","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-10-01T15:07:34Z","receivedAt":"2021-10-01T15:11:42Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 30 2021, Junio C Hamano wrote:\n\n> * ab/config-based-hooks-1 (2021-09-27) 8 commits\n>  - hook-list.h: add a generated list of hooks, like config-list.h\n>  - hook.c users: use \"hook_exists()\" instead of \"find_hook()\"\n>  - hook.c: add a hook_exists() wrapper and use it in bugreport.c\n>  - hook.[ch]: move find_hook() from run-command.c to hook.c\n>  - Makefile: remove an out-of-date comment\n>  - Makefile: don't perform \"mv $@+ $@\" dance for $(GENERATED_H)\n>  - Makefile: stop hardcoding {command,config}-list.h\n>  - Makefile: mark \"check\" target as .PHONY\n>\n>  Mostly preliminary clean-up in the hook API.\n\nI think this has gotten some thorough review from René & Phillip at this\npoint[1][2]. I think th consensus on the v2 is to just keep the \"sed\"\ninvocation I have as-is.\n\nAs you know the greater configurable hook topic is pending on this\nmoving forward, so starting to get at least some of it merged down\nbefore 2.34 would be great. I was hoping we'd have a release with at\nleast the simpler hooks running via the new hook library (and perhaps\nthe --stdin cases too).\n\n1. https://lore.kernel.org/git/0e07cee4-079a-af12-880f-d4a99300df28@web.de/\n2. https://lore.kernel.org/git/6e7d5945-d64f-9511-9668-b453c20c086c@gmail.com/\n"},{"id":"437712","messageId":"xmqq35pk8ylz.fsf@gitster.g","threadId":"56617","inReplyTo":"CABPp-BHKOt+x+B3DGh3BJV_voP64pvTrL5B-w4hWqHNKfr2K3w@mail.gmail.com","subject":"Re: en/removing-untracked-fixes [","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-10-01T17:05:12Z","receivedAt":"2021-10-01T17:05:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elijah Newren <newren@gmail.com> writes:\n\n> I think such a change, if others want it, could and likely should be\n> submitted separately from this series.\n\nLet's take these as we have them right now.  Any incremental\nimprovements can be done after the dust settled.\n\nThanks.\n"}]}