{"thread":{"id":"56554","subject":"[PATCH v2] ls-files: use imperative mood for -X and -z option description","startedAt":"2021-09-21T11:15:15Z","lastAt":"2021-09-21T14:16:20Z","messageCount":2,"participants":["Bagas Sanjaya","Jeff King"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"436595","messageId":"20210921111304.887605-1-bagasdotme@gmail.com","threadId":"56554","inReplyTo":null,"subject":"[PATCH v2] ls-files: use imperative mood for -X and -z option description","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-21T11:13:05Z","receivedAt":"2021-09-21T11:15:15Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Usage description for -X and -z options use descriptive instead of\nimperative mood. Edit it for consistency with other options.\n\nSigned-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n---\n\nChanges since v1 [1]:\n  - Add missing \"the\" article in -z description (suggested by Taylor\n    Blau)\n\nRange-diff against v1 [1]:\n1:  eee9d91fc1 ! 1:  9f02334bdf ls-files: use imperative mood for -X and -z option description\n    @@ Commit message\n         ls-files: use imperative mood for -X and -z option description\n     \n         Usage description for -X and -z options use descriptive instead of\n    -    imperative mood. Change it for consistency with other options.\n    +    imperative mood. Edit it for consistency with other options.\n     \n         Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n     \n    @@ builtin/ls-files.c: int cmd_ls_files(int argc, const char **argv, const char *cm\n      \t\t/* Think twice before adding \"--nul\" synonym to this */\n      \t\tOPT_SET_INT('z', NULL, &line_terminator,\n     -\t\t\tN_(\"paths are separated with NUL character\"), '\\0'),\n    -+\t\t\tN_(\"separate paths with NUL character\"), '\\0'),\n    ++\t\t\tN_(\"separate paths with the NUL character\"), '\\0'),\n      \t\tOPT_BOOL('t', NULL, &show_tag,\n      \t\t\tN_(\"identify the file status with tags\")),\n      \t\tOPT_BOOL('v', NULL, &show_valid_bit,\n\n[1]: https://lore.kernel.org/git/xmqqee9javtd.fsf@gitster.g/T/#t\n\n builtin/ls-files.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/ls-files.c b/builtin/ls-files.c\nindex 29a26ad8ae..e6d415e077 100644\n--- a/builtin/ls-files.c\n+++ b/builtin/ls-files.c\n@@ -614,7 +614,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)\n \tstruct option builtin_ls_files_options[] = {\n \t\t/* Think twice before adding \"--nul\" synonym to this */\n \t\tOPT_SET_INT('z', NULL, &line_terminator,\n-\t\t\tN_(\"paths are separated with NUL character\"), '\\0'),\n+\t\t\tN_(\"separate paths with the NUL character\"), '\\0'),\n \t\tOPT_BOOL('t', NULL, &show_tag,\n \t\t\tN_(\"identify the file status with tags\")),\n \t\tOPT_BOOL('v', NULL, &show_valid_bit,\n@@ -651,7 +651,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)\n \t\t\tN_(\"skip files matching pattern\"),\n \t\t\tPARSE_OPT_NONEG, option_parse_exclude),\n \t\tOPT_CALLBACK_F('X', \"exclude-from\", &dir, N_(\"file\"),\n-\t\t\tN_(\"exclude patterns are read from <file>\"),\n+\t\t\tN_(\"read exclude patterns from <file>\"),\n \t\t\tPARSE_OPT_NONEG, option_parse_exclude_from),\n \t\tOPT_STRING(0, \"exclude-per-directory\", &dir.exclude_per_dir, N_(\"file\"),\n \t\t\tN_(\"read additional per-directory exclude patterns in <file>\")),\n\nbase-commit: 4c719308ce59dc70e606f910f40801f2c6051b24\n-- \n2.25.1\n\n"},{"id":"436616","messageId":"YUnpMgw+GSM8I4DK@coredump.intra.peff.net","threadId":"56554","inReplyTo":"20210921111304.887605-1-bagasdotme@gmail.com","subject":"Re: [PATCH v2] ls-files: use imperative mood for -X and -z option description","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-09-21T14:16:18Z","receivedAt":"2021-09-21T14:16:20Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Sep 21, 2021 at 06:13:05PM +0700, Bagas Sanjaya wrote:\n\n> Usage description for -X and -z options use descriptive instead of\n> imperative mood. Edit it for consistency with other options.\n\nThanks, this version looks fine to me.\n\n-Peff\n"}]}