{"thread":{"id":"56547","subject":"[PATCH] ls-files: use imperative mood for -X and -z option description","startedAt":"2021-09-20T12:20:19Z","lastAt":"2021-09-20T19:33:01Z","messageCount":3,"participants":["Bagas Sanjaya","Taylor Blau","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"436411","messageId":"20210920121940.905549-1-bagasdotme@gmail.com","threadId":"56547","inReplyTo":null,"subject":"[PATCH] ls-files: use imperative mood for -X and -z option description","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-20T12:19:41Z","receivedAt":"2021-09-20T12:20:19Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Usage description for -X and -z options use descriptive instead of\nimperative mood. Change it for consistency with other options.\n\nCc: Jeff King \nCc: \nSigned-off-by: Bagas Sanjaya \n---\n builtin/ls-files.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/ls-files.c b/builtin/ls-files.c\nindex 29a26ad8ae..1f38cd7b17 100644\n--- a/builtin/ls-files.c\n+++ b/builtin/ls-files.c\n@@ -614,7 +614,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)\n \tstruct option builtin_ls_files_options[] = {\n \t\t/* Think twice before adding \"--nul\" synonym to this */\n \t\tOPT_SET_INT('z', NULL, &line_terminator,\n-\t\t\tN_(\"paths are separated with NUL character\"), '\\0'),\n+\t\t\tN_(\"separate paths with NUL character\"), '\\0'),\n \t\tOPT_BOOL('t', NULL, &show_tag,\n \t\t\tN_(\"identify the file status with tags\")),\n \t\tOPT_BOOL('v', NULL, &show_valid_bit,\n@@ -651,7 +651,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)\n \t\t\tN_(\"skip files matching pattern\"),\n \t\t\tPARSE_OPT_NONEG, option_parse_exclude),\n \t\tOPT_CALLBACK_F('X', \"exclude-from\", &dir, N_(\"file\"),\n-\t\t\tN_(\"exclude patterns are read from \"),\n+\t\t\tN_(\"read exclude patterns from \"),\n \t\t\tPARSE_OPT_NONEG, option_parse_exclude_from),\n \t\tOPT_STRING(0, \"exclude-per-directory\", &dir.exclude_per_dir, N_(\"file\"),\n \t\t\tN_(\"read additional per-directory exclude patterns in \")),\n\nbase-commit: 4c719308ce59dc70e606f910f40801f2c6051b24\n-- \n2.25.1\n\n"},{"id":"436421","messageId":"YUij2Aj04B1Q1tRV@nand.local","threadId":"56547","inReplyTo":"20210920121940.905549-1-bagasdotme@gmail.com","subject":"Re: [PATCH] ls-files: use imperative mood for -X and -z option description","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-09-20T15:08:08Z","receivedAt":"2021-09-20T15:08:11Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Bagas,\n\nOn Mon, Sep 20, 2021 at 07:19:41PM +0700, Bagas Sanjaya wrote:\n> Usage description for -X and -z options use descriptive instead of\n> imperative mood. Change it for consistency with other options.\n\nYour patch looks fine to me. I don't think it's urgent to change, but it\nlooks correct nonetheless.\n\n> Cc: Jeff King \n> Cc: \n\nThese Cc trailers can be removed. (They're not entirely unprecedented,\nbut I can only find ~200 examples in git.git's history).\n\n> Signed-off-by: Bagas Sanjaya \n> ---\n> builtin/ls-files.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/ls-files.c b/builtin/ls-files.c\n> index 29a26ad8ae..1f38cd7b17 100644\n> --- a/builtin/ls-files.c\n> +++ b/builtin/ls-files.c\n> @@ -614,7 +614,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix)\n> \tstruct option builtin_ls_files_options[] = {\n> \t\t/* Think twice before adding \"--nul\" synonym to this */\n> \t\tOPT_SET_INT('z', NULL, &line_terminator,\n> -\t\t\tN_(\"paths are separated with NUL character\"), '\\0'),\n> +\t\t\tN_(\"separate paths with NUL character\"), '\\0'),\n\nThe text before your patch should include an article so it reads \"with\n[the] NUL character\" instead of \"with NUL character\".\n\nSo I think the right post-image would be: \"separate paths with the NUL\ncharacter\".\n\nThanks,\nTaylor\n"},{"id":"436454","messageId":"xmqqee9javtd.fsf@gitster.g","threadId":"56547","inReplyTo":"YUij2Aj04B1Q1tRV@nand.local","subject":"Re: [PATCH] ls-files: use imperative mood for -X and -z option description","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-09-20T19:30:54Z","receivedAt":"2021-09-20T19:33:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Taylor Blau writes:\n\n> Your patch looks fine to me. I don't think it's urgent to change, but it\n> looks correct nonetheless.\n>\n>> Cc: Jeff King \n>> Cc: \n>\n> These Cc trailers can be removed. (They're not entirely unprecedented,\n> but I can only find ~200 examples in git.git's history).\n\nYup, \"can\" and probably \"should\". It is meant for consumption by\nyour e-mail software.\n\n>> \t\tOPT_SET_INT('z', NULL, &line_terminator,\n>> -\t\t\tN_(\"paths are separated with NUL character\"), '\\0'),\n>> +\t\t\tN_(\"separate paths with NUL character\"), '\\0'),\n>\n> The text before your patch should include an article so it reads \"with\n> [the] NUL character\" instead of \"with NUL character\".\n>\n> So I think the right post-image would be: \"separate paths with the NUL\n> character\".\n\nCorrect. Grammar fixes are very much appreciated, especially in an\ninternational project like this one.\n\nThanks.\n"}]}