{"thread":{"id":"56513","subject":"[PATCH 0/2] git-request-pull i18n","startedAt":"2021-09-16T11:36:17Z","lastAt":"2021-09-17T20:50:31Z","messageCount":10,"participants":["Bagas Sanjaya","Ævar Arnfjörð Bjarmason","Paolo Bonzini","Đoàn Trần Công Danh","Junio C Hamano","Miklos Vajna"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"436111","messageId":"20210916113516.76445-1-bagasdotme@gmail.com","threadId":"56513","inReplyTo":null,"subject":"[PATCH 0/2] git-request-pull i18n","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-16T11:35:15Z","receivedAt":"2021-09-16T11:36:17Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Internationalize git-request-pull.\n\nThe use case is when sending pull request message to developer mailing\nlists that accepts contributions in non-English languages (for example\n\"foo-dev-it\" for Foo developer list in Italian).\n\nThe first patch is small preparation to make translatable strings can be\nmarked as such, while the second patch is actual marking.\n\nBagas Sanjaya (2):\n  request-pull: simplify \"remote or HEAD\" variable in warning messages\n  request-pull: mark translatable strings\n\n git-request-pull.sh | 31 ++++++++++++++++++-------------\n 1 file changed, 18 insertions(+), 13 deletions(-)\n\n\nbase-commit: 4c719308ce59dc70e606f910f40801f2c6051b24\n-- \n2.25.1\n\n"},{"id":"436112","messageId":"20210916113516.76445-2-bagasdotme@gmail.com","threadId":"56513","inReplyTo":"20210916113516.76445-1-bagasdotme@gmail.com","subject":"[PATCH 1/2] request-pull: simplify \"remote or HEAD\" variable in warning messages","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-16T11:35:16Z","receivedAt":"2021-09-16T11:36:19Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"In order for waring message \"Are you sure you pushed 'remote or HEAD'\nthere?\" to be translatable, replace ${remote:-HEAD} (variable access\nwith defaults) in the message by referring it as $remote_or_head.\n\nCc: Ryan Anderson <ryan@michonline.com>\nCc: pbonzini@redhat.com\nSigned-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n---\n git-request-pull.sh | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/git-request-pull.sh b/git-request-pull.sh\nindex 2d0e44656c..9e1d2be9eb 100755\n--- a/git-request-pull.sh\n+++ b/git-request-pull.sh\n@@ -116,15 +116,17 @@ set fnord $(git ls-remote \"$url\" | @@PERL@@ -e \"$find_matching_ref\" \"${remote:-H\n remote_sha1=$2\n ref=$3\n \n+remote_or_head=${remote:-HEAD}\n+\n if test -z \"$ref\"\n then\n \techo \"warn: No match for commit $headrev found at $url\" >&2\n-\techo \"warn: Are you sure you pushed '${remote:-HEAD}' there?\" >&2\n+\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n \tstatus=1\n elif test \"$local_sha1\" != \"$remote_sha1\"\n then\n \techo \"warn: $head found at $url but points to a different object\" >&2\n-\techo \"warn: Are you sure you pushed '${remote:-HEAD}' there?\" >&2\n+\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n \tstatus=1\n fi\n \n-- \n2.25.1\n\n"},{"id":"436113","messageId":"20210916113516.76445-3-bagasdotme@gmail.com","threadId":"56513","inReplyTo":"20210916113516.76445-1-bagasdotme@gmail.com","subject":"[PATCH 2/2] request-pull: mark translatable strings","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-16T11:35:17Z","receivedAt":"2021-09-16T11:36:22Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Mark user-faced strings as translatable (including PR message output).\n\nCc: Ryan Anderson <ryan@michonline.com>\nCc: vmiklos@frugalware.org \nCc: bedhanger@gmx.de\nSigned-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n---\n git-request-pull.sh | 29 ++++++++++++++++-------------\n 1 file changed, 16 insertions(+), 13 deletions(-)\n\ndiff --git a/git-request-pull.sh b/git-request-pull.sh\nindex 9e1d2be9eb..8aa3a3f342 100755\n--- a/git-request-pull.sh\n+++ b/git-request-pull.sh\n@@ -40,7 +40,7 @@ test -n \"$base\" && test -n \"$url\" || usage\n baserev=$(git rev-parse --verify --quiet \"$base\"^0)\n if test -z \"$baserev\"\n then\n-    die \"fatal: Not a valid revision: $base\"\n+    die \"$(eval_gettext \"fatal: Not a valid revision: \\$base\")\"\n fi\n \n #\n@@ -58,12 +58,12 @@ head=${head:-$(git show-ref --heads --tags \"$local\" | cut -d' ' -f2)}\n head=${head:-$(git rev-parse --quiet --verify \"$local\")}\n \n # None of the above? Bad.\n-test -z \"$head\" && die \"fatal: Not a valid revision: $local\"\n+test -z \"$head\" && die \"$(eval_gettext \"fatal: Not a valid revision: \\$local\")\"\n \n # This also verifies that the resulting head is unique:\n # \"git show-ref\" could have shown multiple matching refs..\n headrev=$(git rev-parse --verify --quiet \"$head\"^0)\n-test -z \"$headrev\" && die \"fatal: Ambiguous revision: $local\"\n+test -z \"$headrev\" && die \"$(eval_gettext \"fatal: Ambiguous revision: \\$local\")\"\n \n local_sha1=$(git rev-parse --verify --quiet \"$head\")\n \n@@ -76,7 +76,7 @@ then\n fi\n \n merge_base=$(git merge-base $baserev $headrev) ||\n-die \"fatal: No commits in common between $base and $head\"\n+die \"$(eval_gettext \"fatal: No commits in common between \\$base and \\$head\")\"\n \n # $head is the refname from the command line.\n # Find a ref with the same name as $head that exists at the remote\n@@ -120,13 +120,13 @@ remote_or_head=${remote:-HEAD}\n \n if test -z \"$ref\"\n then\n-\techo \"warn: No match for commit $headrev found at $url\" >&2\n-\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n+\techo \"$(eval_gettext \"warn: No match for commit \\$headrev found at \\$url\")\" >&2\n+\techo \"$(eval_gettext \"warn: Are you sure you pushed '\\$remote_or_head' there?\")\" >&2\n \tstatus=1\n elif test \"$local_sha1\" != \"$remote_sha1\"\n then\n-\techo \"warn: $head found at $url but points to a different object\" >&2\n-\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n+\techo \"$(eval_gettext \"warn: \\$head found at \\$url but points to a different object\")\" >&2\n+\techo \"$(eval_gettext \"warn: Are you sure you pushed '\\$remote_or_head' there?\")\" >&2\n \tstatus=1\n fi\n \n@@ -138,19 +138,22 @@ fi\n \n url=$(git ls-remote --get-url \"$url\")\n \n-git show -s --format='The following changes since commit %H:\n+git show -s --format=\"\n+$(gettext 'The following changes since commit %H:\n \n   %s (%ci)\n \n are available in the Git repository at:\n-' $merge_base &&\n+')\n+\" $merge_base &&\n echo \"  $url $pretty_remote\" &&\n-git show -s --format='\n+git show -s --format=\"\n+$(gettext '\n for you to fetch changes up to %H:\n \n   %s (%ci)\n \n-----------------------------------------------------------------' $headrev &&\n+----------------------------------------------------------------')\" $headrev &&\n \n if test $(git cat-file -t \"$head\") = tag\n then\n@@ -162,7 +165,7 @@ fi &&\n \n if test -n \"$branch_name\"\n then\n-\techo \"(from the branch description for $branch_name local branch)\"\n+\techo \"$(eval_gettext \"(from the branch description for \\$branch_name local branch)\")\"\n \techo\n \tgit config \"branch.$branch_name.description\"\n \techo \"----------------------------------------------------------------\"\n-- \n2.25.1\n\n"},{"id":"436117","messageId":"87sfy4g1cm.fsf@evledraar.gmail.com","threadId":"56513","inReplyTo":"20210916113516.76445-3-bagasdotme@gmail.com","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-09-16T12:15:15Z","receivedAt":"2021-09-16T12:18:54Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Sep 16 2021, Bagas Sanjaya wrote:\n\n> Mark user-faced strings as translatable (including PR message output).\n>\n> Cc: Ryan Anderson <ryan@michonline.com>\n> Cc: vmiklos@frugalware.org \n> Cc: bedhanger@gmx.de\n> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n> ---\n>  git-request-pull.sh | 29 ++++++++++++++++-------------\n>  1 file changed, 16 insertions(+), 13 deletions(-)\n>\n> diff --git a/git-request-pull.sh b/git-request-pull.sh\n> index 9e1d2be9eb..8aa3a3f342 100755\n> --- a/git-request-pull.sh\n> +++ b/git-request-pull.sh\n> @@ -40,7 +40,7 @@ test -n \"$base\" && test -n \"$url\" || usage\n>  baserev=$(git rev-parse --verify --quiet \"$base\"^0)\n>  if test -z \"$baserev\"\n>  then\n> -    die \"fatal: Not a valid revision: $base\"\n> +    die \"$(eval_gettext \"fatal: Not a valid revision: \\$base\")\"\n>  fi\n>  \n>  #\n> @@ -58,12 +58,12 @@ head=${head:-$(git show-ref --heads --tags \"$local\" | cut -d' ' -f2)}\n>  head=${head:-$(git rev-parse --quiet --verify \"$local\")}\n>  \n>  # None of the above? Bad.\n> -test -z \"$head\" && die \"fatal: Not a valid revision: $local\"\n> +test -z \"$head\" && die \"$(eval_gettext \"fatal: Not a valid revision: \\$local\")\"\n>  \n>  # This also verifies that the resulting head is unique:\n>  # \"git show-ref\" could have shown multiple matching refs..\n>  headrev=$(git rev-parse --verify --quiet \"$head\"^0)\n> -test -z \"$headrev\" && die \"fatal: Ambiguous revision: $local\"\n> +test -z \"$headrev\" && die \"$(eval_gettext \"fatal: Ambiguous revision: \\$local\")\"\n>  \n>  local_sha1=$(git rev-parse --verify --quiet \"$head\")\n>  \n> @@ -76,7 +76,7 @@ then\n>  fi\n>  \n>  merge_base=$(git merge-base $baserev $headrev) ||\n> -die \"fatal: No commits in common between $base and $head\"\n> +die \"$(eval_gettext \"fatal: No commits in common between \\$base and \\$head\")\"\n\nLooks good.\n\n>  # $head is the refname from the command line.\n>  # Find a ref with the same name as $head that exists at the remote\n> @@ -120,13 +120,13 @@ remote_or_head=${remote:-HEAD}\n>  \n>  if test -z \"$ref\"\n>  then\n> -\techo \"warn: No match for commit $headrev found at $url\" >&2\n> -\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n> +\techo \"$(eval_gettext \"warn: No match for commit \\$headrev found at \\$url\")\" >&2\n> +\techo \"$(eval_gettext \"warn: Are you sure you pushed '\\$remote_or_head' there?\")\" >&2\n>  \tstatus=1\n>  elif test \"$local_sha1\" != \"$remote_sha1\"\n>  then\n> -\techo \"warn: $head found at $url but points to a different object\" >&2\n> -\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n> +\techo \"$(eval_gettext \"warn: \\$head found at \\$url but points to a different object\")\" >&2\n> +\techo \"$(eval_gettext \"warn: Are you sure you pushed '\\$remote_or_head' there?\")\" >&2\n>  \tstatus=1\n>  fi\n\nMessages like these should probably be combined into one this one's\nmostly on the edge, but the \"are you sure\" reads like a continuation of\nthe \"no match for\" or \"$head found at\" sentence, so translators may want\nto re-orderthat wording...\n\n> @@ -138,19 +138,22 @@ fi\n>  \n>  url=$(git ls-remote --get-url \"$url\")\n>  \n> -git show -s --format='The following changes since commit %H:\n> +git show -s --format=\"\n> +$(gettext 'The following changes since commit %H:\n>  \n\nThe newline added at the start here looks like a bug or unrelated\nchange.\n\n>    %s (%ci)\n>  \n>  are available in the Git repository at:\n> -' $merge_base &&\n> +')\n> +\" $merge_base &&\n\nAnd this likewise looks like an unrelated formatting change.\n\n>  echo \"  $url $pretty_remote\" &&\n> -git show -s --format='\n> +git show -s --format=\"\n> +$(gettext '\n\nAnd likewise here maybe we want to include the first \\n?\n\n>  for you to fetch changes up to %H:\n>  \n>    %s (%ci)\n>  \n> -----------------------------------------------------------------' $headrev &&\n> +----------------------------------------------------------------')\" $headrev &&\n>  \n>  if test $(git cat-file -t \"$head\") = tag\n>  then\n> @@ -162,7 +165,7 @@ fi &&\n>  \n>  if test -n \"$branch_name\"\n>  then\n> -\techo \"(from the branch description for $branch_name local branch)\"\n> +\techo \"$(eval_gettext \"(from the branch description for \\$branch_name local branch)\")\"\n>  \techo\n>  \tgit config \"branch.$branch_name.description\"\n>  \techo \"----------------------------------------------------------------\"\n\nThe rest looks good/correct,\n"},{"id":"436120","messageId":"02a3f76e-cb59-e4c7-21f2-3772be3cad09@redhat.com","threadId":"56513","inReplyTo":"20210916113516.76445-2-bagasdotme@gmail.com","subject":"Re: [PATCH 1/2] request-pull: simplify \"remote or HEAD\" variable in warning messages","fromName":"Paolo Bonzini","fromEmail":"pbonzini@redhat.com","sentAt":"2021-09-16T13:09:41Z","receivedAt":"2021-09-16T13:09:47Z","isPatch":true,"sender":{"key":"pbonzini@redhat.com","avatar":"https://avatars.githubusercontent.com/u/42082?v=4"},"body":"On 16/09/21 13:35, Bagas Sanjaya wrote:\n> In order for waring message \"Are you sure you pushed 'remote or HEAD'\n                ^^^^^^\n\nwarning\n\nOtherwise,\n\nReviewed-by: Paolo Bonzini <pbonzini@redhat.com>\n\n> there?\" to be translatable, replace ${remote:-HEAD} (variable access\n> with defaults) in the message by referring it as $remote_or_head.\n> \n> Cc: Ryan Anderson <ryan@michonline.com>\n> Cc: pbonzini@redhat.com\n> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>\n> ---\n>   git-request-pull.sh | 6 ++++--\n>   1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/git-request-pull.sh b/git-request-pull.sh\n> index 2d0e44656c..9e1d2be9eb 100755\n> --- a/git-request-pull.sh\n> +++ b/git-request-pull.sh\n> @@ -116,15 +116,17 @@ set fnord $(git ls-remote \"$url\" | @@PERL@@ -e \"$find_matching_ref\" \"${remote:-H\n>   remote_sha1=$2\n>   ref=$3\n>   \n> +remote_or_head=${remote:-HEAD}\n> +\n>   if test -z \"$ref\"\n>   then\n>   \techo \"warn: No match for commit $headrev found at $url\" >&2\n> -\techo \"warn: Are you sure you pushed '${remote:-HEAD}' there?\" >&2\n> +\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n>   \tstatus=1\n>   elif test \"$local_sha1\" != \"$remote_sha1\"\n>   then\n>   \techo \"warn: $head found at $url but points to a different object\" >&2\n> -\techo \"warn: Are you sure you pushed '${remote:-HEAD}' there?\" >&2\n> +\techo \"warn: Are you sure you pushed '$remote_or_head' there?\" >&2\n>   \tstatus=1\n>   fi\n>   \n> \n\n"},{"id":"436121","messageId":"YUNKIj44AlW0tkXk@danh.dev","threadId":"56513","inReplyTo":"20210916113516.76445-3-bagasdotme@gmail.com","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Đoàn Trần Công Danh","fromEmail":"congdanhqx@gmail.com","sentAt":"2021-09-16T13:44:18Z","receivedAt":"2021-09-16T13:44:33Z","isPatch":true,"sender":{"key":"congdanhqx@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42673067?v=4"},"body":"Beside the problems pointed out by Ævar:\n\nOn 2021-09-16 18:35:17+0700, Bagas Sanjaya <bagasdotme@gmail.com> wrote:\n> Mark user-faced strings as translatable (including PR message output).\n\nI would argue request-pull message shouldn't be translated.\n\nThe person who creates the request may prefer to use a different\nlanguage, let's say French, for day-to-day work.\n\nHowever, the recipients may not understand French, and prefer to\nreceive English message.\n\nAnd this change break their workflow badly.\n\n> @@ -138,19 +138,22 @@ fi\n>  \n>  url=$(git ls-remote --get-url \"$url\")\n>  \n> -git show -s --format='The following changes since commit %H:\n> +git show -s --format=\"\n> +$(gettext 'The following changes since commit %H:\n>  \n>    %s (%ci)\n>  \n>  are available in the Git repository at:\n> -' $merge_base &&\n> +')\n\nHence, I think this message shouldn't be translated.\n\n> +\" $merge_base &&\n>  echo \"  $url $pretty_remote\" &&\n> -git show -s --format='\n> +git show -s --format=\"\n> +$(gettext '\n>  for you to fetch changes up to %H:\n>  \n>    %s (%ci)\n\nAnd neither should this message.\n\n>  \n> -----------------------------------------------------------------' $headrev &&\n> +----------------------------------------------------------------')\" $headrev &&\n>  \n>  if test $(git cat-file -t \"$head\") = tag\n>  then\n> @@ -162,7 +165,7 @@ fi &&\n>  \n>  if test -n \"$branch_name\"\n>  then\n> -\techo \"(from the branch description for $branch_name local branch)\"\n> +\techo \"$(eval_gettext \"(from the branch description for \\$branch_name local branch)\")\"\n>  \techo\n>  \tgit config \"branch.$branch_name.description\"\n>  \techo \"----------------------------------------------------------------\"\n\nDitto.\n\n-- \nDanh\n"},{"id":"436159","messageId":"xmqqbl4stg91.fsf@gitster.g","threadId":"56513","inReplyTo":"YUNKIj44AlW0tkXk@danh.dev","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-09-16T20:30:50Z","receivedAt":"2021-09-16T20:30:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:\n\n> I would argue request-pull message shouldn't be translated.\n>\n> The person who creates the request may prefer to use a different\n> language, let's say French, for day-to-day work.\n>\n> However, the recipients may not understand French, and prefer to\n> receive English message.\n>\n> And this change break their workflow badly.\n\n[jc: devil's advocate hat on]\n\nWhile that may be true, it would be a nice-to-have if we had an\noption to help developers who usually work in $French when they\ncontribute to a project where $French is the official tongue (assign\nany value other than English to variable $French).\n\n[jc: devil's advocate hat off]\n\nI haven't done or seen any official survey, but I would not be\nsurprised if English were used as the official project language by\nthe majority of projects that accept pull request messages.\n\nIn that sense, the output that gets translated for the user's usual\nlocale by default, like the patch in question does, is misdesigned.\nThe consequence of the design is that among those who do not usually\nrun in C or en_XX locale, the number of people who will be forced to\nsay\n\n\tLANG=C LC_ALL=C git request-pull ...\n\nto override their usual local in order to send the untranslated\nmessage to their project that do not want translated requests would\nbe far greater than those who can just say\n\n\tgit request-pull ...\n\nto send a message in local language to a local project.\n\nSo a good middle ground may be\n\n - allow translation, like these patches attempt\n\n - introduce the command line option \"--l10n=<value>\" and\n   the requestpull.l10n configuration variable that gives the\n   default for the option:\n\n   - when it is set to 'true', end-user's local taken from the\n     environment is used as the target for translation.\n\n   - when it is set to 'false', translation is turned off.\n\n   - when it is set to any other value, the locale is set to the\n     value of that variable (imagine a Japanese developer\n     contributing to a German project).\n\nperhaps?   I dunno.\n"},{"id":"436215","messageId":"187b4b89-e037-6103-08f4-870ce8f1e4fd@gmail.com","threadId":"56513","inReplyTo":"xmqqbl4stg91.fsf@gitster.g","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-09-17T07:41:56Z","receivedAt":"2021-09-17T07:42:04Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 17/09/21 03.30, Junio C Hamano wrote:\n> So a good middle ground may be\n> \n>   - allow translation, like these patches attempt\n> \n>   - introduce the command line option \"--l10n=<value>\" and\n>     the requestpull.l10n configuration variable that gives the\n>     default for the option:\n> \n>     - when it is set to 'true', end-user's local taken from the\n>       environment is used as the target for translation.\n> \n>     - when it is set to 'false', translation is turned off.\n> \n>     - when it is set to any other value, the locale is set to the\n>       value of that variable (imagine a Japanese developer\n>       contributing to a German project).\n> \n> perhaps?   I dunno.\n> \n\nI'm leaning towards second option.\n\nHowever, I proposed that --l10n and corresponding config \nrequestpull.l10n just take locale value set, and defaults to English \n(en_US or C) if empty.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"436232","messageId":"xmqq7dffi2ed.fsf@gitster.g","threadId":"56513","inReplyTo":"187b4b89-e037-6103-08f4-870ce8f1e4fd@gmail.com","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-09-17T16:37:46Z","receivedAt":"2021-09-17T16:37:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bagas Sanjaya <bagasdotme@gmail.com> writes:\n\n> On 17/09/21 03.30, Junio C Hamano wrote:\n>> So a good middle ground may be\n>>   - allow translation, like these patches attempt\n>>   - introduce the command line option \"--l10n=<value>\" and\n>>     the requestpull.l10n configuration variable that gives the\n>>     default for the option:\n>>     - when it is set to 'true', end-user's local taken from the\n>>       environment is used as the target for translation.\n>>     - when it is set to 'false', translation is turned off.\n>>     - when it is set to any other value, the locale is set to the\n>>       value of that variable (imagine a Japanese developer\n>>       contributing to a German project).\n>> perhaps?   I dunno.\n>> \n>\n> I'm leaning towards second option.\n\nI didn't give that many options for there to exist the second one,\nthough ;-)\n\n> However, I proposed that --l10n and corresponding config\n> requestpull.l10n just take locale value set, and defaults to English \n> (en_US or C) if empty.\n\nI do not quite see merit in that tweak over what I outlined before,\nthough.\n\nBut all of the above depends on the assumption that it is a good use\nof our engineering bandwidth to make request-pull localizable, and\nmore importantly if the \"C locale is much more appropriate than the\nlocal one when it comes to request-pull\" is important enough to make\nit behave quite differently from other subcommands in our toolbox.\n\nTo put it differently, my \"I dunno\" above still stands---I am not\nsure if that is a _good_ middle ground, even though it is a middle\nground.\n\nThanks.\n"},{"id":"436257","messageId":"YUT/kfsQnMaOQHRk@vmiklos.hu","threadId":"56513","inReplyTo":"xmqqbl4stg91.fsf@gitster.g","subject":"Re: [PATCH 2/2] request-pull: mark translatable strings","fromName":"Miklos Vajna","fromEmail":"vmiklos@vmiklos.hu","sentAt":"2021-09-17T20:50:25Z","receivedAt":"2021-09-17T20:50:31Z","isPatch":true,"sender":{"key":"vmiklos@vmiklos.hu","avatar":"https://avatars.githubusercontent.com/u/13838?v=4"},"body":"Hi,\n\nOn Thu, Sep 16, 2021 at 01:30:50PM -0700, Junio C Hamano <gitster@pobox.com> wrote:\n> I haven't done or seen any official survey, but I would not be\n> surprised if English were used as the official project language by\n> the majority of projects that accept pull request messages.\n\nThat would be also my expectation.\n\nBut I don't have a strong opinion on this, I already have LC_MESSAGES=C\nconfigured, and I assume many developers have a similar setting (to e.g.\nget easily searchable error messages).\n\nRegards,\n\nMiklos\n"}]}