{"thread":{"id":"56450","subject":"[PATCH] Makefile: remove the check_bindir script","startedAt":"2021-09-06T07:55:40Z","lastAt":"2021-09-07T20:27:27Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"434777","messageId":"patch-1.1-996c05525db-20210906T075527Z-avarab@gmail.com","threadId":"56450","inReplyTo":null,"subject":"[PATCH] Makefile: remove the check_bindir script","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-09-06T07:55:33Z","receivedAt":"2021-09-06T07:55:40Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This script was added in f28ac70f48 (Move all dashed-form commands to\nlibexecdir, 2007-11-28) when commands such as \"git-add\" lived in the\nbin directory, instead of the git exec directory.\n\nThis notice helped someone incorrectly installing version v1.6.0 and\nlater into a directory built for a pre-v1.6.0 git version.\n\nWe're now long past the point where anyone who'd be helped by this\nwarning is likely to be doing that, so let's just remove this check\nand warning to simplify the Makefile.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Makefile     |  3 +--\n check_bindir | 13 -------------\n 2 files changed, 1 insertion(+), 15 deletions(-)\n delete mode 100755 check_bindir\n\ndiff --git a/Makefile b/Makefile\nindex 429c276058d..60c995696c1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -3099,8 +3099,7 @@ endif\n \t\t  ln \"$$execdir/git-remote-http$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n \t\t  ln -s \"git-remote-http$X\" \"$$execdir/$$p\" 2>/dev/null || \\\n \t\t  cp \"$$execdir/git-remote-http$X\" \"$$execdir/$$p\" || exit; } \\\n-\tdone && \\\n-\t./check_bindir \"z$$bindir\" \"z$$execdir\" \"$$bindir/git-add$X\"\n+\tdone\n \n .PHONY: install-gitweb install-doc install-man install-man-perl install-html install-info install-pdf\n .PHONY: quick-install-doc quick-install-man quick-install-html\ndiff --git a/check_bindir b/check_bindir\ndeleted file mode 100755\nindex 623eadcbb7d..00000000000\n--- a/check_bindir\n+++ /dev/null\n@@ -1,13 +0,0 @@\n-#!/bin/sh\n-bindir=\"$1\"\n-gitexecdir=\"$2\"\n-gitcmd=\"$3\"\n-if test \"$bindir\" != \"$gitexecdir\" && test -x \"$gitcmd\"\n-then\n-\techo\n-\techo \"!! You have installed git-* commands to new gitexecdir.\"\n-\techo \"!! Old version git-* commands still remain in bindir.\"\n-\techo \"!! Mixing two versions of Git will lead to problems.\"\n-\techo \"!! Please remove old version commands in bindir now.\"\n-\techo\n-fi\n-- \n2.33.0.821.gfd4106eadbd\n\n"},{"id":"434930","messageId":"xmqqpmtk9ln9.fsf@gitster.g","threadId":"56450","inReplyTo":"patch-1.1-996c05525db-20210906T075527Z-avarab@gmail.com","subject":"Re: [PATCH] Makefile: remove the check_bindir script","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-09-07T20:27:22Z","receivedAt":"2021-09-07T20:27:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:\n\n> This script was added in f28ac70f48 (Move all dashed-form commands to\n> libexecdir, 2007-11-28) when commands such as \"git-add\" lived in the\n> bin directory, instead of the git exec directory.\n\nThanks.  This removal makes sense.\n"}]}