{"thread":{"id":"56369","subject":"[PATCH] t9001: PATH must not use Windows-style paths","startedAt":"2021-08-24T18:01:43Z","lastAt":"2021-08-25T12:27:31Z","messageCount":2,"participants":["Johannes Sixt","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"433604","messageId":"4f5c5633-f5a2-3c99-329e-3057b8d447d2@kdbg.org","threadId":"56369","inReplyTo":null,"subject":"[PATCH] t9001: PATH must not use Windows-style paths","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2021-08-24T18:01:29Z","receivedAt":"2021-08-24T18:01:43Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Windows, $(pwd) returns a drive-letter style path C:/foo, while $PWD\ncontains a POSIX style /c/foo path. When we want to interpolate the\ncurrent directory in the PATH variable, we must not use the C:/foo style,\nbecause the meaning of the colon is ambiguous. Use the POSIX style.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n This belongs on top of branch ga/send-email-sendmail-cmd.\n\n t/t9001-send-email.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex 57fc10e7f8..595cbad372 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -2198,7 +2198,7 @@ test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '\n \n test_expect_success $PREREQ 'test using command name with --sendmail-cmd' '\n \tclean_fake_sendmail &&\n-\tPATH=\"$(pwd):$PATH\" \\\n+\tPATH=\"$PWD:$PATH\" \\\n \tgit send-email \\\n \t\t--from=\"Example <nobody@example.com>\" \\\n \t\t--to=nobody@example.com \\\n-- \n2.33.0.129.g739793498e\n\n"},{"id":"433731","messageId":"nycvar.QRO.7.76.6.2108251427020.55@tvgsbejvaqbjf.bet","threadId":"56369","inReplyTo":"4f5c5633-f5a2-3c99-329e-3057b8d447d2@kdbg.org","subject":"Re: [PATCH] t9001: PATH must not use Windows-style paths","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-08-25T12:27:26Z","receivedAt":"2021-08-25T12:27:31Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Hannes,\n\nOn Tue, 24 Aug 2021, Johannes Sixt wrote:\n\n> On Windows, $(pwd) returns a drive-letter style path C:/foo, while $PWD\n> contains a POSIX style /c/foo path. When we want to interpolate the\n> current directory in the PATH variable, we must not use the C:/foo style,\n> because the meaning of the colon is ambiguous. Use the POSIX style.\n>\n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n\nAcked-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nThank you,\nDscho\n\n> ---\n>  This belongs on top of branch ga/send-email-sendmail-cmd.\n>\n>  t/t9001-send-email.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\n> index 57fc10e7f8..595cbad372 100755\n> --- a/t/t9001-send-email.sh\n> +++ b/t/t9001-send-email.sh\n> @@ -2198,7 +2198,7 @@ test_expect_success $PREREQ 'leading and trailing whitespaces are removed' '\n>\n>  test_expect_success $PREREQ 'test using command name with --sendmail-cmd' '\n>  \tclean_fake_sendmail &&\n> -\tPATH=\"$(pwd):$PATH\" \\\n> +\tPATH=\"$PWD:$PATH\" \\\n>  \tgit send-email \\\n>  \t\t--from=\"Example <nobody@example.com>\" \\\n>  \t\t--to=nobody@example.com \\\n> --\n> 2.33.0.129.g739793498e\n>\n>\n"}]}