{"thread":{"id":"56353","subject":"[PATCH] ls-remote: set packet_trace_identity(<name>)","startedAt":"2021-08-23T13:18:32Z","lastAt":"2021-08-23T16:08:03Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"433439","messageId":"patch-1.1-5d3a2b96500-20210823T131533Z-avarab@gmail.com","threadId":"56353","inReplyTo":null,"subject":"[PATCH] ls-remote: set packet_trace_identity(<name>)","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-08-23T13:17:49Z","receivedAt":"2021-08-23T13:18:32Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Set packet_trace_identity() for ls-remote. This replaces the generic\n\"git\" identity in GIT_TRACE_PACKET=<file> traces to \"ls-remote\", e.g.:\n\n    [...] packet:  upload-pack> version 2\n    [...] packet:  upload-pack> agent=git/2.32.0-dev\n    [...] packet:    ls-remote< version 2\n    [...] packet:    ls-remote< agent=git/2.32.0-dev\n\nWhere in an \"git ls-remote file://<path>\" dialog \">\" is the sender (or\n\"to the server\") and \"<\" is the recipient (or \"received by the\nclient\").\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n builtin/ls-remote.c    | 2 ++\n t/t5702-protocol-v2.sh | 6 +++---\n 2 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/ls-remote.c b/builtin/ls-remote.c\nindex 1794548c711..f4fd823af83 100644\n--- a/builtin/ls-remote.c\n+++ b/builtin/ls-remote.c\n@@ -84,6 +84,8 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)\n \t\t\t     PARSE_OPT_STOP_AT_NON_OPTION);\n \tdest = argv[0];\n \n+\tpacket_trace_identity(\"ls-remote\");\n+\n \tUNLEAK(sorting);\n \n \tif (argc > 1) {\ndiff --git a/t/t5702-protocol-v2.sh b/t/t5702-protocol-v2.sh\nindex 78de1ff2ad5..d3687b1a2e7 100755\n--- a/t/t5702-protocol-v2.sh\n+++ b/t/t5702-protocol-v2.sh\n@@ -27,9 +27,9 @@ test_expect_success 'list refs with git:// using protocol v2' '\n \t\tls-remote --symref \"$GIT_DAEMON_URL/parent\" >actual &&\n \n \t# Client requested to use protocol v2\n-\tgrep \"git> .*\\\\\\0\\\\\\0version=2\\\\\\0$\" log &&\n+\tgrep \"ls-remote> .*\\\\\\0\\\\\\0version=2\\\\\\0$\" log &&\n \t# Server responded using protocol v2\n-\tgrep \"git< version 2\" log &&\n+\tgrep \"ls-remote< version 2\" log &&\n \n \tgit ls-remote --symref \"$GIT_DAEMON_URL/parent\" >expect &&\n \ttest_cmp expect actual\n@@ -151,7 +151,7 @@ test_expect_success 'list refs with file:// using protocol v2' '\n \t\tls-remote --symref \"file://$(pwd)/file_parent\" >actual &&\n \n \t# Server responded using protocol v2\n-\tgrep \"git< version 2\" log &&\n+\tgrep \"ls-remote< version 2\" log &&\n \n \tgit ls-remote --symref \"file://$(pwd)/file_parent\" >expect &&\n \ttest_cmp expect actual\n-- \n2.33.0.662.gbc81f8cbdca\n\n"},{"id":"433454","messageId":"YSPH4PoRG78Ybv0J@coredump.intra.peff.net","threadId":"56353","inReplyTo":"patch-1.1-5d3a2b96500-20210823T131533Z-avarab@gmail.com","subject":"Re: [PATCH] ls-remote: set packet_trace_identity(<name>)","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-08-23T16:08:00Z","receivedAt":"2021-08-23T16:08:03Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Aug 23, 2021 at 03:17:49PM +0200, Ævar Arnfjörð Bjarmason wrote:\n\n> Set packet_trace_identity() for ls-remote. This replaces the generic\n> \"git\" identity in GIT_TRACE_PACKET=<file> traces to \"ls-remote\", e.g.:\n> \n>     [...] packet:  upload-pack> version 2\n>     [...] packet:  upload-pack> agent=git/2.32.0-dev\n>     [...] packet:    ls-remote< version 2\n>     [...] packet:    ls-remote< agent=git/2.32.0-dev\n> \n> Where in an \"git ls-remote file://<path>\" dialog \">\" is the sender (or\n> \"to the server\") and \"<\" is the recipient (or \"received by the\n> client\").\n\nThanks, this looks like an obvious improvement. I'm a little surprised\nit wasn't there already, but I guess I just missed it way back in\nbbc30f9963 (add packet tracing debug code, 2011-02-24).\n\n-Peff\n"}]}