{"thread":{"id":"56327","subject":"[PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS","startedAt":"2021-08-19T18:37:26Z","lastAt":"2021-08-19T20:49:05Z","messageCount":2,"participants":["Carlo Marcelo Arenas Belón","Jeff Hostetler"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"433148","messageId":"20210819183652.7750-1-carenas@gmail.com","threadId":"56327","inReplyTo":null,"subject":"[PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-19T18:36:52Z","receivedAt":"2021-08-19T18:37:26Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents\nitself as gcc 4.2.1), so instead use the __clang__ specific macro to\ndistinguish between them.\n\ntested with Apple clang 12.0.5, clang 14 and gcc 11.2.0\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c\nindex 02f89de216..c55ec35b5d 100644\n--- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c\n+++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c\n@@ -1,4 +1,4 @@\n-#if defined(__GNUC__)\n+#ifndef __clang__\n /*\n  * It is possible to #include CoreFoundation/CoreFoundation.h when compiling\n  * with clang, but not with GCC as of time of writing.\n-- \n2.33.0.481.g26d3bed244\n\n"},{"id":"433169","messageId":"d2a962d3-f874-87e2-33dc-e0625ded5549@jeffhostetler.com","threadId":"56327","inReplyTo":"20210819183652.7750-1-carenas@gmail.com","subject":"Re: [PATCH] fixup! fsmonitor-fs-listen-macos: implement FSEvent listener on MacOS","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2021-08-19T20:48:58Z","receivedAt":"2021-08-19T20:49:05Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 8/19/21 2:36 PM, Carlo Marcelo Arenas Belón wrote:\n> clang defines __GNUC__ for compatibility with gcc (indeed it misrepresents\n> itself as gcc 4.2.1), so instead use the __clang__ specific macro to\n> distinguish between them.\n> \n> tested with Apple clang 12.0.5, clang 14 and gcc 11.2.0\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n> ---\n>   compat/fsmonitor/fsmonitor-fs-listen-macos.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/compat/fsmonitor/fsmonitor-fs-listen-macos.c b/compat/fsmonitor/fsmonitor-fs-listen-macos.c\n> index 02f89de216..c55ec35b5d 100644\n> --- a/compat/fsmonitor/fsmonitor-fs-listen-macos.c\n> +++ b/compat/fsmonitor/fsmonitor-fs-listen-macos.c\n> @@ -1,4 +1,4 @@\n> -#if defined(__GNUC__)\n> +#ifndef __clang__\n>   /*\n>    * It is possible to #include CoreFoundation/CoreFoundation.h when compiling\n>    * with clang, but not with GCC as of time of writing.\n> \n\nthanks!\nJeff\n"}]}