{"thread":{"id":"56319","subject":"[PATCH] completion: tcsh: Fix regression by drop of wrapper functions","startedAt":"2021-08-18T13:28:18Z","lastAt":"2021-08-18T20:57:27Z","messageCount":2,"participants":["Takashi Iwai","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"433068","messageId":"20210818132729.26021-1-tiwai@suse.de","threadId":"56319","inReplyTo":null,"subject":"[PATCH] completion: tcsh: Fix regression by drop of wrapper functions","fromName":"Takashi Iwai","fromEmail":"tiwai@suse.de","sentAt":"2021-08-18T13:27:29Z","receivedAt":"2021-08-18T13:28:18Z","isPatch":true,"sender":{"key":"tiwai@suse.de","avatar":"https://avatars.githubusercontent.com/u/306482?v=4"},"body":"The cleanup of old compat wrappers in bash completion caused a\nregression on tcsh completion that still uses them.\nLet's update the tcsh call site as well for addressing it.\n\nFixes: 441ecdab37fe (\"completion: bash: remove old compat wrappers\")\nSigned-off-by: Takashi Iwai <tiwai@suse.de>\n---\n contrib/completion/git-completion.tcsh | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh\nindex 4a790d8f4ec1..ba797e5b3cd5 100644\n--- a/contrib/completion/git-completion.tcsh\n+++ b/contrib/completion/git-completion.tcsh\n@@ -80,8 +80,9 @@ else\n \tCOMP_CWORD=\\$((\\${#COMP_WORDS[@]}-1))\n fi\n \n-# Call _git() or _gitk() of the bash script, based on the first argument\n-_\\${1}\n+# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,\n+# based on the first argument\n+__git_wrap__\\${1}_main\n \n IFS=\\$'\\n'\n if [ \\${#COMPREPLY[*]} -eq 0 ]; then\n-- \n2.26.2\n\n"},{"id":"433085","messageId":"xmqqtujm4gjw.fsf@gitster.g","threadId":"56319","inReplyTo":"20210818132729.26021-1-tiwai@suse.de","subject":"Re: [PATCH] completion: tcsh: Fix regression by drop of wrapper functions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-18T20:57:23Z","receivedAt":"2021-08-18T20:57:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Takashi Iwai <tiwai@suse.de> writes:\n\n> The cleanup of old compat wrappers in bash completion caused a\n> regression on tcsh completion that still uses them.\n> Let's update the tcsh call site as well for addressing it.\n>\n> Fixes: 441ecdab37fe (\"completion: bash: remove old compat wrappers\")\n> Signed-off-by: Takashi Iwai <tiwai@suse.de>\n> ---\n>  contrib/completion/git-completion.tcsh | 5 +++--\n>  1 file changed, 3 insertions(+), 2 deletions(-)\n\nThanks.  Will queue.\n\n\n\n> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh\n> index 4a790d8f4ec1..ba797e5b3cd5 100644\n> --- a/contrib/completion/git-completion.tcsh\n> +++ b/contrib/completion/git-completion.tcsh\n> @@ -80,8 +80,9 @@ else\n>  \tCOMP_CWORD=\\$((\\${#COMP_WORDS[@]}-1))\n>  fi\n>  \n> -# Call _git() or _gitk() of the bash script, based on the first argument\n> -_\\${1}\n> +# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,\n> +# based on the first argument\n> +__git_wrap__\\${1}_main\n>  \n>  IFS=\\$'\\n'\n>  if [ \\${#COMPREPLY[*]} -eq 0 ]; then\n"}]}