{"thread":{"id":"5628","subject":"[PATCH 0/6] packed deltas with offset to base instead of sha1","startedAt":"2006-09-21T04:04:14Z","lastAt":"2006-09-22T04:57:53Z","messageCount":4,"participants":["Nicolas Pitre","Junio C Hamano","Shawn Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"27326","messageId":"Pine.LNX.4.64.0609202350450.2627@xanadu.home","threadId":"5628","inReplyTo":null,"subject":"[PATCH 0/6] packed deltas with offset to base instead of sha1","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2006-09-21T04:04:14Z","receivedAt":"2006-09-21T04:04:14Z","isPatch":true,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"The following patches are the result of my work to allow deltas to have\ntheir base specified as an offset within a pack instead of a 20 byte \nsha1.\n\nThis turned to be somewhat more involved than I originally expected. \nGiven the relative pack reduction resulting from that, I might have \ndecided against doing this if I had known beforehand how much work was \nneeded.\n\nBut since it is done now I think it is worth merging nevertheless. Some \nparts are still pure code cleanups anyway.\n\nOverall the larger projects are likely to benefit more as they have a \nlarger proportion of deltas. On the historic Linux archive the pack \nreduction is about 5%.\n\n\nNicolas\n"},{"id":"27336","messageId":"7v4pv1eqgl.fsf@assigned-by-dhcp.cox.net","threadId":"5628","inReplyTo":"Pine.LNX.4.64.0609202350450.2627@xanadu.home","subject":"Re: [PATCH 0/6] packed deltas with offset to base instead of sha1","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-21T05:30:50Z","receivedAt":"2006-09-21T05:30:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nicolas Pitre writes:\n\n> The following patches are the result of my work to allow deltas to have\n> their base specified as an offset within a pack instead of a 20 byte \n> sha1.\n>\n> This turned to be somewhat more involved than I originally expected. \n> Given the relative pack reduction resulting from that, I might have \n> decided against doing this if I had known beforehand how much work was \n> needed.\n>\n> But since it is done now I think it is worth merging nevertheless. Some \n> parts are still pure code cleanups anyway.\n>\n> Overall the larger projects are likely to benefit more as they have a \n> larger proportion of deltas. On the historic Linux archive the pack \n> reduction is about 5%.\n\nNice, although I suspect this would make it a bit more involved\nto merge a few outstanding stuff.\n\nWill take a look when I'm done looking at Linus's packed-ref\nstuff.\n"},{"id":"27365","messageId":"20060921160227.GC3934@spearce.org","threadId":"5628","inReplyTo":"7v4pv1eqgl.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 0/6] packed deltas with offset to base instead of sha1","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2006-09-21T16:02:27Z","receivedAt":"2006-09-21T16:02:27Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Junio C Hamano wrote:\n> Nicolas Pitre writes:\n> \n> > The following patches are the result of my work to allow deltas to have\n> > their base specified as an offset within a pack instead of a 20 byte \n> > sha1.\n> >\n> > This turned to be somewhat more involved than I originally expected. \n> > Given the relative pack reduction resulting from that, I might have \n> > decided against doing this if I had known beforehand how much work was \n> > needed.\n> >\n> > But since it is done now I think it is worth merging nevertheless. Some \n> > parts are still pure code cleanups anyway.\n> >\n> > Overall the larger projects are likely to benefit more as they have a \n> > larger proportion of deltas. On the historic Linux archive the pack \n> > reduction is about 5%.\n> \n> Nice, although I suspect this would make it a bit more involved\n> to merge a few outstanding stuff.\n\nIf you are talking about my mmap window code merge in Nico's\nwork first. Nico posted before me and did so with a working\nimplementation that looks good (at first glance anyway, I didn't\nstudy it in detail). I have yet to finish merging my mmap code\nonto your verify delta before reuse (106d710b) commits. I've just\nbeen too busy with classes and research work to get around to it.\n\nHowever I have looked at the merge and I more or less need to\nrewrite a good chunk of it just to get it onto 106d7; rewriting it\nonto Nico's work here is probably going to be about the same amount\nof effort. I'd prefer to rewrite it only once, given how limited\nmy time has suddenly become.\n\n-- \nShawn.\n"},{"id":"27402","messageId":"7v64fg7b1q.fsf@assigned-by-dhcp.cox.net","threadId":"5628","inReplyTo":"20060921160227.GC3934@spearce.org","subject":"Re: [PATCH 0/6] packed deltas with offset to base instead of sha1","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-09-22T04:57:53Z","receivedAt":"2006-09-22T04:57:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shawn Pearce writes:\n\n>> Nice, although I suspect this would make it a bit more involved\n>> to merge a few outstanding stuff.\n>\n> If you are talking about my mmap window code merge in Nico's\n> work first...\n> However I have looked at the merge and I more or less need to\n> rewrite a good chunk of it just to get it onto 106d7; rewriting it\n> onto Nico's work here is probably going to be about the same amount\n> of effort.\n\nI had the same impression, although without seeing your code.\nWill see to it to have delta-offset code in \"next\" soonish.\n\nThanks.\n"}]}