{"thread":{"id":"56269","subject":"[PATCH] ci: use upload-artifacts v1 for dockerized jobs","startedAt":"2021-08-12T06:53:05Z","lastAt":"2021-08-14T22:18:03Z","messageCount":6,"participants":["Carlo Marcelo Arenas Belón","Junio C Hamano","Carlo Arenas","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"432563","messageId":"20210812065234.71399-1-carenas@gmail.com","threadId":"56269","inReplyTo":null,"subject":"[PATCH] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-12T06:52:34Z","receivedAt":"2021-08-12T06:53:05Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,\n2021-06-23) changed all calls to that action from v1 to v2, but there\nis still an open bug[1] that affects all nodejs actions and prevents\nits use in 32-bit linux (as used by the Linux32 container)\n\nmove all dockerized jobs to use v1 that was build in C# and therefore\ndoesn't have this problem which will otherwise manifest with confusing\nmessages like:\n\n /usr/bin/docker exec 0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c \"cat /etc/*release | grep ^ID\"\n OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown\n\n[1] https://github.com/actions/runner/issues/1011\n---\n .github/workflows/main.yml | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 47876a4f02..9dd41a1742 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -258,7 +258,7 @@ jobs:\n - jobname: linux-musl\n image: alpine\n - jobname: Linux32\n- image: daald/ubuntu32:xenial\n+ image: i386/ubuntu:xenial\n env:\n jobname: ${{matrix.vector.jobname}}\n runs-on: ubuntu-latest\n@@ -271,7 +271,7 @@ jobs:\n if: failure()\n - name: Upload failed tests' directories\n if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n- uses: actions/upload-artifact@v2\n+ uses: actions/upload-artifact@v1\n with:\n name: failed-tests-${{matrix.vector.jobname}}\n path: ${{env.FAILED_TEST_ARTIFACTS}}\n-- \n2.33.0.rc1.379.g2890ef5eb6\n\n"},{"id":"432596","messageId":"xmqq7dgq304m.fsf@gitster.g","threadId":"56269","inReplyTo":"20210812065234.71399-1-carenas@gmail.com","subject":"Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-12T19:59:21Z","receivedAt":"2021-08-12T19:59:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Marcelo Arenas Belón writes:\n\n> e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,\n> 2021-06-23) changed all calls to that action from v1 to v2, but there\n> is still an open bug[1] that affects all nodejs actions and prevents\n> its use in 32-bit linux (as used by the Linux32 container)\n>\n> move all dockerized jobs to use v1 that was build in C# and therefore\n\n\"was build -> was built\", I would think.\n\n> doesn't have this problem which will otherwise manifest with confusing\n> messages like:\n>\n> /usr/bin/docker exec 0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c \"cat /etc/*release | grep ^ID\"\n> OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown\n>\n> [1] https://github.com/actions/runner/issues/1011\n> ---\n\nNot signed off.\n\n> .github/workflows/main.yml | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 47876a4f02..9dd41a1742 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> @@ -258,7 +258,7 @@ jobs:\n> - jobname: linux-musl\n> image: alpine\n> - jobname: Linux32\n> - image: daald/ubuntu32:xenial\n> + image: i386/ubuntu:xenial\n\nIntended or accidental? At least it is not explained where this\nchange comes from in the proposed log message.\n\n> env:\n> jobname: ${{matrix.vector.jobname}}\n> runs-on: ubuntu-latest\n> @@ -271,7 +271,7 @@ jobs:\n> if: failure()\n> - name: Upload failed tests' directories\n> if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n> - uses: actions/upload-artifact@v2\n> + uses: actions/upload-artifact@v1\n\nThis one matches what the proposed log message says, switching from\n@v2 to @v1.\n\n> with:\n> name: failed-tests-${{matrix.vector.jobname}}\n> path: ${{env.FAILED_TEST_ARTIFACTS}}\n"},{"id":"432613","messageId":"CAPUEspg3ci4VVEU+ktDZgZkhykKbs9-+JmiOx_2CmOwFoYdMMw@mail.gmail.com","threadId":"56269","inReplyTo":"xmqq7dgq304m.fsf@gitster.g","subject":"Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2021-08-12T22:19:02Z","receivedAt":"2021-08-12T22:19:16Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, Aug 12, 2021 at 12:59 PM Junio C Hamano wrote:\n>\n> Carlo Marcelo Arenas Belón writes:\n>\n> > diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> > index 47876a4f02..9dd41a1742 100644\n> > --- a/.github/workflows/main.yml\n> > +++ b/.github/workflows/main.yml\n> > @@ -258,7 +258,7 @@ jobs:\n> > - jobname: linux-musl\n> > image: alpine\n> > - jobname: Linux32\n> > - image: daald/ubuntu32:xenial\n> > + image: i386/ubuntu:xenial\n>\n> Intended or accidental?\n\nyes!.\n\nIt was intended but more as an RFC, because I couldn't find an\nexplanation on what was the advantage of using this 5 year old\nunofficial image when there was an equivalent official one that had\nbeen updated just last month.\n\nIt was accidental, because I didn't realize I hadn't updated the log\nmessage and it isn't needed to fix the regression which was the main\nfocus anyway.\n\n> At least it is not explained where this\n> change comes from in the proposed log message.\n\nThe advantages of using an official image will be :\n\n* more likely to be cached and therefore less likely to fail the job\n* easier to move to a newer version (specially considering 16.04 is EOL)\n\nWould it be better to drop or document it for v2?\n\nCarlo\n"},{"id":"432627","messageId":"xmqq1r6xzwmp.fsf@gitster.g","threadId":"56269","inReplyTo":"CAPUEspg3ci4VVEU+ktDZgZkhykKbs9-+JmiOx_2CmOwFoYdMMw@mail.gmail.com","subject":"Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-13T06:28:30Z","receivedAt":"2021-08-13T06:28:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Arenas writes:\n\n> The advantages of using an official image will be :\n>\n> * more likely to be cached and therefore less likely to fail the job\n> * easier to move to a newer version (specially considering 16.04 is EOL)\n>\n> Would it be better to drop or document it for v2?\n\nIt smells like a sensible thing to do to switch to the more\nup-to-date \"official\" one when such a thing exists---I do not think\nwe have any strange dependency that makes us favor using a possibly\nstale one.\n\nIt however should be a separate patch under a different title, as it\nsounds like that it does not have anything to do with the \"use\nupload-artifacts v1\" theme. So\n\n (1) drop the hunk from this patch to make it purely about\n upload-artifacts v1.\n\n (2) add a new patch that lets us use the official image.\n\nwould be a reasonable way forward.\n\nThanks.\n"},{"id":"432662","messageId":"20210813091349.88574-1-carenas@gmail.com","threadId":"56269","inReplyTo":"20210812065234.71399-1-carenas@gmail.com","subject":"[PATCH v2] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-13T09:13:49Z","receivedAt":"2021-08-13T09:14:25Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,\n2021-06-23) changed all calls to that action from v1 to v2, but there\nis still an open bug[1] that affects all nodejs actions and prevents\nits use in 32-bit linux (as used by the Linux32 container)\n\nmove all dockerized jobs to use v1 that was built in C# and therefore\ndoesn't have this problem, which will otherwise manifest with confusing\nmessages like:\n\n /usr/bin/docker exec 0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c \"cat /etc/*release | grep ^ID\"\n OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown\n\n[1] https://github.com/actions/runner/issues/1011\n\nSigned-off-by: Carlo Marcelo Arenas Belón \n---\nv2:\n* dropped unrelated chunk and better grammar as suggested by Junio\n\n .github/workflows/main.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 47876a4f02..68596f2592 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -271,7 +271,7 @@ jobs:\n if: failure()\n - name: Upload failed tests' directories\n if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n- uses: actions/upload-artifact@v2\n+ uses: actions/upload-artifact@v1\n with:\n name: failed-tests-${{matrix.vector.jobname}}\n path: ${{env.FAILED_TEST_ARTIFACTS}}\n-- \n2.33.0.rc1.379.g2890ef5eb6\n\n"},{"id":"432753","messageId":"nycvar.QRO.7.76.6.2108150013510.59@tvgsbejvaqbjf.bet","threadId":"56269","inReplyTo":"20210813091349.88574-1-carenas@gmail.com","subject":"Re: [PATCH v2] ci: use upload-artifacts v1 for dockerized jobs","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-08-14T22:17:57Z","receivedAt":"2021-08-14T22:18:03Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Carlo,\n\nOn Fri, 13 Aug 2021, Carlo Marcelo Arenas Belón wrote:\n\n> e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,\n> 2021-06-23) changed all calls to that action from v1 to v2, but there\n> is still an open bug[1] that affects all nodejs actions and prevents\n> its use in 32-bit linux (as used by the Linux32 container)\n>\n> move all dockerized jobs to use v1 that was built in C# and therefore\n> doesn't have this problem, which will otherwise manifest with confusing\n> messages like:\n>\n> /usr/bin/docker exec 0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c \"cat /etc/*release | grep ^ID\"\n> OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown\n\nACK!\n\nThis seems to be the same issue that didn't let us upgrade to\nactions/checkout@v2 in the `dockerized` matrix (but of course I did not\nnotice the `upload-artifact` issue because the test suite did not fail\nwhen I was working on e9f79acb28).\n\nThank you,\nDscho\n\n>\n> [1] https://github.com/actions/runner/issues/1011\n>\n> Signed-off-by: Carlo Marcelo Arenas Belón \n> ---\n> v2:\n> * dropped unrelated chunk and better grammar as suggested by Junio\n>\n> .github/workflows/main.yml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 47876a4f02..68596f2592 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> @@ -271,7 +271,7 @@ jobs:\n> if: failure()\n> - name: Upload failed tests' directories\n> if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n> - uses: actions/upload-artifact@v2\n> + uses: actions/upload-artifact@v1\n> with:\n> name: failed-tests-${{matrix.vector.jobname}}\n> path: ${{env.FAILED_TEST_ARTIFACTS}}\n> --\n> 2.33.0.rc1.379.g2890ef5eb6\n>\n>\n"}]}