{"thread":{"id":"56240","subject":"[PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","startedAt":"2021-08-09T06:30:18Z","lastAt":"2021-08-28T09:46:11Z","messageCount":13,"participants":["Carlo Marcelo Arenas Belón","Jeff Hostetler","Junio C Hamano","Carlo Arenas"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"432286","messageId":"20210809063004.73736-1-carenas@gmail.com","threadId":"56240","inReplyTo":null,"subject":"[PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-09T06:30:02Z","receivedAt":"2021-08-09T06:30:18Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)\nas of a5a42b9f76 (from Jul 1)\n\nit should be squashed into the corresponding patch from the series as shown\nin the subject and reroll IMHO; notice Junio also has some bandaid sparse\nfixes for t/helper/test-touch.c that should be included.\n\na similar additional fix for C89 compatibility to be send as a reply later\n\nCarlo Marcelo Arenas Belón (2):\n fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n fixup! fsmonitor--daemon: implement handle_client callback\n\n builtin/fsmonitor--daemon.c | 2 +-\n fsmonitor-ipc.h | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)\n\n-- \n2.33.0.rc1.373.gc715f1a457\n\n"},{"id":"432287","messageId":"20210809063004.73736-2-carenas@gmail.com","threadId":"56240","inReplyTo":"20210809063004.73736-1-carenas@gmail.com","subject":"[PATCH 1/2] fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-09T06:30:03Z","receivedAt":"2021-08-09T06:30:19Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"fsmonitor: ensure enum ipc_active_state is defined before using\n\nIn file included from fsmonitor.c:6:\nfsmonitor-ipc.h:23:6: error: ISO C forbids forward references to 'enum' types [-Werror=pedantic]\n 23 | enum ipc_active_state fsmonitor_ipc__get_state(void);\n | ^~~~~~~~~~~~~~~~\nIn file included from t/helper/test-fsmonitor-client.c:9:\n./fsmonitor-ipc.h:23:6: warning: ISO C forbids forward references to 'enum' types [-Wpedantic]\nenum ipc_active_state fsmonitor_ipc__get_state(void);\n ^\n\nSigned-off-by: Carlo Marcelo Arenas Belón \n---\n fsmonitor-ipc.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/fsmonitor-ipc.h b/fsmonitor-ipc.h\nindex 837c5e5b64..7e02c7285a 100644\n--- a/fsmonitor-ipc.h\n+++ b/fsmonitor-ipc.h\n@@ -1,6 +1,8 @@\n #ifndef FSMONITOR_IPC_H\n #define FSMONITOR_IPC_H\n \n+#include \"simple-ipc.h\"\n+\n /*\n * Returns true if built-in file system monitor daemon is defined\n * for this platform.\n-- \n2.33.0.rc1.373.gc715f1a457\n\n"},{"id":"432288","messageId":"20210809063004.73736-3-carenas@gmail.com","threadId":"56240","inReplyTo":"20210809063004.73736-1-carenas@gmail.com","subject":"[PATCH 2/2] fixup! fsmonitor--daemon: implement handle_client callback","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-09T06:30:04Z","receivedAt":"2021-08-09T06:30:23Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"fsmonitor: avoid extra ; for KHASH_INIT\n\nbuiltin/fsmonitor--daemon.c:622:75: error: ISO C does not allow extra ';' outside of a function [-Werror=pedantic]\n 622 | KHASH_INIT(str, const char *, int, 0, kh_str_hash_func, kh_str_hash_equal);\n | ^\n\nSigned-off-by: Carlo Marcelo Arenas Belón \n---\n builtin/fsmonitor--daemon.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/fsmonitor--daemon.c b/builtin/fsmonitor--daemon.c\nindex 25f18f2726..d018af346f 100644\n--- a/builtin/fsmonitor--daemon.c\n+++ b/builtin/fsmonitor--daemon.c\n@@ -619,7 +619,7 @@ static int fsmonitor_parse_client_token(const char *buf_token,\n \treturn 0;\n }\n \n-KHASH_INIT(str, const char *, int, 0, kh_str_hash_func, kh_str_hash_equal);\n+KHASH_INIT(str, const char *, int, 0, kh_str_hash_func, kh_str_hash_equal)\n \n static int do_handle_client(struct fsmonitor_daemon_state *state,\n \t\t\t const char *command,\n-- \n2.33.0.rc1.373.gc715f1a457\n\n"},{"id":"432289","messageId":"20210809072551.94391-1-carenas@gmail.com","threadId":"56240","inReplyTo":"20210809063004.73736-1-carenas@gmail.com","subject":"[PATCH] test-path-utils: use a C89 compatible format for double printf","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-09T07:25:51Z","receivedAt":"2021-08-09T07:26:06Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"a62f9d1ace (test-path-utils: offer to run a protectNTFS/protectHFS\nbenchmark, 2019-09-04) add a tool for testing that uses a double\nvariable to keep track of time but prints them with \"%lf\".\n\nwhile correct for newer C standards, it is not defined in C89 and\nit is not needed, since both float and double will be promoted to\ndouble by printf and should therefore use \"%f\"; change it accordingly.\n\nSigned-off-by: Carlo Marcelo Arenas Belón \n---\n t/helper/test-path-utils.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/t/helper/test-path-utils.c b/t/helper/test-path-utils.c\nindex 229ed416b0..3d33d2a3e7 100644\n--- a/t/helper/test-path-utils.c\n+++ b/t/helper/test-path-utils.c\n@@ -275,18 +275,18 @@ static int protect_ntfs_hfs_benchmark(int argc, const char **argv)\n \t\t\t\tfor (j = 0; j < nr; j++)\n \t\t\t\t\tverify_path(names[j], file_mode);\n \t\t\t\tend = getnanotime();\n-\t\t\t\tprintf(\"protect_ntfs = %d, protect_hfs = %d: %lfms\\n\", protect_ntfs, protect_hfs, (end-begin) / (double)1e6);\n+\t\t\t\tprintf(\"protect_ntfs = %d, protect_hfs = %d: %fms\\n\", protect_ntfs, protect_hfs, (end-begin) / (double)1e6);\n \t\t\t\tcumul += end - begin;\n \t\t\t\tcumul2 += (end - begin) * (end - begin);\n \t\t\t}\n \t\t\tm[protect_ntfs][protect_hfs] = cumul / (double)repetitions;\n \t\t\tv[protect_ntfs][protect_hfs] = my_sqrt(cumul2 / (double)repetitions - m[protect_ntfs][protect_hfs] * m[protect_ntfs][protect_hfs]);\n-\t\t\tprintf(\"mean: %lfms, stddev: %lfms\\n\", m[protect_ntfs][protect_hfs] / (double)1e6, v[protect_ntfs][protect_hfs] / (double)1e6);\n+\t\t\tprintf(\"mean: %fms, stddev: %fms\\n\", m[protect_ntfs][protect_hfs] / (double)1e6, v[protect_ntfs][protect_hfs] / (double)1e6);\n \t\t}\n \n \tfor (protect_ntfs = 0; protect_ntfs < 2; protect_ntfs++)\n \t\tfor (protect_hfs = 0; protect_hfs < 2; protect_hfs++)\n-\t\t\tprintf(\"ntfs=%d/hfs=%d: %lf%% slower\\n\", protect_ntfs, protect_hfs, (m[protect_ntfs][protect_hfs] - m[0][0]) * 100 / m[0][0]);\n+\t\t\tprintf(\"ntfs=%d/hfs=%d: %f%% slower\\n\", protect_ntfs, protect_hfs, (m[protect_ntfs][protect_hfs] - m[0][0]) * 100 / m[0][0]);\n \n \treturn 0;\n }\n-- \n2.33.0.rc1.373.gc715f1a457\n\n"},{"id":"432303","messageId":"42dce285-9599-4c7c-d351-44c1e338337e@jeffhostetler.com","threadId":"56240","inReplyTo":"20210809063004.73736-1-carenas@gmail.com","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2021-08-09T14:34:38Z","receivedAt":"2021-08-09T14:38:14Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:\n> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)\n> as of a5a42b9f76 (from Jul 1)\n> \n> it should be squashed into the corresponding patch from the series as shown\n> in the subject and reroll IMHO; notice Junio also has some bandaid sparse\n> fixes for t/helper/test-touch.c that should be included.\n> \n> a similar additional fix for C89 compatibility to be send as a reply later\n> \n> Carlo Marcelo Arenas Belón (2):\n> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n> fixup! fsmonitor--daemon: implement handle_client callback\n> \n> builtin/fsmonitor--daemon.c | 2 +-\n> fsmonitor-ipc.h | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n\nThanks!\nJeff\n"},{"id":"432312","messageId":"xmqqpmumftry.fsf@gitster.g","threadId":"56240","inReplyTo":"42dce285-9599-4c7c-d351-44c1e338337e@jeffhostetler.com","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-09T16:49:05Z","receivedAt":"2021-08-09T16:49:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff Hostetler writes:\n\n> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:\n>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)\n>> as of a5a42b9f76 (from Jul 1)\n>> it should be squashed into the corresponding patch from the series\n>> as shown\n>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse\n>> fixes for t/helper/test-touch.c that should be included.\n>> a similar additional fix for C89 compatibility to be send as a reply\n>> later\n>> Carlo Marcelo Arenas Belón (2):\n>> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n>> fixup! fsmonitor--daemon: implement handle_client callback\n>> builtin/fsmonitor--daemon.c | 2 +-\n>> fsmonitor-ipc.h | 2 ++\n>> 2 files changed, 3 insertions(+), 1 deletion(-)\n>> \n>\n> Thanks!\n\nThanks, both. \n\nJeff, I understand that this is planned to be rerolled post release,\nso I'll not touch these fixups and let yuou worry about them ;-)\n\n"},{"id":"432351","messageId":"CAPUEspioazo0js5pZj7TzR2=j-+Aeh+XHr8Nbsszs6cq+WJqmw@mail.gmail.com","threadId":"56240","inReplyTo":"xmqqpmumftry.fsf@gitster.g","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2021-08-10T05:49:05Z","receivedAt":"2021-08-10T05:49:20Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Mon, Aug 9, 2021 at 9:49 AM Junio C Hamano wrote:\n> Jeff, I understand that this is planned to be rerolled post release,\n> so I'll not touch these fixups and let you worry about them ;-)\n\nJeff,\n\nAs I mentioned in the cover letter[1] there is an extra patch[2] not\nin the series and that also applies to maint, but is not critical and\nmight be better if included with your reroll IMHO, thanks.\n\nCarlo\n\n[1] https://lore.kernel.org/git/20210809063004.73736-1-carenas@gmail.com/\n[2] https://lore.kernel.org/git/20210809072551.94391-1-carenas@gmail.com/\n"},{"id":"432372","messageId":"b554c82a-4da1-9676-4d93-b769ab6bbcbd@jeffhostetler.com","threadId":"56240","inReplyTo":"xmqqpmumftry.fsf@gitster.g","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2021-08-10T13:41:07Z","receivedAt":"2021-08-10T13:41:15Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 8/9/21 12:49 PM, Junio C Hamano wrote:\n> Jeff Hostetler writes:\n> \n>> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:\n>>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)\n>>> as of a5a42b9f76 (from Jul 1)\n>>> it should be squashed into the corresponding patch from the series\n>>> as shown\n>>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse\n>>> fixes for t/helper/test-touch.c that should be included.\n>>> a similar additional fix for C89 compatibility to be send as a reply\n>>> later\n>>> Carlo Marcelo Arenas Belón (2):\n>>> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n>>> fixup! fsmonitor--daemon: implement handle_client callback\n>>> builtin/fsmonitor--daemon.c | 2 +-\n>>> fsmonitor-ipc.h | 2 ++\n>>> 2 files changed, 3 insertions(+), 1 deletion(-)\n>>>\n>>\n>> Thanks!\n> \n> Thanks, both.\n> \n> Jeff, I understand that this is planned to be rerolled post release,\n> so I'll not touch these fixups and let yuou worry about them ;-)\n> \n\nRight. I'll include them with my next version.\nJeff\n"},{"id":"432373","messageId":"f2d42d19-9378-5d10-cab4-1541027ad6aa@jeffhostetler.com","threadId":"56240","inReplyTo":"CAPUEspioazo0js5pZj7TzR2=j-+Aeh+XHr8Nbsszs6cq+WJqmw@mail.gmail.com","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2021-08-10T13:52:09Z","receivedAt":"2021-08-10T13:52:12Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 8/10/21 1:49 AM, Carlo Arenas wrote:\n> On Mon, Aug 9, 2021 at 9:49 AM Junio C Hamano wrote:\n>> Jeff, I understand that this is planned to be rerolled post release,\n>> so I'll not touch these fixups and let you worry about them ;-)\n> \n> Jeff,\n> \n> As I mentioned in the cover letter[1] there is an extra patch[2] not\n> in the series and that also applies to maint, but is not critical and\n> might be better if included with your reroll IMHO, thanks.\n> \n> Carlo\n> \n> [1] https://lore.kernel.org/git/20210809063004.73736-1-carenas@gmail.com/\n> [2] https://lore.kernel.org/git/20210809072551.94391-1-carenas@gmail.com/\n> \n\nYou're talking about the commit with \"%lf\" vs \"%f\".\n\nI saw that, but I was unsure what it had to do with my FSMonitor\nseries. It seemed like it could just be a standalone patch by itself.\n\n(I'm not opposed to including it in mine, but it'd be easier and\nquicker to just treat it in isolation, IMHO.)\n\nThoughts??\n\nJeff\n"},{"id":"433902","messageId":"xmqqsfyvbg8m.fsf@gitster.g","threadId":"56240","inReplyTo":"b554c82a-4da1-9676-4d93-b769ab6bbcbd@jeffhostetler.com","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-27T05:37:13Z","receivedAt":"2021-08-27T05:37:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff Hostetler writes:\n\n> On 8/9/21 12:49 PM, Junio C Hamano wrote:\n>> Jeff Hostetler writes:\n>> \n>>> On 8/9/21 2:30 AM, Carlo Marcelo Arenas Belón wrote:\n>>>> seen with both clang 12 and gcc 11 in seen (including jh/builtin-fsmonitor)\n>>>> as of a5a42b9f76 (from Jul 1)\n>>>> it should be squashed into the corresponding patch from the series\n>>>> as shown\n>>>> in the subject and reroll IMHO; notice Junio also has some bandaid sparse\n>>>> fixes for t/helper/test-touch.c that should be included.\n>>>> a similar additional fix for C89 compatibility to be send as a reply\n>>>> later\n>>>> Carlo Marcelo Arenas Belón (2):\n>>>> fixup! fsmonitor-ipc: create client routines for git-fsmonitor--daemon\n>>>> fixup! fsmonitor--daemon: implement handle_client callback\n>>>> builtin/fsmonitor--daemon.c | 2 +-\n>>>> fsmonitor-ipc.h | 2 ++\n>>>> 2 files changed, 3 insertions(+), 1 deletion(-)\n>>>>\n>>>\n>>> Thanks!\n>> Thanks, both.\n>> Jeff, I understand that this is planned to be rerolled post release,\n>> so I'll not touch these fixups and let yuou worry about them ;-)\n\nHere is what I had to do to work around\n\n https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136\n\nI also have another SQUASH??? fix queued on the topic, but I think\nyou've already seen it.\n\n---\n fsmonitor-ipc.h | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/fsmonitor-ipc.h b/fsmonitor-ipc.h\nindex 837c5e5b64..7e02c7285a 100644\n--- a/fsmonitor-ipc.h\n+++ b/fsmonitor-ipc.h\n@@ -1,6 +1,8 @@\n #ifndef FSMONITOR_IPC_H\n #define FSMONITOR_IPC_H\n \n+#include \"simple-ipc.h\"\n+\n /*\n * Returns true if built-in file system monitor daemon is defined\n * for this platform.\n-- \n2.33.0-205-g1b5b9d966b\n\n"},{"id":"433906","messageId":"CAPUEsphe0N6w_qCTAp46YPH7vBj2dkJa9kOm2HaixkFkVuk3GA@mail.gmail.com","threadId":"56240","inReplyTo":"xmqqsfyvbg8m.fsf@gitster.g","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2021-08-27T06:04:09Z","receivedAt":"2021-08-27T06:04:25Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Thu, Aug 26, 2021 at 10:37 PM Junio C Hamano wrote:\n> Here is what I had to do to work around\n>\n> https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136\n\ncorrect; that was 1/2 of the fixups I proposed and were waiting for the reroll.\n\ninteresting that the job was able to build without 2/2[1] but it might\nbe because clang is even more pedantic.\n\nCarlo\n\n[1] https://lore.kernel.org/git/20210809063004.73736-3-carenas@gmail.com/\n"},{"id":"433937","messageId":"xmqq1r6ebyo5.fsf@gitster.g","threadId":"56240","inReplyTo":"CAPUEsphe0N6w_qCTAp46YPH7vBj2dkJa9kOm2HaixkFkVuk3GA@mail.gmail.com","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-27T17:11:22Z","receivedAt":"2021-08-27T17:11:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Arenas writes:\n\n> On Thu, Aug 26, 2021 at 10:37 PM Junio C Hamano wrote:\n>> Here is what I had to do to work around\n>>\n>> https://github.com/git/git/runs/3438543601?check_suite_focus=true#step:5:136\n>\n> correct; that was 1/2 of the fixups I proposed and were waiting for the reroll.\n>\n> interesting that the job was able to build without 2/2[1] but it might\n> be because clang is even more pedantic.\n>\n> Carlo\n>\n> [1] https://lore.kernel.org/git/20210809063004.73736-3-carenas@gmail.com/\n\nOne thing I noticed is that simple-ipc.h can disable itself\naltogether with \"#ifdef SUPPORTS_SIMPLE_IPC\", so the unconditional\nuse of \"enum ipc_active_state\" by fsmonitor-ipc.h would still be a\nproblem. fsmonitor-ipc.h is included even in help.c so it seems\nthat with this topic, you practically will not get a working Git at\nall with -pedantic when SUPPORTS_SIMPLE_IPC is not true.\n\n"},{"id":"434014","messageId":"CAPUEspgDbi1v32p+H=afZSDVOo_VpJzKn7bU8_s+fPJxm=mtBQ@mail.gmail.com","threadId":"56240","inReplyTo":"xmqq1r6ebyo5.fsf@gitster.g","subject":"Re: [PATCH 0/2] fsmonitor: fixup to avoid warnings from pedantic","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2021-08-28T09:45:57Z","receivedAt":"2021-08-28T09:46:11Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Fri, Aug 27, 2021 at 10:11 AM Junio C Hamano wrote:\n>\n> One thing I noticed is that simple-ipc.h can disable itself\n> altogether with \"#ifdef SUPPORTS_SIMPLE_IPC\", so the unconditional\n> use of \"enum ipc_active_state\" by fsmonitor-ipc.h would still be a\n> problem.\n\nThat is why we also need an additional patch[1] to be able to build\n(at least in macOS).\n\nin windows additional changes are required, but I suspect that\nconfiguration is probably not expected.\n\n> fsmonitor-ipc.h is included even in help.c so it seems\n> that with this topic, you practically will not get a working Git at\n> all with -pedantic when SUPPORTS_SIMPLE_IPC is not true.\n\nnot sure if I understand the logic here, but there is a \"mock\" daemon\nthat is used in the platforms that don't have support that will be\navailable then (even if it just refuses to start), and that is still\nIMHO a working git configuration.\n\nCarlo\n\n[1] https://lore.kernel.org/git/20210817082310.2157-1-carenas@gmail.com/\n"}]}