{"thread":{"id":"56196","subject":"[PATCH] t7508: avoid non POSIX BRE","startedAt":"2021-08-01T21:53:17Z","lastAt":"2021-08-02T02:37:04Z","messageCount":2,"participants":["Carlo Marcelo Arenas Belón","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"431657","messageId":"20210801215300.53781-1-carenas@gmail.com","threadId":"56196","inReplyTo":null,"subject":"[PATCH] t7508: avoid non POSIX BRE","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-08-01T21:53:00Z","receivedAt":"2021-08-01T21:53:17Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"24c30e0b6 (wt-status: tolerate dangling marks, 2020-09-01) adds a test\nthat uses a BRE which breaks at least with OpenBSD's grep.\n\nswitch to an ERE as it is done for similar checks and while at it, remove\nthe now obsolete test_i18ngrep call.\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n t/t7508-status.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7508-status.sh b/t/t7508-status.sh\nindex 2b72451ba3..05c6c02435 100755\n--- a/t/t7508-status.sh\n+++ b/t/t7508-status.sh\n@@ -882,7 +882,7 @@ test_expect_success 'status shows detached HEAD properly after checking out non-\n \tgit clone upstream downstream &&\n \tgit -C downstream checkout @{u} &&\n \tgit -C downstream status >actual &&\n-\ttest_i18ngrep \"HEAD detached at [0-9a-f]\\\\+\" actual\n+\tgrep -E \"HEAD detached at [0-9a-f]+\" actual\n '\n \n test_expect_success 'setup status submodule summary' '\n-- \n2.32.0.826.g286871f41a\n\n"},{"id":"431660","messageId":"xmqqv94oy3le.fsf@gitster.g","threadId":"56196","inReplyTo":"20210801215300.53781-1-carenas@gmail.com","subject":"Re: [PATCH] t7508: avoid non POSIX BRE","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-08-02T02:37:01Z","receivedAt":"2021-08-02T02:37:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:\n\n> 24c30e0b6 (wt-status: tolerate dangling marks, 2020-09-01) adds a test\n> that uses a BRE which breaks at least with OpenBSD's grep.\n>\n> switch to an ERE as it is done for similar checks and while at it, remove\n> the now obsolete test_i18ngrep call.\n\nThanks, obviously correct.\n\nI wonder if we can more automate detection of such a bug---it is\nunfortunate that it has become very hard to avoid GNUisms as\neverybody, even Windows folks, is more likely to be with GNU tools\nthan BSD tools X-<.\n\n>\n> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n> ---\n>  t/t7508-status.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t7508-status.sh b/t/t7508-status.sh\n> index 2b72451ba3..05c6c02435 100755\n> --- a/t/t7508-status.sh\n> +++ b/t/t7508-status.sh\n> @@ -882,7 +882,7 @@ test_expect_success 'status shows detached HEAD properly after checking out non-\n>  \tgit clone upstream downstream &&\n>  \tgit -C downstream checkout @{u} &&\n>  \tgit -C downstream status >actual &&\n> -\ttest_i18ngrep \"HEAD detached at [0-9a-f]\\\\+\" actual\n> +\tgrep -E \"HEAD detached at [0-9a-f]+\" actual\n>  '\n>  \n>  test_expect_success 'setup status submodule summary' '\n"}]}