{"thread":{"id":"56166","subject":"[PATCH] http.c: use error_errno(), not error() after fopen() failure","startedAt":"2021-07-27T00:07:40Z","lastAt":"2021-07-27T00:07:40Z","messageCount":1,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"431264","messageId":"patch-1.1-ad71faa6da-20210727T000657Z-avarab@gmail.com","threadId":"56166","inReplyTo":null,"subject":"[PATCH] http.c: use error_errno(), not error() after fopen() failure","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-07-27T00:07:33Z","receivedAt":"2021-07-27T00:07:40Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Improve the error reporting added in e929cd20bb3 (http.c: new\nfunctions for the http API, 2009-06-06) to emit strerror(), as fopen()\nis a failing system call we'll have a meaningful errno to report.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n http.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/http.c b/http.c\nindex 8119247149..f7940f1b5e 100644\n--- a/http.c\n+++ b/http.c\n@@ -2341,8 +2341,8 @@ struct http_pack_request *new_direct_http_pack_request(\n \tstrbuf_addf(&preq->tmpfile, \"%s.temp\", sha1_pack_name(packed_git_hash));\n \tpreq->packfile = fopen(preq->tmpfile.buf, \"a\");\n \tif (!preq->packfile) {\n-\t\terror(\"Unable to open local file %s for pack\",\n-\t\t      preq->tmpfile.buf);\n+\t\terror_errno(\"Unable to open local file %s for pack\",\n+\t\t\t    preq->tmpfile.buf);\n \t\tgoto abort;\n \t}\n \n-- \n2.32.0.988.g1a6a4b2c5f\n\n"}]}