{"thread":{"id":"56080","subject":"[PATCH] Replace \"stateless separator\" with \"response end\"","startedAt":"2021-07-09T02:27:35Z","lastAt":"2021-07-09T02:27:35Z","messageCount":1,"participants":["Denton Liu"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"429523","messageId":"9c834801c85d873738577a45c87d4404a23666d6.1625797617.git.liu.denton@gmail.com","threadId":"56080","inReplyTo":null,"subject":"[PATCH] Replace \"stateless separator\" with \"response end\"","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2021-07-09T02:27:22Z","receivedAt":"2021-07-09T02:27:35Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"In 0181b600a6 (pkt-line: define PACKET_READ_RESPONSE_END, 2020-05-19),\nthe Response End packet was defined for Git's network protocol. When the\npatch was sent, it included an oversight where the error messages\nreferenced \"stateless separator\", the work-in-progress name, over\n\"response end\", the final name chosen.\n\nCorrect these error messages by having them correctly reference\na \"response end\" packet.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n pkt-line.c    | 2 +-\n remote-curl.c | 2 +-\n serve.c       | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/pkt-line.c b/pkt-line.c\nindex 98304ce374..9f63eae2e6 100644\n--- a/pkt-line.c\n+++ b/pkt-line.c\n@@ -103,7 +103,7 @@ void packet_response_end(int fd)\n {\n \tpacket_trace(\"0002\", 4, 1);\n \tif (write_in_full(fd, \"0002\", 4) < 0)\n-\t\tdie_errno(_(\"unable to write stateless separator packet\"));\n+\t\tdie_errno(_(\"unable to write response end packet\"));\n }\n \n int packet_flush_gently(int fd)\ndiff --git a/remote-curl.c b/remote-curl.c\nindex 9d432c299a..6c320d5704 100644\n--- a/remote-curl.c\n+++ b/remote-curl.c\n@@ -653,7 +653,7 @@ static int rpc_read_from_out(struct rpc_state *rpc, int options,\n \t\t\tmemcpy(buf - 4, \"0000\", 4);\n \t\t\tbreak;\n \t\tcase PACKET_READ_RESPONSE_END:\n-\t\t\tdie(_(\"remote server sent stateless separator\"));\n+\t\t\tdie(_(\"remote server sent unexpected response end packet\"));\n \t\t}\n \t}\n \ndiff --git a/serve.c b/serve.c\nindex aa8209f147..f11c0e07c4 100644\n--- a/serve.c\n+++ b/serve.c\n@@ -258,7 +258,7 @@ static int process_request(void)\n \t\t\tstate = PROCESS_REQUEST_DONE;\n \t\t\tbreak;\n \t\tcase PACKET_READ_RESPONSE_END:\n-\t\t\tBUG(\"unexpected stateless separator packet\");\n+\t\t\tBUG(\"unexpected response end packet\");\n \t\t}\n \t}\n \n-- \n2.32.0.rc1.186.g3cb6fa43cd\n\n"}]}