{"thread":{"id":"55968","subject":"[GSoC] My Git Dev Blog - Week 5","startedAt":"2021-06-19T13:32:33Z","lastAt":"2021-06-21T06:28:51Z","messageCount":5,"participants":["Atharva Raykar","Christian Couder","Kaartic Sivaraam"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"427963","messageId":"D32894F5-FC76-4DD2-A2F6-E69AAE88C645@gmail.com","threadId":"55968","inReplyTo":null,"subject":"[GSoC] My Git Dev Blog - Week 5","fromName":"Atharva Raykar","fromEmail":"raykar.ath@gmail.com","sentAt":"2021-06-19T13:32:24Z","receivedAt":"2021-06-19T13:32:33Z","isPatch":false,"sender":{"key":"raykar.ath@gmail.com","avatar":"https://avatars.githubusercontent.com/u/24277692?v=4"},"body":"Here's the latest instalment of my weekly Git blog:\nhttp://atharvaraykar.me/gitnotes/week5\n\nA peek at what's inside:\n\n * The blog starts with a summary of all the relevant things\n that have happened so far in my time with Git, including\n the status of my submodule-related work.\n\n * A question I had about reading the index into memory\n (any kind of help would be appreciated!):\n http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking\n\n * Reflections, mostly as a note to myself and to people who\n might be in a similar position as me in the future.\n\nHave a great weekend :)\n\n---\nAtharva Raykar\nಅಥರ್ವ ರಾಯ್ಕರ್\nअथर्व रायकर\n\n"},{"id":"427969","messageId":"CAP8UFD2sXjRgn6FqOcBor=Q_PXmy+xL4mHmV7Qy_fSrc0q+O9w@mail.gmail.com","threadId":"55968","inReplyTo":"D32894F5-FC76-4DD2-A2F6-E69AAE88C645@gmail.com","subject":"Re: [GSoC] My Git Dev Blog - Week 5","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2021-06-20T05:52:18Z","receivedAt":"2021-06-20T05:52:42Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sat, Jun 19, 2021 at 3:32 PM Atharva Raykar wrote:\n>\n> Here's the latest instalment of my weekly Git blog:\n> http://atharvaraykar.me/gitnotes/week5\n\nGreat!\n\nJust a note about:\n\n> if (ps_matched[0]) {\n> if (!force)\n> die(_(\"'%s' already exists in the index\"), path);\n> else if (!S_ISGITLINK(active_cache[i]->ce_mode))\n\nThe \"else\" above is not needed.\n\n> die(_(\"'%s' already exists in the index \"\n> \"and is not a submodule\"), path);\n> break;\n> }\n\n\n\n> A peek at what's inside:\n>\n> * The blog starts with a summary of all the relevant things\n> that have happened so far in my time with Git, including\n> the status of my submodule-related work.\n>\n> * A question I had about reading the index into memory\n> (any kind of help would be appreciated!):\n> http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking\n>\n> * Reflections, mostly as a note to myself and to people who\n> might be in a similar position as me in the future.\n>\n> Have a great weekend :)\n>\n> ---\n> Atharva Raykar\n> ಅಥರ್ವ ರಾಯ್ಕರ್\n> अथर्व रायकर\n>\n"},{"id":"427992","messageId":"ac381db1-fb14-2a23-cfee-863840b89493@gmail.com","threadId":"55968","inReplyTo":"D32894F5-FC76-4DD2-A2F6-E69AAE88C645@gmail.com","subject":"Re: [GSoC] My Git Dev Blog - Week 5","fromName":"Kaartic Sivaraam","fromEmail":"kaartic.sivaraam@gmail.com","sentAt":"2021-06-20T19:16:32Z","receivedAt":"2021-06-20T19:16:39Z","isPatch":false,"sender":{"key":"kaartic.sivaraam@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12448084?v=4"},"body":"On 19/06/21 7:02 pm, Atharva Raykar wrote:\n> Here's the latest instalment of my weekly Git blog:\n> http://atharvaraykar.me/gitnotes/week5\n>\n\nNice blog.\n \n> A peek at what's inside:\n> \n> * The blog starts with a summary of all the relevant things\n> that have happened so far in my time with Git, including\n> the status of my submodule-related work.\n> \n> * A question I had about reading the index into memory\n> (any kind of help would be appreciated!):\n> http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking\n> \n\nI've tried to clarify this to an extent in a comment [1] on your branch.\n\nA few other things:\n\n> After Rafael and Eric commented on my patch, I forgot to CC them when\n> I rerolled. New contributors: please check your CC’s before hitting send!\n\nTo add to that, Cc-ing people in the e-mail of all the patches in the series\nand not just in the cover letter would be nice too. :) Of course, if you have\na specific reason to not do that, then it's fine.\n\n> And my other blooper was to forget signing off one of my patches. Oops.\n\nAre you aware of `format.signOff` [2] which could save you from issues\nlike these?\n\n\n[1]: https://github.com/tfidfwastaken/git/commit/3c46c108a195c42edaab939ab6dd6731e52aefc3#r52396546\n\n[2]: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff\n\n-- \nSivaraam\n"},{"id":"428018","messageId":"19DC5989-2AB9-4349-815E-631CC7AF0E91@gmail.com","threadId":"55968","inReplyTo":"CAP8UFD2sXjRgn6FqOcBor=Q_PXmy+xL4mHmV7Qy_fSrc0q+O9w@mail.gmail.com","subject":"Re: [GSoC] My Git Dev Blog - Week 5","fromName":"Atharva Raykar","fromEmail":"raykar.ath@gmail.com","sentAt":"2021-06-21T06:20:26Z","receivedAt":"2021-06-21T06:20:35Z","isPatch":false,"sender":{"key":"raykar.ath@gmail.com","avatar":"https://avatars.githubusercontent.com/u/24277692?v=4"},"body":"On 20-Jun-2021, at 11:22, Christian Couder wrote:\n> \n> On Sat, Jun 19, 2021 at 3:32 PM Atharva Raykar wrote:\n>> \n>> Here's the latest instalment of my weekly Git blog:\n>> http://atharvaraykar.me/gitnotes/week5\n> \n> Great!\n> \n> Just a note about:\n> \n>> if (ps_matched[0]) {\n>> if (!force)\n>> die(_(\"'%s' already exists in the index\"), path);\n>> else if (!S_ISGITLINK(active_cache[i]->ce_mode))\n> \n> The \"else\" above is not needed.\n\nNoted. Thanks!"},{"id":"428019","messageId":"9C21B26E-7A17-4BDC-8EF0-5D1A90BECF25@gmail.com","threadId":"55968","inReplyTo":"ac381db1-fb14-2a23-cfee-863840b89493@gmail.com","subject":"Re: [GSoC] My Git Dev Blog - Week 5","fromName":"Atharva Raykar","fromEmail":"raykar.ath@gmail.com","sentAt":"2021-06-21T06:28:46Z","receivedAt":"2021-06-21T06:28:51Z","isPatch":false,"sender":{"key":"raykar.ath@gmail.com","avatar":"https://avatars.githubusercontent.com/u/24277692?v=4"},"body":"On 21-Jun-2021, at 00:46, Kaartic Sivaraam wrote:\n> \n> On 19/06/21 7:02 pm, Atharva Raykar wrote:\n>> Here's the latest instalment of my weekly Git blog:\n>> http://atharvaraykar.me/gitnotes/week5\n>> \n> \n> Nice blog.\n> \n>> A peek at what's inside:\n>> * The blog starts with a summary of all the relevant things\n>> that have happened so far in my time with Git, including\n>> the status of my submodule-related work.\n>> * A question I had about reading the index into memory\n>> (any kind of help would be appreciated!):\n>> http://atharvaraykar.me/gitnotes/week5#some-challenges-with-the-changes-that-are-cooking\n> \n> I've tried to clarify this to an extent in a comment [1] on your branch.\n\nThanks, I'll have a look.\n\n> A few other things:\n> \n>> After Rafael and Eric commented on my patch, I forgot to CC them when\n>> I rerolled. New contributors: please check your CC’s before hitting send!\n> \n> To add to that, Cc-ing people in the e-mail of all the patches in the series\n> and not just in the cover letter would be nice too. :) Of course, if you have\n> a specific reason to not do that, then it's fine.\n\nOkay, I will remember to do this.\n\n>> And my other blooper was to forget signing off one of my patches. Oops.\n> \n> Are you aware of `format.signOff` [2] which could save you from issues\n> like these?\n\nThanks, this should have been in my config all along. Unfortunately,\nit won't be possible to automate adding the other trailers in my\npatches, unless Git learns to read my mind ;-)\n\n> \n> [1]: https://github.com/tfidfwastaken/git/commit/3c46c108a195c42edaab939ab6dd6731e52aefc3#r52396546\n> \n> [2]: https://git-scm.com/docs/git-config#Documentation/git-config.txt-formatsignOff\n> \n> -- \n> Sivaraam\n\n"}]}