{"thread":{"id":"55965","subject":"[PATCH] blame: fix typo in documentation","startedAt":"2021-06-18T22:11:11Z","lastAt":"2021-06-29T01:12:47Z","messageCount":16,"participants":["Andrei Rybak","Bagas Sanjaya","Felipe Contreras","Barret Rhoden","Carlo Marcelo Arenas Belón","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"427920","messageId":"20210618221104.42260-1-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":null,"subject":"[PATCH] blame: fix typo in documentation","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-18T22:11:04Z","receivedAt":"2021-06-18T22:11:11Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"As can be seen in files \"Documentation/blame-options.txt\" and\n\"builtin/blame.c\", the name of this configuration variable is\n\"blame.markUnblamableLines\".\n\nSigned-off-by: Andrei Rybak \n---\n Documentation/config/blame.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt\nindex 9468e8599c..4d047c1790 100644\n--- a/Documentation/config/blame.txt\n+++ b/Documentation/config/blame.txt\n@@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n \tfile names will reset the list of ignored revisions. This option will\n \tbe handled before the command line option `--ignore-revs-file`.\n \n-blame.markUnblamables::\n+blame.markUnblamableLines::\n \tMark lines that were changed by an ignored revision that we could not\n \tattribute to another commit with a '*' in the output of\n \tlinkgit:git-blame[1].\n-- \n2.32.0\n\n"},{"id":"427936","messageId":"8921ac50-e628-9a60-2a8d-1b8cc2a5a056@gmail.com","threadId":"55965","inReplyTo":"20210618221104.42260-1-rybak.a.v@gmail.com","subject":"Re: [PATCH] blame: fix typo in documentation","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-06-19T05:27:12Z","receivedAt":"2021-06-19T05:27:23Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Hi,\n\nOn 19/06/21 05.11, Andrei Rybak wrote:\n> As can be seen in files \"Documentation/blame-options.txt\" and\n> \"builtin/blame.c\", the name of this configuration variable is\n> \"blame.markUnblamableLines\".\n> \n> Signed-off-by: Andrei Rybak \n> ---\n> Documentation/config/blame.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt\n> index 9468e8599c..4d047c1790 100644\n> --- a/Documentation/config/blame.txt\n> +++ b/Documentation/config/blame.txt\n> @@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n> \tfile names will reset the list of ignored revisions. This option will\n> \tbe handled before the command line option `--ignore-revs-file`.\n> \n> -blame.markUnblamables::\n> +blame.markUnblamableLines::\n> \tMark lines that were changed by an ignored revision that we could not\n> \tattribute to another commit with a '*' in the output of\n> \tlinkgit:git-blame[1].\n> \n\nThat above is not typo fixing; that is correcting configuration variable \nname.\n\nPS: I have to download mbox of this thread and reply from it because I \ndidn't receive the thread on my Thunderbird, regardless of CCing Git ML.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"427960","messageId":"7cbbd59b-d5e3-4b96-a1ee-a242a7839028@gmail.com","threadId":"55965","inReplyTo":"8921ac50-e628-9a60-2a8d-1b8cc2a5a056@gmail.com","subject":"Re: [PATCH] blame: fix typo in documentation","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-19T11:12:41Z","receivedAt":"2021-06-19T11:12:46Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"On 19/06/2021 07:27, Bagas Sanjaya wrote:\n> On 19/06/21 05.11, Andrei Rybak wrote:\n>> As can be seen in files \"Documentation/blame-options.txt\" and\n>> \"builtin/blame.c\", the name of this configuration variable is\n>> \"blame.markUnblamableLines\".\n>>\n>> Signed-off-by: Andrei Rybak \n>> ---\n>>   Documentation/config/blame.txt | 2 +-\n>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/Documentation/config/blame.txt \n>> b/Documentation/config/blame.txt\n>> index 9468e8599c..4d047c1790 100644\n>> --- a/Documentation/config/blame.txt\n>> +++ b/Documentation/config/blame.txt\n>> @@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n>>       file names will reset the list of ignored revisions.  This \n>> option will\n>>       be handled before the command line option `--ignore-revs-file`.\n>> -blame.markUnblamables::\n>> +blame.markUnblamableLines::\n>>       Mark lines that were changed by an ignored revision that we \n>> could not\n>>       attribute to another commit with a '*' in the output of\n>>       linkgit:git-blame[1].\n>>\n> \n> That above is not typo fixing; that is correcting configuration variable \n> name.\n\nThis issue in documentation of git-blame was introduced when the config \noption\nwas added in commit 8934ac8c92 (blame: add config options for the output of\nignored or unblamable lines, 2019-05-15). It first appeared in v6 of that\nseries [1] where it was called blame.maskIgnoredUnblamables. In v7 [2] \nit got\nrenamed to blame.markUnblamableLines. v7 of that series is the first \ntime when\nincorrect blame.markUnblamables appears in Documentation/config/blame.txt.\n\nAs far as I can tell, it's most probable that Barret Rhoden just missed one\nplace when renaming this config option between v6 and v7.\n\nIf we shouldn't refer to this patch as typofix, how about\n\n\tblame: fix name of blame.markUnblamableLines in docs\n\nor\n\n\tblame: correct name of config option in docs\n\nor\n\n\tconfig/blame.txt: correct name of blame.markUnblamableLines\n\n?\n\n[1] https://lore.kernel.org/git/20190410162409.117264-5-brho@google.com/\n[2] https://lore.kernel.org/git/20190515214503.77162-6-brho@google.com/\n"},{"id":"427961","messageId":"e0199bd4-1585-061b-5dba-7da1232d9b43@gmail.com","threadId":"55965","inReplyTo":"7cbbd59b-d5e3-4b96-a1ee-a242a7839028@gmail.com","subject":"Re: [PATCH] blame: fix typo in documentation","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-06-19T11:20:50Z","receivedAt":"2021-06-19T11:21:11Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 19/06/21 18.12, Andrei Rybak wrote:\n> If we shouldn't refer to this patch as typofix, how about\n> \n>     blame: fix name of blame.markUnblamableLines in docs\n> \n> or\n> \n>     blame: correct name of config option in docs\n> \n> or\n> \n>     config/blame.txt: correct name of blame.markUnblamableLines\n> \n> ?\n> \n\nI prefer the second, because I prefer not to reveal actual config name \nso that readers must see the whole patch to see the name.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"427962","messageId":"20210619112912.76136-1-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":"20210618221104.42260-1-rybak.a.v@gmail.com","subject":"[PATCH v2] blame: correct name of config option in docs","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-19T11:29:12Z","receivedAt":"2021-06-19T11:29:21Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"As can be seen in files \"Documentation/blame-options.txt\" and\n\"builtin/blame.c\", the name of this configuration option is\n\"blame.markUnblamableLines\".\n\nSigned-off-by: Andrei Rybak \n---\n\nThanks to Bagas Sanjaya for review. Changes since v1:\n\n - tweaked commit message\n\nRange-diff:\n\n1: e32c298ee8 ! 1: 6ea64765e7 blame: fix typo in documentation\n @@ Metadata\n Author: Andrei Rybak \n \n ## Commit message ##\n - blame: fix typo in documentation\n + blame: correct name of config option in docs\n \n As can be seen in files \"Documentation/blame-options.txt\" and\n - \"builtin/blame.c\", the name of this configuration variable is\n + \"builtin/blame.c\", the name of this configuration option is\n \"blame.markUnblamableLines\".\n \n Signed-off-by: Andrei Rybak \n\n Documentation/config/blame.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt\nindex 9468e8599c..4d047c1790 100644\n--- a/Documentation/config/blame.txt\n+++ b/Documentation/config/blame.txt\n@@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n \tfile names will reset the list of ignored revisions. This option will\n \tbe handled before the command line option `--ignore-revs-file`.\n \n-blame.markUnblamables::\n+blame.markUnblamableLines::\n \tMark lines that were changed by an ignored revision that we could not\n \tattribute to another commit with a '*' in the output of\n \tlinkgit:git-blame[1].\n-- \n2.32.0\n\n"},{"id":"427965","messageId":"60ce29d9144e9_cc2b1208f8@natae.notmuch","threadId":"55965","inReplyTo":"8921ac50-e628-9a60-2a8d-1b8cc2a5a056@gmail.com","subject":"Re: [PATCH] blame: fix typo in documentation","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2021-06-19T17:31:05Z","receivedAt":"2021-06-19T17:31:10Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Bagas Sanjaya wrote:\n> That above is not typo fixing; that is correcting configuration variable \n> name.\n> \n> PS: I have to download mbox of this thread and reply from it because I \n> didn't receive the thread on my Thunderbird, regardless of CCing Git ML.\n\nThis is something I've noticed; I can always see mails on the archive,\nhowever, I don't receive them on my inbox until much later.\n\n-- \nFelipe Contreras\n"},{"id":"427971","messageId":"744f5e3e-808e-3ea1-9f3a-892c3936dcbd@gmail.com","threadId":"55965","inReplyTo":"20210619112912.76136-1-rybak.a.v@gmail.com","subject":"Re: [PATCH v2] blame: correct name of config option in docs","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-06-20T09:37:36Z","receivedAt":"2021-06-20T09:40:30Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 19/06/21 18.29, Andrei Rybak wrote:\n> As can be seen in files \"Documentation/blame-options.txt\" and\n> \"builtin/blame.c\", the name of this configuration option is\n> \"blame.markUnblamableLines\".\n> \n> Signed-off-by: Andrei Rybak \n> ---\n> \n> Thanks to Bagas Sanjaya for review. Changes since v1:\n> \n> - tweaked commit message\n> \n> Range-diff:\n> \n> 1: e32c298ee8 ! 1: 6ea64765e7 blame: fix typo in documentation\n> @@ Metadata\n> Author: Andrei Rybak \n> \n> ## Commit message ##\n> - blame: fix typo in documentation\n> + blame: correct name of config option in docs\n> \n> As can be seen in files \"Documentation/blame-options.txt\" and\n> - \"builtin/blame.c\", the name of this configuration variable is\n> + \"builtin/blame.c\", the name of this configuration option is\n> \"blame.markUnblamableLines\".\n> \n> Signed-off-by: Andrei Rybak \n> \n> Documentation/config/blame.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt\n> index 9468e8599c..4d047c1790 100644\n> --- a/Documentation/config/blame.txt\n> +++ b/Documentation/config/blame.txt\n> @@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n> \tfile names will reset the list of ignored revisions. This option will\n> \tbe handled before the command line option `--ignore-revs-file`.\n> \n> -blame.markUnblamables::\n> +blame.markUnblamableLines::\n> \tMark lines that were changed by an ignored revision that we could not\n> \tattribute to another commit with a '*' in the output of\n> \tlinkgit:git-blame[1].\n> \n\nLooks OK, thanks for contributing.\n\nReviewed-by: Bagas Sanjaya \n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"428075","messageId":"662bf3a8-4690-0a32-275e-7298ccbb09c0@google.com","threadId":"55965","inReplyTo":"744f5e3e-808e-3ea1-9f3a-892c3936dcbd@gmail.com","subject":"Re: [PATCH v2] blame: correct name of config option in docs","fromName":"Barret Rhoden","fromEmail":"brho@google.com","sentAt":"2021-06-21T16:57:25Z","receivedAt":"2021-06-21T17:06:42Z","isPatch":true,"sender":{"key":"brho@google.com","avatar":null},"body":"On 6/20/21 5:37 AM, Bagas Sanjaya wrote:\n> On 19/06/21 18.29, Andrei Rybak wrote:\n>> As can be seen in files \"Documentation/blame-options.txt\" and\n>> \"builtin/blame.c\", the name of this configuration option is\n>> \"blame.markUnblamableLines\".\n>>\n>> Signed-off-by: Andrei Rybak \n> Looks OK, thanks for contributing.\n> \n> Reviewed-by: Bagas Sanjaya \n> \n\nthanks for the fix. =)\n"},{"id":"428497","messageId":"20210625193851.2233114-1-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":"20210619112912.76136-1-rybak.a.v@gmail.com","subject":"[PATCH v3 0/3] Config option names typofixes","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-25T19:38:48Z","receivedAt":"2021-06-25T19:38:58Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"First patch in this series is the same as the v2 patch. Second patch fixes\nsimilar typos in mentions of config options in test messages. Third patch is\njust a fix for an unrelated typo I've stumbled upon.\n\nAndrei Rybak (3):\n blame: correct name of config option in docs\n t: fix typos in test messages\n git-worktree.txt: fix typo in example path\n\n Documentation/config/blame.txt | 2 +-\n Documentation/git-worktree.txt | 2 +-\n t/t4258-am-quoted-cr.sh | 2 +-\n t/t9001-send-email.sh | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)\n\n-- \n2.32.0\n\n"},{"id":"428498","messageId":"20210625193851.2233114-2-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":"20210625193851.2233114-1-rybak.a.v@gmail.com","subject":"[PATCH v3 1/3] blame: correct name of config option in docs","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-25T19:38:49Z","receivedAt":"2021-06-25T19:39:00Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"As can be seen in files \"Documentation/blame-options.txt\" and\n\"builtin/blame.c\", the name of this configuration option is\n\"blame.markUnblamableLines\".\n\nSigned-off-by: Andrei Rybak \nReviewed-by: Bagas Sanjaya \n---\n Documentation/config/blame.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/config/blame.txt b/Documentation/config/blame.txt\nindex 9468e8599c..4d047c1790 100644\n--- a/Documentation/config/blame.txt\n+++ b/Documentation/config/blame.txt\n@@ -27,7 +27,7 @@ blame.ignoreRevsFile::\n \tfile names will reset the list of ignored revisions. This option will\n \tbe handled before the command line option `--ignore-revs-file`.\n \n-blame.markUnblamables::\n+blame.markUnblamableLines::\n \tMark lines that were changed by an ignored revision that we could not\n \tattribute to another commit with a '*' in the output of\n \tlinkgit:git-blame[1].\n-- \n2.32.0\n\n"},{"id":"428499","messageId":"20210625193851.2233114-3-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":"20210625193851.2233114-1-rybak.a.v@gmail.com","subject":"[PATCH v3 2/3] t: fix typos in test messages","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-25T19:38:50Z","receivedAt":"2021-06-25T19:39:03Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"Both in t4258 and in t9001, the code of the tests following shows the\nproper name for the configuration variables. So use the correct names\nin the test messages as well.\n\nSigned-off-by: Andrei Rybak \n---\n t/t4258-am-quoted-cr.sh | 2 +-\n t/t9001-send-email.sh | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t4258-am-quoted-cr.sh b/t/t4258-am-quoted-cr.sh\nindex fb5071f914..201915b45a 100755\n--- a/t/t4258-am-quoted-cr.sh\n+++ b/t/t4258-am-quoted-cr.sh\n@@ -26,7 +26,7 @@ test_expect_success 'am --quoted-cr=strip' '\n \tgit diff --exit-code HEAD two\n '\n \n-test_expect_success 'am with config mailinfo.quotecr=strip' '\n+test_expect_success 'am with config mailinfo.quotedCr=strip' '\n \ttest_might_fail git am --abort &&\n \tgit reset --hard one &&\n \ttest_config mailinfo.quotedCr strip &&\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex c66d9190de..9ec7d75f0f 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -1839,7 +1839,7 @@ test_expect_success $PREREQ 'sendemail.aliasfiletype=mailrc' '\n \tgrep \"^!somebody@example\\.org!$\" commandline1\n '\n \n-test_expect_success $PREREQ 'sendemail.aliasfile=~/.mailrc' '\n+test_expect_success $PREREQ 'sendemail.aliasesfile=~/.mailrc' '\n \tclean_fake_sendmail &&\n \techo \"alias sbd someone@example.org\" >\"$HOME/.mailrc\" &&\n \tgit config --replace-all sendemail.aliasesfile \"~/.mailrc\" &&\n-- \n2.32.0\n\n"},{"id":"428501","messageId":"20210625193851.2233114-4-rybak.a.v@gmail.com","threadId":"55965","inReplyTo":"20210625193851.2233114-1-rybak.a.v@gmail.com","subject":"[PATCH v3 3/3] git-worktree.txt: fix typo in example path","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-25T19:38:51Z","receivedAt":"2021-06-25T19:39:49Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"Signed-off-by: Andrei Rybak \n---\n Documentation/git-worktree.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt\nindex f1bb1fa5f5..66e67e6cbf 100644\n--- a/Documentation/git-worktree.txt\n+++ b/Documentation/git-worktree.txt\n@@ -387,7 +387,7 @@ These annotations are:\n ------------\n $ git worktree list\n /path/to/linked-worktree abcd1234 [master]\n-/path/to/locked-worktreee acbd5678 (brancha) locked\n+/path/to/locked-worktree acbd5678 (brancha) locked\n /path/to/prunable-worktree 5678abc (detached HEAD) prunable\n ------------\n \n-- \n2.32.0\n\n"},{"id":"428512","messageId":"YNbQGoMP+wYZS0CA@carlos-mbp.lan","threadId":"55965","inReplyTo":"20210625193851.2233114-4-rybak.a.v@gmail.com","subject":"Re: [PATCH v3 3/3] git-worktree.txt: fix typo in example path","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2021-06-26T06:58:34Z","receivedAt":"2021-06-26T06:58:40Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"not sure if this patch really belongs in this specific patchset, but it\nmight be worth also fixing the same typo in grep as shown by :\n\n--- >8 ---\nSubject: grep: fix worktree mis spelling\n\n1d1729caeb (grep: replace grep_read_mutex by internal obj read lock,\n 2020-01-15) adds it as part of a comment\n\nfix it to the right spelling without the extra trailing 'e'.\n\ndiff --git a/grep.c b/grep.c\nindex 8f91af1cb0..f40c734565 100644\n--- a/grep.c\n+++ b/grep.c\n@@ -1510,7 +1510,7 @@ static int fill_textconv_grep(struct repository *r,\n \t *\n \t * TODO: allowing text conversion to run in parallel with object\n \t * reading operations might increase performance in the multithreaded\n-\t * non-worktreee git-grep with --textconv.\n+\t * non-worktree git-grep with --textconv.\n \t */\n \tobj_read_lock();\n \tsize = fill_textconv(r, driver, df, &buf);\n\nSigned-off-by: Carlo Marcelo Arenas Belón \n"},{"id":"428516","messageId":"8da4cb97-eb46-1ce5-ee74-fb1286d230aa@gmail.com","threadId":"55965","inReplyTo":"YNbQGoMP+wYZS0CA@carlos-mbp.lan","subject":"Re: [PATCH v3 3/3] git-worktree.txt: fix typo in example path","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2021-06-26T10:07:05Z","receivedAt":"2021-06-26T10:07:16Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"On 26/06/2021 08:58, Carlo Marcelo Arenas Belón wrote:\n> not sure if this patch really belongs in this specific patchset\n\nYes, third patch is unrelated to the first two.\n\n>, but it\n> might be worth also fixing the same typo in grep as shown by :\n> \n> --- >8 ---\n> Subject: grep: fix worktree mis spelling\n\ns/mis spelling/misspelling/\n\n> \n> 1d1729caeb (grep: replace grep_read_mutex by internal obj read lock,\n> 2020-01-15) adds it as part of a comment\n> \n> fix it to the right spelling without the extra trailing 'e'.\n> \n> diff --git a/grep.c b/grep.c\n> index 8f91af1cb0..f40c734565 100644\n> --- a/grep.c\n> +++ b/grep.c\n> @@ -1510,7 +1510,7 @@ static int fill_textconv_grep(struct repository *r,\n> \t *\n> \t * TODO: allowing text conversion to run in parallel with object\n> \t * reading operations might increase performance in the multithreaded\n> -\t * non-worktreee git-grep with --textconv.\n> +\t * non-worktree git-grep with --textconv.\n\nI deliberately skipped this typo, because it is in a TODO comment, which\nI thought isn't worth fixing. I probably should have mentioned that in\nthe patch I've sent.\n\n> \t */\n> \tobj_read_lock();\n> \tsize = fill_textconv(r, driver, df, &buf);\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón \n> \n\n"},{"id":"428519","messageId":"94a4dc6e-a8e7-d6d1-33c1-5a0dcfa9a4ca@gmail.com","threadId":"55965","inReplyTo":"20210625193851.2233114-1-rybak.a.v@gmail.com","subject":"Re: [PATCH v3 0/3] Config option names typofixes","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-06-26T11:50:06Z","receivedAt":"2021-06-26T11:50:17Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 26/06/21 02.38, Andrei Rybak wrote:\n> First patch in this series is the same as the v2 patch. Second patch fixes\n> similar typos in mentions of config options in test messages. Third patch is\n> just a fix for an unrelated typo I've stumbled upon.\n> \n> Andrei Rybak (3):\n> blame: correct name of config option in docs\n> t: fix typos in test messages\n> git-worktree.txt: fix typo in example path\n\nI suggest that the third patch should be on separate single patch, as it \nis unrelated to two other patches that correct config option names.\n\nThanks.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"428656","messageId":"xmqq5yxx4gol.fsf@gitster.g","threadId":"55965","inReplyTo":"8da4cb97-eb46-1ce5-ee74-fb1286d230aa@gmail.com","subject":"Re: [PATCH v3 3/3] git-worktree.txt: fix typo in example path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-06-29T01:12:42Z","receivedAt":"2021-06-29T01:12:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrei Rybak writes:\n\n> On 26/06/2021 08:58, Carlo Marcelo Arenas Belón wrote:\n>> not sure if this patch really belongs in this specific patchset\n>\n> Yes, third patch is unrelated to the first two.\n>\n>>, but it\n>> might be worth also fixing the same typo in grep as shown by :\n>> --- >8 ---\n>> Subject: grep: fix worktree mis spelling\n>\n> s/mis spelling/misspelling/\n>\n>> 1d1729caeb (grep: replace grep_read_mutex by internal obj read lock,\n>> 2020-01-15) adds it as part of a comment\n>> fix it to the right spelling without the extra trailing 'e'.\n>> diff --git a/grep.c b/grep.c\n>> index 8f91af1cb0..f40c734565 100644\n>> --- a/grep.c\n>> +++ b/grep.c\n>> @@ -1510,7 +1510,7 @@ static int fill_textconv_grep(struct repository *r,\n>> \t *\n>> \t * TODO: allowing text conversion to run in parallel with object\n>> \t * reading operations might increase performance in the multithreaded\n>> -\t * non-worktreee git-grep with --textconv.\n>> +\t * non-worktree git-grep with --textconv.\n>\n> I deliberately skipped this typo, because it is in a TODO comment, which\n> I thought isn't worth fixing. I probably should have mentioned that in\n> the patch I've sent.\n\nAll sound sensible. Will queue these three patches as-is.\n\nThanks.\n"}]}