{"thread":{"id":"55911","subject":"[PATCH resend] graph: improve grammar of \"invalid color\" error message","startedAt":"2021-06-12T18:43:20Z","lastAt":"2021-06-15T03:55:42Z","messageCount":3,"participants":["Alex Henrie","Bagas Sanjaya","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"427192","messageId":"20210612184144.6894-1-alexhenrie24@gmail.com","threadId":"55911","inReplyTo":null,"subject":"[PATCH resend] graph: improve grammar of \"invalid color\" error message","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-06-12T18:41:44Z","receivedAt":"2021-06-12T18:43:20Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Without the \"d\", it sounds like a command, not an error, and is liable\nto be translated incorrectly.\n\nSigned-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\nResending to make sure that this patch isn't forgotten.\n---\n graph.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/graph.c b/graph.c\nindex c128ad0cce..e3828eb8f2 100644\n--- a/graph.c\n+++ b/graph.c\n@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n \t\tif (!color_parse_mem(start, comma - start, color))\n \t\t\tstrvec_push(colors, color);\n \t\telse\n-\t\t\twarning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n+\t\t\twarning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n \t\t\t\t(int)(comma - start), start);\n \t\tstart = comma + 1;\n \t}\n-- \n2.31.1\n\n"},{"id":"427199","messageId":"21c43663-9d2a-0173-bd5c-4e2c9f95bc05@gmail.com","threadId":"55911","inReplyTo":"20210612184144.6894-1-alexhenrie24@gmail.com","subject":"Re: [PATCH resend] graph: improve grammar of \"invalid color\" error message","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-06-13T02:21:33Z","receivedAt":"2021-06-13T02:22:54Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Hi,\n\nOn 13/06/21 01.41, Alex Henrie wrote:\n> Without the \"d\", it sounds like a command, not an error, and is liable\n> to be translated incorrectly.\n> \n\ns/liable/prone/\n\n> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> ---\n> Resending to make sure that this patch isn't forgotten.\n> ---\n>   graph.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/graph.c b/graph.c\n> index c128ad0cce..e3828eb8f2 100644\n> --- a/graph.c\n> +++ b/graph.c\n> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n>   \t\tif (!color_parse_mem(start, comma - start, color))\n>   \t\t\tstrvec_push(colors, color);\n>   \t\telse\n> -\t\t\twarning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n> +\t\t\twarning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n>   \t\t\t\t(int)(comma - start), start);\n>   \t\tstart = comma + 1;\n>   \t}\n> \n\nWhy did you resend the patch?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"427409","messageId":"xmqqv96fwzlx.fsf@gitster.g","threadId":"55911","inReplyTo":"20210612184144.6894-1-alexhenrie24@gmail.com","subject":"Re: [PATCH resend] graph: improve grammar of \"invalid color\" error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-06-15T03:55:38Z","receivedAt":"2021-06-15T03:55:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Henrie <alexhenrie24@gmail.com> writes:\n\n> Without the \"d\", it sounds like a command, not an error, and is liable\n> to be translated incorrectly.\n>\n> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> ---\n> Resending to make sure that this patch isn't forgotten.\n\nThanks, will queue.\n\n> ---\n>  graph.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/graph.c b/graph.c\n> index c128ad0cce..e3828eb8f2 100644\n> --- a/graph.c\n> +++ b/graph.c\n> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n>  \t\tif (!color_parse_mem(start, comma - start, color))\n>  \t\t\tstrvec_push(colors, color);\n>  \t\telse\n> -\t\t\twarning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n> +\t\t\twarning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n>  \t\t\t\t(int)(comma - start), start);\n>  \t\tstart = comma + 1;\n>  \t}\n"}]}