{"thread":{"id":"5590","subject":"PATCH] gitweb: Fix warnings when PATH_INFO is empty","startedAt":"2006-09-17T12:09:44Z","lastAt":"2006-09-17T12:09:44Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"27073","messageId":"200609171409.44958.jnareb@gmail.com","threadId":"5590","inReplyTo":null,"subject":"PATCH] gitweb: Fix warnings when PATH_INFO is empty","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-09-17T12:09:44Z","receivedAt":"2006-09-17T12:09:44Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |   44 +++++++++++++++++++++++---------------------\n 1 files changed, 23 insertions(+), 21 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 1549f5f..689528e 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -274,29 +274,31 @@ if (defined $searchtext) {\n \n # now read PATH_INFO and use it as alternative to parameters\n our $path_info = $ENV{\"PATH_INFO\"};\n-$path_info =~ s|^/||;\n-$path_info =~ s|/$||;\n-if (validate_input($path_info) && !defined $project) {\n-\t$project = $path_info;\n-\twhile ($project && !-e \"$projectroot/$project/HEAD\") {\n-\t\t$project =~ s,/*[^/]*$,,;\n-\t}\n-\tif (defined $project) {\n-\t\t$project = undef unless $project;\n-\t}\n-\tif ($path_info =~ m,^$project/([^/]+)/(.+)$,) {\n-\t\t# we got \"project.git/branch/filename\"\n-\t\t$action    ||= \"blob_plain\";\n-\t\t$hash_base ||= $1;\n-\t\t$file_name ||= $2;\n-\t} elsif ($path_info =~ m,^$project/([^/]+)$,) {\n-\t\t# we got \"project.git/branch\"\n-\t\t$action ||= \"shortlog\";\n-\t\t$hash   ||= $1;\n+if ($path_info) {\n+\t$path_info =~ s|^/||;\n+\t$path_info =~ s|/$||;\n+\tif (validate_input($path_info) && !defined $project) {\n+\t\t$project = $path_info;\n+\t\twhile ($project && !-e \"$projectroot/$project/HEAD\") {\n+\t\t\t$project =~ s,/*[^/]*$,,;\n+\t\t}\n+\t\tif (defined $project) {\n+\t\t\t$project = undef unless $project;\n+\t\t}\n+\t\tif ($path_info =~ m,^$project/([^/]+)/(.+)$,) {\n+\t\t\t# we got \"project.git/branch/filename\"\n+\t\t\t$action    ||= \"blob_plain\";\n+\t\t\t$hash_base ||= $1;\n+\t\t\t$file_name ||= $2;\n+\t\t} elsif ($path_info =~ m,^$project/([^/]+)$,) {\n+\t\t\t# we got \"project.git/branch\"\n+\t\t\t$action ||= \"shortlog\";\n+\t\t\t$hash   ||= $1;\n+\t\t}\n \t}\n-}\n \n-$git_dir = \"$projectroot/$project\";\n+\t$git_dir = \"$projectroot/$project\";\n+}\n \n # dispatch\n my %actions = (\n-- \n1.4.2.1\n"}]}