{"thread":{"id":"55830","subject":"[PATCH] Remove warning that repack only works on non-promisor packfiles","startedAt":"2021-06-02T11:47:31Z","lastAt":"2021-06-04T01:03:49Z","messageCount":4,"participants":["Tao Klerks via GitGitGadget","Taylor Blau","Jonathan Tan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"426229","messageId":"pull.968.git.1622634446643.gitgitgadget@gmail.com","threadId":"55830","inReplyTo":null,"subject":"[PATCH] Remove warning that repack only works on non-promisor packfiles","fromName":"Tao Klerks via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-06-02T11:47:26Z","receivedAt":"2021-06-02T11:47:31Z","isPatch":true,"sender":{"key":"tao@klerks.biz","avatar":"https://avatars.githubusercontent.com/u/531704?v=4"},"body":"From: Tao Klerks \n\nThe git-repack doc clearly states that it *does* operate on promisor\npackfiles (in a separate partition), with \"-a\" specified. Presumably\nthe statements here are outdated, as they feature from the first doc\nin 2017 (and the repack support was added in 2018)\n\nSigned-off-by: Tao Klerks \n---\n Remove warning that repack only works on non-promisor packfiles\n \n The git-repack doc clearly states that it does operate on promisor\n packfiles (in a separate partition), with \"-a\" specified. Presumably the\n statements here are outdated, as they feature from the first doc in 2017\n (and the repack support was added in 2018)\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-968%2FTaoK%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-968/TaoK/patch-1-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/968\n\n Documentation/technical/partial-clone.txt | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)\n\ndiff --git a/Documentation/technical/partial-clone.txt b/Documentation/technical/partial-clone.txt\nindex 0780d30caca6..a0dd7c66f247 100644\n--- a/Documentation/technical/partial-clone.txt\n+++ b/Documentation/technical/partial-clone.txt\n@@ -242,8 +242,7 @@ remote in a specific order.\n repository and can satisfy all such requests.\n \n - Repack essentially treats promisor and non-promisor packfiles as 2\n- distinct partitions and does not mix them. Repack currently only works\n- on non-promisor packfiles and loose objects.\n+ distinct partitions and does not mix them.\n \n - Dynamic object fetching invokes fetch-pack once *for each item*\n because most algorithms stumble upon a missing object and need to have\n@@ -273,9 +272,6 @@ to use those promisor remotes in that order.\"\n The user might want to work in a triangular work flow with multiple\n promisor remotes that each have an incomplete view of the repository.\n \n-- Allow repack to work on promisor packfiles (while keeping them distinct\n- from non-promisor packfiles).\n-\n - Allow non-pathname-based filters to make use of packfile bitmaps (when\n present). This was just an omission during the initial implementation.\n \n\nbase-commit: ed125c4f07ba69c53c9f4d74ff395a4bf7854ea7\n-- \ngitgitgadget\n"},{"id":"426251","messageId":"YLffyI3rp9hSZZdy@nand.local","threadId":"55830","inReplyTo":"pull.968.git.1622634446643.gitgitgadget@gmail.com","subject":"Re: [PATCH] Remove warning that repack only works on non-promisor packfiles","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-06-02T19:45:12Z","receivedAt":"2021-06-02T19:45:17Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:\n> From: Tao Klerks \n>\n> The git-repack doc clearly states that it *does* operate on promisor\n> packfiles (in a separate partition), with \"-a\" specified. Presumably\n> the statements here are outdated, as they feature from the first doc\n> in 2017 (and the repack support was added in 2018)\n\nYeah, this all originally comes from Jeff H.'s design document in\n637fc4467e (partial-clone: design doc, 2017-12-14), but probably should\nhave been updated in 5d19e8138d (repack: repack promisor objects if -a\nor -A is set, 2018-08-08).\n\nThis looks good to me, but I'll add Jonathan Tan to the CC list to\ndouble check.\n\n Reviewed-by: Taylor Blau \n\nThanks,\nTaylor\n"},{"id":"426363","messageId":"20210603213558.453725-1-jonathantanmy@google.com","threadId":"55830","inReplyTo":"YLffyI3rp9hSZZdy@nand.local","subject":"Re: [PATCH] Remove warning that repack only works on non-promisor packfiles","fromName":"Jonathan Tan","fromEmail":"jonathantanmy@google.com","sentAt":"2021-06-03T21:35:58Z","receivedAt":"2021-06-03T21:37:18Z","isPatch":true,"sender":{"key":"jonathantanmy@fastmail.com","avatar":null},"body":"> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:\n> > From: Tao Klerks \n> >\n> > The git-repack doc clearly states that it *does* operate on promisor\n> > packfiles (in a separate partition), with \"-a\" specified. Presumably\n> > the statements here are outdated, as they feature from the first doc\n> > in 2017 (and the repack support was added in 2018)\n> \n> Yeah, this all originally comes from Jeff H.'s design document in\n> 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should\n> have been updated in 5d19e8138d (repack: repack promisor objects if -a\n> or -A is set, 2018-08-08).\n> \n> This looks good to me, but I'll add Jonathan Tan to the CC list to\n> double check.\n> \n> Reviewed-by: Taylor Blau \n\nThanks, Taylor. Yes, the patch is correct.\n"},{"id":"426372","messageId":"xmqqy2bq30gg.fsf@gitster.g","threadId":"55830","inReplyTo":"20210603213558.453725-1-jonathantanmy@google.com","subject":"Re: [PATCH] Remove warning that repack only works on non-promisor packfiles","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-06-04T01:03:43Z","receivedAt":"2021-06-04T01:03:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Tan writes:\n\n>> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:\n>> > From: Tao Klerks \n>> >\n>> > The git-repack doc clearly states that it *does* operate on promisor\n>> > packfiles (in a separate partition), with \"-a\" specified. Presumably\n>> > the statements here are outdated, as they feature from the first doc\n>> > in 2017 (and the repack support was added in 2018)\n>> \n>> Yeah, this all originally comes from Jeff H.'s design document in\n>> 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should\n>> have been updated in 5d19e8138d (repack: repack promisor objects if -a\n>> or -A is set, 2018-08-08).\n>> \n>> This looks good to me, but I'll add Jonathan Tan to the CC list to\n>> double check.\n>> \n>> Reviewed-by: Taylor Blau \n>\n> Thanks, Taylor. Yes, the patch is correct.\n\nThanks, all of you. Will queue.\n"}]}