{"thread":{"id":"55773","subject":"CI: 'seen' minus a few passes tests, eh, almost","startedAt":"2021-05-25T22:25:27Z","lastAt":"2021-06-02T11:59:55Z","messageCount":8,"participants":["Junio C Hamano","Taylor Blau","ZheNing Hu","Jeff King","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"425541","messageId":"xmqqcztecuy7.fsf@gitster.g","threadId":"55773","inReplyTo":null,"subject":"CI: 'seen' minus a few passes tests, eh, almost","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-25T22:25:20Z","receivedAt":"2021-05-25T22:25:27Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"It is sad that the tip of 'seen' rarely passes all tests these days.\n\nI excluded a few topics (chosen primarily by prejudice after looking\nat which tests failed earlier, without locating exactly where and\nwhy they fail) from 'seen' and the exclusion of them seems to have\nmade 'seen' finally pass the tests, eh, almost [*1*].\n\n82b1e47 is such a \"reduced\" 'seen' branch, and the CI run for it can\nbe found here:\n\n https://github.com/git/git/actions/runs/876448385\n\nExcluded are:\n\n ab/fsck-unexpected-type\n hn/reftable\n hn/refs-errno-cleanup\n zh/ref-filter-raw-data\n\nAny of these may not be broken by themselves, and it could be that\nthe tests may still pass even if one or some of them are merged on\ntop of 82b1e47 and the problem may manifest only when two or more of\nthese topics in certain combinations are merged to 'seen'.\n\nThe CI run for 'seen' with all these four topics merged back can be\nfound here:\n\n https://github.com/git/git/actions/runs/876534959\n\n\n[Footnote]\n\n*1* Except for \"git repack\" segfaults only in one of the tests:\n\n https://github.com/git/git/runs/2669668815?check_suite_focus=true#step:5:2846\n"},{"id":"425547","messageId":"xmqqzgwiawm4.fsf@gitster.g","threadId":"55773","inReplyTo":"xmqqcztecuy7.fsf@gitster.g","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-26T05:32:19Z","receivedAt":"2021-05-26T05:32:32Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> It is sad that the tip of 'seen' rarely passes all tests these days.\n>\n> I excluded a few topics (chosen primarily by prejudice after looking\n> at which tests failed earlier, without locating exactly where and\n> why they fail) from 'seen' and the exclusion of them seems to have\n> made 'seen' finally pass the tests, eh, almost [*1*].\n> ...\n> Excluded are:\n>\n> ab/fsck-unexpected-type\n> hn/reftable\n> hn/refs-errno-cleanup\n> zh/ref-filter-raw-data\n>\n> ...\n> [Footnote]\n>\n> *1* Except for \"git repack\" segfaults only in one of the tests:\n>\n> https://github.com/git/git/runs/2669668815?check_suite_focus=true#step:5:2846\n\nJust with a hunch, I further excluded tb/multi-pack-bitmaps from\n'seen', in addition to these four topics. It seems to pass the\nwhole test suite on both 32- and 64-bit build combinations.\n\n https://github.com/git/git/actions/runs/877225207\n\nExcept that vs-build sometimes fails to download the sdk, that is.\n\n"},{"id":"425548","messageId":"xmqqtumqauz3.fsf@gitster.g","threadId":"55773","inReplyTo":"xmqqzgwiawm4.fsf@gitster.g","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-26T06:07:44Z","receivedAt":"2021-05-26T06:07:51Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> It is sad that the tip of 'seen' rarely passes all tests these days.\n>>\n>> I excluded a few topics (chosen primarily by prejudice after looking\n>> at which tests failed earlier, without locating exactly where and\n>> why they fail) from 'seen' and the exclusion of them seems to have\n>> made 'seen' finally pass the tests, eh, almost [*1*].\n>> ...\n>> Excluded are:\n>>\n>> ab/fsck-unexpected-type\n>> hn/reftable\n>> hn/refs-errno-cleanup\n>> zh/ref-filter-raw-data\n>>\n>> ...\n>> [Footnote]\n>>\n>> *1* Except for \"git repack\" segfaults only in one of the tests:\n>>\n>> https://github.com/git/git/runs/2669668815?check_suite_focus=true#step:5:2846\n>\n> Just with a hunch, I further excluded tb/multi-pack-bitmaps from\n> 'seen', in addition to these four topics. It seems to pass the\n> whole test suite on both 32- and 64-bit build combinations.\n>\n> https://github.com/git/git/actions/runs/877225207\n>\n> Except that vs-build sometimes fails to download the sdk, that is.\n\nAnd https://github.com/git/git/actions/runs/877379968 tests the\nabove with hn/refs-errno-cleanup added back. The usual tests all\nseem to pass, even though vs-build fails to download the sdk.\n\n"},{"id":"425570","messageId":"YK5dubBcSwm9c4Ta@nand.local","threadId":"55773","inReplyTo":"xmqqzgwiawm4.fsf@gitster.g","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-05-26T14:39:53Z","receivedAt":"2021-05-26T14:39:58Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:\n> Just with a hunch, I further excluded tb/multi-pack-bitmaps from\n> 'seen', in addition to these four topics. It seems to pass the\n> whole test suite on both 32- and 64-bit build combinations.\n>\n> https://github.com/git/git/actions/runs/877225207\n>\n> Except that vs-build sometimes fails to download the sdk, that is.\n\nThanks for letting me know. I have accumulated a few local changes that\nI wanted to include in a reroll of that topic, but I was waiting on\nother reviewer eyes before sending it.\n\nI should be able to spend some more time pushing that topic forward\nafter the release. There are a few other patch series waiting on it from\nGitHub, too.\n\n\nThanks,\nTaylor\n"},{"id":"425571","messageId":"CAOLTT8SEmb6AXQPie7oYK8FruC2-9_yytojYYKxkVWLpks246A@mail.gmail.com","threadId":"55773","inReplyTo":"xmqqcztecuy7.fsf@gitster.g","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"ZheNing Hu","fromEmail":"adlternative@gmail.com","sentAt":"2021-05-26T15:02:45Z","receivedAt":"2021-05-26T15:03:02Z","isPatch":false,"sender":{"key":"adlternative@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58138461?v=4"},"body":"Junio C Hamano 于2021年5月26日周三 上午6:25写道：\n>\n> It is sad that the tip of 'seen' rarely passes all tests these days.\n>\n> I excluded a few topics (chosen primarily by prejudice after looking\n> at which tests failed earlier, without locating exactly where and\n> why they fail) from 'seen' and the exclusion of them seems to have\n> made 'seen' finally pass the tests, eh, almost [*1*].\n>\n> 82b1e47 is such a \"reduced\" 'seen' branch, and the CI run for it can\n> be found here:\n>\n> https://github.com/git/git/actions/runs/876448385\n>\n> Excluded are:\n>\n> ab/fsck-unexpected-type\n> hn/reftable\n> hn/refs-errno-cleanup\n> zh/ref-filter-raw-data\n>\n\nHi, Junio,\nI find my patch may cause some bug:\nI ignored those blobs with no content (objectsize == 0) before,\nSome things about \"--sort=contents:raw\" need to be changed.\nso please remove my patch from `seen`.\n\n--\nZheNing Hu\n"},{"id":"425573","messageId":"YK5u/qxFJUr9d/qS@coredump.intra.peff.net","threadId":"55773","inReplyTo":"YK5dubBcSwm9c4Ta@nand.local","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-05-26T15:53:34Z","receivedAt":"2021-05-26T15:53:44Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:\n\n> On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:\n> > Just with a hunch, I further excluded tb/multi-pack-bitmaps from\n> > 'seen', in addition to these four topics. It seems to pass the\n> > whole test suite on both 32- and 64-bit build combinations.\n> >\n> > https://github.com/git/git/actions/runs/877225207\n> >\n> > Except that vs-build sometimes fails to download the sdk, that is.\n> \n> Thanks for letting me know. I have accumulated a few local changes that\n> I wanted to include in a reroll of that topic, but I was waiting on\n> other reviewer eyes before sending it.\n\nI think the best thing in a situation like this (where reviewers like me\nhave been very slow to respond) is to repost it explaining the\nsituation. That makes it clear what the current state is, and brings it\nto the forefront of the list's attention (both reviewers you'd expect to\nlook at it, but people in general). Doing that too often can be\nobnoxious, of course, but after 6-8 weeks saying \"hey, this didn't get\nattention; can anybody take a look at it?\" is perfectly reasonable.\n\n> I should be able to spend some more time pushing that topic forward\n> after the release. There are a few other patch series waiting on it from\n> GitHub, too.\n\nBut yeah, waiting until after the release is good, to keep attention on\nregression fixes in the meantime.\n\n-Peff\n"},{"id":"425578","messageId":"YK5754JqOUXL/+/L@nand.local","threadId":"55773","inReplyTo":"YK5u/qxFJUr9d/qS@coredump.intra.peff.net","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2021-05-26T16:48:39Z","receivedAt":"2021-05-26T16:48:44Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, May 26, 2021 at 11:53:34AM -0400, Jeff King wrote:\n> On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:\n>\n> > On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:\n> > > Just with a hunch, I further excluded tb/multi-pack-bitmaps from\n> > > 'seen', in addition to these four topics. It seems to pass the\n> > > whole test suite on both 32- and 64-bit build combinations.\n> > >\n> > > https://github.com/git/git/actions/runs/877225207\n> > >\n> > > Except that vs-build sometimes fails to download the sdk, that is.\n> >\n> > Thanks for letting me know. I have accumulated a few local changes that\n> > I wanted to include in a reroll of that topic, but I was waiting on\n> > other reviewer eyes before sending it.\n>\n> I think the best thing in a situation like this (where reviewers like me\n> have been very slow to respond) is to repost it explaining the\n> situation. That makes it clear what the current state is, and brings it\n> to the forefront of the list's attention (both reviewers you'd expect to\n> look at it, but people in general). Doing that too often can be\n> obnoxious, of course, but after 6-8 weeks saying \"hey, this didn't get\n> attention; can anybody take a look at it?\" is perfectly reasonable.\n\nIndeed, but I had been putting even doing that off. I've had some\nsporadic time off in the last few months (as you know) and so usually by\nthe time that I'm back enough other stuff has accumulated that I don't\nfeel like adding more to the list by encouraging further review.\n\nSo the topic (and my participation on the list in general) has kind of\nlanguished, but I'm hoping that since things have mostly cooled down for\nme outside of work that I'll be able to participate and submit patches\nmore consistently.\n\nThanks,\nTaylor\n"},{"id":"426230","messageId":"nycvar.QRO.7.76.6.2106021358410.55@tvgsbejvaqbjf.bet","threadId":"55773","inReplyTo":"xmqqzgwiawm4.fsf@gitster.g","subject":"Re: CI: 'seen' minus a few passes tests, eh, almost","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2021-06-02T11:59:46Z","receivedAt":"2021-06-02T11:59:55Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Wed, 26 May 2021, Junio C Hamano wrote:\n\n> [CI failed, and was fixed...]\n>\n> Except that vs-build sometimes fails to download the sdk, that is.\n\nI have a patch series to help with that (at least a little bit), but I am\nholding it until after v2.32.0.\n\nCiao,\nDscho\n"}]}