{"thread":{"id":"55744","subject":"[PATCH] help: fix small typo in error message","startedAt":"2021-05-20T07:42:32Z","lastAt":"2021-05-20T22:53:17Z","messageCount":3,"participants":["Jean-Noël Avila","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"425057","messageId":"20210520074214.40903-1-jn.avila@free.fr","threadId":"55744","inReplyTo":null,"subject":"[PATCH] help: fix small typo in error message","fromName":"Jean-Noël Avila","fromEmail":"jn.avila@free.fr","sentAt":"2021-05-20T07:42:14Z","receivedAt":"2021-05-20T07:42:32Z","isPatch":true,"sender":{"key":"jn.avila@free.fr","avatar":"https://avatars.githubusercontent.com/u/156172?v=4"},"body":"Classic string concatenation while forgetting a space character.\n\nSigned-off-by: Jean-Noël Avila <jn.avila@free.fr>\n---\n list-objects-filter-options.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/list-objects-filter-options.c b/list-objects-filter-options.c\nindex 96a605c8ad..fd8d59f653 100644\n--- a/list-objects-filter-options.c\n+++ b/list-objects-filter-options.c\n@@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(\n \t} else if (skip_prefix(arg, \"object:type=\", &v0)) {\n \t\tint type = type_from_string_gently(v0, strlen(v0), 1);\n \t\tif (type < 0) {\n-\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is\"\n+\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is \"\n \t\t\t\t\t      \"not a valid object type\"), v0);\n \t\t\treturn 1;\n \t\t}\n-- \n2.31.0.rc2.1.gaceb20851f.dirty\n\n"},{"id":"425147","messageId":"YKbWZMTW2Evux1VR@google.com","threadId":"55744","inReplyTo":"20210520074214.40903-1-jn.avila@free.fr","subject":"Re: [PATCH] help: fix small typo in error message","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2021-05-20T21:36:36Z","receivedAt":"2021-05-20T21:36:41Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(cc: pks)\nJean-Noël Avila wrote:\n\n> Classic string concatenation while forgetting a space character.\n>\n> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>\n> ---\n[...]\n> -\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is\"\n> +\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is \"\n>  \t\t\t\t\t      \"not a valid object type\"), v0);\n\nGood catch!\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"},{"id":"425167","messageId":"xmqqbl95t3u4.fsf@gitster.g","threadId":"55744","inReplyTo":"20210520074214.40903-1-jn.avila@free.fr","subject":"Re: [PATCH] help: fix small typo in error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-20T22:53:07Z","receivedAt":"2021-05-20T22:53:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jean-Noël Avila <jn.avila@free.fr> writes:\n\n> Classic string concatenation while forgetting a space character.\n>\n> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>\n> ---\n>  list-objects-filter-options.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks.  This is a new message added in this round, so let's\nfast-track this fix down.\n\n\n\n> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c\n> index 96a605c8ad..fd8d59f653 100644\n> --- a/list-objects-filter-options.c\n> +++ b/list-objects-filter-options.c\n> @@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(\n>  \t} else if (skip_prefix(arg, \"object:type=\", &v0)) {\n>  \t\tint type = type_from_string_gently(v0, strlen(v0), 1);\n>  \t\tif (type < 0) {\n> -\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is\"\n> +\t\t\tstrbuf_addf(errbuf, _(\"'%s' for 'object:type=<type>' is \"\n>  \t\t\t\t\t      \"not a valid object type\"), v0);\n>  \t\t\treturn 1;\n>  \t\t}\n"}]}