{"thread":{"id":"5573","subject":"cg-commit -p -m ignores -p","startedAt":"2006-09-15T13:23:19Z","lastAt":"2006-09-24T17:48:37Z","messageCount":2,"participants":["Gerrit Pape","Petr Baudis"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"26971","messageId":"20060915132319.12117.qmail@7d60384c102e6d.315fe32.mid.smarden.org","threadId":"5573","inReplyTo":null,"subject":"cg-commit -p -m ignores -p","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2006-09-15T13:23:19Z","receivedAt":"2006-09-15T13:23:19Z","isPatch":false,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"Hi, please see http:/bugs.debian.org/387515 or below.  I agree that\nideally cg-commit should behave differently.\n\nThanks, Gerrit.\n\n----- Forwarded message from Andrew Suffield <asuffield@suffields.me.uk> -----\n\ncg-commit -p -m ignores the -p argument and silently commits. Yes,\nthis is documented, but it's still stupid behaviour; if the user had\nmeant that, they would have just used -m alone.\n\nAt the very least, it should abort with an error (on the basis that\nthe command makes no sense); more sensibly, it should create a log\nmessage with the given string and then spawn an editor (and then since\nthe user will probably exit without changing the file, the \"Abort or\ncommit?\" message would appear as per usual, which seems to me to be\nappropriate behaviour).\n\n\n----- End forwarded message -----\n"},{"id":"27569","messageId":"20060924174837.GX20017@pasky.or.cz","threadId":"5573","inReplyTo":"20060915132319.12117.qmail@7d60384c102e6d.315fe32.mid.smarden.org","subject":"Re: cg-commit -p -m ignores -p","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-09-24T17:48:37Z","receivedAt":"2006-09-24T17:48:37Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Sep 15, 2006 at 03:23:19PM CEST, I got a letter\nwhere Gerrit Pape <pape@smarden.org> said that...\n> Hi, please see http:/bugs.debian.org/387515 or below.  I agree that\n> ideally cg-commit should behave differently.\n> \n> Thanks, Gerrit.\n> \n> ----- Forwarded message from Andrew Suffield <asuffield@suffields.me.uk> -----\n> \n> cg-commit -p -m ignores the -p argument and silently commits. Yes,\n> this is documented, but it's still stupid behaviour; if the user had\n> meant that, they would have just used -m alone.\n> \n> At the very least, it should abort with an error (on the basis that\n> the command makes no sense); more sensibly, it should create a log\n> message with the given string and then spawn an editor (and then since\n> the user will probably exit without changing the file, the \"Abort or\n> commit?\" message would appear as per usual, which seems to me to be\n> appropriate behaviour).\n> \n> \n> ----- End forwarded message -----\n\nThanks, fixed by making cg-commit -p imply -e.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj\n$/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\nlK[d2%Sa2/d0$^Ixp\"|dc`;s/\\W//g;$_=pack('H*',/((..)*)$/)\n"}]}