{"thread":{"id":"55717","subject":"[PATCH] setup: split \"extensions found\" messages into singular and plural","startedAt":"2021-05-18T06:19:27Z","lastAt":"2021-05-18T08:27:19Z","messageCount":3,"participants":["Alex Henrie","Jeff King","Michal Suchánek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"424828","messageId":"20210518061917.57556-1-alexhenrie24@gmail.com","threadId":"55717","inReplyTo":null,"subject":"[PATCH] setup: split \"extensions found\" messages into singular and plural","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-18T06:19:17Z","receivedAt":"2021-05-18T06:19:27Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"It's easier to translate this way.\n\nSigned-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\n setup.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/setup.c b/setup.c\nindex 59e2facd9d..ead2f80cd8 100644\n--- a/setup.c\n+++ b/setup.c\n@@ -666,7 +666,9 @@ int verify_repository_format(const struct repository_format *format,\n \tif (format->version >= 1 && format->unknown_extensions.nr) {\n \t\tint i;\n \n-\t\tstrbuf_addstr(err, _(\"unknown repository extensions found:\"));\n+\t\tstrbuf_addstr(err, Q_(\"unknown repository extension found:\",\n+\t\t\t\t      \"unknown repository extensions found:\",\n+\t\t\t\t      format->unknown_extensions.nr));\n \n \t\tfor (i = 0; i < format->unknown_extensions.nr; i++)\n \t\t\tstrbuf_addf(err, \"\\n\\t%s\",\n@@ -678,7 +680,9 @@ int verify_repository_format(const struct repository_format *format,\n \t\tint i;\n \n \t\tstrbuf_addstr(err,\n-\t\t\t      _(\"repo version is 0, but v1-only extensions found:\"));\n+\t\t\t      Q_(\"repo version is 0, but v1-only extension found:\",\n+\t\t\t\t \"repo version is 0, but v1-only extensions found:\",\n+\t\t\t\t format->v1_only_extensions.nr));\n \n \t\tfor (i = 0; i < format->v1_only_extensions.nr; i++)\n \t\t\tstrbuf_addf(err, \"\\n\\t%s\",\n-- \n2.31.1\n\n"},{"id":"424832","messageId":"YKNe50TDMftkadYI@coredump.intra.peff.net","threadId":"55717","inReplyTo":"20210518061917.57556-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] setup: split \"extensions found\" messages into singular and plural","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-05-18T06:29:59Z","receivedAt":"2021-05-18T06:30:02Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, May 18, 2021 at 12:19:17AM -0600, Alex Henrie wrote:\n\n> It's easier to translate this way.\n\nMakes sense.\n\nI don't know about \"easier to translate\", since there are twice as many\nstrings now. But certainly what the user sees will be more grammatically\ncorrect. :)\n\n-Peff\n"},{"id":"424845","messageId":"20210518082715.GO8544@kitsune.suse.cz","threadId":"55717","inReplyTo":"YKNe50TDMftkadYI@coredump.intra.peff.net","subject":"Re: [PATCH] setup: split \"extensions found\" messages into singular and plural","fromName":"Michal Suchánek","fromEmail":"msuchanek@suse.de","sentAt":"2021-05-18T08:27:15Z","receivedAt":"2021-05-18T08:27:19Z","isPatch":true,"sender":{"key":"msuchanek@suse.de","avatar":"https://avatars.githubusercontent.com/u/787652?v=4"},"body":"On Tue, May 18, 2021 at 02:29:59AM -0400, Jeff King wrote:\n> On Tue, May 18, 2021 at 12:19:17AM -0600, Alex Henrie wrote:\n> \n> > It's easier to translate this way.\n> \n> Makes sense.\n> \n> I don't know about \"easier to translate\", since there are twice as many\n> strings now. But certainly what the user sees will be more grammatically\n> correct. :)\n\nNote that some languages may still have dual (that is 2 extensions is\ndifferent from both 1 and 3 and more extensions), and so on for 3 and 4,\nand in some languages 21 (and 31 but not necessarily 11) extensions may\nbe singular again.\n\nKind of reminds me of\nhttps://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/\n\nThanks\n\nMichal\n"}]}