{"thread":{"id":"55705","subject":"[PATCH] stash: don't translate literal commands","startedAt":"2021-05-16T21:58:29Z","lastAt":"2021-05-18T06:08:28Z","messageCount":3,"participants":["Alex Henrie","Derrick Stolee"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"424692","messageId":"20210516215704.32440-1-alexhenrie24@gmail.com","threadId":"55705","inReplyTo":null,"subject":"[PATCH] stash: don't translate literal commands","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-16T21:57:04Z","receivedAt":"2021-05-16T21:58:29Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\n builtin/stash.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/stash.c b/builtin/stash.c\nindex d68ed784d2..075bcf6ee5 100644\n--- a/builtin/stash.c\n+++ b/builtin/stash.c\n@@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {\n \tN_(\"git stash drop [-q|--quiet] [<stash>]\"),\n \tN_(\"git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]\"),\n \tN_(\"git stash branch <branchname> [<stash>]\"),\n-\tN_(\"git stash clear\"),\n+\t\"git stash clear\",\n \tN_(\"git stash [push [-p|--patch] [-k|--[no-]keep-index] [-q|--quiet]\\n\"\n \t   \"          [-u|--include-untracked] [-a|--all] [-m|--message <message>]\\n\"\n \t   \"          [--pathspec-from-file=<file> [--pathspec-file-nul]]\\n\"\n@@ -67,7 +67,7 @@ static const char * const git_stash_branch_usage[] = {\n };\n \n static const char * const git_stash_clear_usage[] = {\n-\tN_(\"git stash clear\"),\n+\t\"git stash clear\",\n \tNULL\n };\n \n-- \n2.31.1\n\n"},{"id":"424762","messageId":"91d3d4e7-a04f-3fc4-a97b-90af02b20ed5@gmail.com","threadId":"55705","inReplyTo":"20210516215704.32440-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] stash: don't translate literal commands","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2021-05-17T16:48:33Z","receivedAt":"2021-05-17T16:51:29Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 5/16/2021 5:57 PM, Alex Henrie wrote:\n> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> ---\n>  builtin/stash.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/builtin/stash.c b/builtin/stash.c\n> index d68ed784d2..075bcf6ee5 100644\n> --- a/builtin/stash.c\n> +++ b/builtin/stash.c\n> @@ -26,7 +26,7 @@ static const char * const git_stash_usage[] = {\n>  \tN_(\"git stash drop [-q|--quiet] [<stash>]\"),\n>  \tN_(\"git stash ( pop | apply ) [--index] [-q|--quiet] [<stash>]\"),\n>  \tN_(\"git stash branch <branchname> [<stash>]\"),\n> -\tN_(\"git stash clear\"),\n> +\t\"git stash clear\",\n\nI immediately saw the commands above and wondered why you are\nnot removing them from being translated. My guess is that the\n\"<stash>\" strings are the bits that are interesting to\ntranslate. Perhaps add some description in your commit message\nas to why you are drawing the line here?\n\n>  static const char * const git_stash_clear_usage[] = {\n> -\tN_(\"git stash clear\"),\n> +\t\"git stash clear\",\n>  \tNULL\n>  };\n\nAre there other instances in builtin/*.c? If not, then it\nwould be nice to say so. Otherwise, it would be good to fix\nthem, while you are here.\n\nThanks,\n-Stolee\n"},{"id":"424826","messageId":"CAMMLpeS-Gb1QPZaUQsafy-rpRuDi4-hVpJ8JO-vu2SaXTZyqGA@mail.gmail.com","threadId":"55705","inReplyTo":"91d3d4e7-a04f-3fc4-a97b-90af02b20ed5@gmail.com","subject":"Re: [PATCH] stash: don't translate literal commands","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-18T06:08:12Z","receivedAt":"2021-05-18T06:08:28Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"On Mon, May 17, 2021 at 10:48 AM Derrick Stolee <stolee@gmail.com> wrote:\n>\n> On 5/16/2021 5:57 PM, Alex Henrie wrote:\n>\n> >  static const char * const git_stash_clear_usage[] = {\n> > -     N_(\"git stash clear\"),\n> > +     \"git stash clear\",\n> >       NULL\n> >  };\n>\n> Are there other instances in builtin/*.c? If not, then it\n> would be nice to say so. Otherwise, it would be good to fix\n> them, while you are here.\n\nI reviewed all of the translatable strings and only found this problem\nin graph.c and builtin/stash.c.\n\n-Alex\n"}]}