{"thread":{"id":"5567","subject":"stgit: cannot push a patch - Python trace dump","startedAt":"2006-09-15T05:07:48Z","lastAt":"2006-09-15T14:33:37Z","messageCount":4,"participants":["Auke Kok","Catalin Marinas"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"26944","messageId":"450A3524.5040403@intel.com","threadId":"5567","inReplyTo":null,"subject":"stgit: cannot push a patch - Python trace dump","fromName":"Auke Kok","fromEmail":"auke-jan.h.kok@intel.com","sentAt":"2006-09-15T05:07:48Z","receivedAt":"2006-09-15T05:07:48Z","isPatch":false,"sender":{"key":"auke-jan.h.kok@intel.com","avatar":null},"body":"\nHi all,\n\nI'm preparing patches for upstream and am haunted by an apparent patch breaking\nstg. The problem appears to be one or more of my patches breaking a push:\n\n$ stg push\nTraceback (most recent call last):\n   File \"/usr/bin/stg\", line 43, in ?\n     main()\n   File \"/usr/lib/python2.4/site-packages/stgit/main.py\", line 255, in main\n     command.func(parser, options, args)\n   File \"/usr/lib/python2.4/site-packages/stgit/commands/push.py\", line 101, in\nfunc\n     push_patches(patches, options.merged)\n   File \"/usr/lib/python2.4/site-packages/stgit/commands/common.py\", line 160,\nin push_patches\n     forwarded = crt_series.forward_patches(patches)\n   File \"/usr/lib/python2.4/site-packages/stgit/stack.py\", line 789, in\nforward_patches\n     committer_email = committer_email)\n   File \"/usr/lib/python2.4/site-packages/stgit/git.py\", line 439, in commit\n     if message[-1:] != '\\n':\nTypeError: unsubscriptable object\n\n\nI've been abusing stg by leaving the commit messages empty so I assume that\nthat's the cause here, or related to the problem.\n\nThis happens with today's stg as well as stg-0.10\n\nAfter scraping all my patches out manually and adding meaningfull (non-empty) \ncommit messages I seem to be able to push and pop them all again.\n\nCheers,\n\nAuke\n"},{"id":"26953","messageId":"tnxwt855wvr.fsf@arm.com","threadId":"5567","inReplyTo":"450A3524.5040403@intel.com","subject":"Re: stgit: cannot push a patch - Python trace dump","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@arm.com","sentAt":"2006-09-15T08:58:48Z","receivedAt":"2006-09-15T08:58:48Z","isPatch":false,"sender":{"key":"catalin.marinas@arm.com","avatar":null},"body":"Auke Kok <auke-jan.h.kok@intel.com> wrote:\n> I'm preparing patches for upstream and am haunted by an apparent\n> patch breaking stg. The problem appears to be one or more of my\n> patches breaking a push:\n[...]\n> I've been abusing stg by leaving the commit messages empty so I\n> assume that that's the cause here, or related to the problem.\n\nThanks, I fixed StGIT to cope with this and I'll update the repository\nand snapshot tonight (which, BTW, will contain the initial support for\npatch history tracking).\n\n-- \nCatalin\n"},{"id":"26972","messageId":"450AB81F.2090305@intel.com","threadId":"5567","inReplyTo":"tnxwt855wvr.fsf@arm.com","subject":"Re: stgit: cannot push a patch - Python trace dump","fromName":"Auke Kok","fromEmail":"auke-jan.h.kok@intel.com","sentAt":"2006-09-15T14:26:39Z","receivedAt":"2006-09-15T14:26:39Z","isPatch":false,"sender":{"key":"auke-jan.h.kok@intel.com","avatar":null},"body":"Catalin Marinas wrote:\n> Auke Kok <auke-jan.h.kok@intel.com> wrote:\n>> I'm preparing patches for upstream and am haunted by an apparent\n>> patch breaking stg. The problem appears to be one or more of my\n>> patches breaking a push:\n> [...]\n>> I've been abusing stg by leaving the commit messages empty so I\n>> assume that that's the cause here, or related to the problem.\n> \n> Thanks, I fixed StGIT to cope with this and I'll update the repository\n> and snapshot tonight (which, BTW, will contain the initial support for\n> patch history tracking).\n\nawesome and awesome, allthough I have no idea what that (patch history \ntracking) is about :)\n\nAuke\n"},{"id":"26973","messageId":"b0943d9e0609150733v6cbe465esfd8d2b598c496768@mail.gmail.com","threadId":"5567","inReplyTo":"450AB81F.2090305@intel.com","subject":"Re: stgit: cannot push a patch - Python trace dump","fromName":"Catalin Marinas","fromEmail":"catalin.marinas@gmail.com","sentAt":"2006-09-15T14:33:37Z","receivedAt":"2006-09-15T14:33:37Z","isPatch":false,"sender":{"key":"catalin.marinas@gmail.com","avatar":null},"body":"On 15/09/06, Auke Kok <auke-jan.h.kok@intel.com> wrote:\n> Catalin Marinas wrote:\n> > Thanks, I fixed StGIT to cope with this and I'll update the repository\n> > and snapshot tonight (which, BTW, will contain the initial support for\n> > patch history tracking).\n>\n> awesome and awesome, allthough I have no idea what that (patch history\n> tracking) is about :)\n\nIt keeps the history of all the patch modifications (like refresh,\npush) so that you can get previous versions if something went wrong.\nIt's like having many small commits reflecting the changes to a patch.\nThese commits are totally separate from the main patch commit (so that\nan StGIT repository is still compatible with GIT) but you can access\nthem with \"stg log [--graphical] <patch>\". The --graphical option will\nautomatically invoke gitk.\n\n-- \nCatalin\n"}]}