{"thread":{"id":"55653","subject":"[PATCH] graph: improve grammar of \"invalid color\" error message","startedAt":"2021-05-09T21:23:05Z","lastAt":"2021-05-10T06:10:52Z","messageCount":4,"participants":["Alex Henrie","Eric Sunshine","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"423978","messageId":"20210509212220.29557-1-alexhenrie24@gmail.com","threadId":"55653","inReplyTo":null,"subject":"[PATCH] graph: improve grammar of \"invalid color\" error message","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-09T21:22:20Z","receivedAt":"2021-05-09T21:23:05Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Without the \"d\", it sounds like a command, not an error, and is liable\nto be translated incorrectly.\n\nSigned-off-by: Alex Henrie <alexhenrie24@gmail.com>\n---\n graph.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/graph.c b/graph.c\nindex c128ad0cce..e3828eb8f2 100644\n--- a/graph.c\n+++ b/graph.c\n@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n \t\tif (!color_parse_mem(start, comma - start, color))\n \t\t\tstrvec_push(colors, color);\n \t\telse\n-\t\t\twarning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n+\t\t\twarning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n \t\t\t\t(int)(comma - start), start);\n \t\tstart = comma + 1;\n \t}\n-- \n2.31.1\n\n"},{"id":"423982","messageId":"CAPig+cTm7rW7V2DasW2XTArHAY_91rxxm5QaF31U8rB1ZLXOvQ@mail.gmail.com","threadId":"55653","inReplyTo":"20210509212220.29557-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] graph: improve grammar of \"invalid color\" error message","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2021-05-09T22:02:51Z","receivedAt":"2021-05-09T22:11:17Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, May 9, 2021 at 5:23 PM Alex Henrie <alexhenrie24@gmail.com> wrote:\n> Without the \"d\", it sounds like a command, not an error, and is liable\n> to be translated incorrectly.\n>\n> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> ---\n> diff --git a/graph.c b/graph.c\n> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n> -                       warning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n> +                       warning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n\nAnother possibility: \"ignoring invalid color ... in ...\"\n\nEven better: \"invalid color ... in ...\"\n"},{"id":"423985","messageId":"CAMMLpeRFjHNCUqzRhJZDuUA_CxsNvR-gn4-Mb6kmNQSZ4L8y6g@mail.gmail.com","threadId":"55653","inReplyTo":"CAPig+cTm7rW7V2DasW2XTArHAY_91rxxm5QaF31U8rB1ZLXOvQ@mail.gmail.com","subject":"Re: [PATCH] graph: improve grammar of \"invalid color\" error message","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2021-05-09T23:06:49Z","receivedAt":"2021-05-09T23:07:04Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"On Sun, May 9, 2021 at 4:03 PM Eric Sunshine <sunshine@sunshineco.com> wrote:\n>\n> On Sun, May 9, 2021 at 5:23 PM Alex Henrie <alexhenrie24@gmail.com> wrote:\n> > Without the \"d\", it sounds like a command, not an error, and is liable\n> > to be translated incorrectly.\n> >\n> > Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n> > ---\n> > diff --git a/graph.c b/graph.c\n> > @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n> > -                       warning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n> > +                       warning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n>\n> Another possibility: \"ignoring invalid color ... in ...\"\n>\n> Even better: \"invalid color ... in ...\"\n\nAny of those would be fine. I don't have a strong opinion.\n\n-Alex\n"},{"id":"424001","messageId":"xmqqy2cnqftm.fsf@gitster.g","threadId":"55653","inReplyTo":"CAPig+cTm7rW7V2DasW2XTArHAY_91rxxm5QaF31U8rB1ZLXOvQ@mail.gmail.com","subject":"Re: [PATCH] graph: improve grammar of \"invalid color\" error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-10T06:10:45Z","receivedAt":"2021-05-10T06:10:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine <sunshine@sunshineco.com> writes:\n\n> On Sun, May 9, 2021 at 5:23 PM Alex Henrie <alexhenrie24@gmail.com> wrote:\n>> Without the \"d\", it sounds like a command, not an error, and is liable\n>> to be translated incorrectly.\n>>\n>> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>\n>> ---\n>> diff --git a/graph.c b/graph.c\n>> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)\n>> -                       warning(_(\"ignore invalid color '%.*s' in log.graphColors\"),\n>> +                       warning(_(\"ignored invalid color '%.*s' in log.graphColors\"),\n>\n> Another possibility: \"ignoring invalid color ... in ...\"\n>\n> Even better: \"invalid color ... in ...\"\n\nThe last one, if it does not say what we did to that invalid thing,\nis not as helpful as Alex's or your \"another possibility\".\n\nBetweein \"ignored\" vs \"ignoring\", I do not have a preference, but\nwhichever one is more prevalent in our existing messages should be\nused, I would think.\n\nThanks.\n"}]}