{"thread":{"id":"55651","subject":"[PATCH 0/2] minor doc fixes","startedAt":"2021-05-09T09:10:39Z","lastAt":"2021-05-10T04:14:41Z","messageCount":6,"participants":["Martin Ågren","ZheNing Hu","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"423960","messageId":"cover.1620551314.git.martin.agren@gmail.com","threadId":"55651","inReplyTo":null,"subject":"[PATCH 0/2] minor doc fixes","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2021-05-09T09:09:58Z","receivedAt":"2021-05-09T09:10:39Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Two small things I noticed while going through the doc-diff between\nv2.31.0 and master (\"The fourteenth batch\").\n\nMartin Ågren (2):\n git-repack.txt: remove spurious \")\"\n pretty-formats.txt: add missing space\n\n Documentation/git-repack.txt | 2 +-\n Documentation/pretty-formats.txt | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n-- \n2.31.1.751.gd2f1c929bd\n\n"},{"id":"423961","messageId":"8adf03f456c756188863a8258f3867c389958a52.1620551314.git.martin.agren@gmail.com","threadId":"55651","inReplyTo":"cover.1620551314.git.martin.agren@gmail.com","subject":"[PATCH 1/2] git-repack.txt: remove spurious \")\"","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2021-05-09T09:09:59Z","receivedAt":"2021-05-09T09:10:48Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Drop the \")\" at the end of this paragraph. There's a parenthetical\nremark in this paragraph, but it's been closed on the line above.\n\nSigned-off-by: Martin Ågren \n---\n Documentation/git-repack.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-repack.txt b/Documentation/git-repack.txt\nindex 317d63cf0d..ef310f362e 100644\n--- a/Documentation/git-repack.txt\n+++ b/Documentation/git-repack.txt\n@@ -186,7 +186,7 @@ When `--unpacked` is specified, loose objects are implicitly included in\n this \"roll-up\", without respect to their reachability. This is subject\n to change in the future. This option (implying a drastically different\n repack mode) is not guaranteed to work with all other combinations of\n-option to `git repack`).\n+option to `git repack`.\n \n CONFIGURATION\n -------------\n-- \n2.31.1.751.gd2f1c929bd\n\n"},{"id":"423962","messageId":"3d06c3beee0299db369f1dd859b092d529bd6846.1620551314.git.martin.agren@gmail.com","threadId":"55651","inReplyTo":"cover.1620551314.git.martin.agren@gmail.com","subject":"[PATCH 2/2] pretty-formats.txt: add missing space","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2021-05-09T09:10:00Z","receivedAt":"2021-05-09T09:10:49Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"The description of \"%ch\" is missing a space after \"human style\", before\nthe parenthetical remark. This description was introduced in b722d4560e\n(\"pretty: provide human date format\", 2021-04-25). That commit also\nadded \"%ah\", which does have the space already.\n\nSigned-off-by: Martin Ågren \n---\n Documentation/pretty-formats.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\nindex cd697f508c..58bb279528 100644\n--- a/Documentation/pretty-formats.txt\n+++ b/Documentation/pretty-formats.txt\n@@ -208,7 +208,7 @@ The placeholders are:\n '%ci':: committer date, ISO 8601-like format\n '%cI':: committer date, strict ISO 8601 format\n '%cs':: committer date, short format (`YYYY-MM-DD`)\n-'%ch':: committer date, human style(like the `--date=human` option of\n+'%ch':: committer date, human style (like the `--date=human` option of\n \tlinkgit:git-rev-list[1])\n '%d':: ref names, like the --decorate option of linkgit:git-log[1]\n '%D':: ref names without the \" (\", \")\" wrapping.\n-- \n2.31.1.751.gd2f1c929bd\n\n"},{"id":"423965","messageId":"CAOLTT8R2ACJtcL7esLd8AiSu22Wn2hrdVTwub-HXc-eT_U2-+w@mail.gmail.com","threadId":"55651","inReplyTo":"3d06c3beee0299db369f1dd859b092d529bd6846.1620551314.git.martin.agren@gmail.com","subject":"Re: [PATCH 2/2] pretty-formats.txt: add missing space","fromName":"ZheNing Hu","fromEmail":"adlternative@gmail.com","sentAt":"2021-05-09T14:13:34Z","receivedAt":"2021-05-09T14:13:48Z","isPatch":true,"sender":{"key":"adlternative@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58138461?v=4"},"body":"Martin Ågren 于2021年5月9日周日 下午5:10写道：\n>\n> The description of \"%ch\" is missing a space after \"human style\", before\n> the parenthetical remark. This description was introduced in b722d4560e\n> (\"pretty: provide human date format\", 2021-04-25). That commit also\n> added \"%ah\", which does have the space already.\n>\n> Signed-off-by: Martin Ågren \n> ---\n> Documentation/pretty-formats.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index cd697f508c..58bb279528 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -208,7 +208,7 @@ The placeholders are:\n> '%ci':: committer date, ISO 8601-like format\n> '%cI':: committer date, strict ISO 8601 format\n> '%cs':: committer date, short format (`YYYY-MM-DD`)\n> -'%ch':: committer date, human style(like the `--date=human` option of\n> +'%ch':: committer date, human style (like the `--date=human` option of\n> linkgit:git-rev-list[1])\n> '%d':: ref names, like the --decorate option of linkgit:git-log[1]\n> '%D':: ref names without the \" (\", \")\" wrapping.\n> --\n> 2.31.1.751.gd2f1c929bd\n>\n\nSorry, but in here:[1], I have fixed this space missing error.\n\nJunio, this patch have not been merged to master?\n\n[1]: https://lore.kernel.org/git/pull.939.v4.git.1620056221874.gitgitgadget@gmail.com/\n"},{"id":"423966","messageId":"CAN0heSqi9v3dGgGFSGB7J-17MJj9jOvMwC6x7pW1bRGwra5N2g@mail.gmail.com","threadId":"55651","inReplyTo":"CAOLTT8R2ACJtcL7esLd8AiSu22Wn2hrdVTwub-HXc-eT_U2-+w@mail.gmail.com","subject":"Re: [PATCH 2/2] pretty-formats.txt: add missing space","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2021-05-09T15:27:55Z","receivedAt":"2021-05-09T15:28:10Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"On Sun, 9 May 2021 at 16:13, ZheNing Hu wrote:\n>\n> Martin Ågren 于2021年5月9日周日 下午5:10写道：\n> >\n> > The description of \"%ch\" is missing a space after \"human style\", before\n> > the parenthetical remark. This description was introduced in b722d4560e\n> > (\"pretty: provide human date format\", 2021-04-25). That commit also\n> > added \"%ah\", which does have the space already.\n\n> > --- a/Documentation/pretty-formats.txt\n> > +++ b/Documentation/pretty-formats.txt\n> > @@ -208,7 +208,7 @@ The placeholders are:\n> > '%ci':: committer date, ISO 8601-like format\n> > '%cI':: committer date, strict ISO 8601 format\n> > '%cs':: committer date, short format (`YYYY-MM-DD`)\n> > -'%ch':: committer date, human style(like the `--date=human` option of\n> > +'%ch':: committer date, human style (like the `--date=human` option of\n> > linkgit:git-rev-list[1])\n\n> Sorry, but in here:[1], I have fixed this space missing error.\n>\n> Junio, this patch have not been merged to master?\n>\n> [1]: https://lore.kernel.org/git/pull.939.v4.git.1620056221874.gitgitgadget@gmail.com/\n\nAh, thanks for the pointer. It looks like this was merged to \"next\" in\n2320ad8fb0 (\"Merge branch 'zh/pretty-date-human' into next\", 2021-04-30), so a\nfew days before you sent v4.\n\nJunio probably missed v4 entirely, or he might have responded with something\nlike \"v3 is already in next, so please build incrementally on top of it\".\n\nThanks for contributing this functionality. I quite like the \"human\" format.\n\nMartin\n"},{"id":"423991","messageId":"xmqqo8djrzrp.fsf@gitster.g","threadId":"55651","inReplyTo":"CAN0heSqi9v3dGgGFSGB7J-17MJj9jOvMwC6x7pW1bRGwra5N2g@mail.gmail.com","subject":"Re: [PATCH 2/2] pretty-formats.txt: add missing space","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-10T04:14:34Z","receivedAt":"2021-05-10T04:14:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren writes:\n\n> Ah, thanks for the pointer. It looks like this was merged to \"next\" in\n> 2320ad8fb0 (\"Merge branch 'zh/pretty-date-human' into next\", 2021-04-30), so a\n> few days before you sent v4.\n>\n> Junio probably missed v4 entirely, or he might have responded with something\n> like \"v3 is already in next, so please build incrementally on top of it\".\n>\n> Thanks for contributing this functionality. I quite like the \"human\" format.\n\nThanks, I think that is exactly what happened, except that I wrote\nthe message but it is still in my draft mailbox without being sent\n;-)\n\n\n\n"}]}