{"thread":{"id":"55642","subject":"[PATCH] Fix typo in Documentation/RelNotes/2.31.0.txt","startedAt":"2021-05-07T06:26:22Z","lastAt":"2021-05-13T20:11:04Z","messageCount":4,"participants":["lilinchao@oschina.cn","Bagas Sanjaya","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"423863","messageId":"21c2f550aefd11eb9a470026b95c99cc@oschina.cn","threadId":"55642","inReplyTo":null,"subject":"[PATCH] Fix typo in Documentation/RelNotes/2.31.0.txt","fromName":"","fromEmail":"lilinchao@oschina.cn","sentAt":"2021-05-07T06:26:12Z","receivedAt":"2021-05-07T06:26:22Z","isPatch":true,"sender":{"key":"lilinchao@oschina.cn","avatar":null},"body":"From: Li Linchao \n\nreplace 'whey' with `when`\n\nSigned-off-by: Li Linchao \n---\n Documentation/RelNotes/2.31.0.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/RelNotes/2.31.0.txt b/Documentation/RelNotes/2.31.0.txt\nindex cf0c7d8d40..617d211f3f 100644\n--- a/Documentation/RelNotes/2.31.0.txt\n+++ b/Documentation/RelNotes/2.31.0.txt\n@@ -49,7 +49,7 @@ UI, Workflows & Features\n @{1}, but we failed to answer \"what commit were we on?\", i.e. @{1}\n \n * \"git bundle\" learns \"--stdin\" option to read its refs from the\n- standard input. Also, it now does not lose refs whey they point\n+ standard input. Also, it now does not lose refs when they point\n at the same object.\n \n * \"git log\" learned a new \"--diff-merges=\" option.\n-- \n2.31.1.442.g7e39198978\n\n"},{"id":"424445","messageId":"fe07e104b3c311eba3eb0024e87935e7@oschina.cn","threadId":"55642","inReplyTo":"21c2f550aefd11eb9a470026b95c99cc@oschina.cn","subject":"Re: [PATCH] Fix typo in Documentation/RelNotes/2.31.0.txt","fromName":"lilinchao@oschina.cn","fromEmail":"lilinchao@oschina.cn","sentAt":"2021-05-13T08:19:53Z","receivedAt":"2021-05-13T08:19:58Z","isPatch":true,"sender":{"key":"lilinchao@oschina.cn","avatar":null},"body":"ping\n---\n>From: Li Linchao \n>\n>replace 'whey' with `when`\n>\n>Signed-off-by: Li Linchao \n>---\n> Documentation/RelNotes/2.31.0.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/Documentation/RelNotes/2.31.0.txt b/Documentation/RelNotes/2.31.0.txt\n>index cf0c7d8d40..617d211f3f 100644\n>--- a/Documentation/RelNotes/2.31.0.txt\n>+++ b/Documentation/RelNotes/2.31.0.txt\n>@@ -49,7 +49,7 @@ UI, Workflows & Features\n>    @{1}, but we failed to answer \"what commit were we on?\", i.e. @{1}\n>\n>  * \"git bundle\" learns \"--stdin\" option to read its refs from the\n>-   standard input.  Also, it now does not lose refs whey they point\n>+   standard input.  Also, it now does not lose refs when they point\n>    at the same object.\n>\n>  * \"git log\" learned a new \"--diff-merges=\" option.\n>--\n>2.31.1.442.g7e39198978\n>\n>"},{"id":"424453","messageId":"889ed1db-1fda-8d96-d966-bd610951b377@gmail.com","threadId":"55642","inReplyTo":"21c2f550aefd11eb9a470026b95c99cc@oschina.cn","subject":"Re: [PATCH] Fix typo in Documentation/RelNotes/2.31.0.txt","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-05-13T09:39:19Z","receivedAt":"2021-05-13T09:39:26Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Hi Li, welcome to Git mailing list!\n\nOn 07/05/21 13.26, lilinchao@oschina.cn wrote:\n> From: Li Linchao \n> \n> replace 'whey' with `when`\n> \n> Signed-off-by: Li Linchao \n> ---\n> Documentation/RelNotes/2.31.0.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/RelNotes/2.31.0.txt b/Documentation/RelNotes/2.31.0.txt\n> index cf0c7d8d40..617d211f3f 100644\n> --- a/Documentation/RelNotes/2.31.0.txt\n> +++ b/Documentation/RelNotes/2.31.0.txt\n> @@ -49,7 +49,7 @@ UI, Workflows & Features\n> @{1}, but we failed to answer \"what commit were we on?\", i.e. @{1}\n> \n> * \"git bundle\" learns \"--stdin\" option to read its refs from the\n> - standard input. Also, it now does not lose refs whey they point\n> + standard input. Also, it now does not lose refs when they point\n\nLooks OK.\n\n> at the same object.\n> \n> * \"git log\" learned a new \"--diff-merges=\" option.\n> \n\nThanks.\n\nReviewed-by: Bagas Sanjaya \n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"424502","messageId":"xmqqa6oybdij.fsf@gitster.g","threadId":"55642","inReplyTo":"fe07e104b3c311eba3eb0024e87935e7@oschina.cn","subject":"Re: [PATCH] Fix typo in Documentation/RelNotes/2.31.0.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-05-13T20:11:00Z","receivedAt":"2021-05-13T20:11:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"lilinchao@oschina.cn\" writes:\n\n> ping\n> ---\n>>From: Li Linchao \n>>\n>>replace 'whey' with `when`\n>>\n>>Signed-off-by: Li Linchao \n>>---\n>> Documentation/RelNotes/2.31.0.txt | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>>diff --git a/Documentation/RelNotes/2.31.0.txt b/Documentation/RelNotes/2.31.0.txt\n>>index cf0c7d8d40..617d211f3f 100644\n>>--- a/Documentation/RelNotes/2.31.0.txt\n>>+++ b/Documentation/RelNotes/2.31.0.txt\n>>@@ -49,7 +49,7 @@ UI, Workflows & Features\n>> @{1}, but we failed to answer \"what commit were we on?\", i.e. @{1}\n>>\n>> * \"git bundle\" learns \"--stdin\" option to read its refs from the\n>>- standard input. Also, it now does not lose refs whey they point\n>>+ standard input. Also, it now does not lose refs when they point\n>> at the same object.\n>>\n>> * \"git log\" learned a new \"--diff-merges=\" option.\n>>--\n>>2.31.1.442.g7e39198978\n\nThanks. Will see if it makes sense to apply.\n\nWhile it is true that is a typo, fixing it here won't correct it for\nthe 2.31 release as it was tagged and released long time ago. And\nof course, it will be silly to issue 2.31.1 maintenance release to\nfix a typo in the release notes for 2.31.0 release. So...\n"}]}