{"thread":{"id":"55520","subject":"[PATCH 0/2] git: support separate arg for `--config-env`'s value","startedAt":"2021-04-19T15:55:22Z","lastAt":"2021-04-30T00:47:39Z","messageCount":11,"participants":["Patrick Steinhardt","Ævar Arnfjörð Bjarmason","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"422316","messageId":"cover.1618847606.git.ps@pks.im","threadId":"55520","inReplyTo":null,"subject":"[PATCH 0/2] git: support separate arg for `--config-env`'s value","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-19T15:56:45Z","receivedAt":"2021-04-19T15:55:22Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"Hi,\n\nAs pointed out by Ævar, the synopsis in the git(1) manpage was\nmisdocumenting the syntax of the `--config-env` option. This patch\nseries fixes it and also addresses the shortcoming that while most of\nthe other options support both `--git-dir=foo` and `--git-dir foo`,\n`--config-env` only supported the former format.\n\nI'm happy to drop the latter patch if it's generally seen as something\nthat's not needed, but Ævar and Peff got a point in that it feels\ninconsistent with the other options.\n\nPatrick\n\nPatrick Steinhardt (2):\n git.txt: fix synopsis of `--config-env` missing the equals sign\n git: support separate arg for `--config-env`'s value\n\n Documentation/git.txt | 2 +-\n git.c | 8 ++++++++\n t/t1300-config.sh | 15 ++++++++++++++-\n 3 files changed, 23 insertions(+), 2 deletions(-)\n\n-- \n2.31.1\n\n"},{"id":"422317","messageId":"08049f3b1088a301ea87db9a69454a2516b9525b.1618847606.git.ps@pks.im","threadId":"55520","inReplyTo":"cover.1618847606.git.ps@pks.im","subject":"[PATCH 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-19T15:56:50Z","receivedAt":"2021-04-19T15:55:28Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"When executing `git -h`, then the `--config-env` documentation rightly\nlists the option as requiring an equals between the option and its\nargument: this is the only currently supported format. But the git(1)\nmanpage incorrectly lists the option as taking a space in between.\n\nFix the issue by adding the missing space.\n\nReported-by: Ævar Arnfjörð Bjarmason \nSigned-of-by: Patrick Steinhardt \n---\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex 3a9c44987f..ba5c8e9d98 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -13,7 +13,7 @@ SYNOPSIS\n [--exec-path[=]] [--html-path] [--man-path] [--info-path]\n [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--bare]\n [--git-dir=] [--work-tree=] [--namespace=]\n- [--super-prefix=] [--config-env =]\n+ [--super-prefix=] [--config-env==]\n []\n \n DESCRIPTION\n-- \n2.31.1\n\n"},{"id":"422318","messageId":"d52db89bc2f40a9df5e9fafe4e1bb8c173a7f45f.1618847606.git.ps@pks.im","threadId":"55520","inReplyTo":"cover.1618847606.git.ps@pks.im","subject":"[PATCH 2/2] git: support separate arg for `--config-env`'s value","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-19T15:56:55Z","receivedAt":"2021-04-19T15:55:35Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"While not documented as such, many of the top-level options like\n`--git-dir` and `--work-tree` support two syntaxes: they accept both an\nequals sign between option and its value, and they do support option and\nvalue as two separate arguments. The recently added `--config-env`\noption only supports the syntax with an equals sign.\n\nMitigate this inconsistency by accepting both syntaxes and add tests to\nverify both work.\n\nSigned-off-by: Patrick Steinhardt \n---\n git.c | 8 ++++++++\n t/t1300-config.sh | 15 ++++++++++++++-\n 2 files changed, 22 insertions(+), 1 deletion(-)\n\ndiff --git a/git.c b/git.c\nindex b53e665671..ad365c05c7 100644\n--- a/git.c\n+++ b/git.c\n@@ -255,6 +255,14 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)\n \t\t\tgit_config_push_parameter((*argv)[1]);\n \t\t\t(*argv)++;\n \t\t\t(*argc)--;\n+\t\t} else if (!strcmp(cmd, \"--config-env\")) {\n+\t\t\tif (*argc < 2) {\n+\t\t\t\tfprintf(stderr, _(\"no config key given for --config-env\\n\" ));\n+\t\t\t\tusage(git_usage_string);\n+\t\t\t}\n+\t\t\tgit_config_push_env((*argv)[1]);\n+\t\t\t(*argv)++;\n+\t\t\t(*argc)--;\n \t\t} else if (skip_prefix(cmd, \"--config-env=\", &cmd)) {\n \t\t\tgit_config_push_env(cmd);\n \t\t} else if (!strcmp(cmd, \"--literal-pathspecs\")) {\ndiff --git a/t/t1300-config.sh b/t/t1300-config.sh\nindex e0dd5d65ce..18803f9953 100755\n--- a/t/t1300-config.sh\n+++ b/t/t1300-config.sh\n@@ -1374,16 +1374,29 @@ test_expect_success 'git --config-env=key=envvar support' '\n \tcat >expect <<-\\EOF &&\n \tvalue\n \tvalue\n+\tvalue\n+\tvalue\n+\tfalse\n \tfalse\n \tEOF\n \t{\n \t\tENVVAR=value git --config-env=core.name=ENVVAR config core.name &&\n+\t\tENVVAR=value git --config-env core.name=ENVVAR config core.name &&\n \t\tENVVAR=value git --config-env=foo.CamelCase=ENVVAR config foo.camelcase &&\n-\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag\n+\t\tENVVAR=value git --config-env foo.CamelCase=ENVVAR config foo.camelcase &&\n+\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag &&\n+\t\tENVVAR= git --config-env foo.flag=ENVVAR config --bool foo.flag\n \t} >actual &&\n \ttest_cmp expect actual\n '\n \n+test_expect_success 'git --config-env with missing value' '\n+\ttest_must_fail env ENVVAR=value git --config-env 2>error &&\n+\ttest_i18ngrep \"no config key given for --config-env\" error &&\n+\ttest_must_fail env ENVVAR=value git --config-env config core.name 2>error &&\n+\ttest_i18ngrep \"invalid config format: config\" error\n+'\n+\n test_expect_success 'git --config-env fails with invalid parameters' '\n \ttest_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&\n \ttest_i18ngrep \"invalid config format: foo.flag\" error &&\n-- \n2.31.1\n\n"},{"id":"422381","messageId":"874kg14490.fsf@evledraar.gmail.com","threadId":"55520","inReplyTo":"d52db89bc2f40a9df5e9fafe4e1bb8c173a7f45f.1618847606.git.ps@pks.im","subject":"Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-04-20T10:52:43Z","receivedAt":"2021-04-20T10:52:47Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Mon, Apr 19 2021, Patrick Steinhardt wrote:\n\n> While not documented as such, many of the top-level options like\n> `--git-dir` and `--work-tree` support two syntaxes: they accept both an\n> equals sign between option and its value, and they do support option and\n> value as two separate arguments. The recently added `--config-env`\n> option only supports the syntax with an equals sign.\n>\n> Mitigate this inconsistency by accepting both syntaxes and add tests to\n> verify both work.\n>\n> Signed-off-by: Patrick Steinhardt \n\nThis whole series LGTM.\n\n> git.c | 8 ++++++++\n> t/t1300-config.sh | 15 ++++++++++++++-\n> 2 files changed, 22 insertions(+), 1 deletion(-)\n>\n> diff --git a/git.c b/git.c\n> index b53e665671..ad365c05c7 100644\n> --- a/git.c\n> +++ b/git.c\n> @@ -255,6 +255,14 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)\n> \t\t\tgit_config_push_parameter((*argv)[1]);\n> \t\t\t(*argv)++;\n> \t\t\t(*argc)--;\n> +\t\t} else if (!strcmp(cmd, \"--config-env\")) {\n> +\t\t\tif (*argc < 2) {\n> +\t\t\t\tfprintf(stderr, _(\"no config key given for --config-env\\n\" ));\n\n\nI found this use of fprintf() slightly odd, why not error(), but then\nwent back and read the function and saw that it has N number of\n\"fprintf(stderr, [...])\" already.\n\nThat could probably all be converted to error(), but better to be\nconsistent for now.\n\n> +\t\t\t\tusage(git_usage_string);\n> +\t\t\t}\n> +\t\t\tgit_config_push_env((*argv)[1]);\n> +\t\t\t(*argv)++;\n> +\t\t\t(*argc)--;\n> \t\t} else if (skip_prefix(cmd, \"--config-env=\", &cmd)) {\n> \t\t\tgit_config_push_env(cmd);\n> \t\t} else if (!strcmp(cmd, \"--literal-pathspecs\")) {\n> diff --git a/t/t1300-config.sh b/t/t1300-config.sh\n> index e0dd5d65ce..18803f9953 100755\n> --- a/t/t1300-config.sh\n> +++ b/t/t1300-config.sh\n> @@ -1374,16 +1374,29 @@ test_expect_success 'git --config-env=key=envvar support' '\n> \tcat >expect <<-\\EOF &&\n> \tvalue\n> \tvalue\n> +\tvalue\n> +\tvalue\n> +\tfalse\n> \tfalse\n> \tEOF\n> \t{\n> \t\tENVVAR=value git --config-env=core.name=ENVVAR config core.name &&\n> +\t\tENVVAR=value git --config-env core.name=ENVVAR config core.name &&\n> \t\tENVVAR=value git --config-env=foo.CamelCase=ENVVAR config foo.camelcase &&\n> -\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag\n> +\t\tENVVAR=value git --config-env foo.CamelCase=ENVVAR config foo.camelcase &&\n> +\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag &&\n> +\t\tENVVAR= git --config-env foo.flag=ENVVAR config --bool foo.flag\n> \t} >actual &&\n> \ttest_cmp expect actual\n> '\n> \n> +test_expect_success 'git --config-env with missing value' '\n> +\ttest_must_fail env ENVVAR=value git --config-env 2>error &&\n> +\ttest_i18ngrep \"no config key given for --config-env\" error &&\n> +\ttest_must_fail env ENVVAR=value git --config-env config core.name 2>error &&\n> +\ttest_i18ngrep \"invalid config format: config\" error\n> +'\n> +\n> test_expect_success 'git --config-env fails with invalid parameters' '\n> \ttest_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&\n> \ttest_i18ngrep \"invalid config format: foo.flag\" error &&\n\n"},{"id":"422384","messageId":"87sg3l2o7r.fsf@evledraar.gmail.com","threadId":"55520","inReplyTo":"d52db89bc2f40a9df5e9fafe4e1bb8c173a7f45f.1618847606.git.ps@pks.im","subject":"Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-04-20T11:24:24Z","receivedAt":"2021-04-20T11:24:32Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Mon, Apr 19 2021, Patrick Steinhardt wrote:\n\n> +test_expect_success 'git --config-env with missing value' '\n> +\ttest_must_fail env ENVVAR=value git --config-env 2>error &&\n> +\ttest_i18ngrep \"no config key given for --config-env\" error &&\n> +\ttest_must_fail env ENVVAR=value git --config-env config core.name 2>error &&\n> +\ttest_i18ngrep \"invalid config format: config\" error\n> +'\n> +\n\nNit: (not spotted on the first reading): s/test_i18ngrep/grep/.\n\n> test_expect_success 'git --config-env fails with invalid parameters' '\n> \ttest_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&\n> \ttest_i18ngrep \"invalid config format: foo.flag\" error &&\n\n"},{"id":"422745","messageId":"YIKcZxEDsG7qsE4G@coredump.intra.peff.net","threadId":"55520","inReplyTo":"874kg14490.fsf@evledraar.gmail.com","subject":"Re: [PATCH 2/2] git: support separate arg for `--config-env`'s value","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-04-23T10:07:35Z","receivedAt":"2021-04-23T10:07:38Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Apr 20, 2021 at 12:52:43PM +0200, Ævar Arnfjörð Bjarmason wrote:\n\n> > Mitigate this inconsistency by accepting both syntaxes and add tests to\n> > verify both work.\n> >\n> > Signed-off-by: Patrick Steinhardt \n> \n> This whole series LGTM.\n\nMe too. Thanks for finding it (and Patrick for fixing it).\n\n> > +\t\t} else if (!strcmp(cmd, \"--config-env\")) {\n> > +\t\t\tif (*argc < 2) {\n> > +\t\t\t\tfprintf(stderr, _(\"no config key given for --config-env\\n\" ));\n> \n> \n> I found this use of fprintf() slightly odd, why not error(), but then\n> went back and read the function and saw that it has N number of\n> \"fprintf(stderr, [...])\" already.\n> \n> That could probably all be converted to error(), but better to be\n> consistent for now.\n\nYep. Likewise the weird extra space at the end of the string.\n\n-Peff\n"},{"id":"423265","messageId":"08049f3b1088a301ea87db9a69454a2516b9525b.1619700731.git.ps@pks.im","threadId":"55520","inReplyTo":"cover.1619700731.git.ps@pks.im","subject":"[PATCH v2 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-29T12:55:29Z","receivedAt":"2021-04-29T12:53:52Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"When executing `git -h`, then the `--config-env` documentation rightly\nlists the option as requiring an equals between the option and its\nargument: this is the only currently supported format. But the git(1)\nmanpage incorrectly lists the option as taking a space in between.\n\nFix the issue by adding the missing space.\n\nReported-by: Ævar Arnfjörð Bjarmason \nSigned-of-by: Patrick Steinhardt \n---\n Documentation/git.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git.txt b/Documentation/git.txt\nindex 3a9c44987f..ba5c8e9d98 100644\n--- a/Documentation/git.txt\n+++ b/Documentation/git.txt\n@@ -13,7 +13,7 @@ SYNOPSIS\n [--exec-path[=]] [--html-path] [--man-path] [--info-path]\n [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--bare]\n [--git-dir=] [--work-tree=] [--namespace=]\n- [--super-prefix=] [--config-env =]\n+ [--super-prefix=] [--config-env==]\n []\n \n DESCRIPTION\n-- \n2.31.1\n\n"},{"id":"423266","messageId":"cover.1619700731.git.ps@pks.im","threadId":"55520","inReplyTo":"cover.1618847606.git.ps@pks.im","subject":"[PATCH v2 0/2] git: support separate arg for `--config-env`'s value","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-29T12:55:25Z","receivedAt":"2021-04-29T12:53:53Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"Hi,\n\nthis is the second version of this series fixing inconsistencies with\nthe `--config-env` parameter. It's only got a single change compared to\nv1, which is to replace `test_i18ngrep` with `grep` as pointed out by\nÆvar.\n\nPatrick\n\nPatrick Steinhardt (2):\n git.txt: fix synopsis of `--config-env` missing the equals sign\n git: support separate arg for `--config-env`'s value\n\n Documentation/git.txt | 2 +-\n git.c | 8 ++++++++\n t/t1300-config.sh | 15 ++++++++++++++-\n 3 files changed, 23 insertions(+), 2 deletions(-)\n\nRange-diff against v1:\n1: 08049f3b10 = 1: 08049f3b10 git.txt: fix synopsis of `--config-env` missing the equals sign\n2: d52db89bc2 ! 2: 5264fb6fa7 git: support separate arg for `--config-env`'s value\n @@ t/t1300-config.sh: test_expect_success 'git --config-env=key=envvar support' '\n \n +test_expect_success 'git --config-env with missing value' '\n +\ttest_must_fail env ENVVAR=value git --config-env 2>error &&\n -+\ttest_i18ngrep \"no config key given for --config-env\" error &&\n ++\tgrep \"no config key given for --config-env\" error &&\n +\ttest_must_fail env ENVVAR=value git --config-env config core.name 2>error &&\n -+\ttest_i18ngrep \"invalid config format: config\" error\n ++\tgrep \"invalid config format: config\" error\n +'\n +\n test_expect_success 'git --config-env fails with invalid parameters' '\n-- \n2.31.1\n\n"},{"id":"423267","messageId":"5264fb6fa7e05b55ab48d02265d8611536dc93f1.1619700731.git.ps@pks.im","threadId":"55520","inReplyTo":"cover.1619700731.git.ps@pks.im","subject":"[PATCH v2 2/2] git: support separate arg for `--config-env`'s value","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2021-04-29T12:55:34Z","receivedAt":"2021-04-29T12:53:54Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"While not documented as such, many of the top-level options like\n`--git-dir` and `--work-tree` support two syntaxes: they accept both an\nequals sign between option and its value, and they do support option and\nvalue as two separate arguments. The recently added `--config-env`\noption only supports the syntax with an equals sign.\n\nMitigate this inconsistency by accepting both syntaxes and add tests to\nverify both work.\n\nSigned-off-by: Patrick Steinhardt \n---\n git.c | 8 ++++++++\n t/t1300-config.sh | 15 ++++++++++++++-\n 2 files changed, 22 insertions(+), 1 deletion(-)\n\ndiff --git a/git.c b/git.c\nindex b53e665671..ad365c05c7 100644\n--- a/git.c\n+++ b/git.c\n@@ -255,6 +255,14 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)\n \t\t\tgit_config_push_parameter((*argv)[1]);\n \t\t\t(*argv)++;\n \t\t\t(*argc)--;\n+\t\t} else if (!strcmp(cmd, \"--config-env\")) {\n+\t\t\tif (*argc < 2) {\n+\t\t\t\tfprintf(stderr, _(\"no config key given for --config-env\\n\" ));\n+\t\t\t\tusage(git_usage_string);\n+\t\t\t}\n+\t\t\tgit_config_push_env((*argv)[1]);\n+\t\t\t(*argv)++;\n+\t\t\t(*argc)--;\n \t\t} else if (skip_prefix(cmd, \"--config-env=\", &cmd)) {\n \t\t\tgit_config_push_env(cmd);\n \t\t} else if (!strcmp(cmd, \"--literal-pathspecs\")) {\ndiff --git a/t/t1300-config.sh b/t/t1300-config.sh\nindex e0dd5d65ce..ad4e6d0cfc 100755\n--- a/t/t1300-config.sh\n+++ b/t/t1300-config.sh\n@@ -1374,16 +1374,29 @@ test_expect_success 'git --config-env=key=envvar support' '\n \tcat >expect <<-\\EOF &&\n \tvalue\n \tvalue\n+\tvalue\n+\tvalue\n+\tfalse\n \tfalse\n \tEOF\n \t{\n \t\tENVVAR=value git --config-env=core.name=ENVVAR config core.name &&\n+\t\tENVVAR=value git --config-env core.name=ENVVAR config core.name &&\n \t\tENVVAR=value git --config-env=foo.CamelCase=ENVVAR config foo.camelcase &&\n-\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag\n+\t\tENVVAR=value git --config-env foo.CamelCase=ENVVAR config foo.camelcase &&\n+\t\tENVVAR= git --config-env=foo.flag=ENVVAR config --bool foo.flag &&\n+\t\tENVVAR= git --config-env foo.flag=ENVVAR config --bool foo.flag\n \t} >actual &&\n \ttest_cmp expect actual\n '\n \n+test_expect_success 'git --config-env with missing value' '\n+\ttest_must_fail env ENVVAR=value git --config-env 2>error &&\n+\tgrep \"no config key given for --config-env\" error &&\n+\ttest_must_fail env ENVVAR=value git --config-env config core.name 2>error &&\n+\tgrep \"invalid config format: config\" error\n+'\n+\n test_expect_success 'git --config-env fails with invalid parameters' '\n \ttest_must_fail git --config-env=foo.flag config --bool foo.flag 2>error &&\n \ttest_i18ngrep \"invalid config format: foo.flag\" error &&\n-- \n2.31.1\n\n"},{"id":"423295","messageId":"YIsRQG7TFtt7MU2k@coredump.intra.peff.net","threadId":"55520","inReplyTo":"cover.1619700731.git.ps@pks.im","subject":"Re: [PATCH v2 0/2] git: support separate arg for `--config-env`'s value","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2021-04-29T20:04:16Z","receivedAt":"2021-04-29T20:04:18Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Apr 29, 2021 at 02:55:25PM +0200, Patrick Steinhardt wrote:\n\n> this is the second version of this series fixing inconsistencies with\n> the `--config-env` parameter. It's only got a single change compared to\n> v1, which is to replace `test_i18ngrep` with `grep` as pointed out by\n> Ævar.\n\nThanks, this version looks good to me.\n\n-Peff\n"},{"id":"423308","messageId":"xmqqwnskegyf.fsf@gitster.g","threadId":"55520","inReplyTo":"YIsRQG7TFtt7MU2k@coredump.intra.peff.net","subject":"Re: [PATCH v2 0/2] git: support separate arg for `--config-env`'s value","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-04-30T00:47:36Z","receivedAt":"2021-04-30T00:47:39Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Thu, Apr 29, 2021 at 02:55:25PM +0200, Patrick Steinhardt wrote:\n>\n>> this is the second version of this series fixing inconsistencies with\n>> the `--config-env` parameter. It's only got a single change compared to\n>> v1, which is to replace `test_i18ngrep` with `grep` as pointed out by\n>> Ævar.\n>\n> Thanks, this version looks good to me.\n>\n> -Peff\n\nThanks, will replace.\n"}]}