{"thread":{"id":"5551","subject":"[PATCH] git-archive: inline default_parse_extra()","startedAt":"2006-09-13T20:55:04Z","lastAt":"2006-09-13T20:55:04Z","messageCount":1,"participants":["Rene Scharfe"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"26826","messageId":"45087028.2070006@lsrfire.ath.cx","threadId":"5551","inReplyTo":null,"subject":"[PATCH] git-archive: inline default_parse_extra()","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-09-13T20:55:04Z","receivedAt":"2006-09-13T20:55:04Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n\ndiff --git a/builtin-archive.c b/builtin-archive.c\nindex da3f714..6dabdee 100644\n--- a/builtin-archive.c\n+++ b/builtin-archive.c\n@@ -145,17 +145,6 @@ void parse_treeish_arg(const char **argv\n \tar_args->time = archive_time;\n }\n \n-static const char *default_parse_extra(struct archiver *ar,\n-\t\t\t\t       const char **argv)\n-{\n-\tstatic char msg[64];\n-\n-\tsnprintf(msg, sizeof(msg) - 4, \"'%s' format does not handle %s\",\n-\t\t ar->name, *argv);\n-\n-\treturn strcat(msg, \"...\");\n-}\n-\n int parse_archive_args(int argc, const char **argv, struct archiver *ar)\n {\n \tconst char *extra_argv[MAX_EXTRA_ARGS];\n@@ -208,7 +197,8 @@ int parse_archive_args(int argc, const c\n \n \tif (extra_argc) {\n \t\tif (!ar->parse_extra)\n-\t\t\tdie(\"%s\", default_parse_extra(ar, extra_argv));\n+\t\t\tdie(\"'%s' format does not handle %s\",\n+\t\t\t    ar->name, extra_argv[0]);\n \t\tar->args.extra = ar->parse_extra(extra_argc, extra_argv);\n \t}\n \tar->args.verbose = verbose;\n"}]}