{"thread":{"id":"55504","subject":"[PATCH] completion: avoid aliased command lookup error in nounset mode","startedAt":"2021-04-16T19:19:46Z","lastAt":"2021-04-16T20:40:54Z","messageCount":2,"participants":["Ville Skyttä","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"422116","messageId":"20210416191939.1120651-1-ville.skytta@iki.fi","threadId":"55504","inReplyTo":null,"subject":"[PATCH] completion: avoid aliased command lookup error in nounset mode","fromName":"Ville Skyttä","fromEmail":"ville.skytta@iki.fi","sentAt":"2021-04-16T19:19:39Z","receivedAt":"2021-04-16T19:19:46Z","isPatch":true,"sender":{"key":"ville.skytta@iki.fi","avatar":"https://avatars.githubusercontent.com/u/109152?v=4"},"body":"Aliased command lookup accesses the `list` variable before it has been\nset, causing an error in \"nounset\" mode. Initialize to an empty string\nto avoid that.\n\n    $ git nonexistent-command <Tab>bash: list: unbound variable\n\nSigned-off-by: Ville Skyttä <ville.skytta@iki.fi>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex dfa735ea62..49e76e9d08 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1129,7 +1129,7 @@ __git_pretty_aliases ()\n # __git_aliased_command requires 1 argument\n __git_aliased_command ()\n {\n-\tlocal cur=$1 last list word cmdline\n+\tlocal cur=$1 last list= word cmdline\n \n \twhile [[ -n \"$cur\" ]]; do\n \t\tif [[ \"$list\" == *\" $cur \"* ]]; then\n-- \n2.25.1\n\n"},{"id":"422121","messageId":"xmqq7dl2klo1.fsf@gitster.g","threadId":"55504","inReplyTo":"20210416191939.1120651-1-ville.skytta@iki.fi","subject":"Re: [PATCH] completion: avoid aliased command lookup error in nounset mode","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-04-16T20:40:46Z","receivedAt":"2021-04-16T20:40:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ville Skyttä <ville.skytta@iki.fi> writes:\n\n> Aliased command lookup accesses the `list` variable before it has been\n> set, causing an error in \"nounset\" mode. Initialize to an empty string\n> to avoid that.\n>\n>     $ git nonexistent-command <Tab>bash: list: unbound variable\n>\n> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>\n> ---\n>  contrib/completion/git-completion.bash | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks, will queue.\n\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index dfa735ea62..49e76e9d08 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1129,7 +1129,7 @@ __git_pretty_aliases ()\n>  # __git_aliased_command requires 1 argument\n>  __git_aliased_command ()\n>  {\n> -\tlocal cur=$1 last list word cmdline\n> +\tlocal cur=$1 last list= word cmdline\n>  \n>  \twhile [[ -n \"$cur\" ]]; do\n>  \t\tif [[ \"$list\" == *\" $cur \"* ]]; then\n"}]}